From nobody Thu Dec 18 08:38:44 2025 Received: from mail-pg1-f202.google.com (mail-pg1-f202.google.com [209.85.215.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC3AE23717F for ; Tue, 9 Dec 2025 22:38:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765319884; cv=none; b=DrRVOensOFGEfKkY3wWil7EZj6WBB6md6UOWE6DtEbCjqh8BM/BPPFzk+6Aqua8Fa7GhQYEgJf5ST5U6aF6KJbUOYJAz0PYvzVAi2BS4We/dmzHbMcKmG9L73AYLvOnQ3Rj3GJnVin5wL/l98zPnCDdWeQYe+94QhkGII9XYwvQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765319884; c=relaxed/simple; bh=sdXGJfBHkvwR6kjDlZOa2OqG/E8eoLySwLycL+bnfeQ=; h=Date:Mime-Version:Message-ID:Subject:From:To:Content-Type; b=M0KN71En59gYO0hpbI6nWYPOiPV3nAHRRk3h7KnZaP0qsqDaBUXIpQEZIpV1rlnM1DDGfIqtE0U6jy6G/NUqYtBlDNjWrCJQOFyfOxgEKQ8F8G+4I09vawZ2k7LXUhKCTRcrSEhXckXN9UxJwXNmprTNElxxVQVJKc5c7SZIpHk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=I1Whoiqu; arc=none smtp.client-ip=209.85.215.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="I1Whoiqu" Received: by mail-pg1-f202.google.com with SMTP id 41be03b00d2f7-b630b4d8d52so6501687a12.3 for ; Tue, 09 Dec 2025 14:38:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1765319881; x=1765924681; darn=vger.kernel.org; h=to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=AMwjmsmi4mVv5vZzNSGwrM0RkjwLo+Rq8irZPLzhGz4=; b=I1Whoiqu2vP9ATedkb/VpjxcZOBNbI8BNYFe+J87ZvEAYb7DuqPzkp/YEpO+DRtlj8 VxXVTJjvroyHEo7A21CE3LepBMWakww1uXpOvoXaFJUgDNeLUtO3xhQJ92aqzXe/ZwUv zx6+iFgOEPHskCt1VW13D/dE3ZiFWsTRH+6h02VAlRRf77auEa9yaWxl0AJ1Vb/c0xrx CYMW5EgA9HbBgeLzNFghj/PFAANotIuJtfV/AEvU19Fd8/5vEFdaBXsPEG9s3QwdzKtH /l7DriZD9SFj8Pvl2Jdd3u3j6XJCIUIttAipj0OuK99N6p07Dfczt91B0dRT+mHiEJx/ QHRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765319881; x=1765924681; h=to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=AMwjmsmi4mVv5vZzNSGwrM0RkjwLo+Rq8irZPLzhGz4=; b=REOheOKfSePuaGbIBKjOmPbnsjbBPR3Z+RCPLBLCvybO0RM9X5NZDzi04MhWRuan/q Dluaq6fdK2TMoL/3EnFv+rBFajnSgXrzNoPLv7i348ehqkttjYH4NBarN0pP6myDRTzB 2k6WXOwsiBdaH15gDUH7zWryb7bC25duMVbjXoGwRp1Ty/dYRMuv5yyBedk5O7pCP65L nNzgbAkCLIx/zNr3O5sOT160k+D8uR4sNBCb4IrgAdrW2B5TdyFfNItKKBaVIrKh0qK4 8wuYGpcd9C78OCTgQwKlXtGIkdzzfMjqZWqisqwJxM3G/kADey2PhP8bxREZ5y9fN0XY yOsw== X-Forwarded-Encrypted: i=1; AJvYcCX2uIp+uLA6vqYfmcJmPpK2HpDPcAH4KkhY5hWJqqh0JYsS8jnVZZc9rlV2XOt7XFoXEQ7KXMhRr7iphUA=@vger.kernel.org X-Gm-Message-State: AOJu0YzSPgmeZe+5e3m89TewuSuELL5xFReV0nZbL6VjwAcCCPqFelhF 7xwrIAcJ8i6Ew4lGfVWJBcz0cYMhoLIjHRV6w2FqnXJBdYWGtU80CMJfEPv9pVhcCyjt0ds+g2l JiaV4z6VdAg== X-Google-Smtp-Source: AGHT+IGGxoI8LkWA0cg6HYhGeqQhcotQufROrVQ1zXABSXp1DJk1xVggP6NDezXDolKA1OIj/0pqvwbnikS8 X-Received: from dycrr5.prod.google.com ([2002:a05:693c:2c85:b0:2a4:6f9d:b3cb]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:693c:8050:b0:2a4:3593:ddf2 with SMTP id 5a478bee46e88-2ac05625cf7mr517110eec.31.1765319881049; Tue, 09 Dec 2025 14:38:01 -0800 (PST) Date: Tue, 9 Dec 2025 14:37:56 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.52.0.223.gf5cc29aaa4-goog Message-ID: <20251209223756.2321578-1-irogers@google.com> Subject: [PATCH v1] PCI: Cadence: Avoid possible signed 64-bit truncation From: Ian Rogers To: Lorenzo Pieralisi , "=?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?=" , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Siddharth Vadapalli , Kishon Vijay Abraham I , Hans Zhang <18255117159@163.com>, Chen Wang , Ian Rogers , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" 64-bit truncation to 32-bit can result in the sign of the truncated value changing. The cdns_pcie_host_dma_ranges_cmp is used in list_sort and so the truncation could result in an invalid sort order. This would only happen were the resource_size values large. Signed-off-by: Ian Rogers --- drivers/pci/controller/cadence/pcie-cadence-host.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/pci/controller/cadence/pcie-cadence-host.c b/drivers/p= ci/controller/cadence/pcie-cadence-host.c index fffd63d6665e..e5fd02305ab6 100644 --- a/drivers/pci/controller/cadence/pcie-cadence-host.c +++ b/drivers/pci/controller/cadence/pcie-cadence-host.c @@ -414,11 +414,19 @@ static int cdns_pcie_host_dma_ranges_cmp(void *priv, = const struct list_head *a, const struct list_head *b) { struct resource_entry *entry1, *entry2; + u64 size1, size2; =20 - entry1 =3D container_of(a, struct resource_entry, node); - entry2 =3D container_of(b, struct resource_entry, node); + entry1 =3D container_of(a, struct resource_entry, node); + entry2 =3D container_of(b, struct resource_entry, node); =20 - return resource_size(entry2->res) - resource_size(entry1->res); + size1 =3D resource_size(entry1->res); + size2 =3D resource_size(entry2->res); + + if (size1 > size2) + return -1; + if (size1 < size2) + return 1; + return 0; } =20 static void cdns_pcie_host_unmap_dma_ranges(struct cdns_pcie_rc *rc) --=20 2.52.0.223.gf5cc29aaa4-goog