From nobody Fri Dec 19 11:30:56 2025 Received: from canpmsgout01.his.huawei.com (canpmsgout01.his.huawei.com [113.46.200.216]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D1D5B32E68F; Tue, 9 Dec 2025 13:39:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=113.46.200.216 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765287580; cv=none; b=tvDQqeJKrBrbCGRbc7r9g4oDw0PflM++oxG+4jjSSWLOyDU5o7uP7RxWrFow4lXAAJmDmUOPTd7O36xP15+P1rrWOK5oitjr0I/wEAH00xeGoC/lIDWQqy0olw2o5bp3WWDZKUlYJ8Wvvq68HW5KQCoca5tUD1T//UI8P0J8rKM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765287580; c=relaxed/simple; bh=zi/CHuYpDOHVfno5zf7h6Uw8jW/PFOJ0urKlP+UCSvQ=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=KBClPz7gbG/RWoBLTkHM6C832jbvIBUp4hFlIzVeOkMuOTB9Tegf1TQW6wHgBrAfLDxBLPWS2hcSdjZyPPRm3qeteU+2DqaoXEFcWSb3+NjOnZFNhwnnNYyJkln/Rph8zk4o0oSxJw+8TIJ+Aat/UVUNwa+BHgywifyNXUubPYg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b=VMfrziEz; arc=none smtp.client-ip=113.46.200.216 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b="VMfrziEz" dkim-signature: v=1; a=rsa-sha256; d=huawei.com; s=dkim; c=relaxed/relaxed; q=dns/txt; h=From; bh=DGZOeQlV0A3mhwAwX2SZ1xAaly3ZzKR6+7S2neuG5zc=; b=VMfrziEzv8jN7F91p+zZNI5c5/CKWlVH678OIni2zikbPVlwAWQ+gfuz1NV5PZly0KRXc13Jo jw3dPTs0BR0tZqRNFYV5PUaWtuRdtPh6yNJh0cSbCf1vxJqcsVMO9ZvQIl919PuUVqfBQaZ4hsi joiRLpT8fJwG7Laui5lxuzA= Received: from mail.maildlp.com (unknown [172.19.163.252]) by canpmsgout01.his.huawei.com (SkyGuard) with ESMTPS id 4dQfzd38Q6z1T4G3; Tue, 9 Dec 2025 21:37:33 +0800 (CST) Received: from kwepemk100013.china.huawei.com (unknown [7.202.194.61]) by mail.maildlp.com (Postfix) with ESMTPS id 950AB180BD5; Tue, 9 Dec 2025 21:39:34 +0800 (CST) Received: from localhost.localdomain (10.90.31.46) by kwepemk100013.china.huawei.com (7.202.194.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Tue, 9 Dec 2025 21:39:33 +0800 From: Jijie Shao To: , , , , , CC: , , , , , , , , , , Subject: [PATCH net 3/3] net: hns3: add VLAN id validation before using Date: Tue, 9 Dec 2025 21:38:25 +0800 Message-ID: <20251209133825.3577343-4-shaojijie@huawei.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20251209133825.3577343-1-shaojijie@huawei.com> References: <20251209133825.3577343-1-shaojijie@huawei.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: kwepems200002.china.huawei.com (7.221.188.68) To kwepemk100013.china.huawei.com (7.202.194.61) Content-Type: text/plain; charset="utf-8" From: Jian Shen Currently, the VLAN id may be used without validation when receive a VLAN configuration mailbox from VF. It may cause out-of-bounds memory access once the VLAN id is bigger than 4095. Fixes: fe4144d47eef ("net: hns3: sync VLAN filter entries when kill VLAN ID= failed") Signed-off-by: Jian Shen Signed-off-by: Jijie Shao Reviewed-by: Simon Horman --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c b/driv= ers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c index cf8abbe01840..c589baea7c77 100644 --- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c +++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c @@ -10555,6 +10555,9 @@ int hclge_set_vlan_filter(struct hnae3_handle *hand= le, __be16 proto, bool writen_to_tbl =3D false; int ret =3D 0; =20 + if (vlan_id >=3D VLAN_N_VID) + return -EINVAL; + /* When device is resetting or reset failed, firmware is unable to * handle mailbox. Just record the vlan id, and remove it after * reset finished. --=20 2.33.0