From nobody Fri Dec 19 09:47:25 2025 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0396C28541A for ; Tue, 9 Dec 2025 12:00:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765281608; cv=none; b=o2jUFvgia1ZtShxUmWPhnddr7pnp2yP4au5AeJclYaxUkTviWH+4+lOaeIF38xfpXpPo5/HWG8c4NwlffHlidG5hx9j2SlsQknOnRdG2xIWaRlI7/ex0C0nU44Ed7IfSlQPYAspeWGGe7YnZ579cl2aJa3l7ffQe9X+23s5Ftvw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765281608; c=relaxed/simple; bh=D+TP//wjPltlG0/Y49/xfy2Rewaag9dC3HNcA+UOyQo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=IPsovyxjcDsI/Os8snyz8ef3zIzAkPtErjcBTYIJU2U9PTqiSQiXFLvYgEVZQIGL5U46YWSnjmyITSIaaqSKfV28yEoUPKKWiG7qNI3OWBMerIkIzEAF3ZkR7NUac7ygV4bcBN5BIpdZt9xb62iT66pfLefXMGyl2uKMrY+nALE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=bzjf+Egp; arc=none smtp.client-ip=209.85.218.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="bzjf+Egp" Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-b79d0a0537bso712707166b.2 for ; Tue, 09 Dec 2025 04:00:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1765281603; x=1765886403; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=tooAGZtbgdZjjhD9HMU80T91Y7IuvPUrt9iA6ZDBNz0=; b=bzjf+EgpwHxdCz+lZP+QAYppu8sQB53vCTVmcaWxGMVRmlwpt8tmLa3E+Aojainirv 0Z5suXv8iUFnXiAcgN6gXafsnQ5vfY7Mz79acJf75Y9zkYnOd+24BhCZmSvfzCj2Gz0s UDZavE7P3ZKPmJ2FxzjkCYe/ENP8ng6XjA1xSR6q6ErYrgBd3ORpKSSOACBLJDqknH/o zunHojPUfn5QFA9gn+neckV17M7TtlWDp07F0zEltorqix8020viHybNXjlBYiLVFlmv 6o0IKLr/QzdlLY7fUEyS/93Z8PXl9iJW341ERE9UrtDYbINZ3+wMlgOj5MAMBhdd8pgN cdJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765281603; x=1765886403; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=tooAGZtbgdZjjhD9HMU80T91Y7IuvPUrt9iA6ZDBNz0=; b=TR2ezOy34gzJGXx+BqobyiPtV5xv/MZBR3WbX8wrc00uookPrxQ+C4F2/8T8pyPhgV 6T3lu9VPZEYSPMgT4ALRKbrLnfirMz2ydJeRKhBg++1bNutl7VIGvAD/gS+oc8QQuk4X OIJ4E8PP/45/K1sHeZ9XFPvph1vO8vvuIWLnNLozFY6zRNUu3Zs+xmcMMVRuoYYw5VXG Blej7KkddJm6Sb5TuP++hw8YVPSYoUDO9nqav2IwIVWb5yFFiHsCXuWcTgAC/+8pDMSx h83Mq+zoZz29Gy+Zi/lSBSEWdRPKtZEiywfDwxCRF1388BpbPrDWdeQRIS5o/wLcMz3T F8cQ== X-Forwarded-Encrypted: i=1; AJvYcCWBBoL/ADKoUmI4e1K0VsIBEOtjzdqIe12oh9CVwnzLCURwxP3Uf5Phj+SJWGKpwxVNW1OqFFCOnM78yqY=@vger.kernel.org X-Gm-Message-State: AOJu0YzOXozCdJ5n5asI/ORiEaRtEw07S05IBEY/9ZPuplxQQ1RyLpH4 EDZhzs3sIXWzPAK+V4MbzOngagncAhI3wIIpI8OJjDoaKjkAc4Z2163wHbVkYF+itPE= X-Gm-Gg: ASbGncsORzc1VbLlQij8zoAcOYnxTKGrVg9XANlWwxNhNoilzKbF9WYChZceGaYMPXk ikytosridvajASRyQGOoNwiVEQ0olN/Q95jtlIqMqF0ZcCavF/azu7Kh/wGN5crMf2YCUkcveFY bsroG8uYORSwByMmHpOMbEdCXNR+oSE2uh1QvdydIX3ofIV3LmkNNPQQiHZqv3ofOIs4qtgZkyw VrONnk+BB7exNCeer+0t8xt534m2YI3ohIwJOMyxW7fiIgSsCPclU5doosB1V/2Jr9aUxh2DxWy OA9JB76joaLtJOGiNL2UDY7OJAstA+OfkvUsWB4hlykfzfDZMHVgWnO8U82ZUeTQYu2ehgUPpcH k9E3YI91IDICuKo0nVP4aBNcQi26+KjsbDtZCwlmhYqdu63gC8SI5XAws5y/wZnJmUfr6PBFpbT 7b3zgbnCfW5Wx2l65gW91wfkd4M9fex3D/SWTdbCcrHMKExMURrxViNpzDmbe6KAQLuQs/+LhA+ bY= X-Google-Smtp-Source: AGHT+IFgETqaC11zCIghKXmz8a2Du8BZsnSjgwTiIV4/AwfFC0cLtuFvwMtSg09tu/Is1VZI3/5I7Q== X-Received: by 2002:a17:907:9494:b0:b73:780d:2bcf with SMTP id a640c23a62f3a-b7a2432fd1amr1148519166b.16.1765281602948; Tue, 09 Dec 2025 04:00:02 -0800 (PST) Received: from localhost (p200300f65f00660846b2ba6e435ad603.dip0.t-ipconnect.de. [2003:f6:5f00:6608:46b2:ba6e:435a:d603]) by smtp.gmail.com with UTF8SMTPSA id a640c23a62f3a-b79f4498947sm1338972766b.15.2025.12.09.04.00.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Dec 2025 04:00:02 -0800 (PST) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Ioana Ciornei , "Christophe Leroy (CS GROUP)" Cc: Greg Kroah-Hartman , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH] bus: fsl-mc: Cope for unbound devices in fsl_mc_shutdown Date: Tue, 9 Dec 2025 12:59:47 +0100 Message-ID: <20251209115950.3382308-2-u.kleine-koenig@baylibre.com> X-Mailer: git-send-email 2.47.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1256; i=u.kleine-koenig@baylibre.com; h=from:subject; bh=D+TP//wjPltlG0/Y49/xfy2Rewaag9dC3HNcA+UOyQo=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBpOA823BEGyNQrUN6u3myCd6N6bdWfKs1ZFblBd 9v+hzs9veqJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCaTgPNgAKCRCPgPtYfRL+ TkrACAClnqHkRti/GhhFX2g8Cvpp+VW727Q9wsexzhfcUxB92YXNil6Dm+HZ4l0OZfJL+kfS7Iq PZ4IczMKbeAfFFqJeUXTgKkWg60xVNYC/df+BvO54HN0CdCVqJ+daJTHsyKPdFqaX1X2Ej97bl2 6CSFgmk3HI7qRjSs0a4VsNqjb/i3hUn/g7aMe8FNDic/GATldzG4tHVp+1tvaCkyzrznEsxKcbX WB1e0lyK1o9u3aMyVpmLiWexLXMhiZ7U8BsIsM26IUptUEK0i4idQDjOW4PiZBSlk6m6sjIZhTz DYPjBQZ8qnSUwIoDjkZw3iGsb9muWbGbQhAKuSdF74Y3FtXb X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable Other than a driver's shutdown callback the bus shutdown callback is also called for unbound drivers. So check for the device being bound before following the pointer to its driver. Fixes: ef980bda574d ("bus: fsl-mc: Convert to bus callbacks") Signed-off-by: Uwe Kleine-K=C3=B6nig --- Hello, I pointed out this issue a few days ago in the thread that resulted in commit ef980bda574d, but didn't receive a reaction so far. Given that ef980bda574d is contained in next, I guess it's time for a proper patch to fix the issue. Here it is. Best regards Uwe drivers/bus/fsl-mc/fsl-mc-bus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/bus/fsl-mc/fsl-mc-bus.c b/drivers/bus/fsl-mc/fsl-mc-bu= s.c index 6bc163d2ca49..c08c04047ae2 100644 --- a/drivers/bus/fsl-mc/fsl-mc-bus.c +++ b/drivers/bus/fsl-mc/fsl-mc-bus.c @@ -162,7 +162,7 @@ static void fsl_mc_shutdown(struct device *dev) struct fsl_mc_driver *mc_drv =3D to_fsl_mc_driver(dev->driver); struct fsl_mc_device *mc_dev =3D to_fsl_mc_device(dev); =20 - if (mc_drv->shutdown) + if (dev->driver && mc_drv->shutdown) mc_drv->shutdown(mc_dev); } =20 base-commit: ef980bda574d3a2ebaa297def62f03d2222e6ef3 --=20 2.47.3