From nobody Fri Dec 19 11:48:16 2025 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A1A3280A5B for ; Tue, 9 Dec 2025 09:02:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765270935; cv=none; b=RPG6Eyvl5NQ7sl44oIxxYuKQp/9Z+ikP/8eKvT79koX2Ybk0RO2BHkrXB8SepKtqo1V3yRXT9ReYp6oyX2lXnJHh3PnVXCB7Qxn0jg1/y5WWqxbXTEox+bt3m092+Jxx5r5OdZFLq15aDJc0qnaK8doj5RYKvoqi0LQfJyxc9WE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765270935; c=relaxed/simple; bh=54Xh/j2WhG2Ei4a1qEnIpkmDGonn8ZggrBoCMAcXO3g=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=DZMFaEOEKk0yXE1iWuxZr1j8lsBLl+bgEcaZZ8Io7EtzdCojuT5fQmByFTSrg+eOf9+9McLdgDkKbH+lxcxZC7cAnOmuZVgKXeOYCwENtW3FEhSlrK0QCPgkRjg6OdGvahT2YRiQqu6HZfnfVtH3lUv79FKmHZTQP02kwz2cWAM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EpJxwryK; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EpJxwryK" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-29806bd47b5so32097485ad.3 for ; Tue, 09 Dec 2025 01:02:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765270932; x=1765875732; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=i/7vzy1FUoDsUfjpWUzueUpIzsuHBaOImPA4L+Mj+ZI=; b=EpJxwryK9g1Feixo5HHg0A7IWUjHhSJZm9ujaEBQ9sWhRetOzFD3gsyryoOuyYVUBJ 19Rx37MWHMc/F+ASQSz0osshuiVFw8yVyYJRhaNqSTphkLEfR0DmMrC0q6ACdLYGpRHP k0yKYhmmAoAgYzAmVppILLEScbdCuZZyhUYeRQiEpb5KVxVYpi0H9xXddfTGa6sfcSST FdWWUcc6l0AwwalAkqJ/DCpJvEDPQ0SEw9BYRn4EJKnThghmHaotEaw3MdTvV7mhx7vY 8Gxvz0EE08zYWCKUQFmw07iIiPoJNq+Ozq+4xhqxM43CfFRz62SwrzFM6U6hv9a3lOjn QdXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765270932; x=1765875732; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=i/7vzy1FUoDsUfjpWUzueUpIzsuHBaOImPA4L+Mj+ZI=; b=bjBbaGQ+gN92PSMbeodhKBsBwhCp/Yw8QJwXqWtBTTTudXpLIEo7dJuPn47m8h5F3b G5A+xJmMvly1CSU0I+xd92b/BlUDMNyC5QLKmtBDi3FqXu8bC53nd2sET+zvn/3aEp3Y yuwHFemJ2eC9FbBkmNr3Kd5NN0zKEJMwjHrRIJSMDAHsoLc6Jali9MHTrzIOMIuVGp2l Rj3qY8ImE2ZoHRovJS1yzCMGyYHdCtrwU8YmVGnBqflfIF+9fXeqpvwzEv10SKiouq/E Z3DDKTXGcFUzwTuOLFnsdW4/pDk1nyn79D3SdLs7D5PGCddhWnZNVY06Ml73XUVP25Av Ipyg== X-Forwarded-Encrypted: i=1; AJvYcCWR0EZITXOiDA9Cz4/whm57sVQX6TBp3qsUW+JOM1DGRML6XqI/rFcU5gqC8ehfaQAT44sjbSdFY0Bp0LE=@vger.kernel.org X-Gm-Message-State: AOJu0Yx/YYXEe1SuXNFgiSR3IyDl1bKYeUemToByq4zEYfgQIBHnuwzy ahWSvWqTkOJoGRIUb1tG5VhCCQkKDHKZwvQFXtuEWyvPJ7wBxo67YiIWlL3mDg== X-Gm-Gg: ASbGnctWk7Fls365KkjvixkBXp2i9+lLztJSK9e53eWJANmBXhPNjke1akYx6AoOl+e Q5Q/0nKJsOUNUgAe9iS9MlHIwWLNG1i+9Bs57Md7bSwJwRUjHurluOmhhnNBHQeG2pkg1ceheCX 6LfRLA3C2M2gvQbtPeOsR5vfnfr1LG0KFmrkAAVnHmNyZ5DcLtlLCOafsVStT4fpOMP8mRHcE20 QTmnRIyIHdHMbsAmB5n7lLR+9JerEK0h57MS1FTeMx3C0iZvJ4x6JqCzNxnP2VYQ43ChMf8gs7G Tw9yfE7WXBlsB+OtTha3NNqSPq7ZVejD8RiFAhjpL4HSgm1pzsoZ2O87QIPLRvngfh0SZfVH8i2 r1/vSKTTqsLkX92dpG+Mtv9MxV+jONEGY+bxawZ67zfSIpfWMcQhCZwOmGNwXRHrlSRDLpz2Laj aPEY5hbsKKjofV6yNO2WT75KoFjYuPoY+E2e1D X-Google-Smtp-Source: AGHT+IEWOR2FgI2CN9m4o4aayuOxDe2oGxmpJeGBPF7NkEyhYo7Qnk9E6QoJf+0EWwAzSeLh/XP9Fw== X-Received: by 2002:a05:7022:170d:b0:11b:9386:8258 with SMTP id a92af1059eb24-11e032d86demr4398847c88.45.1765270932150; Tue, 09 Dec 2025 01:02:12 -0800 (PST) Received: from localhost.localdomain ([104.128.72.41]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-11df7576932sm69700982c88.4.2025.12.09.01.02.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Dec 2025 01:02:11 -0800 (PST) From: zhangshida X-Google-Original-From: zhangshida To: Johannes.Thumshirn@wdc.com, hch@infradead.org, agruenba@redhat.com, ming.lei@redhat.com, hsiangkao@linux.alibaba.com, csander@purestorage.com, colyli@fnnas.com Cc: linux-block@vger.kernel.org, linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org, zhangshida@kylinos.cn, starzhangzsd@gmail.com, Christoph Hellwig Subject: [PATCH v7 1/2] bcache: fix improper use of bi_end_io Date: Tue, 9 Dec 2025 17:01:56 +0800 Message-Id: <20251209090157.3755068-2-zhangshida@kylinos.cn> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20251209090157.3755068-1-zhangshida@kylinos.cn> References: <20251209090157.3755068-1-zhangshida@kylinos.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Shida Zhang Don't call bio->bi_end_io() directly. Use the bio_endio() helper function instead, which handles completion more safely and uniformly. Suggested-by: Christoph Hellwig Reviewed-by: Christoph Hellwig Signed-off-by: Shida Zhang --- drivers/md/bcache/request.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/md/bcache/request.c b/drivers/md/bcache/request.c index af345dc6fde..82fdea7dea7 100644 --- a/drivers/md/bcache/request.c +++ b/drivers/md/bcache/request.c @@ -1104,7 +1104,7 @@ static void detached_dev_end_io(struct bio *bio) } =20 kfree(ddip); - bio->bi_end_io(bio); + bio_endio(bio); } =20 static void detached_dev_do_request(struct bcache_device *d, struct bio *b= io, @@ -1121,7 +1121,7 @@ static void detached_dev_do_request(struct bcache_dev= ice *d, struct bio *bio, ddip =3D kzalloc(sizeof(struct detached_dev_io_private), GFP_NOIO); if (!ddip) { bio->bi_status =3D BLK_STS_RESOURCE; - bio->bi_end_io(bio); + bio_endio(bio); return; } =20 @@ -1136,7 +1136,7 @@ static void detached_dev_do_request(struct bcache_dev= ice *d, struct bio *bio, =20 if ((bio_op(bio) =3D=3D REQ_OP_DISCARD) && !bdev_max_discard_sectors(dc->bdev)) - bio->bi_end_io(bio); + detached_dev_end_io(bio); else submit_bio_noacct(bio); } --=20 2.34.1 From nobody Fri Dec 19 11:48:16 2025 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3BE6C27E054 for ; Tue, 9 Dec 2025 09:02:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765270938; cv=none; b=Uq/puitEHnVAkUawZtbkoekQ9h59ZnW+h45K2mohntKmE5yowpT2UIScXphF8w48E9K9fGSoc/O2zL9mM/vQvuocUWXi8aL8G39RVAKBIUoIvJvq49tHwfOFHgTD+qmIJ4tYcKkwlTFP4P3yIlzmDdzsL2m9a6vRmZKMuiVlNPk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765270938; c=relaxed/simple; bh=4CeP8091EqjUK9CskNSlEn27rcVvsb9klIf5F54UFj4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=I3gm4VzsB7u8fuNijkm9b7CqNMHP8VXCK1sqM5GUnDMxaPlFaRnyohIVYIVql7VU9CKQbRmuh5sMyeR76fLQcGbv/rEWvh14Zj4ONlzcxHieciAraSrEXDHVX9hh49B/Lq2LCG8Z1uwXuiFnQWISZB0bIgBoN/ZdTvyZFGHnKSc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=U92gp+DN; arc=none smtp.client-ip=209.85.210.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="U92gp+DN" Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-7aae5f2633dso5862416b3a.3 for ; Tue, 09 Dec 2025 01:02:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765270936; x=1765875736; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FDKxCQi4WubAv8KgzENdDuZ74b0CZmQcA4s08IiUA3A=; b=U92gp+DNB8aTeJFSPPcFW8Df4V6N3KpXKzI/GvYks6SIJvxKwcc80tWL4mLkisWHBt eCRq+aaula5gnIpnnxwtzbAp9mF1TJ7+V4bKqooWAwb/SeninyaQRUPg5Mdr//IUeLSU o2dUxc/iPw+x+iaapBdd/mgRcOQ5Zg2CSil/WPOdxi2DeMH0OElgOyFem/icwi9Ux1JQ m1K6Qm2keAuKEJkALmQCx72EmnSq3d6/kwNVDx6GaNw7irCoh/H6nXrlY1Gmg2RF8xnm LTFayombFysbwPamMoNl5Oq8HMg/KLR1R8w1ecwdCHX7/rbO+hUvvmeaOmG9gMgcIjVL hlsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765270936; x=1765875736; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=FDKxCQi4WubAv8KgzENdDuZ74b0CZmQcA4s08IiUA3A=; b=LaMT5Jj41l93B5sse3alMYe/y1nE9fwuakjrniWIf2Cmf3H71Zy6CmXs1/no0BF8qE TrcBRl6gfQNVT5iznC6+TB7ZFd7jqXvz2hMThTYeXheInhos4/yRXwyeLpNjzbtptq0M FqygPuOCgsdaPOh8KFi8kXih7+TJE44T188I/5cRHwPR05um/xK7qTot1igxi9HBWGzJ 3XrWpDo7vDeTMIJGLM48tdsO6ywo8gco5QSyRz767wwWV7VzBsPb/UyvieYW/eqgiG9F XEMzpHUXZaf7WTUag7NCCYhdywGqq2zjNPb4aOTSICRsixmMbDURnqTDq6rW27+sN0Lh JNiw== X-Forwarded-Encrypted: i=1; AJvYcCXUJlNNoNVuB5jAInoClWKsIIqwQogtbiflznqIY/xJC1e1PMFx3bXYKl1zfo6NHvupmqpbZTvncev1p8g=@vger.kernel.org X-Gm-Message-State: AOJu0YxyplAqGnqw/IvvnjTu7yH4XKQhkIEuIMuxwbJbbGcE5V5wi+bT rhDy2BSuVMOr7d+zCiZPBjvrQqzeQ1nbr/Df0SDnfa7rK4uBkAcFMdrn X-Gm-Gg: ASbGncs5locy1Y9tS4F1aha8ANEuoycMwAS8V6KSi3wIBZqBOrtf0lvveQL2Jr5HOfB yfvuYujltldmWTW/URKbi4LR0SZbRnmmgrrRL5neED/9m91d4emfQc3XgQq9oTCI7qH7lMQxqIe r39wytrYjLXW6WTimpSPNrf8jvb96sRwCTZ86Bt/AjzGlw2DzrmOpuMSMEHAte0rtZLncR9ahR9 yhMizfTe0alt2yaaCdAJjlT9rmjnozN1B26UxuI9P8z68j0/ynCJPNnQ3t3zvK9AcOsj+Uo8hya ZSewe/5FBc4jf+vgvzVVGi2vr+4YmNpwxu1Q6l1Za+NYGuAhK6aqbKEMlhphXjvnjVjG7bsoOR5 O2uVaJY2XivzN/rcAn87WdTXHDls2mr1Gj5rppN6Hpyd290Fo1EjUx8WVnoNdGJkDRB2ywB0TcQ TdaYLpZ32yg4ibMOIIQyByVQNzdg== X-Google-Smtp-Source: AGHT+IH8UlmlQXv3ttCFRjc372AUW0Jx64eBzRuhm6/sFfQMDcgq/zQ1pavi1pYW8AOCCBSPo+vrzQ== X-Received: by 2002:a05:7022:239c:b0:11b:9386:a3cf with SMTP id a92af1059eb24-11e032ef6f6mr8436937c88.48.1765270936449; Tue, 09 Dec 2025 01:02:16 -0800 (PST) Received: from localhost.localdomain ([104.128.72.41]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-11df7576932sm69700982c88.4.2025.12.09.01.02.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Dec 2025 01:02:16 -0800 (PST) From: zhangshida X-Google-Original-From: zhangshida To: Johannes.Thumshirn@wdc.com, hch@infradead.org, agruenba@redhat.com, ming.lei@redhat.com, hsiangkao@linux.alibaba.com, csander@purestorage.com, colyli@fnnas.com Cc: linux-block@vger.kernel.org, linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org, zhangshida@kylinos.cn, starzhangzsd@gmail.com, Christoph Hellwig Subject: [PATCH v7 2/2] block: prohibit calls to bio_chain_endio Date: Tue, 9 Dec 2025 17:01:57 +0800 Message-Id: <20251209090157.3755068-3-zhangshida@kylinos.cn> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20251209090157.3755068-1-zhangshida@kylinos.cn> References: <20251209090157.3755068-1-zhangshida@kylinos.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Shida Zhang Now that all potential callers of bio_chain_endio have been eliminated, completely prohibit any future calls to this function. Suggested-by: Ming Lei Suggested-by: Andreas Gruenbacher Suggested-by: Christoph Hellwig Reviewed-by: Christoph Hellwig Signed-off-by: Shida Zhang --- block/bio.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/block/bio.c b/block/bio.c index b3a79285c27..d236ca35271 100644 --- a/block/bio.c +++ b/block/bio.c @@ -320,9 +320,13 @@ static struct bio *__bio_chain_endio(struct bio *bio) return parent; } =20 +/* + * This function should only be used as a flag and must never be called. + * If execution reaches here, it indicates a serious programming error. + */ static void bio_chain_endio(struct bio *bio) { - bio_endio(__bio_chain_endio(bio)); + BUG(); } =20 /** --=20 2.34.1