From nobody Fri Dec 19 08:23:03 2025 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E43D43203A9 for ; Tue, 9 Dec 2025 06:12:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765260771; cv=none; b=cPcgjJLNTAnTQ4SrzZP23PxKR8NaLolvGAMIVGDltFmhR/MftrWPkkj6NF073NQJIbO1dgU/qfvlWy2nKM9KXi8NkGHVrPowky4OCXu8aIe6bno2pP++xrPNRSwmjRD9CkbuqXGytfZyXC5u9fVjAHltpeE8uif86lTlNrc6roI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765260771; c=relaxed/simple; bh=5HEwMc6g/H+WmnrQeMOy4bf3TlkDuTzuPc7R+m64k60=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=nWsWq3btEbw79gPlBAsvfgtXMebkx2tKEnok7ogzVbMiWeo82Fya5V7/SKPh+MJ1yT0gd8Pn+76XXSCXmLRzlMTQKXBXyhwy7fdHqwBTpz5OL343Y9uwoAe9iEMjBZqXJ0CoqqeJU8X66Z6UaZhctqB/9gWWUkEsLX/PiHMgwy0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=BHpfpaQF; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=PO41EEi1; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="BHpfpaQF"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="PO41EEi1" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5B8NXgCe2368397 for ; Tue, 9 Dec 2025 06:12:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=qcppdkim1; bh=/4YrqwbCQbEUroydksm+hI1mp31D40f4JPv aO4QqkN8=; b=BHpfpaQFBR7jKvT85E9brEImrrQqFfFjmYM5qjI6Vxjk/bTlph0 wgut916uUk+zY1+qrGK19zJdbQ1JHXOiz3baJtqrbmyY4XQQHZ8LgOHF5gTNkqjs oa+VOf+A/+KKJ9SAh0D8k91fuOG4stbY9niSLcvZCPacok8/LbLnO2b3jk1eZ4MF KqrHnHR9b9tyWRnU5j7VohwXSkbzQr5oEAhE9n0Fv6rg+bdzIAKrbanalYfoJZO3 NOl5XD4vYtORXjronf4NEJrz2e/08h/BiJCJRUK+NtBw4av+avq0oPUUnBZO5NTk /wicEHaQJG9zy2vN8VTfF9cSJObJLSxDn7A== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ax4fqhk0a-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 09 Dec 2025 06:12:48 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-7b8973c4608so13322640b3a.3 for ; Mon, 08 Dec 2025 22:12:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1765260767; x=1765865567; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=/4YrqwbCQbEUroydksm+hI1mp31D40f4JPvaO4QqkN8=; b=PO41EEi1YzbNt+bkJzEYQac4jFIgHtIvV3n9JR04bbYKa+UWfkTIoSmoMo6WTz4ake dVLmg2+WjoucGZlyM8GnSwNuy2RjCI+T1+xY1hHmvFmT5FcLwVBCJCvbpul71Z26FWy/ zt4dEHLcZP2eU8KITg9eJoEjioQGPZVjkbWGoGeJsIlXAGrpCNGao4K3eW0BT+H1qfXV 5uPvszoIypQ9X9ll50/iQzdMVl14cZFJl4IG8GlspeZIPnEZT2m5kJOvhVvxzN2NaIgr FwWAve91d1uM3+gH5k9W9t36kyFIFTSaMhogHzT2+k+89ur3io5fC5L70ne1gPps6FLl GRfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765260767; x=1765865567; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/4YrqwbCQbEUroydksm+hI1mp31D40f4JPvaO4QqkN8=; b=Xla++gVuLrPyq5xdSvikOtBOq5SDMB4A0nnU0avbGYTsX4F7GPgrY7jpEVwjzGLTz/ xp+08mItmSoWO8YnEeiIXIfQ4vtMkMcB1gMgIH3M/ot5iOf8FoJO17KZKVr29YVTRozz 9uFlkpHLrkeGvlixNd/TfOZwqIQhjRTbyh4ArEgCqLg+bvdpKOdJukpxKMFGDaC/1Qeu XLyWYMQQWYckaIZPJ1z8FXbaW/l/Vieh9kd4LWUOUfAdLerfin+LGJiA9DucsJUW4wL8 asM2gBFjDMb7jKBi7Eur+Jzb03X6Hm6USZ4SAeG/uHY3vEExgTKaGi79Y1FfJ2GqIOsL Av4A== X-Forwarded-Encrypted: i=1; AJvYcCX46GS1mfy4ZzrJYpGirpGz01eiXIHTZJbeGF87QO2Yf+tvi4kl4m2qEpM4u7pY4T7S5URiS7Oag0qGz90=@vger.kernel.org X-Gm-Message-State: AOJu0Yw+CS8lagC3NwBsViUjKD2bdcfmIpeqdKj6OKEcjLsn5E4VeJKM Jfs0FWg4DV/mHBnunI0XU795dQAHNaYuZJ7/jB33O+E3I3/dvIyB8lISxsSyMxd9rErrR2trGeP 13g2y2wRr+k5gBU4khn0jLIc6y0CXF4bOYEPTGNb9H6bMQQfx7gesGINaA5YyYctusY8= X-Gm-Gg: ASbGncvvKHmZFYq/wzUCguX+wE/TmfpyjE8ADN2i8AcsngeKsBGPgrfRP4NIt/tMBdb QD6XJlHmfXNYqjSK71ujDVjt/orAhYQS4X1sM1JpylhQau1ezr/ZCgH2lo/9Jt679d98Sl1S+T2 s+cMsio1eli33HXbsOlfB9A2iCGGFj8sBuba3t9hNlgdRFSPS16gc621D9rF4q632EbMonMOGov 9c0WkMs/ydagdL9/9Itp7JWuzrmjXbSITRJJtO1B7Xh+pz7V22YWWO1Lu6et8R1XdEpPmu0H+n6 nKbk2J+ZrcNaBkOG9NbLlqZDrBt/4OrCUmU6951gdJldri+fhTEyWBoRdYQ03PmQiY4/HGbqdWG 1WbRuxrIppNg0P3mo+2gPQdYUgWVfg5qjGDlIqseV27O4sXk6HLQZrWQesdK4VzM= X-Received: by 2002:a05:6a20:7d8b:b0:35d:cad7:cd63 with SMTP id adf61e73a8af0-36617e83b4amr9642894637.30.1765260767036; Mon, 08 Dec 2025 22:12:47 -0800 (PST) X-Google-Smtp-Source: AGHT+IE0PBmC+WHQP3uF9gMRmBLS7UutMbhLozQqQ3F8Nx/VflyKd/TqjFoD6aF0IESEtICN8Y9LqA== X-Received: by 2002:a05:6a20:7d8b:b0:35d:cad7:cd63 with SMTP id adf61e73a8af0-36617e83b4amr9642875637.30.1765260766618; Mon, 08 Dec 2025 22:12:46 -0800 (PST) Received: from brgl-uxlite (fs96f9c361.tkyc007.ap.nuro.jp. [150.249.195.97]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c0259dd7bdesm4249459a12.27.2025.12.08.22.12.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Dec 2025 22:12:46 -0800 (PST) From: Bartosz Golaszewski To: Linus Walleij , Peng Fan , Bartosz Golaszewski Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski , Daniel Gibson Subject: [PATCH] gpio: it87: balance superio enter/exit calls in error path Date: Tue, 9 Dec 2025 07:12:36 +0100 Message-ID: <20251209061237.7949-1-bartosz.golaszewski@oss.qualcomm.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjA5MDA0NSBTYWx0ZWRfX5zQAO5NxCE12 7gGMlGm/tYBVVDDo5pYQDfXwPmcuCefPVndPkdsdH2UrISa1R6tXQNO0y1r0p5THAxGzhWmdQ9v HQs+ZZ855nvxmDChM7H5JdkN9HwTCJsEXrC85fEYUPQsYlL8XdGdhREKQl+JUZVaft3FJY7ULEG Sb+ijet6AFM1rrZudBEtvhgJqPEEeUYWpfW/1J0O3ZheFH8w0ERSBTHFfcRUv25sAaRzjdt+DHu tIzFQrB0muks2Z6gpzWaNuvOTcvk3ZiVZRkkJID/iIUmZzjMdIFfwuUK6qOR36mBeLy9socZ6L3 qMX2sPgZnGTtF4vh5on7CSLJKzbnNYDGto+asEFlxxcGdsgnOSrrPUVgYsYko33P4OAUFaNj87F ZtyJrpdKmbr0EbWwh3bMJDvzELLvfg== X-Proofpoint-ORIG-GUID: 2x2uA_l0OGfgzOwnUZD1HrfG13KaboK2 X-Authority-Analysis: v=2.4 cv=TPFIilla c=1 sm=1 tr=0 ts=6937bde0 cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=kS9sT8ua8GhuIhCqqd6Lkg==:17 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=Rq-G4BoJ1QqpnPmLVJEA:9 a=OpyuDcXvxspvyRM73sMx:22 X-Proofpoint-GUID: 2x2uA_l0OGfgzOwnUZD1HrfG13KaboK2 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-09_01,2025-12-04_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 lowpriorityscore=0 adultscore=0 spamscore=0 malwarescore=0 bulkscore=0 priorityscore=1501 clxscore=1015 impostorscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512090045 Content-Type: text/plain; charset="utf-8" We always call superio_enter() in it87_gpio_direction_out() but only call superio_exit() if the call to it87_gpio_set() succeeds. Move the label to balance the calls in error path as well. Fixes: ef877a159072 ("gpio: it87: use new line value setter callbacks") Reported-by: Daniel Gibson Closes: https://lore.kernel.org/all/bd0a00e3-9b8c-43e8-8772-e67b91f4c71e@gi= bson.sh/ Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-it87.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-it87.c b/drivers/gpio/gpio-it87.c index 5d677bcfccf2..528ac1890613 100644 --- a/drivers/gpio/gpio-it87.c +++ b/drivers/gpio/gpio-it87.c @@ -254,9 +254,8 @@ static int it87_gpio_direction_out(struct gpio_chip *ch= ip, if (rc) goto exit; =20 - superio_exit(); - exit: + superio_exit(); spin_unlock(&it87_gpio->lock); return rc; } --=20 2.51.0