From nobody Sat Feb 7 16:25:39 2026 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 548883B8D63 for ; Tue, 9 Dec 2025 04:28:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765254500; cv=none; b=KtjF+vldHptGbtyRi/3BpzxhuAUGFLTMq0aN9mDVmyARLKdU0xIbaIgvgM+91uQgTonh0XUHlAEMv+EsiefzDK+Ta9Bn8b2UVvGVvVCasGxr2tcXNjraO2IDECPEAM5ePofk1muXkHtTL+1QIeUmM2ISCiL0fjWAV4DiknPKv4E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765254500; c=relaxed/simple; bh=nshWNu78Q/XMh0LlE3oui168SyNeyp8mzorR1kZ8bsA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Lysyg7Ktbs5DwlTtCMP/rhmue5S7VdTqKhhWw9+4UQjroipAWXaD8IhNFtP6/cF4lXxEkMLoWOmil3euQzszpA8j396zvtpnXWxxw1zVhVP7Z46J+sOesOmZcD2f0PhlLp+Bw9tV2gIpgJorhNnJWjPqprzmh/UdE1748Ti4/98= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QsECSg+d; arc=none smtp.client-ip=209.85.216.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QsECSg+d" Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-340bb1cb9ddso4282623a91.2 for ; Mon, 08 Dec 2025 20:28:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765254499; x=1765859299; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=okmIi4vWYl0QHDsaJwQNy/3wmdsCyJzm0p/g7ebWdjU=; b=QsECSg+dJ4DzL0l1Lo6jg3hQ2OIjMM4PSdt7Dk+xvAuCoD2luEvLgUaewALpsW4EzZ PFNrLx9xaYfhsroyyfXB6ZShfCVopsFgOa2m3V6/+JVZIdTvfxb7DwlZU3FQHFDjh7tx Pb5gdDNcbR1xWTd0JCNDW5vhYh21io8pBiXfcsUhCpW1Ms+x9ctFJa4X34TTn5a0cxgS P8N/Gu1sMi9FlQRnKNqD9xe1Kps++QDhvwjncASR0DCWC5JPXW2k95bJinff1g3fdNmK Nubeefy5VQZ3ttzuvo4b+erx0sbzFIKt1FJUDV7Xe6I3KAkwaucJh1OFuXRvC6UelGvH 9VYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765254499; x=1765859299; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=okmIi4vWYl0QHDsaJwQNy/3wmdsCyJzm0p/g7ebWdjU=; b=nyPNSpmkfgvodXfkrdIvVUp+tQ70RnrnSGusFx/86COkQXFXkInZDXfa12upJSpppl 47pAhzQuyCn8uMLggX+f++HYN2eP+8lC3TR5yQDzckr7SE4sr831cRjun2kF+Zkt/kof E5BLMerWT/cYeFn/1ICdwuGQnEDaexfzn6qQ4l9Q6ZfLZZFLkMu9CgeOIFcz2iymAq4+ C1HCC99jjI1CEC7bZNVvbwodAbZemKbjRzQvpMqSWtn/xIq4kkCyoFtEc16Bu2jIDAr2 iiAAtBDuMOcc4vZhu6pdFBCikHdMVgcFKrp0L+Kv7+J36yOiD06Qd4vEooezvgbZjkL7 ceVg== X-Gm-Message-State: AOJu0YwJVXfHrc+H5YV6tbSNjCZxDPRpx64cOotJSmYQx145etccFItY wui02eAipeu6ADMQtNXh5IkqQ2OidyIZ/qQKJNhSy1sgfp9FClpHVAsROvbMo3oS/yU= X-Gm-Gg: ASbGncu5y/YBDOWnBLf1i3uwwYd+ZgHJ4Miu5HPVlHRD8gxufLiTyyilwAbEqvnMU8z mrhLydlpScYKDoYLevhTV2HEw4nUGDfKWIkKwIKM0a6UInKXbVW5zrx8b8JRmH7914fUeK6Jslj p5qwQMgvX+ojsTGL67C8NmMY4w57h2NDIiWtFhbO+2gSvc3rgrENzKrOOksF1KYc3Kekq1EpJVQ vPhugzXoBjylF/MdWWd1huNOWPKjVWxmTtHzJUy1mqA+8F4qQvzVLkb9WG67EFE7Z3SDlDCdU+J sG+WtRJ7tQcsihQ2IB3/A+8biHXquZUPCEiLvqYIfH+kS2rFnXs3Qi3FV+9PnU1ggIon8RC1ztz FXPT/wDYgr6YhYmzPDKVfrq8xulHq77Ds4J5P5bca5J2osqQrfBxRIoBx4WlGpMAZ6tLC/E+HPH l4LMtW9iIniGfviuUuy+H+T9g1s/zFRM5gKMtnDei5isE= X-Google-Smtp-Source: AGHT+IH/sZjDstHQBk/4kkoOc4q4BWQ69NzeICX5PBywIS3oa9fbeB6YzchPZljjw9QmJ7GHpZIn7A== X-Received: by 2002:a17:90b:1801:b0:340:b908:9665 with SMTP id 98e67ed59e1d1-349a260ac22mr8426365a91.37.1765254498693; Mon, 08 Dec 2025 20:28:18 -0800 (PST) Received: from cmpatel-home.hsd1.or.comcast.net ([2601:1c0:5780:9200:b455:298d:48bb:1784]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-34a49b90fd5sm765185a91.10.2025.12.08.20.28.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Dec 2025 20:28:18 -0800 (PST) From: Chintan Patel To: linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-omap@vger.kernel.org Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, tzimmermann@suse.de, andy@kernel.org, deller@gmx.de, gregkh@linuxfoundation.org, Chintan Patel Subject: [PATCH 1/3] fbtft: Make sysfs and dev_*() logging conditional on FB_DEVICE Date: Mon, 8 Dec 2025 20:27:42 -0800 Message-ID: <20251209042744.7875-2-chintanlike@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251209042744.7875-1-chintanlike@gmail.com> References: <20251209042744.7875-1-chintanlike@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The fbtft core and sysfs implementation unconditionally dereference fb_info->dev and register sysfs attributes. When FB_DEVICE=3Dn, these fields are unavailable, leading to build failures. This patch wraps all sysfs attribute creation/removal and dev_dbg/dev_info logging in #ifdef CONFIG_FB_DEVICE, with pr_*() fallbacks for the non-FB_DEVICE case. This makes fbtft fully buildable when FB_DEVICE is disabled. Signed-off-by: Chintan Patel Acked-by: Thomas Zimmermann --- drivers/staging/fbtft/fbtft-core.c | 20 ++++++++++++++++++-- drivers/staging/fbtft/fbtft-sysfs.c | 8 ++++++++ 2 files changed, 26 insertions(+), 2 deletions(-) diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbt= ft-core.c index 9e7b84071174..dc967bdeabe8 100644 --- a/drivers/staging/fbtft/fbtft-core.c +++ b/drivers/staging/fbtft/fbtft-core.c @@ -365,9 +365,14 @@ static int fbtft_fb_setcolreg(unsigned int regno, unsi= gned int red, unsigned int val; int ret =3D 1; =20 +#ifdef CONFIG_FB_DEVICE dev_dbg(info->dev, "%s(regno=3D%u, red=3D0x%X, green=3D0x%X, blue=3D0x%X, trans=3D0x%X)\n", __func__, regno, red, green, blue, transp); +#else + pr_debug("%s(regno=3D%u, red=3D0x%X, green=3D0x%X, blue=3D0x%X, trans=3D0= x%X)\n", + __func__, regno, red, green, blue, transp); +#endif =20 switch (info->fix.visual) { case FB_VISUAL_TRUECOLOR: @@ -391,8 +396,11 @@ static int fbtft_fb_blank(int blank, struct fb_info *i= nfo) struct fbtft_par *par =3D info->par; int ret =3D -EINVAL; =20 - dev_dbg(info->dev, "%s(blank=3D%d)\n", - __func__, blank); +#ifdef CONFIG_FB_DEVICE + dev_dbg(info->dev, "%s(blank=3D%d)\n", __func__, blank); +#else + pr_debug("%s(blank=3D%d)\n", __func__, blank); +#endif =20 if (!par->fbtftops.blank) return ret; @@ -793,6 +801,8 @@ int fbtft_register_framebuffer(struct fb_info *fb_info) if (spi) sprintf(text2, ", spi%d.%d at %d MHz", spi->controller->bus_num, spi_get_chipselect(spi, 0), spi->max_speed_hz / 1000000); + +#ifdef CONFIG_FB_DEVICE dev_info(fb_info->dev, "%s frame buffer, %dx%d, %d KiB video memory%s, fps=3D%lu%s\n", fb_info->fix.id, fb_info->var.xres, fb_info->var.yres, @@ -804,6 +814,12 @@ int fbtft_register_framebuffer(struct fb_info *fb_info) fb_info->bl_dev->props.power =3D BACKLIGHT_POWER_ON; fb_info->bl_dev->ops->update_status(fb_info->bl_dev); } +#else + pr_info("%s frame buffer, %dx%d, %d KiB video memory%s, fps=3D%lu%s\n", + fb_info->fix.id, fb_info->var.xres, fb_info->var.yres, + fb_info->fix.smem_len >> 10, text1, + HZ / fb_info->fbdefio->delay, text2); +#endif =20 return 0; =20 diff --git a/drivers/staging/fbtft/fbtft-sysfs.c b/drivers/staging/fbtft/fb= tft-sysfs.c index e45c90a03a90..944f74f592d0 100644 --- a/drivers/staging/fbtft/fbtft-sysfs.c +++ b/drivers/staging/fbtft/fbtft-sysfs.c @@ -89,6 +89,7 @@ int fbtft_gamma_parse_str(struct fbtft_par *par, u32 *cur= ves, return ret; } =20 +#ifdef CONFIG_FB_DEVICE static ssize_t sprintf_gamma(struct fbtft_par *par, u32 *curves, char *buf) { @@ -145,6 +146,7 @@ static ssize_t show_gamma_curve(struct device *device, static struct device_attribute gamma_device_attrs[] =3D { __ATTR(gamma, 0660, show_gamma_curve, store_gamma_curve), }; +#endif =20 void fbtft_expand_debug_value(unsigned long *debug) { @@ -173,6 +175,7 @@ void fbtft_expand_debug_value(unsigned long *debug) } } =20 +#ifdef CONFIG_FB_DEVICE static ssize_t store_debug(struct device *device, struct device_attribute *attr, const char *buf, size_t count) @@ -200,17 +203,22 @@ static ssize_t show_debug(struct device *device, =20 static struct device_attribute debug_device_attr =3D __ATTR(debug, 0660, show_debug, store_debug); +#endif =20 void fbtft_sysfs_init(struct fbtft_par *par) { +#ifdef CONFIG_FB_DEVICE device_create_file(par->info->dev, &debug_device_attr); if (par->gamma.curves && par->fbtftops.set_gamma) device_create_file(par->info->dev, &gamma_device_attrs[0]); +#endif } =20 void fbtft_sysfs_exit(struct fbtft_par *par) { +#ifdef CONFIG_FB_DEVICE device_remove_file(par->info->dev, &debug_device_attr); if (par->gamma.curves && par->fbtftops.set_gamma) device_remove_file(par->info->dev, &gamma_device_attrs[0]); +#endif } --=20 2.43.0 From nobody Sat Feb 7 16:25:39 2026 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 507713009E5 for ; Tue, 9 Dec 2025 04:28:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765254505; cv=none; b=YVir9M2Uh4qhj2esAPgGpctyeOtDM+/bAaY2vHaDMWmgU13yBUCHAucHcDUkLuZKxPbRP/1bEJlBEQwtNpPmSQeaMmMIFf4OvIsfK+BMxnLz8CT6T+I/5sMsBBkw/oVyfNgzxj9r6Gn73MFGuF9tWL2Vuxy3k4OOu5n6OiQ18Sw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765254505; c=relaxed/simple; bh=3pidgD9TpcdjmuGEM4+2gj7Du8pBd7MRvFriroyxajI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hlqtVbYTC90pBMWn5rmcmiplVWhSq8MCqhkQn35I6yBocsESL8vzD54bc/CyUhJRyUqxM3ZjoYF48RmH6w4PZ1VD3zOZaubS0zv5FbIkn6ohyX1D7zS2vVLopA0NMSZcDAnLZ9K4hqL3lPuUOiN15KTWc0lvS6Q8gZsew/cmX+E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dTpVjikD; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dTpVjikD" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-297f35be2ffso77273525ad.2 for ; Mon, 08 Dec 2025 20:28:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765254502; x=1765859302; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DoV8ebquCT6L/RZ0AqbPbGv9Gx9G1WrRRbUTSZpd9fE=; b=dTpVjikD2Nh9Nc85uX18Y/CF7eeymtNW82EdDmUYat0Nn0eaW3hWy2d1mDIg8raI0N vBYPWMW4+VI/KgaBRhNBMhFJ1138Gu2S+xIAnSwHV+O5n5+iMJ5L/pWbth2xJANeNL2/ hiU+8+W1RTyvh2mBjgezwdSjVp0GPD8w1StXgX9lPsgCYfW+p/7OKUsz3wIaF2yAJcnd ljpa4rcpo7whB7tK0lKapQTP+zMQgESlRSc4LACfyEkhbZOUFCo8POPJbJ7pI38uaTOb Tr1tzz0U+Ab40qF1zCoMhfBY0pW/132j99/8IyleurMrGYc3l2XLBawcHT9u7bMxtjTu qpxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765254502; x=1765859302; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=DoV8ebquCT6L/RZ0AqbPbGv9Gx9G1WrRRbUTSZpd9fE=; b=mUyY5sGGUrIrt26/73Q2+WMSChZlCn3BhLcI0RL5h4uvxb/usTJ1U7ujcn3wCNozdR iFCi5Ovg/OtL07ky18q1GsHsoNpVkq20u6989gqIaIXeXmHZqcv594z5Qnkzhqg3wYaJ KgP4bTmnnzkEGEtnBLozrbljjH5gqPzulw7HwYhh0bTKx9yTTlwn9j8r/5p+WkbPqRQ0 pZUA+rEslFzy2mQvHbiETbB8NiupQqnTvJf/08rLa0dpwd1SKoiUCJN3IJPjmUeSsHj9 JK8bX/4F+ltt6nU9o9lB+F8oa1x8m17asB6uHzjC65gnkqsyCB57Q/oMAwJCzv1mD+cg gLBQ== X-Gm-Message-State: AOJu0Yw97IwPuFaXN6ZqVaXCmhiMDdbwQZdms+zFTxjUD5wuxl9dBUmS Mv0HZFISf9xLqWwyWglcMlAYbAKEwl2TQZfYSBrLyPkK5KG3qAxH8+2Y X-Gm-Gg: ASbGncvMERDqaC71d4wX8xu1weQT5dTEIuWBEH3wQ0suJQYNZgJYTyO17bnWXltMAXW EhVyHF6omxzw9flcR5usob4hqTfH9h8FO2Je7+4G0ksVWiLS5hd4s+vXX/5/8FJTJE0wQpCIRsI bQEmIk0WPoYxdDEJ7Erwep8LkdDfxFYtT0QjhzWZ2xTIDZJLn/OAwC2jw6zEWy4ByH1dcQ3XVBZ 4fdFGE8SQC3ahWD+5LvpeH59fcKdMMTeWUaCxISSt0L5zOLj5ZQAEL3caOkBDHkWYsBWjdNayq8 ojsxTHsU+m8ycPE5lp1JH4coiN58QzITW50BbTZU5OrQHPjfGHNruqfPUMQcL9zLeKSHbDGLN7g oKjDV7gTGuvd+OyidFlgE1tD05tbw3YvWhbpClbmfPqXoWgx0TlSJkIHj3a8ntHmHAC8mJLCQuA VeqNNmse1KOGe0He43DAQVAUvfo5PVH39tE5nDOY8NN2c= X-Google-Smtp-Source: AGHT+IGhZ172wJMCe8Y+hl9H/FCCQtSdsSpkHLmThykFWMzH/YAfrcNiqXS6r43YyTp5Eyv9aHLeZg== X-Received: by 2002:a17:90b:1a8b:b0:343:f509:aa4a with SMTP id 98e67ed59e1d1-349a260a9d0mr7994609a91.36.1765254501596; Mon, 08 Dec 2025 20:28:21 -0800 (PST) Received: from cmpatel-home.hsd1.or.comcast.net ([2601:1c0:5780:9200:b455:298d:48bb:1784]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-34a49b90fd5sm765185a91.10.2025.12.08.20.28.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Dec 2025 20:28:21 -0800 (PST) From: Chintan Patel To: linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-omap@vger.kernel.org Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, tzimmermann@suse.de, andy@kernel.org, deller@gmx.de, gregkh@linuxfoundation.org, Chintan Patel Subject: [PATCH 2/3] omapfb: Guard sysfs code under CONFIG_FB_DEVICE Date: Mon, 8 Dec 2025 20:27:43 -0800 Message-ID: <20251209042744.7875-3-chintanlike@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251209042744.7875-1-chintanlike@gmail.com> References: <20251209042744.7875-1-chintanlike@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" omapfb implements multiple sysfs attributes for framebuffer rotation, overlays, and debug information. These interfaces depend on FB_DEVICE being enabled. This patch wraps all sysfs attribute definitions, registration, and removal in #ifdef CONFIG_FB_DEVICE. For FB_DEVICE=3Dn, lightweight stub functions are provided so that the driver builds and runs without exposing sysfs interfaces. Signed-off-by: Chintan Patel Acked-by: Thomas Zimmermann --- drivers/video/fbdev/omap2/omapfb/Kconfig | 2 +- drivers/video/fbdev/omap2/omapfb/omapfb-sysfs.c | 11 +++++++++++ 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/video/fbdev/omap2/omapfb/Kconfig b/drivers/video/fbdev= /omap2/omapfb/Kconfig index f4cdf999a080..ee664decbb64 100644 --- a/drivers/video/fbdev/omap2/omapfb/Kconfig +++ b/drivers/video/fbdev/omap2/omapfb/Kconfig @@ -5,7 +5,6 @@ config OMAP2_VRFB menuconfig FB_OMAP2 tristate "OMAP2+ frame buffer support" depends on FB - depends on FB_DEVICE depends on DRM_OMAP =3D n depends on GPIOLIB select FB_OMAP2_DSS @@ -13,6 +12,7 @@ menuconfig FB_OMAP2 select FB_IOMEM_HELPERS help Frame buffer driver for OMAP2+ based boards. + Selecting FB_DEVICE enables additional sysfs interfaces. =20 if FB_OMAP2 =20 diff --git a/drivers/video/fbdev/omap2/omapfb/omapfb-sysfs.c b/drivers/vide= o/fbdev/omap2/omapfb/omapfb-sysfs.c index 831b2c2fbdf9..0a340f69484f 100644 --- a/drivers/video/fbdev/omap2/omapfb/omapfb-sysfs.c +++ b/drivers/video/fbdev/omap2/omapfb/omapfb-sysfs.c @@ -24,6 +24,7 @@ =20 #include "omapfb.h" =20 +#ifdef CONFIG_FB_DEVICE static ssize_t show_rotate_type(struct device *dev, struct device_attribute *attr, char *buf) { @@ -585,4 +586,14 @@ void omapfb_remove_sysfs(struct omapfb2_device *fbdev) &omapfb_attrs[t]); } } +#else +int omapfb_create_sysfs(struct omapfb2_device *fbdev) +{ + return 0; +} + +void omapfb_remove_sysfs(struct omapfb2_device *fbdev) +{ +} +#endif =20 --=20 2.43.0 From nobody Sat Feb 7 16:25:39 2026 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 996332F6930 for ; Tue, 9 Dec 2025 04:28:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765254506; cv=none; b=db6aAWTdGl9Ay1uWDq7HaUcj8dKgmPf1fkBelDqjbVRPPRBGzOUUqP/fqYCexpus/3GDMC4UhOmYaFB6OrMDeTjiGbcL1fDEDSBDfUKDctljRydOn0/LGyQGG/VBPpbI77c0seooVBWMpl3dZ5DT4fj5NQoLECyYV7Cna4I5hyU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765254506; c=relaxed/simple; bh=LxCofJzFToPOuZEjMx+TyTe6Tdr2NQUdvBjzyB7tTZg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ga14GOeQx3Q6nAV18vWJN2QloDyowZJXewUt35NDn9vgolCkNL61TAokz2pY7gHkJ7l+HeVhVe4pq2sdBwntP64xV7Y5CniYKdsuarp8OGy/pwPE4Vh8FT0g7ofC3KuSYYMDKfDBpBU8WizSRA0s9Vok/bXx5y88GvHR9ORU4vs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=goJwjEoq; arc=none smtp.client-ip=209.85.216.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="goJwjEoq" Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-3438231df5fso6539840a91.2 for ; Mon, 08 Dec 2025 20:28:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765254503; x=1765859303; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6Pa1Xejftpj9ZCjaie2sXROdWsX12z9SbomyYLGQRdM=; b=goJwjEoqVOr6p7uDo7IzL9xDE4qhUn0v1XiAr1rrsELp/IGup24aKtS62i4PlweLln +0/953zqSjBqzpeYJwOLf2j6bY8entu+OeUkZa1VUppTc+CjdajO3+IqlOYo3RubV1ix f//+XOjaNgw5GBNf6KuYrgw9mHzR5stoYs9uKH5QKb3dqmNWaR0y+DfF4eAH1FHEVfAg doqZTD81Z67tBWN7d4TCx4mC9dmafUMgsJNgzSB7Ljz/Dxy/KAMpug++hlhCzewYNTQ5 1idvTp2rM+G13w+dymJnHiMrRHdZNSDAHaJ/nYfgypC1ERMFqQaZChUkDobYrbxDLXTC H5Zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765254503; x=1765859303; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=6Pa1Xejftpj9ZCjaie2sXROdWsX12z9SbomyYLGQRdM=; b=wf1XrOoW6R+Z4ANmuGcLSEpjPSEm+FHKPJE8+skhKW9sBwIMhhRAHkEfmZ2i4iDP2X 7hfh8WLGVkCSHTilLxz0eSjT1ZWGLk29yuMvRJ1/3Nqs7ps1ejpXNspEVCzZP4J3kEu4 8njz+9SZRsN9Q+3t1VKi1sMj8VjukxtuKQLswQmJebvpW+ctwdLBOdHYklPEQlZ920FO OtSoVugXK8GSGuLf0scDck6Lk5e58Lrmr7lM+eA3YInHl0ZH87Y9sDA8UoGi5WW5o5VY MetLVvFCalCxtHtICfvLJAOxiKlfRiHNGptCHhvl9doOq5PNNTZUl0QvFK0vNS0G4wMn fJ4g== X-Gm-Message-State: AOJu0YxRXqSEQosXuA+Cx0b508ql1oi9gmb3YXI3W4waXWubCr6iLHFE /049A5ovqSE7aZ635zuqLqAe4wV+jS/8Cgk2Xe1FkxIw5znrSRRLg7XT X-Gm-Gg: ASbGncsyrpW9jM+MCEmhoatJGcnJF5Xin62nGTgRUEQAbRmut3EM8jC1CNJ8B3UO1Ja apcmxDbiEhlhMXLJxP7h6OaQtuPaXXr7ipIVn928EvRYp0yi9U5AtxemVCaGBYiJVHnszUZVggz PdY8gWI1SAESu8vXEdijTKIE/24eWHrK/ENaYIgXvKD3/2/2aIC6Mu2G2EExsr+lfmErdFgOAo7 cGMGXDBMeEXcU2vqIJrb29sHMgczOz1Jcljk0OAXaMVHeaEcUcwSFoQVgdBE1y5c1cR3/+dP/Xu r7Xq4t0TuaVmXVfY0kXA2RaVSg/N/C8oqEVYpuHhDg14a7wLgnJ6F/e8xj5ICCZojqr+9cUR2bQ bAb9phnUCw73BFDwKHGDufLLjmGyxSKVQH7UIElp0MvtrZMEqPpye9N5kNVwcBgaYxr9NWPK1cL bhwHZmhqxlfQELZQQ5hEqmfqa4H+xZB1mEqs8xWQNRxqA= X-Google-Smtp-Source: AGHT+IEAgpMVzxFDELmSe1EcFgFHHrMmtin3pr01zEUtdDpWNY9djhS44HySFgwBkRAy8M6k41HDxw== X-Received: by 2002:a17:90b:58c5:b0:340:e517:4e05 with SMTP id 98e67ed59e1d1-349a256431bmr9237622a91.12.1765254503018; Mon, 08 Dec 2025 20:28:23 -0800 (PST) Received: from cmpatel-home.hsd1.or.comcast.net ([2601:1c0:5780:9200:b455:298d:48bb:1784]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-34a49b90fd5sm765185a91.10.2025.12.08.20.28.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Dec 2025 20:28:22 -0800 (PST) From: Chintan Patel To: linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-omap@vger.kernel.org Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, tzimmermann@suse.de, andy@kernel.org, deller@gmx.de, gregkh@linuxfoundation.org, Chintan Patel Subject: [PATCH 3/3] sh_mobile_lcdc: Guard overlay sysfs interfaces under CONFIG_FB_DEVICE Date: Mon, 8 Dec 2025 20:27:44 -0800 Message-ID: <20251209042744.7875-4-chintanlike@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251209042744.7875-1-chintanlike@gmail.com> References: <20251209042744.7875-1-chintanlike@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The SH Mobile LCDC driver exposes overlay configuration via sysfs. These attributes depend on FB_DEVICE and cause build failures when FB_DEVICE=3Dn. Wrap all overlay sysfs attribute definitions and group registrations within CONFIG_FB_DEVICE. When FB_DEVICE is disabled, the driver still loads but without sysfs entries. Signed-off-by: Chintan Patel Acked-by: Thomas Zimmermann --- drivers/video/fbdev/sh_mobile_lcdcfb.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/video/fbdev/sh_mobile_lcdcfb.c b/drivers/video/fbdev/s= h_mobile_lcdcfb.c index dd950e4ab5ce..a46da10789c3 100644 --- a/drivers/video/fbdev/sh_mobile_lcdcfb.c +++ b/drivers/video/fbdev/sh_mobile_lcdcfb.c @@ -1182,6 +1182,7 @@ static int __sh_mobile_lcdc_check_var(struct fb_var_s= creeninfo *var, * Frame buffer operations - Overlays */ =20 +#ifdef CONFIG_FB_DEVICE static ssize_t overlay_alpha_show(struct device *dev, struct device_attribute *attr, char= *buf) { @@ -1351,6 +1352,7 @@ static struct attribute *overlay_sysfs_attrs[] =3D { NULL, }; ATTRIBUTE_GROUPS(overlay_sysfs); +#endif =20 static const struct fb_fix_screeninfo sh_mobile_lcdc_overlay_fix =3D { .id =3D "SH Mobile LCDC", @@ -2637,7 +2639,9 @@ static int sh_mobile_lcdc_probe(struct platform_devic= e *pdev) static struct platform_driver sh_mobile_lcdc_driver =3D { .driver =3D { .name =3D "sh_mobile_lcdc_fb", +#ifdef CONFIG_FB_DEVICE .dev_groups =3D overlay_sysfs_groups, +#endif .pm =3D &sh_mobile_lcdc_dev_pm_ops, }, .probe =3D sh_mobile_lcdc_probe, --=20 2.43.0