From nobody Fri Dec 19 11:32:21 2025 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D80B7270EC1 for ; Tue, 9 Dec 2025 11:15:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765278949; cv=pass; b=HUdsxwskLpfuEGypoxzhNI5pYHyCU6PXO/TkoOtamKkL5iQPs1ScaNjZ/oefoLYC0rl8f9l7RtQ+QRvbxbLeVWK27pTJO+0uA6t3pn8JGD+Rc67YYWmE/1Niw2rBvNVD8gSq+17Iw8rvQLIHC1Lb8a4P/zz9rc3pjKgNhAmdw4s= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765278949; c=relaxed/simple; bh=w60TlGu/HbwiQT7TsAxKJ6Tjmf+z/UOiszujtwkutFE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=DSW5TUjO8QesASK/LoUsnh+di5zG3VY8DgzqFq3OiJeREqUxsV43sW8aOmB9ZEgOzH9bOg39VA4gcGfbmIWWRLVhooFaFIqeJXYVt64WhoC4YsFlkPs0wleztP8GZeJKsB+9ksyMLKMYgNIuaNQrOhfcz9SauTaV3EJZinxUGgM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b=B2tU8ffu; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b="B2tU8ffu" ARC-Seal: i=1; a=rsa-sha256; t=1765278906; cv=none; d=zohomail.com; s=zohoarc; b=hmQ+WDrlK20PAVuSXqU9VsKpW6ennsTdRbnnsMaTnj7l3Qgjj5wGuvPQqyUjkrIJGJVkspCW5ZZN2zDGQU4cr+aT8kjDXGo2WM4L7TZKC58tSJOduuT/3MPPeIasUbLM0AeILL3iUpx+3wxZlTdpV6pBU5VMQD4Byzvp4palFr4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1765278906; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=JBSVTApRGFO6ipPPb6rgBGPYE/Z13lbAZXToGPqvWnU=; b=PomfXWwZPYsN+7d0YF77fIqkQX4nUzNNJ4PnRRJgJPOjcVrVTHeMWmH+vcpt9nojm9/+r995FK1MWrGwVYU0LzqTHgt6izYW86LjLESsVo/pWEE/7jpn4yTaqosflYABrx8s4LM11lbEAryJWvmqCv8brlit+Bv7OGfb9T7leow= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=nicolas.frattaroli@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1765278906; s=zohomail; d=collabora.com; i=nicolas.frattaroli@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:References:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=JBSVTApRGFO6ipPPb6rgBGPYE/Z13lbAZXToGPqvWnU=; b=B2tU8ffukWTB0ZZ5SJzDsUxs01CxzlPgG9k6FYC4sLl3eFBAh7v7CE3hhM4iGqbD WgUinyR+1HsIBtJ7wLcX9kZjRi5713GFNS7YUprWOIxOQ/0vNb21Gvuz67SBz07pLbf gDApTE/8G/prcPq38o6IBGB2PdmjYgC3k/zi9xRk= Received: by mx.zohomail.com with SMTPS id 1765278905191300.842301852009; Tue, 9 Dec 2025 03:15:05 -0800 (PST) From: Nicolas Frattaroli Date: Tue, 09 Dec 2025 12:14:17 +0100 Subject: [PATCH v3 4/8] drm/rockchip: vop2: Enforce scaling workaround in plane_check Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251209-vop2-atomic-fixups-v3-4-07c48f0f1f0d@collabora.com> References: <20251209-vop2-atomic-fixups-v3-0-07c48f0f1f0d@collabora.com> In-Reply-To: <20251209-vop2-atomic-fixups-v3-0-07c48f0f1f0d@collabora.com> To: Chaoyi Chen , Sandy Huang , =?utf-8?q?Heiko_St=C3=BCbner?= , Andy Yan , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: Daniel Stone , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@collabora.com, Nicolas Frattaroli X-Mailer: b4 0.14.3 From: Daniel Stone It seems only cluster windows are capable of applying downscaling when the source region has an odd width. Instead of applying a workaround inside atomic_update, fail the plane check if this is requested. Signed-off-by: Daniel Stone Signed-off-by: Nicolas Frattaroli --- drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm= /rockchip/rockchip_drm_vop2.c index 9d715d7659af..6d4f22872e67 100644 --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c @@ -998,6 +998,7 @@ static int vop2_plane_atomic_check(struct drm_plane *pl= ane, struct drm_crtc *crtc =3D pstate->crtc; struct drm_crtc_state *cstate; struct vop2_video_port *vp; + struct vop2_win *win =3D to_vop2_win(plane); struct vop2 *vop2; const struct vop2_data *vop2_data; struct drm_rect *dest =3D &pstate->dst; @@ -1065,6 +1066,16 @@ static int vop2_plane_atomic_check(struct drm_plane = *plane, return -EINVAL; } =20 + /* + * This is workaround solution for IC design: + * esmart can't support scale down when src_w % 16 =3D=3D 1. + */ + if (!vop2_cluster_window(win) && src_w > dest_w && (src_w & 1)) { + drm_dbg_kms(vop2->drm, + "Esmart windows cannot downscale odd-width source regions\n"); + return -EINVAL; + } + return 0; } =20 @@ -1226,16 +1237,6 @@ static void vop2_plane_atomic_update(struct drm_plan= e *plane, WARN_ON(src_w < 4); WARN_ON(src_h < 4); =20 - /* - * This is workaround solution for IC design: - * esmart can't support scale down when src_w % 16 =3D=3D 1. - */ - if (!vop2_cluster_window(win) && src_w > dsp_w && (src_w & 1)) { - drm_dbg_kms(vop2->drm, "vp%d %s act_w[%d] MODE 16 =3D=3D 1\n", - vp->id, win->data->name, src_w); - src_w -=3D 1; - } - if (afbc_en && src_w % 4) { drm_dbg_kms(vop2->drm, "vp%d %s src_w[%d] not 4 pixel aligned\n", vp->id, win->data->name, src_w); --=20 2.52.0