From nobody Fri Dec 19 11:32:22 2025 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 82A5F276050 for ; Tue, 9 Dec 2025 11:15:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765278934; cv=pass; b=fn+wsi1SuBhJXdHVEMGsAGPqJJwIxpKL9ys8Qk6v0WmqUNTTofXloGFAxTvSSLwMJ6ipccSsCv1IjGV+cXDKnbYK1DrimOF1YkK1xJQEkMez9woKcjG+89WXM05J/KzSZyqA49cp4VO3B/7kl46mW4fohosBdSppHEvJ+VDXK+g= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765278934; c=relaxed/simple; bh=6E18dV5zOcIIOGTLCMr+qSBcDG6bvbXnDI+YtnfYsOI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=UuhEpGkTIq7SHsJ7GpecAUUYqUcVC0kceOg9ixRkzi+g3UCUsRmLAQPcwBwJblupmw8W+gtOpkUus7pED1ucdk3fRww+wXhLhGmLH02fYQQz8TLy4drkMpSFVQvvGZZ4nb+/iszzbMA60jv+mxEkF8cVh+1mmmTPjWXhjjMQsZM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b=kI+f29ce; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b="kI+f29ce" ARC-Seal: i=1; a=rsa-sha256; t=1765278893; cv=none; d=zohomail.com; s=zohoarc; b=eEZNGIJtKeP67NSw2lOuxu0zvU+Sv6FLpNuoU8UHJ//dKfUQahi2kqqrp57Y2jYWAXy7gpppu7tDRYxQwxF2AKDS+/f50eqflugZvuqGgo2XG3j3sNJjQ2DfjOzPLIkmMx2QvOez7vmOoQuY1FubEe6whWd/bAqiaU01GVBg6lg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1765278893; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=Cg4WUfMDQUwvwvbTJsa9XBH4T44qYNwtUMAw30CfLvQ=; b=iqn96Oh7vG0MxJEq0vEole2StmszatnCtBfprwo+SlhXnoFbzGgyCnrWff2Q62fFr/LUUzPEnzpAS20WspFnIU+XATqR3Uxj5okYjYL89JSmTapz2rNXEbN1h9k8NH2BqK4EPs/o794VWz2RoIxa3xnI/K3HWft462Y9tWHXQ2Y= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=nicolas.frattaroli@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1765278893; s=zohomail; d=collabora.com; i=nicolas.frattaroli@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:References:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=Cg4WUfMDQUwvwvbTJsa9XBH4T44qYNwtUMAw30CfLvQ=; b=kI+f29cemP/nKIWH4glFjpkkimX11G7DmPWs9qgbks6DokueOayvPgF13hpE02PW SKh+pa/jYNzzl78Gmkvd/NQs/FvcU2p0eZOyekmY759lb8Dg8iAy48+e0oQ+1BLwJmG iaPTG0L2Jufp7HsTX6PSwjYunGk+Q0A4+krKmn1I= Received: by mx.zohomail.com with SMTPS id 1765278892854392.0031445733065; Tue, 9 Dec 2025 03:14:52 -0800 (PST) From: Nicolas Frattaroli Date: Tue, 09 Dec 2025 12:14:14 +0100 Subject: [PATCH v3 1/8] drm/rockchip: vop2: Switch impossible format conditional to WARN_ON Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251209-vop2-atomic-fixups-v3-1-07c48f0f1f0d@collabora.com> References: <20251209-vop2-atomic-fixups-v3-0-07c48f0f1f0d@collabora.com> In-Reply-To: <20251209-vop2-atomic-fixups-v3-0-07c48f0f1f0d@collabora.com> To: Chaoyi Chen , Sandy Huang , =?utf-8?q?Heiko_St=C3=BCbner?= , Andy Yan , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: Daniel Stone , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@collabora.com, Nicolas Frattaroli X-Mailer: b4 0.14.3 From: Daniel Stone We should never be able to create a framebuffer with an unsupported format, so throw a warning if this ever happens, instead of attempting to stagger on. Signed-off-by: Daniel Stone Signed-off-by: Nicolas Frattaroli --- drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm= /rockchip/rockchip_drm_vop2.c index 498df0ce4680..20b49209ddcd 100644 --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c @@ -1030,7 +1030,8 @@ static int vop2_plane_atomic_check(struct drm_plane *= plane, return 0; =20 format =3D vop2_convert_format(fb->format->format); - if (format < 0) + /* We shouldn't be able to create a fb for an unsupported format */ + if (WARN_ON(format < 0)) return format; =20 /* Co-ordinates have now been clipped */ --=20 2.52.0