From nobody Sun Feb 8 02:51:48 2026 Received: from mail-pj1-f74.google.com (mail-pj1-f74.google.com [209.85.216.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 708A530C60A for ; Tue, 9 Dec 2025 05:44:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.74 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765259064; cv=none; b=f+AbA11ggA9bg8GqrMZZ0psb4SR2isf3QfVBT+DaQ+PRtZDSfEvrpC/X9d26ztC68337YmGQz9ZcMJBa4UHScENnQw4cC1HTpyhhebHiucksHIBDlh0LluksnYcG4O+A97kUubsmBLUWygcBWsGxgIqNgbjFsU/Rd7leoZzxres= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765259064; c=relaxed/simple; bh=OiCnU4ZaOFUIzQdTM8xNKUwqVOlzBeXiGDq/8syrhvw=; h=Date:Mime-Version:Message-ID:Subject:From:To:Cc:Content-Type; b=Vx0dgBkO/t5UmcGXYFosXSDMafI2XPhGU3yWmP/F3HgpiJ2KE8KLjbKCTvaGqDYVPmK8u/779sDaP7eD2RVNlHgiqwsH+rK/Ppcvws9/rOHqkiWS7huNye5jKzCBnSpRvqZL9N8kqFN21LJbdmuUD3gIKIX6Omv6i3GoPzB55Us= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=qQjQOQj+; arc=none smtp.client-ip=209.85.216.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="qQjQOQj+" Received: by mail-pj1-f74.google.com with SMTP id 98e67ed59e1d1-3438b1220bcso5886356a91.2 for ; Mon, 08 Dec 2025 21:44:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1765259057; x=1765863857; darn=vger.kernel.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=aeRS0rrF2ORdDNQRDFOZx3EYhiwIbLZ/NuYorYmEULo=; b=qQjQOQj++/S2dLoUNC98eII4xGT/E7Od3j5Wq/69Qkv+kF+YuW/bvGHbjYde2ropZI 4USBMajLUY6W0d6qqaUt7mkutfdArcDrxZj/JX1xzFGLlNdCWMqk2me1tEed0N1JIb7r x5bsIMs2dtq/Gc+larAcSw3lnChqaz5gxfyy+yGtpYo5RxIep/4Wahob7AQlbLHHtc3p a1pUTNyMbSC1RiiKeE3Qj0oCxttml6nC7l5dxBYmdbrp8EksolEKjtqJeBbcRTVSVVaP wDQi1YP3J2EXMZhHM3EH3JPjS4d5FANYPHs6bCl69E//tLc894Z0E99emrOsooX67GYT 84tA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765259057; x=1765863857; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=aeRS0rrF2ORdDNQRDFOZx3EYhiwIbLZ/NuYorYmEULo=; b=SvOisgcu+9/uJwe6Z6mGc9n82L7Sg9Y3ElkM7GhlehYChMQ72b5tsvrH/GjSa3aVSN AZ11xqhY1wPe27UO3j50igEPosznBjmCALizCTVybemHzP9O7SePZgaVDl9/nA6JKFac FnTF2cTEKiFvU+N/drO5PvQK+pWvJ+1JFwDgmA9iIfYZ/BO+fQ6G6PZT3lqI3sjdjrwo QMFN4Sj6Z/8GRJmBksyy4JQkFZfAxkKWez8oDZ4djEBzFXBtx6eGRBzN8QxvsgNjHuTd Yx6pSHJ4cw0gnGtWD6h1Rb5+ZoZstXmuvheR+sq75h8ok82WEjj9JifcoMx7gmI4pFix wXBw== X-Forwarded-Encrypted: i=1; AJvYcCWhDQCShdeVg4MgUEWbgTXxS4d0mAUiEtUqIKLT2HkNr+7CCYINxV57+NUKP0Zoo1eSi6+1CT6rn194YDk=@vger.kernel.org X-Gm-Message-State: AOJu0YyjWlsrbEuHuvXwy1KonVmZxCe2Zn9tWFtJCPbZcsrUvUmwtb8q /0ihgpa4YPQfJWWha+cmBJiWOVwMAJxwTn59n9W26RHxV6LEiXwqLeS/BeFlW2qrG23QgvPbPi1 O0UfjHLuBWagR8A== X-Google-Smtp-Source: AGHT+IH4X90kdSgY4gS6T2ygfWyabi8rSDiiqcDLF1Md3MDGtyvaNqc10OgaH/bpc5lD84VGSrNHO3O0B1jxUw== X-Received: from pgac24.prod.google.com ([2002:a05:6a02:2958:b0:bd9:a349:94c7]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a21:e082:b0:252:2bfe:b65a with SMTP id adf61e73a8af0-36617e36e06mr9940237637.7.1765259056752; Mon, 08 Dec 2025 21:44:16 -0800 (PST) Date: Tue, 09 Dec 2025 05:44:14 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-B4-Tracking: v=1; b=H4sIAC23N2kC/4WNQQrDIBRErxL+uhYVQ5Kueo8Sitpf80Fj0CAtI XevTQ/Q3byBebNBxkSY4dJskLBQpjhXkKcG7KRnh4welUFy2QrJe2YUK0F7Hy0L5Kb1/stdq3Q 3CFQoONTxkvBJr0N8GytPlNeY3sdPEd/2r7IIJtig9GBMj9bw/upidB7PNgYY933/AOsBhcq9A AAA X-Change-Id: 20251208-b4-vmalloc-might_alloc-754a791e4e10 X-Mailer: b4 0.14.2 Message-ID: <20251209-b4-vmalloc-might_alloc-v2-1-2462ba26ead1@google.com> Subject: [PATCH v2] mm/vmalloc: clarify why vmap_range_noflush() might sleep From: Brendan Jackman To: Andrew Morton , Uladzislau Rezki Cc: Anshuman Khandual , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Brendan Jackman Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable The only reason vmap_range_noflush() can sleep is because of pagetable allocations. The actual allocation mechanism is arch-specific so might_alloc() doesn't work here (what GFP flags would be used?). Hence, just add a comment. Signed-off-by: Brendan Jackman --- Changes in v2: - Switched from might_alloc() to keeping might_sleep() + comment - Link to v1: https://lore.kernel.org/r/20251208-b4-vmalloc-might_alloc-v1-= 1-94a9bb8ecb08@google.com --- mm/vmalloc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/mm/vmalloc.c b/mm/vmalloc.c index a53c7462671bdd896f95712af71398ffbe22fb80..c23d378dd4446e2784505ec3d5b= b9568fb0d3c9a 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -305,6 +305,7 @@ static int vmap_range_noflush(unsigned long addr, unsig= ned long end, int err; pgtbl_mod_mask mask =3D 0; =20 + /* Might allocate pagetables. */ might_sleep(); BUG_ON(addr >=3D end); =20 --- base-commit: ecc46e02e0abe025a6e840cba2d647f23fd1d721 change-id: 20251208-b4-vmalloc-might_alloc-754a791e4e10 Best regards, --=20 Brendan Jackman