From nobody Fri Dec 19 13:09:34 2025 Received: from PH8PR06CU001.outbound.protection.outlook.com (mail-westus3azon11012005.outbound.protection.outlook.com [40.107.209.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E957313E28 for ; Mon, 8 Dec 2025 09:29:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.209.5 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765186195; cv=fail; b=LL+jO6o8HGkxiVDTsbn+7Pl8VAxD7PqGiMBIl3ckPzSO+O8l599emLYtTTne3Uf0ba4NrlaF3jqQVs6HS7FSW0+xDnwTzzj/vHIIjCcfrn3qq/pL4S9rCiYkFYn+uHA75WqgEBpMXBK2ho45MljXKgXjo92M5PvN9EqR91SQYrk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765186195; c=relaxed/simple; bh=9mOxjdxvlIR6JmO9N1AsfWKYLeyyu/rNbjss+ozdv8g=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=aXff/dMLJpAchXY4rqaRDBa70OUkPT8P7c7LbWeDm3CdpGZo6zl6J1ck2VI3z53FropNFafYheDfHsI7vQoDEB1tYj/KsJFdNXhdQjVVAyNxYD00gFKPrRWmPH2UdQx7bDw1Ev2bWJpX+upRCknYNWqureNSk8btSq4lZ4Vy3oI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=IYAPaSe6; arc=fail smtp.client-ip=40.107.209.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="IYAPaSe6" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=MrQThESzisWz66j4t+OsTglBBZCzmvZS8d8m9UDZS7PCAtwgnSRabEsNFXn9yJ94ZaOhheE46G0aGaVV1nx8PTcZVporqfm3E1ZdHJRV3/v+l8dmgPnO/DBlJUQ/W0x6ctoT46tFiKa1H8nRUzvR7hf/ZERGmprWWbmAdOQYndeRK+JqGIfqW3ORlF/wnR3KNXAJd3Y2JX8RinANw09Mt/WJe9g3veCnBvvp8yNYpjLyXVrLkuNDxFgwMh2KPLipkugjZZ+tnHq66htXsmgxiU0u/8Fh9aG5+vyvw4L+GaMmxXni/9Dzn5EH9rmr1odjnwbSnXJtyOTA+0UYnH/jDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lY4pSD/tiTMksrrvmRVLxeTJqM5UfXp+jg667UyaX+o=; b=LWgKLMfMPrlEP0CLwyna5r79aW9FubOAfhqtjSS1SCzMEYOho/NzrQ453CXV148ybrF5Vbbgi7rgCvGLgPkx2Cp8dmMillN0quOdKNuhprJlThL7Iv4HAeYE7I3KQJ0VWXa97jrpRbnNYDj8qKm4Qwkojl4ECWS0W1TDGpJIYs5+l460OVLgVBOqlAl2wSYvbI3x0Rgoj9YuqLmXeP6m1IFMlAUaCHzij4HPIcamB3e6QjQccyKTX3Mfsv/Hhc20T5xfFqxU5B1aTVuWdqHhvBvWAq4ncM7GFTuZgI9lH4jeMVVNG590PFDNTw5KdjCWiV+/jDHG3adYLAQ6SjGG+w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=redhat.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lY4pSD/tiTMksrrvmRVLxeTJqM5UfXp+jg667UyaX+o=; b=IYAPaSe6MaOSq6fct4CBwgiZsYsq/FOqemQkjxtStjywXggrNKqL7g7UGimsE3yD+DONYkqwAXPhHSi/tymogPfm2corisMY+XIJq52M9iTIromT8iFqX+sawsK61HlvpQqiYBK1HE6MiGU/n4/6E6oiCX6oY7oKn89dewhPIMs= Received: from BYAPR01CA0041.prod.exchangelabs.com (2603:10b6:a03:94::18) by CH2PR12MB4165.namprd12.prod.outlook.com (2603:10b6:610:a4::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9388.14; Mon, 8 Dec 2025 09:29:45 +0000 Received: from CO1PEPF000042AC.namprd03.prod.outlook.com (2603:10b6:a03:94:cafe::e) by BYAPR01CA0041.outlook.office365.com (2603:10b6:a03:94::18) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9388.14 via Frontend Transport; Mon, 8 Dec 2025 09:30:39 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by CO1PEPF000042AC.mail.protection.outlook.com (10.167.243.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9388.8 via Frontend Transport; Mon, 8 Dec 2025 09:29:44 +0000 Received: from BLRKPRNAYAK.amd.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Mon, 8 Dec 2025 03:29:38 -0600 From: K Prateek Nayak To: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Anna-Maria Behnsen , Frederic Weisbecker , Thomas Gleixner CC: , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , K Prateek Nayak , "Gautham R. Shenoy" , Swapnil Sapkal , Shrikanth Hegde , Chen Yu , "Yury Norov" , Rasmus Villemoes Subject: [RESEND RFC PATCH v2 07/29] sched/fair: Use for_each_cpu_and_wrap() in select_idle_capacity() Date: Mon, 8 Dec 2025 09:26:53 +0000 Message-ID: <20251208092744.32737-7-kprateek.nayak@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251208083602.31898-1-kprateek.nayak@amd.com> References: <20251208083602.31898-1-kprateek.nayak@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: satlexmb07.amd.com (10.181.42.216) To satlexmb07.amd.com (10.181.42.216) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000042AC:EE_|CH2PR12MB4165:EE_ X-MS-Office365-Filtering-Correlation-Id: 95912aae-5ac7-4003-6059-08de363c52e4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|1800799024|36860700013|376014|7416014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?wtL2ecdpLFE/351i8ymkqVonaZ9NpBHdNeE/bnRWzZuHy2qCCmbBQZx7hth7?= =?us-ascii?Q?+zrq7fp4Lwv69eJCi+0K0ARNDRsC4zFDdbpMzLC5FG/Nd10QLNsignxxVJ1O?= =?us-ascii?Q?Ef22qjnDia5LHcT3VXFywQuIZqaOcGJo/8J+W6eWyfmhxisnZ0lpa9e8oLvf?= =?us-ascii?Q?lCIO5P+G7ldQFkvZW5KoO5cwsDX62NIrAdaq/ab3MTGkdIHEH4HoUJ/3KkU3?= =?us-ascii?Q?fQcv2DYd5ddzU/lsTxpIjg9h/66Y4lHq48TsuMwTFZy6oqA+ahnPImGUQOUe?= =?us-ascii?Q?+Lo68lCh8Rxm3H0Ce+52ZhROzhyoq6zIgYPmOwo0rgAdd2TNNLeKFvmFmYZp?= =?us-ascii?Q?uk399mOLilEQDeNhpqufzjGm2ciAtYZ6/3xdrglBfFiomSCiQPg0cKNqQoa9?= =?us-ascii?Q?IDfISGH4438y5qLPz+nwQUwGTsXvbJgXriZa6BsOFEhg2ZQ5YQdHMHuUTdq9?= =?us-ascii?Q?NBDRhrMrD/zGiw+UNuMJbNTtUjORkSgyBEGRUFwewUpJELfdNQSKP+q3sRjS?= =?us-ascii?Q?KvjrIY1VTXkX3T62ltU3UEV8YT8FCrPZXugF2IMSV6vsjEuCBCoTOwJ/f6tM?= =?us-ascii?Q?C53wa+RJUVJLv09ggRP4HdlXQA+2VdgOL9XssTFbNNRtHuH0vrusTwo2AaOJ?= =?us-ascii?Q?jVqfZzM1mc3VagPSUpcewerADuJExLDJJzlifspMgZFxgh5+QeFbLUFJWvD/?= =?us-ascii?Q?MsTaWsW09VcNSzixaJH3ptdecVQaZnEcPYvDS5rjz/0C6XUGejDqwYw4+oNv?= =?us-ascii?Q?LXm7FXeMAOvCwOiqXooqtvajbbuuh+Vc9MZQ+8Q9xWGPKFRnoaV5rRQVAhDs?= =?us-ascii?Q?E/X1gAziKyMh/DnnYo8+hn6tBZj6Qft9/N+JsZmHcV39hanLB3q0Rodc53b1?= =?us-ascii?Q?YSIz1FMjzEArnGhUr6DcdyqDrjNIWFJxP//NV+z5AxUIgNFeDnWlQ1s1j/fS?= =?us-ascii?Q?NUp4c3A2UucA2hLlXD66k3Wt464IVyIsbg8W5ZI52VQLS9UwnOcyZpYd11B/?= =?us-ascii?Q?mX9jrH39sCNQJ7YpBkAeLRikbW+5Fw6iaFol4IJZSYMJWKwzMdngE1zKkyOl?= =?us-ascii?Q?Vv+j9/8voD4nk4yYvbyoo9X2hoihXrzZ16QDdfjCwWo0uU0bSOOkhM7DoeNk?= =?us-ascii?Q?resoxBMNxTGFzPNrGkCK5Qb329pIqj0QjqNcFgESC+3CqCsH/RDxX49sffQj?= =?us-ascii?Q?GBG8WojjExrmr0U7Obrwscs/4qh9PEiEUzU4SA/7cK848KVIuq8yDwAduXMO?= =?us-ascii?Q?oz5FblqysVYg5SiswmaoQST9ZbWwtdRzRdMGN9XTjA6HiX//TEMpkf4eH/IB?= =?us-ascii?Q?8r5wIUhXDpz/tzuh3FuVGKcWgKwKKUXC7dWNFw92VdkLPA4xgqHDO+9WlOZR?= =?us-ascii?Q?5PAETtydmVZlnVK9qXO92wX9Y7jqujhbSqoVeqa6RA4izuFUV/AT++WTRPFi?= =?us-ascii?Q?JzR9QB3HhJqxgUmWfGZEGdh2BNCL6Pa3CakVp01KYCQku2EoMZbgPnSN+1c3?= =?us-ascii?Q?VGqj3qohtJvTC9c7/GugDXif3W3qN1ctRHfjTS56uEgRasP70wjNk5hbtcnU?= =?us-ascii?Q?Kre2YZegdKrhysTb0Uk=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(36860700013)(376014)(7416014);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Dec 2025 09:29:44.8490 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 95912aae-5ac7-4003-6059-08de363c52e4 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000042AC.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4165 Content-Type: text/plain; charset="utf-8" select_idle_capacity() does not modify the temporary cpumask used to find the common CPUs between the domain span and the task's affinity. Use the for_each_cpu_and_wrap() helper to avoid the temporary cpumask. No functional changes intended. Cc: Yury Norov Cc: Rasmus Villemoes Signed-off-by: K Prateek Nayak --- kernel/sched/fair.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 20198aa64882..5abe0ccecef3 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -7704,16 +7704,12 @@ select_idle_capacity(struct task_struct *p, struct = sched_domain *sd, int target) unsigned long task_util, util_min, util_max, best_cap =3D 0; int fits, best_fits =3D 0; int cpu, best_cpu =3D -1; - struct cpumask *cpus; - - cpus =3D this_cpu_cpumask_var_ptr(select_rq_mask); - cpumask_and(cpus, sched_domain_span(sd), p->cpus_ptr); =20 task_util =3D task_util_est(p); util_min =3D uclamp_eff_value(p, UCLAMP_MIN); util_max =3D uclamp_eff_value(p, UCLAMP_MAX); =20 - for_each_cpu_wrap(cpu, cpus, target) { + for_each_cpu_and_wrap(cpu, sched_domain_span(sd), p->cpus_ptr, target) { unsigned long cpu_cap =3D capacity_of(cpu); =20 if (!available_idle_cpu(cpu) && !sched_idle_cpu(cpu)) --=20 2.43.0