From nobody Fri Dec 19 13:07:33 2025 Received: from PH8PR06CU001.outbound.protection.outlook.com (mail-westus3azon11012036.outbound.protection.outlook.com [40.107.209.36]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 75B353101C7 for ; Mon, 8 Dec 2025 09:28:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.209.36 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765186089; cv=fail; b=oxLeG/GxGqI1hfsSWJl5ftN8W9Xo+niSUie43MrwsGIZYtFqE7NZDrYrl8z/255Lai4+KZAPW7s4CoA+Svkz0pfyXU3Pi8oZ6YE3+3nnspap1gFppwwkMNsbzcJfpyLqVodfA1KKSBKV+2rJW3iQd5ZfgxUJttJEKWgV87j363Q= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765186089; c=relaxed/simple; bh=Pqijg/pPuXSIzkhkVH0c22lZNaRMR6OkjDZ+tSRxKl0=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Nt/Ah7uDvjGx7NYmZU2vZRaRXjjLYBuwvqAOxcZ8ftEwHNddfki2d3LvpK70JHfYMBsLuGz5DvdraYc7B+FskARqJiWHZ0Z6RYKXpJfeZBWZ45Aop/n9dHl1zRWdBZG7OSYPKLHb6fSfEhhpWrGOPC4nLdl2mUKbD4KFywbYHEg= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=q/d9JvIC; arc=fail smtp.client-ip=40.107.209.36 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="q/d9JvIC" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=VWhKdTs+9ClS9BGdFiKlkHYFgUUHDkQ/8+unp+xhm2wDeuYKWB1sLpl9tkboP5uquTlfifZcF+pdG6qaJqgVhUp9DyYQ1b0TX1HOl2H3bM9wzLaLGAUDqug8ISXIYrVyRvvstNP6igxoNBvubQ6B8S5T4nRdcNAKWmBWOpaln/40CzCx2TMbuJAhTzdDZtM/XfWkcEuvEsIcY8sETx9k5g2THBaUHCoA/6NrzP5Eyu9ERODPjb6ch96qD/aqavhNji4Z4IDGJh1wsGGcJiWjHGQD2zM1cxJSf0MTbADIdBgNCLIXmyxcn+D6MqxwqSKru9UzqAvcUct6qLNh4kOSYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1mAexYCvP36s8OgBm9K21zef5pZYDUXqPo11JHxbb9k=; b=lfXfAwdiqFTkaiykza/ZtQP2lDBlwHgKhk+9n1LLp/jU0LgBLeYGv45A1h6ZlXag23oevmKC565BU4kgRRZImjlfNEYvwlydihqw0GQpEKOt5Pc+zueW9Emw6Xv+DrTiAOecszYdvXSfjoJd3wn6UNpADIm7idYxI6YArOedcHPkQ1W5PkUy6xDufgphw3lYgVRFaH0rUT59CRpQo6BD5gyJ/Ck2/BUTo8anWphz4c+DIszVnu2T6GeCFBw5U2Mw6C8B7zUXV9cBV09LhLxvq/ZC0CAg6gYK47Zcj+L9IbFxg1BcIJMk6RFtg4ZDXu5NOijcLI7SA3xQuLyhLwdj5A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=redhat.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1mAexYCvP36s8OgBm9K21zef5pZYDUXqPo11JHxbb9k=; b=q/d9JvIC1GjdnC0O6FHdYhZW40LRAUBS99YVdYS8mekbvEHpqnEXc5O8LbRlKqT+qRy71+T0KBzH0+ZaCOile1fDGXKAsFkfqigS6htJ6JvaJmm4cCL9mmvaDlkxpSZcXHUyx4U+aKuKqm7eEF9CbSQEFKn9CfMCSqgjzG9PJi0= Received: from SJ0PR03CA0002.namprd03.prod.outlook.com (2603:10b6:a03:33a::7) by CH2PR12MB4038.namprd12.prod.outlook.com (2603:10b6:610:7b::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9388.14; Mon, 8 Dec 2025 09:27:59 +0000 Received: from CO1PEPF000042AB.namprd03.prod.outlook.com (2603:10b6:a03:33a:cafe::26) by SJ0PR03CA0002.outlook.office365.com (2603:10b6:a03:33a::7) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9388.14 via Frontend Transport; Mon, 8 Dec 2025 09:27:41 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by CO1PEPF000042AB.mail.protection.outlook.com (10.167.243.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9388.8 via Frontend Transport; Mon, 8 Dec 2025 09:27:58 +0000 Received: from BLRKPRNAYAK.amd.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Mon, 8 Dec 2025 03:27:51 -0600 From: K Prateek Nayak To: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Anna-Maria Behnsen , Frederic Weisbecker , Thomas Gleixner CC: , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , K Prateek Nayak , "Gautham R. Shenoy" , Swapnil Sapkal , Shrikanth Hegde , Chen Yu Subject: [RESEND RFC PATCH v2 01/29] sched/fair: Simplify set_cpu_sd_state_*() with guards Date: Mon, 8 Dec 2025 09:26:47 +0000 Message-ID: <20251208092744.32737-1-kprateek.nayak@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251208083602.31898-1-kprateek.nayak@amd.com> References: <20251208083602.31898-1-kprateek.nayak@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: satlexmb07.amd.com (10.181.42.216) To satlexmb07.amd.com (10.181.42.216) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000042AB:EE_|CH2PR12MB4038:EE_ X-MS-Office365-Filtering-Correlation-Id: 975f879e-13bb-47d1-d0b9-08de363c139d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|1800799024|82310400026|376014|7416014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?k4PiMvP655buXyjbFt3e8DzJ7Pg6n03elwAbKVWqsFj1AnLY8mjhodqF5QyA?= =?us-ascii?Q?zIEuo8h6+RJjor6ofZev5o3bLY9WqGbThKbBNqI6ScGW6ZEd0/MmIwlb/GCX?= =?us-ascii?Q?v/b4r+Hn0SnOMfof1DZJpIiIUInpEIQlqgsCNwJOWlT0rWMbyFunD1pIUVVX?= =?us-ascii?Q?nTbyWFLa1vrfmk6wdEN5KKm0qRnHHa0nVPKitPzVS+6FyDzK2zkem+dF96aO?= =?us-ascii?Q?DwA62oBbCqJbcMtqjjbE5/uHSMocT/LutOrishUeKSsb0rva35YcN2Un81Y+?= =?us-ascii?Q?NuNQYpXye6DxLW0UjqML/+p4QtSyV7O4VW7uoZTd6YHcROXYW+f1HQfkn+SV?= =?us-ascii?Q?doL3PZqA1hfPSYaoEPWx8dK29aslALy+A/lM2Q9dBSOxPkfHP4hy61nPPMzq?= =?us-ascii?Q?OFKsstxhmTqLj1+NmXA0yC/ERj+WeAqRO8L9T4i+KixcxIDV5IveOiwS+6a0?= =?us-ascii?Q?78lrkcArDkDZkZrlJ42b3Lp7SMZUUEuhjx1hScHePYpLHVY2lzEbEtxErPyp?= =?us-ascii?Q?qwNj+lCGaVUquU2f1cd6vv7pHD9uoJ97i85QksIg0bxo/8ugpPi/l6xZ75dS?= =?us-ascii?Q?ScgbsFc1E0oYpnhPPL5sHekcxsSVHF1qoeBj8EGu4Ci7mds6L61MT2OsKwbh?= =?us-ascii?Q?ENZR3uGqhaaZHC5yHwQm1Pxcq9xJKjri4/DjYNBOM9bAEPUzi3nt14U60VIM?= =?us-ascii?Q?5HoEVfG4IPsdBCj8UoUws8GkrKr3oJKjyWRSkTPv5zgU6tlCfFQMh3vhGeYc?= =?us-ascii?Q?me2AqJFIN2bj69tIalv9/kuNazSFFTv6lZE9eCTt1vzgb2VTiv16vKEUc26a?= =?us-ascii?Q?mkqwz/RoCah9OG3S+icFgCD1Z8u5Udr6BjVU9eKjwt0hXf6Md2S/7YhSKfP1?= =?us-ascii?Q?51eqpIDYfptdmXT/ZziTYJ4bsJZW8yo7qEGHoVkAQ16yUjUQNkQmnKyokAAl?= =?us-ascii?Q?AQk9fUll5O2KQ4FbcEfTvRw8Zlwg+HiDS+uGfWu1SUUdWdAsl21MisADQKH4?= =?us-ascii?Q?Vrvus7OIeqty2FEACO6rllzXInKe7Eli69cGyBbMWkI1dyuk66rjbbe+66uw?= =?us-ascii?Q?sDsglVwItPdP/8H47yYXGA8VqI4gFwYsNZj4jPr6bBudJZVGpNHOFEfRmyD3?= =?us-ascii?Q?AZYfKKrpPQ64KFBGSinLbkguXx2jtZHsfzLxxhNGdf/4AhqwnOTRbkWjTfwY?= =?us-ascii?Q?eSGq5IAkX+lAd7yBkViuCHiPoSlEK4wPqVyU9z3mA1W6dyDBZUNYU3D8RAdZ?= =?us-ascii?Q?Y7TntD7zfAyAbDZhco6oUKjbAgJvMhbzEtQPuMXnwmI9qU74LZTN0JiwfOip?= =?us-ascii?Q?G7rUDcY1Zfkukm5+LW9M7WTbJBYoKCRnINiVsIrmBCQLhRzmghMI/FxhUYLM?= =?us-ascii?Q?QBhHxpN9YJ37tlq4RCJXUaEhOPhmdjvslCVQU7l+GZy7UcedzNgOnKCMeBH/?= =?us-ascii?Q?qeBpWJfMotViAgo7WMdHNSwNbntJCLaX1NhFAhDwKIiYUbMG+U40KaYCPBP5?= =?us-ascii?Q?2UbBBZwj+bdORdQqsyROqyj1y6xwPVpcK4fuoQXBPw97KD1k1JujP5X6cng8?= =?us-ascii?Q?dggIcBc84XKQspbnZXI=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(1800799024)(82310400026)(376014)(7416014);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Dec 2025 09:27:58.6898 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 975f879e-13bb-47d1-d0b9-08de363c139d X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000042AB.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4038 Content-Type: text/plain; charset="utf-8" Simplify set_cpu_sd_state_{busy,idle}() using guard(rcu). Reviewed-by: Gautham R. Shenoy Reviewed-by: Shrikanth Hegde Signed-off-by: K Prateek Nayak --- kernel/sched/fair.c | 20 ++++++++------------ 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 769d7b7990df..8a5168284eaf 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -12543,16 +12543,14 @@ static void set_cpu_sd_state_busy(int cpu) { struct sched_domain *sd; =20 - rcu_read_lock(); - sd =3D rcu_dereference(per_cpu(sd_llc, cpu)); + guard(rcu)(); =20 + sd =3D rcu_dereference(per_cpu(sd_llc, cpu)); if (!sd || !sd->nohz_idle) - goto unlock; - sd->nohz_idle =3D 0; + return; =20 + sd->nohz_idle =3D 0; atomic_inc(&sd->shared->nr_busy_cpus); -unlock: - rcu_read_unlock(); } =20 void nohz_balance_exit_idle(struct rq *rq) @@ -12573,16 +12571,14 @@ static void set_cpu_sd_state_idle(int cpu) { struct sched_domain *sd; =20 - rcu_read_lock(); - sd =3D rcu_dereference(per_cpu(sd_llc, cpu)); + guard(rcu)(); =20 + sd =3D rcu_dereference(per_cpu(sd_llc, cpu)); if (!sd || sd->nohz_idle) - goto unlock; - sd->nohz_idle =3D 1; + return; =20 + sd->nohz_idle =3D 1; atomic_dec(&sd->shared->nr_busy_cpus); -unlock: - rcu_read_unlock(); } =20 /* --=20 2.43.0