From nobody Fri Dec 19 11:50:38 2025 Received: from m16.mail.163.com (m16.mail.163.com [220.197.31.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B0333946C for ; Mon, 8 Dec 2025 02:42:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.31.3 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765161736; cv=none; b=a182sqzZY3i8K4Bd9yT+aKUH42rqg5LWmQyBWCDrB4DN9u/jMOdMYXulHeXD7/3jmzLRqzAMjL4KZAOJwa3Z5gUr2idrgpH0ayxmVTCZa6/fdZZx5bKdn9TOfy8luTZ5ISvkx7ugrfhY3StF+FvK8u8XdMVECKNQwzCBDIqw3Rc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765161736; c=relaxed/simple; bh=P1OyWDehi0qqvbvWMSMDaHNONJ127ZhXTV+QvNjb7AQ=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=j0WHxGPzAUzHlTlycWYDanzvaD6qNl+dcfAhk95BoWkOSRQlAwOs6rvUqe380Z1cmCr4QA9/1LdHngUnuQA9WJDas8W0PT2O1GYs9vqBb9AqcELSep8At7lyhsQjSor10ZqUChepeEIgKv4BuQvijKkZIfyVRnJOB2XwaubOZHM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=QrS4ZvlF; arc=none smtp.client-ip=220.197.31.3 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="QrS4ZvlF" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=N+ O1YVpfTYOdrPZnCJ1Rhqcgb9A6INTw6hl5g9S2jbs=; b=QrS4ZvlFi/Z6mHFiOt XKg6LInGjLgDAGzn16JdvkTv1OLyYhqJb6ZtHHRKqCwyVdA0JWnV8PnziSJkmXN2 NTbSE0howhKxvAW0+TXHnkVr7kjCXsFcodMd80j2NV71o/isx13R66LSwo6ixWwJ 2WX7cMU5AkJOj84vYfG8hh5gI= Received: from localhost.localdomain (unknown []) by gzga-smtp-mtada-g1-4 (Coremail) with SMTP id _____wB3J0DEOjZpxSzkAQ--.693S2; Mon, 08 Dec 2025 10:41:09 +0800 (CST) From: Wanwu Li To: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org Cc: dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com, linux-kernel@vger.kernel.org, Wanwu Li Subject: [PATCH] sched/fair: Remove redundant error handling path in alloc_fair_sched_group Date: Mon, 8 Dec 2025 10:40:43 +0800 Message-Id: <20251208024043.2887311-1-liwanwu9113@163.com> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _____wB3J0DEOjZpxSzkAQ--.693S2 X-Coremail-Antispam: 1Uf129KBjvdXoWrtr1rGrW8Zw47GrW3tr1DKFg_yoWDXwc_C3 W3ur42gry0yr4rAr1xuws8ZFZIgFW0gr1xuwnFyFWUKa4kX3s8JF98uFyfGr9xCw40vF9x KasagFnrXr1kCjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU8c_-PUUUUU== X-CM-SenderInfo: polzt01zxziiqt6rljoofrz/xtbBcxseiGk2MVjjSwAAsg Content-Type: text/plain; charset="utf-8" From: Wanwu Li On error, the sched_free_group function already centrally handles resource cleanup, making the explicit kfree(cfs_rq) in alloc_fair_sched_group redundant. Signed-off-by: Wanwu Li --- kernel/sched/fair.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index da46c3164537..b657d3281f44 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -13645,7 +13645,7 @@ int alloc_fair_sched_group(struct task_group *tg, s= truct task_group *parent) se =3D kzalloc_node(sizeof(struct sched_entity_stats), GFP_KERNEL, cpu_to_node(i)); if (!se) - goto err_free_rq; + goto err; =20 init_cfs_rq(cfs_rq); init_tg_cfs_entry(tg, cfs_rq, se, i, parent->se[i]); @@ -13654,8 +13654,6 @@ int alloc_fair_sched_group(struct task_group *tg, s= truct task_group *parent) =20 return 1; =20 -err_free_rq: - kfree(cfs_rq); err: return 0; } --=20 2.25.1