From nobody Fri Dec 19 11:50:09 2025 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 377D526ED46 for ; Mon, 8 Dec 2025 02:08:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765159708; cv=none; b=prXXiFCqb4RuQM7n/2OXbmkYCQNQMTfZy4zob5gOSms5cJo+aJvIFVLjaiTWdBxkeac8vCDnCWUWdkyAT+H/LADcwOrtOOytzjWhZLGZilU8Cm9s2/70S4d0OJYzT6d2UUhb6d4ZUGIpuy9Xi28IoUxi33vrmqjyLAgDk/xLrqM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765159708; c=relaxed/simple; bh=VccLCferOc+mdB16nfI0HlBzXI9Os/PGGnbeSXCmwo4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=bPkIG0C4HnLF8pvIweY8X2iC1cSNR1bYJ8Lb7WX0iRGk8rYpxbk37RmT/zJ42g2as55zxxgUCZiq0DKo9EUseRcpYhb9/x6B+vvqy7Lw8VVsAazzudWQj04VYRITwSP82DwctP6IY4eKhzDWvDipWrXxB1fx3KF1kCXM56CDiKc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=V/JgLOom; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=PpZIEf45; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="V/JgLOom"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="PpZIEf45" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5B7LwJM43567175 for ; Mon, 8 Dec 2025 02:08:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=qcppdkim1; bh=kzMAceVgYEV3LRopVsx6XpOY2J2YDxUetSp uW12UF28=; b=V/JgLOomjrBFM5RJfUjcf5cMMe5RowQIY0WKHAio4r5kLG1T+7A sQwDCcB5CnOwHmFT6YtOqYgZajooCXuZQq7uwsHzuN3Br5EQpxXMrAZ9Mv89GUrE pqF6mCQcO3p9dChXUKdGEEqjSCJk9rdr9jUqDrbj1UB40N0qf9V1Y5Vy1XwHsuk8 VE0B9A9Pm+SD6F/Wt32yCkLzr5DiIz4TF67RwmB9gXo5w21zldIbVj21jnM/FD0r cKIeO+4FyQEN01FgOA/IPdgKsz55i9tq+ZKFU8wCOQk3WepjAkKavbtzCNri5HfO JwFr1/RobATCbNSYBe8iFEeiJM22uQnAG1Q== Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4avc2wkb1f-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 08 Dec 2025 02:08:26 +0000 (GMT) Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-b62da7602a0so4107935a12.2 for ; Sun, 07 Dec 2025 18:08:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1765159705; x=1765764505; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=kzMAceVgYEV3LRopVsx6XpOY2J2YDxUetSpuW12UF28=; b=PpZIEf45GCw6uYJ6vvh+Yziyw9pWluN+72yLEoH6josJP9l5n3hWFfkHxMpeEe2DJm S13EpyTyBsvmQEYl92RETyQVJ/1fQ9oJeRahzXoVdgGaIUufiU6+2fLaObVz2E1EIxiK Wcyhnu8z9YROgKO6wRaeHWYVPvGUwLS75ous5Z4Z3KiA/WvwQsyDvsf8Z7ckoAK2N9Zi KRn05jXCamBIIAzFzISiU+CLRau4WfFKmh9Wypgb2o9q4YDOTBbFikBaehljVt/ObO3b pYHUpMQvcje/uhfI5N1f5QS5ePRNLHk9jH3n0+iAzUWR/q2muL/8QhGNR3+gX9ALyHAb Jg4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765159705; x=1765764505; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=kzMAceVgYEV3LRopVsx6XpOY2J2YDxUetSpuW12UF28=; b=QblFISyt9fcNgI8VwDTLO3+fxONrpB5Yiu0fWLNGtVEEUzDjjUZ8Xgg71we2YMV5W2 PEhCDqZV5IDdioQbLQGUVt8++lGyJ/gKVUBV4YVh+8bJWWzyc8yAIt+Iol6lrz70hpcV 67bTNxsGYccarmPM1IQ2O7WWRPJ/TU2peDICVoEoNVKnx2nfTQbNdOl+zlZRtTeaIcnN JSo6TzkpwxTfMWJpEsMlUmHvTfm/xORaSlT0IL4wPH8dRtPGJKygAAfVKt1T2YZ/sukM M+4eMkhdQ5pJULwDzQpYLchrzj1FDstLPCWvi9ciP0amqR3Yx68SxjkjKawBhfdEmDLu z+tw== X-Forwarded-Encrypted: i=1; AJvYcCXMiajMlubdNunq9NffJu7uqqiS2PQdfSZ0a7MgSl4lNEzGer4zcti6xExmkBDnqaJgLGSMGWY6JfJN434=@vger.kernel.org X-Gm-Message-State: AOJu0YzTM4tsyVGJfvE30BYvR+A2dYJtOwZimPVT0huunqjFZmrLkatk XRtuBK4+z0dJTxwNg1h4HLjbgurk5gVABH9Lm+0td0Z0uRs+oCrRmjE7UZNDO9FvbsuwEOB+Isb 5ve47zOLdoIobShDvpgYJi209F1/tl8Bfgbgh96u5LDe5zihI6Y6rFZcBH1ErX1lEQclkZsVGTu M= X-Gm-Gg: ASbGnctXJNnAcP4mFuIAQ4eaTGrSgPo43KCHE6TDdgoWgYWXWzQAe+gL4qOmdmLrNQC bfhbIrvf+9dqHtrjsGJ+ibkq/hPfCypSthNKQeQrXygRDWTXq1l6neQwhgVBdpo/XATC0UTT3f/ u3Bei2rmTl6LlewSAXjJvIkYzrHtkDGtYDe4v171xKMIQ/vdAH1dh+T5MVY1zxEwWRByCsCDx1f Ib9ukAlwzQb9HIGzWpeCoad0PbZme2RsOXSZtZtQJW81vId49q5X0tFTH02vyXGVk7IwFfnPRSD CxvqvkheV8p0aPst1mUdtBRqRY6OkyFFRJCjjhjBIr8tpln1asPzZyg68XAuy5XsNd7cAAex8hc eV+uETVp9RvdaIVRnNFAVW2oZV/t+TBtLCWeu/FcdU/sK0ltOAl7g/KIV X-Received: by 2002:a05:6a20:258a:b0:34f:68e9:da94 with SMTP id adf61e73a8af0-36617e8aa09mr5482228637.30.1765159704840; Sun, 07 Dec 2025 18:08:24 -0800 (PST) X-Google-Smtp-Source: AGHT+IFLWVe6gIB8P74v7a1QrkyOpnJq/8Z8WDZ38f3W2f7R80V4KSedeD0N4al3nh7zsNxc12nJyw== X-Received: by 2002:a05:6a20:258a:b0:34f:68e9:da94 with SMTP id adf61e73a8af0-36617e8aa09mr5482205637.30.1765159704343; Sun, 07 Dec 2025 18:08:24 -0800 (PST) Received: from quoll (fs98a57d9d.tkyc007.ap.nuro.jp. [152.165.125.157]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29dae99f1cfsm108001255ad.55.2025.12.07.18.08.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Dec 2025 18:08:24 -0800 (PST) From: Krzysztof Kozlowski To: Richard Cochran , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH] ptp: chardev: Fix confusing cleanup.h syntax Date: Mon, 8 Dec 2025 03:08:20 +0100 Message-ID: <20251208020819.5168-2-krzysztof.kozlowski@oss.qualcomm.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2051; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject; bh=VccLCferOc+mdB16nfI0HlBzXI9Os/PGGnbeSXCmwo4=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBpNjMTnjIROfzmbzCUSuzKP7esUV6Bxhoh0qf1g kqSSn9XVzOJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaTYzEwAKCRDBN2bmhouD 1wO4D/4lAMnD+vm96R+r1TzQ8gkd/6eI46/tnhRAkdL4PKEPAOY/y6C497KZ/HtznagZ74EZ0Mb 97pDynBThHAN3LiQXx83kC8n3+ev71L8dkaxRhDIYrgatb3a2LTk1PaDw7ZPtyrg78lyl6FAs2n Vy7dDaI4bX1ngu4mr4bWeFLTRPsKUFX0DV7c95PbX4sPED3CML80v2sM6znNjK/B1PWLe7X36+y Idwn4/89aigqByvlTmRlxm/NjrKYzOUFaH3L22FXXYU/kz8g81vYZD8e0Zv2oISzkIrBbne7lOC NYJM/8L9WFyccdZ1uBY1Lx/FdN42PJZQ98SNyFeDUVhA5wMA0sno1U6qxntqWKZWY1I/LoG83X6 DsrkQMw/QQcR5opzUs0pXml0rUUI1NlTzll1mTgKk3BY5thd5eru/5I7lJuiYVe9o7pfgHsFivP ORHXGh4FBO2qEtwqFjMysiOMTrdbrgmRWV9P0qzD0EFFK/bpnIrVMtJ8Zo+bFP5M1KKsznsz0hD ZKYVknoSLnc/rpZi4bbFqDWvVh37OFGl/PLeH18e3avvZADjOQvfFehrQSGCW1tqnrMXJcFXG9a Gd2zu5pBbdOwt6xsVQKdU7mxan/ExJ7StvfxE3Ro/aYWRVL5pT0tLgoHoS5ujpuxtmP66k7JMJB YSIMpB9cesniFrA== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: 57vCfSM-pJ2wUucCImauIKrFZdojohKw X-Proofpoint-ORIG-GUID: 57vCfSM-pJ2wUucCImauIKrFZdojohKw X-Authority-Analysis: v=2.4 cv=d774CBjE c=1 sm=1 tr=0 ts=6936331a cx=c_pps a=Oh5Dbbf/trHjhBongsHeRQ==:117 a=vTE1kzb4AqIx7XBf0Bkr0A==:17 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=4ikAd483rJ0gCz60bdsA:9 a=_Vgx9l1VpLgwpw_dHYaR:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjA4MDAxNiBTYWx0ZWRfXzr8haN0vZFC6 cdXxonx4Q1OVZ8XtMx/Y0wsLRN/8Ja2P9a9NxjB5Hhp+hmBpDp9Kq1efaZnv0xqrGfZQcdvwyU+ ySm7o/j8Yi4mEwePWutAfa6HHEwxwRR+5BrwNWJtlBczqNw7JvU+g/U2W7QMzNEPs3lcTDv8HJA 9g9yoL3k0MkyOOY8WVu0OMLVyabpUUI5rYDFCwjM1fwvAuhW31Jjrlyjy0frhnPmJZZ3/4zeHrP VF4xvBNg858u3/tpO4kKWsqMJOo7/+hT4MvyuzzSMtl2jAKCVlUWP+Q7GAm+YhrCryDkbD7ZzKL 8ZCuzkw4zjwMIviPk6C2DGbCDSk0rgY1c1Yiz043z0/EdSCM8AVaaxKoRmSgJXxgqY+0P4j7n43 cnpacUnr1nb8xxfmQHJ7JZxPl/FkkQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-06_02,2025-12-04_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 clxscore=1015 impostorscore=0 phishscore=0 adultscore=0 lowpriorityscore=0 spamscore=0 suspectscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512080016 Content-Type: text/plain; charset="utf-8" Initializing automatic __free variables to NULL without need (e.g. branches with different allocations), followed by actual allocation is in contrary to explicit coding rules guiding cleanup.h: "Given that the "__free(...) =3D NULL" pattern for variables defined at the top of the function poses this potential interdependency problem the recommendation is to always define and assign variables in one statement and not group variable definitions at the top of the function when __free() is used." Code does not have a bug, but is less readable and uses discouraged coding practice, so fix that by moving declaration to the place of assignment. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Simon Horman --- drivers/ptp/ptp_chardev.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/ptp/ptp_chardev.c b/drivers/ptp/ptp_chardev.c index c61cf9edac48..2a52cc7bccd1 100644 --- a/drivers/ptp/ptp_chardev.c +++ b/drivers/ptp/ptp_chardev.c @@ -350,13 +350,13 @@ typedef int (*ptp_gettimex_fn)(struct ptp_clock_info = *, static long ptp_sys_offset_extended(struct ptp_clock *ptp, void __user *ar= g, ptp_gettimex_fn gettimex_fn) { - struct ptp_sys_offset_extended *extoff __free(kfree) =3D NULL; struct ptp_system_timestamp sts; =20 if (!gettimex_fn) return -EOPNOTSUPP; =20 - extoff =3D memdup_user(arg, sizeof(*extoff)); + struct ptp_sys_offset_extended *extoff __free(kfree) =3D + memdup_user(arg, sizeof(*extoff)); if (IS_ERR(extoff)) return PTR_ERR(extoff); =20 @@ -402,11 +402,11 @@ static long ptp_sys_offset_extended(struct ptp_clock = *ptp, void __user *arg, =20 static long ptp_sys_offset(struct ptp_clock *ptp, void __user *arg) { - struct ptp_sys_offset *sysoff __free(kfree) =3D NULL; struct ptp_clock_time *pct; struct timespec64 ts; =20 - sysoff =3D memdup_user(arg, sizeof(*sysoff)); + struct ptp_sys_offset *sysoff __free(kfree) =3D + memdup_user(arg, sizeof(*sysoff)); if (IS_ERR(sysoff)) return PTR_ERR(sysoff); =20 --=20 2.51.0