From nobody Fri Dec 19 11:51:29 2025 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C540A20F067 for ; Mon, 8 Dec 2025 02:08:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765159697; cv=none; b=OF7OC2pyZWMdHZM3G8X2tqG4Bult6apAZf9evEzkc+BJf4KJ7/7iYQ/LxcZ8uE8bGIRUIAiAYznVdpH8o512INQnO+sGuWgOwY0IoGAxydcZrfkBTo6x6cCGbNtRx5O4vuprW9FpASsrhrnO1kCyAwKcILQArvUQgZSKeI/xJ4M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765159697; c=relaxed/simple; bh=9KrkAmm7MnqomImFw8vEd7rSzuG7x9txbxdzzCDnJN4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=l3zzJxfNfDW3PCOkX+58ZhTQ8T1FxZtiDXagqaNJkYJqEOtyQEWj+jErM5d1pThFo8UEKDj99AYRxgMNvluwigWXQZdvqBXqUBmnaJ80bgaRqIknRPW6WliJQQPl1TcAJYMZtQm+taYdF7aj2Li65623bT0TRbTLKghs8409JC4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=VhcxJQcQ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=XJ/4sMoi; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="VhcxJQcQ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="XJ/4sMoi" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5B826tY43668982 for ; Mon, 8 Dec 2025 02:08:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=qcppdkim1; bh=F3JilCaP9S+osKl/XDqS/9GF8yI2ZMjEEyd JRPLBsMM=; b=VhcxJQcQSIH+/skkPTLxAxhnXVvl2aOf4Vh5qf0bQgl6QNR0wUy oPuP5Vv57hQ3KLaQxosFE9vjLFF+dSYpOGz0XZNcPSx48sl779SEEnUVRSEaNuf9 LmJVnhzas/eHFxowy1BSytVsBRXP1dmIsxRvJv0dgei1CtOroEapkQAzCr60dp9i qIKDi/z588TUXCYK1hK6lodTGB0xQYrkuCh52OWMZT/Z/N41Lcdnuzlaybh1CHVC v2Kl1Gf5kozmS9xsaL6BbF2o1vLBlWmlI6VopvyU9cMohcJrICzO0PidY2lheex/ WJHLfOXOA/VEf8rnKz2e/2Kt4HjwmSIRw1g== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4awnkr0039-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 08 Dec 2025 02:08:14 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-7b9208e1976so7335458b3a.1 for ; Sun, 07 Dec 2025 18:08:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1765159694; x=1765764494; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=F3JilCaP9S+osKl/XDqS/9GF8yI2ZMjEEydJRPLBsMM=; b=XJ/4sMoiqaGhhhzp+mLHRvGWEC6OXCv2fRFcUG6J3yfQ/r/6dKjWZh4S4d3OfHXUVA ZtmIylCPxwgNTeTtuENw2NRWNanOb3Mq2y1D0NCCyM5FVZTNNoH0LearZMAuPFf4HgMR 751nYI5TyG+iISd+OB3g+ouufxfm0pXiAoMxfyu8byozPmHvfmyPkXRUJVtVhusaNaMz uRHrhd4P2fUN1ifSRWNY51uFZ0jLc2lzdXFY/QReCy50U6d/4/71xcP4LjxqLdEh/y6t 7sv6VpgPWMyjjQIHwhMIIZ6Op8IPfozesWpcXFf4zr2J1GddoCs8uHEkMkvh7ZPvcEdg cq7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765159694; x=1765764494; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=F3JilCaP9S+osKl/XDqS/9GF8yI2ZMjEEydJRPLBsMM=; b=n8NnHNpWlbknhdlt2WLaJAABoi1bcZ8bJYANoClKtHXnehndFKsN+ZzynMkdfbqYRA iJLrgxe4qmdpRjcE7RfDV9PNAhEcmkH/e1VIDRxnaNx0cUlklJBdYzXzTg9Y7CwcsGLz D/DpdIiSw5mtbaD8qZJyICS3uPqQz+Nd1GVXs53rG9MyHYGpWber3hXEoI9WbCbfU62K yDJ0kCDJsqZpNFRJLbGiVwzwAcy6xj2mVk9Us2rJbnNAqR0NRpAwwp7wa/XuJGfTEVIN neW/mt1OXW9H6Vd3dyic7buFvDSA3TFphjlB4nJuuPkf13VQo/dk6aOauqIb19j2p4OG SsMw== X-Forwarded-Encrypted: i=1; AJvYcCXXkLmPxSVhT0SP9c/409FnTb1/zmmYlw49x3yB/OfVzNsPxCmEZuvtDFMvSOfMJpoYbVBdan/+Ik3JLjQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxpqbkL5i/LkFzg3XzWNqwKr2zyuz+TXOct8OKs5Ld9SXR+PMkk V+JEtRNk23vt7Chz794w/jarC0JKCfg7U4ffSQiL9pf5Pqqoui46us2JwSWY/t4TDH2c3bLQx9s uvTjpA0qnONegwf2fSEq0uvpoz7uKZy8/AYTFgvrnX43J/G27vwX+Sfg1YnbfhdMxv8w= X-Gm-Gg: ASbGnct/RxvQmkRznSeTySjPIm/5pCo38mKbHLOPCGgRVTcPwP6jAU90jM6oEL+xlg7 3LHQVUyL11KACe+LNQFaahywJmKDYZi8wYLzHjHFe9yXprc3hjumBX6Rl1ZH1fUa0qzSQ5vaY8X wgQ74pr6vJEAYT9Ur9F0Cuzi4MRUCjNLFtKqNug+s7GyEOpN64z+KFgwg4Hz8wd8gu2WIeymV5Y NFdDpTe7LaZcUb8GFrr4OxrIf6kZDIWSft0hEdFHGVaiHLT13QO5FITh2AV4Z49aZkl0NM8f6OT TvHMZMlaBmm4Jf92C3CulmVrAhH5faAwkMtRWetlEViI1tU8Ea59NfSuGkJ3XgUOuS+uJqGyn8B /BzBy0SSOOoQ5EHjFt0qTzlN9ZTcr5+HCMGxeSYLcWHUjaj9WS8Fen8LN X-Received: by 2002:a05:6a00:847:b0:7ac:3529:afbb with SMTP id d2e1a72fcca58-7e8c184a40dmr5886544b3a.20.1765159693602; Sun, 07 Dec 2025 18:08:13 -0800 (PST) X-Google-Smtp-Source: AGHT+IFmqKGrOVJWYEKlVFzoRvfTjukrWw7Zf9dWoIHH4kt9YUpmPBQbF/hCNWi/GGPVmqsfKZVr+A== X-Received: by 2002:a05:6a00:847:b0:7ac:3529:afbb with SMTP id d2e1a72fcca58-7e8c184a40dmr5886519b3a.20.1765159693064; Sun, 07 Dec 2025 18:08:13 -0800 (PST) Received: from quoll (fs98a57d9d.tkyc007.ap.nuro.jp. [152.165.125.157]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7e29f2ee0b3sm11364990b3a.7.2025.12.07.18.08.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Dec 2025 18:08:12 -0800 (PST) From: Krzysztof Kozlowski To: Manivannan Sadhasivam , "James E.J. Bottomley" , "Martin K. Petersen" , linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH] ufs: qcom: Fix confusing cleanup.h syntax Date: Mon, 8 Dec 2025 03:08:08 +0100 Message-ID: <20251208020807.5043-2-krzysztof.kozlowski@oss.qualcomm.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1895; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject; bh=9KrkAmm7MnqomImFw8vEd7rSzuG7x9txbxdzzCDnJN4=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBpNjMHgfQXVHIDl21ct4d5A2Eocm71jsbahvR6V wE9LmOJD+uJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaTYzBwAKCRDBN2bmhouD 14R1D/9gtEdRMpR1H6yLvTE1LBP8Kqzy/efwIkXl4C2vlLOcNUEBp797Isig0yMsVYtyV2NtA7c 7Kb7RsuRaW58ocjMKhc9X5OPgO8VdGGL5cEIoHgA+4hsU+GAtDaxbf96GUjL3Fc+KJbh5MM2e4O MnF0ZYYbSEO++x1IDm8RiqOmsvvgEWkeUaQWL6NIZ9yEVfT4mJyYzQ5U7Fxcz2TOEuBeWpqmAY5 y8Tqv6USqOJF9mgUTJVubYgJWwmccF9f4YjtR+THB9fCPxTvN6wR0MbUeptL1rRlrTTX87Ej+uH CCxUqwesxj2TICQrpPNJq0Op8+h0PfLdvATSmpDmZrhCE5YA+Yy2KTSK7r+MuWG7mrsOw6fET45 xHgzvsYIbaUqDlA+vEEPcP6OwzjcuDuBranXrtHWu/kbG21k1A95g2vHnR/T9ELepv3vvD8YRlL lb/CFrOttZg5Kj7nt2yIIoV0TNFLQ0osI3w4GTo95xfbI3sDMpzgcA3DGd4L+40onBVt8pWmuBQ pcuISKyGGJwBb+oIDtgq8fCosy/ZSVfbx+9VjPIF5AKyBnV8sBxpU8RNU7POTE31SxKZZ8gnEfC mOaQvFVeyNSRezM9PwKAX+aBfV5ftNgrXlA0QkBjG5c9xx9tAKjVNmnaO/P8BpSBowdxHB5yLDc DVSc/HXBPPse6Yw== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjA4MDAxNSBTYWx0ZWRfXyndzQxCLkmkg Lz0cjCOmJjHHYhO3wNgZ7IhUADqdAjjj4QOmG/y5n0szry2IOn68vXkdyr4NpVFHNMvR5nDcgwd Kv033Cd4jdGbojxRDDRgss3pcR/zCha8nNhiA1sIXVCFr03PmbZ5EHMmSNfzxyR4d4TPW6tM50o CwaGn0mE6ATd1cISdnigG45Z5Yd5STg/2Pr3iz4lqanaKfNVJ+nGcFn7ciPv1+QqZC9qH8yjrgM 1dON4LkP7CKMOga5j+l1LGtbRMiFrzhBhlnUy4dPJucgcv2T+rv4c57pkHGiJS2ZQ4FbzmUFLQu ILXj15/s/5QiKe9w7viZ5a6rQk0U/7stVFhts5FEEW3JNKDjE67cPB/JWkMj6ST5cvYmOee7krg piZ1NVjP+YhwxUrYZK6WhxAeQ/XAJg== X-Proofpoint-GUID: 6jvhHGC3FWcgIY-Olf7oYEaQMAr-rMaQ X-Proofpoint-ORIG-GUID: 6jvhHGC3FWcgIY-Olf7oYEaQMAr-rMaQ X-Authority-Analysis: v=2.4 cv=RMy+3oi+ c=1 sm=1 tr=0 ts=6936330e cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=vTE1kzb4AqIx7XBf0Bkr0A==:17 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=PuYmaTqjycMhXPiJH-UA:9 a=OpyuDcXvxspvyRM73sMx:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-06_02,2025-12-04_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 bulkscore=0 suspectscore=0 spamscore=0 lowpriorityscore=0 adultscore=0 phishscore=0 clxscore=1015 impostorscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512080015 Content-Type: text/plain; charset="utf-8" Initializing automatic __free variables to NULL without need (e.g. branches with different allocations), followed by actual allocation is in contrary to explicit coding rules guiding cleanup.h: "Given that the "__free(...) =3D NULL" pattern for variables defined at the top of the function poses this potential interdependency problem the recommendation is to always define and assign variables in one statement and not group variable definitions at the top of the function when __free() is used." Code does not have a bug, but is less readable and uses discouraged coding practice, so fix that by moving declaration to the place of assignment. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Manivannan Sadhasivam --- drivers/ufs/host/ufs-qcom.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c index 8d119b3223cb..8ebee0cc5313 100644 --- a/drivers/ufs/host/ufs-qcom.c +++ b/drivers/ufs/host/ufs-qcom.c @@ -1769,10 +1769,9 @@ static void ufs_qcom_dump_testbus(struct ufs_hba *hb= a) { struct ufs_qcom_host *host =3D ufshcd_get_variant(hba); int i, j, nminor =3D 0, testbus_len =3D 0; - u32 *testbus __free(kfree) =3D NULL; char *prefix; =20 - testbus =3D kmalloc_array(256, sizeof(u32), GFP_KERNEL); + u32 *testbus __free(kfree) =3D kmalloc_array(256, sizeof(u32), GFP_KERNEL= ); if (!testbus) return; =20 @@ -1794,13 +1793,12 @@ static void ufs_qcom_dump_testbus(struct ufs_hba *h= ba) static int ufs_qcom_dump_regs(struct ufs_hba *hba, size_t offset, size_t l= en, const char *prefix, void __iomem *base) { - u32 *regs __free(kfree) =3D NULL; size_t pos; =20 if (offset % 4 !=3D 0 || len % 4 !=3D 0) return -EINVAL; =20 - regs =3D kzalloc(len, GFP_ATOMIC); + u32 *regs __free(kfree) =3D kzalloc(len, GFP_ATOMIC); if (!regs) return -ENOMEM; =20 --=20 2.51.0