From nobody Wed Dec 17 04:20:30 2025 Received: from exactco.de (exactco.de [176.9.10.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A12377262B for ; Mon, 8 Dec 2025 13:18:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=176.9.10.151 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765199908; cv=none; b=rNlI43SIBndnHFwgpCgsTpXld5TImo1QTHln8v/utlHBsFOA9ioBj3GsfkBUr073610GKrVyMxo9/PAzBQ6Ya3oyQPB66yJzdb1EKpVeR2LsZFNS9681d3aUwSOWkCIG9EAC8QH1zYrbc4OY8XGpH5ek5hEjgIpD9gS8ONvst0Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765199908; c=relaxed/simple; bh=Bo6yBVVAM/q7ytic6EOrWYW5tuqKCQGP9qnQHZ2m1Ls=; h=Date:Message-Id:To:Cc:Subject:From:Mime-Version:Content-Type; b=GQa+YoXdiIt1yY+/Ut0XAor7SvWtk1giiTCtGK46ARt12MgH8+MXzHrBIDx4QopsQBWF147ThxelwQqoMNOZh/QwHAnKY18zE10bLJ2Gg+mMY+8EUc6P08iqMKigPlHpjhSTiZa8WbNTGtONaLcV2ahHJ5v3oHV7/Oano2AiI0g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=exactco.de; spf=pass smtp.mailfrom=exactco.de; dkim=pass (2048-bit key) header.d=exactco.de header.i=@exactco.de header.b=EXtWl3j6; arc=none smtp.client-ip=176.9.10.151 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=exactco.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=exactco.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=exactco.de header.i=@exactco.de header.b="EXtWl3j6" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=exactco.de; s=x; h=Content-Transfer-Encoding:Content-Type:Mime-Version:From:Subject:Cc:To :Message-Id:Date:Sender:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=8a/CeZwjwq49K+NNP2Sd67JTF5oqlthgSeIDmPISdkE=; b=E XtWl3j6hlg/N804h4N5zFD4HCluJLYWcP7tOBH0fDQWyJ4UbgIjRM6ru2jt4kSi7t/wmOMFkIxxef dWzJJ6iaOl7EkTzP9gTnAOYu0Ugrv301K2EUC3+voaFr6yrEqP2lufLd7H5LiY1UgGhsx8eJczarK R8LZ56Sn93K3iQ3aX1UQI9636UULGEmxddl0YWvpFdik2g89IPqoQJmjvn+liW5IPJj43KRh3sttl d0AQMZHQN/dQvf0ML/rjxdYiTrCLsk4Zkj1oKyZ0ziUAo8cewBdXBCSn9m4r8JI68aqKX/rSlPukr llHCNXTzWdnCczLg7UrGWAYmUXWTUedAg==; Date: Mon, 08 Dec 2025 14:18:27 +0100 (CET) Message-Id: <20251208.141827.965103015954471168.rene@exactco.de> To: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Dave Airlie , Thomas Zimmermann Subject: [PATCH V3] drm/mgag200: Fix big-endian support From: =?iso-8859-1?Q?Ren=E9?= Rebe X-Mailer: Mew version 6.10 on Emacs 30.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Unlike the original, deleted Matrox mga driver, the new mgag200 driver has the XRGB frame-buffer byte swapped on big-endian "RISC" systems. Fix by enabling byte swapping "PowerPC" OPMODE for any __BIG_ENDIAN config. Fixes: 414c45310625 ("mgag200: initial g200se driver (v2)") Signed-off-by: Ren=C3=A9 Rebe Cc: stable@kernel.org Reviewed-by: Thomas Zimmermann --- V3: move to func, mask prev reg content V2: move to atomic_update V3 was only compile tested, while V1/2 were tested on IBM 43p w/ T2/Linux. --- drivers/gpu/drm/mgag200/mgag200_mode.c | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c b/drivers/gpu/drm/mgag2= 00/mgag200_mode.c index 951d715dea30..191037ce1029 100644 --- a/drivers/gpu/drm/mgag200/mgag200_mode.c +++ b/drivers/gpu/drm/mgag200/mgag200_mode.c @@ -161,6 +161,29 @@ static void mgag200_set_startadd(struct mga_device *md= ev, WREG_ECRT(0x00, crtcext0); } =20 +/* + * Set the opmode for the hardware swapper for Big-Endian processor + * support for the frame buffer aperture and DMAWIN space. + */ +static void mgag200_set_datasiz(struct mga_device *mdev, u32 format) +{ +#if __BIG_ENDIAN + u32 opmode =3D RREG32(MGAREG_OPMODE); + opmode &=3D ~(GENMASK(17, 16) | GENMASK(9, 8) | GENMASK(3, 2)); + + /* Big-endian byte-swapping */ + switch (format) { + case DRM_FORMAT_RGB565: + opmode |=3D 0x10100; + break; + case DRM_FORMAT_XRGB8888: + opmode |=3D 0x20200; + break; + } + WREG32(MGAREG_OPMODE, opmode); +#endif +} + void mgag200_init_registers(struct mga_device *mdev) { u8 crtc11, misc; @@ -496,6 +519,7 @@ void mgag200_primary_plane_helper_atomic_update(struct = drm_plane *plane, struct drm_atomic_helper_damage_iter iter; struct drm_rect damage; =20 + mgag200_set_datasiz(mdev, fb->format->format); drm_atomic_helper_damage_iter_init(&iter, old_plane_state, plane_state); drm_atomic_for_each_plane_damage(&iter, &damage) { mgag200_handle_damage(mdev, shadow_plane_state->data, fb, &damage); --=20 2.52.0 --=20 Ren=C3=A9 Rebe, ExactCODE GmbH, Berlin, Germany https://exactco.de =E2=80=A2 https://t2linux.com =E2=80=A2 https://patreon.= com/renerebe