From nobody Fri Dec 19 11:49:32 2025 Received: from mx07-00178001.pphosted.com (mx08-00178001.pphosted.com [91.207.212.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 591C31E2606; Mon, 8 Dec 2025 07:29:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=91.207.212.93 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765178999; cv=fail; b=cZMzihvSw9Nm90jzIEjkkLI/QZlg3ffdlxaXGqeuX9Q2BYAvT+AeCBNX4OwfJw3H1eHZdlrF/Ep3XJ5Rj0WRK0SIvrg1T/r5eCmXSZXT9IRHy4vuwBHsXPmyB8xF5WE5obIvQOZEiUEcGxpVWC52kmy3uOZMLRt/0E2LbS0Kun4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765178999; c=relaxed/simple; bh=wzCkZzPbWhj39oG9eKu97XakUMXNooBsQoajHNemf1c=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=N2iwzXSgm91ky/OGEzQ0M3EZSWOXbnBIsCwzIdr81689DjaJQ1ce2b+wqV5HP7dJDM+djZaS9h9u9HFTyNMo5y4cU6Bn5sQhv5Kwykakg2V6EHsjOTn9BwP1WGevrt/DrwMBsmPkFHdqzETRfTDUO20XyNwKn+SRhu/Eesh7hos= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com; spf=pass smtp.mailfrom=foss.st.com; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b=KQUbg2rU; arc=fail smtp.client-ip=91.207.212.93 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=foss.st.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b="KQUbg2rU" Received: from pps.filterd (m0046660.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5B87A03G1096628; Mon, 8 Dec 2025 08:29:25 +0100 Received: from am0pr02cu008.outbound.protection.outlook.com (mail-westeuropeazon11013053.outbound.protection.outlook.com [52.101.72.53]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 4avagaw3dq-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Mon, 08 Dec 2025 08:29:25 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=WtrPUsmOYbIvO/gznJgJewzPz9MNnOoM2qtzZSrIsQy8Q1PEkn0++gzMAsSNELnHg6mNvYbW1xvvE3dWDWHVh29AA+uUaSKQ6L3DxGA3JlhBhVzorb2PQ3OD1Qyt0iDaRCPWX5/wfe4R8kxhRdh7/NDZU/iUPuy2qLtpRVlwUL8lGJZAw/yZusg+P5ZaG5Sxk9fPn8e6/OjoYlnMCZOrttJjY8afEBEmXSPDBo3aItBHLAaeJlWot/MYkiOempZQPchK+tguxbCBKWrXVrz75qj53itOVZgviNnh2o4QeD4tWhpz1Hw/yVEHX822OZMqxy9fDgCMlenHJrkAoRlLZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sFifFDVVPlmakVLPtIWQFBDHLcEXcpKDiqB76TIJ8pg=; b=Cf/MmlBxA+yNKst+qcjjDPRuM//qCWtqT4fO+5+SbPpMy3P9bglZJGS0GqlCv0TvdfPY8mm6OJiOpQnMc4wVedZ8htK2c6c2nWe2vvsDIUlVMIkW2wDGOfnlKbzvqqs3EcFTR6DnR0n7TEjNGwtJ1Jdpr3sfArS+PKov8+X1h0kCk8m1QYSBjc6tTWSNnERPjueOSPmwkhD+fqCHAqexc/LldQpDGKRXu9joKakGJ/ejOYrhLS5zNM80SlFPXwqLDbtzaJwoaKilJOxIZmB1RJ2/GG+DYSnH8mIkUIPVORxTrmTm83bhNjToLo/YxlrCiEZLK+PjRos352EE4n4Sjw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=fail (sender ip is 164.130.1.60) smtp.rcpttodomain=st-md-mailman.stormreply.com smtp.mailfrom=foss.st.com; dmarc=fail (p=none sp=none pct=100) action=none header.from=foss.st.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sFifFDVVPlmakVLPtIWQFBDHLcEXcpKDiqB76TIJ8pg=; b=KQUbg2rUxj+mjb9F1zcKTfeRz4+balunzGu/htP73qN7r8CrXVr4H4c1hz+hTBWguBywzSp+z5HhOYo4XbQo94iF17xrZtSs+qiznKzFjMuPVVwGl4JjEcbSej+xKrgxQV5gF9614ACvB0VpjpnaUzsu5OEYdMgn14By7k71JWz76K3uW1SPHAJOnt44XsUV/szDtHpVCrGH8x27aWo9cFbk3FnUMlaaKZ3PKGh+VJ9Bj0ajYKWgncYEjRm5DuZwnE/TVAVuVZvZGHqhvaL4A8/Y2DAhrUEVHlnb18hl6v9zEpPWwz7nTeLgtuDLvDbEXUIoLTNj71oergLi8B1nYw== Received: from AS4P189CA0019.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:5db::10) by AS2PR10MB6925.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:57b::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9388.14; Mon, 8 Dec 2025 07:29:22 +0000 Received: from AMS1EPF00000046.eurprd04.prod.outlook.com (2603:10a6:20b:5db:cafe::41) by AS4P189CA0019.outlook.office365.com (2603:10a6:20b:5db::10) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9388.14 via Frontend Transport; Mon, 8 Dec 2025 07:29:15 +0000 X-MS-Exchange-Authentication-Results: spf=fail (sender IP is 164.130.1.60) smtp.mailfrom=foss.st.com; dkim=none (message not signed) header.d=none;dmarc=fail action=none header.from=foss.st.com; Received-SPF: Fail (protection.outlook.com: domain of foss.st.com does not designate 164.130.1.60 as permitted sender) receiver=protection.outlook.com; client-ip=164.130.1.60; helo=smtpO365.st.com; Received: from smtpO365.st.com (164.130.1.60) by AMS1EPF00000046.mail.protection.outlook.com (10.167.16.43) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9412.4 via Frontend Transport; Mon, 8 Dec 2025 07:29:21 +0000 Received: from STKDAG1NODE1.st.com (10.75.128.132) by smtpO365.st.com (10.250.44.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Mon, 8 Dec 2025 08:30:00 +0100 Received: from localhost (10.48.87.93) by STKDAG1NODE1.st.com (10.75.128.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Mon, 8 Dec 2025 08:29:20 +0100 From: Patrice Chotard Date: Mon, 8 Dec 2025 08:29:08 +0100 Subject: [PATCH v2 1/8] spi: stm32-ospi: Set DMA maxburst dynamically Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20251208-upstream_qspi_ospi_updates-v2-1-62526c9467dc@foss.st.com> References: <20251208-upstream_qspi_ospi_updates-v2-0-62526c9467dc@foss.st.com> In-Reply-To: <20251208-upstream_qspi_ospi_updates-v2-0-62526c9467dc@foss.st.com> To: Mark Brown , Maxime Coquelin , Alexandre Torgue CC: , , , , Patrice Chotard X-Mailer: b4 0.14.3 X-ClientProxiedBy: ENXCAS1NODE2.st.com (10.75.128.138) To STKDAG1NODE1.st.com (10.75.128.132) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AMS1EPF00000046:EE_|AS2PR10MB6925:EE_ X-MS-Office365-Filtering-Correlation-Id: e0c560b1-8527-4c37-e383-08de362b816d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|82310400026|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?UlNWbkZZOHpRb1lDNk54K1lvNVZoTHRhQ1FsYnd6Y1hLMDB5aDhudCsvZm1K?= =?utf-8?B?NUloUkVSZW14M3pBcDZtM3EzbTlkU2lnaDFpRnI4UjQ0WGU2VGlMdGNhbGNJ?= =?utf-8?B?YTRmbms0U3dqZGlvYjhCUEh4NDVMeldwamlPSjlmU3lRN0F1MWhYMTNsK2pW?= =?utf-8?B?emtsZUtKMnE1M0dqMy95SjQ3NFMwNTNnZUdWWHdiSWt4Zy9LRGxHa1krbS9O?= =?utf-8?B?S3dOTEkzMzYvSkl4Rzc2NmJjYjlJdWFrTFhvMzU1Q3pqUGFmYVlQY0M3VUJN?= =?utf-8?B?enpQRm1POUZZYkRqb2E1bmcrQlZ0cEZGVHJkeDRpRmVTcU5vaU9QdzRYa2Ey?= =?utf-8?B?c2lvWGg5RTZkQVVSc3pQUmQ1UFZGTEdlSDBaZXFzb2lHNmNqdCt6QmwyNVR3?= =?utf-8?B?YnZobjVoL0h0eUFZWHhzVENBU3NIS2xhSXZENEd3bzFUazBUUWhlSVpqa2U1?= =?utf-8?B?OXB1R0VxbHM0L1oySVdIeERIbzRFV2lGZ0w2d0Y1cVJIWFFpVmNFYmIzVVJo?= =?utf-8?B?K2tpZ2RTYUhEV3FWKzZhZFZ6a0lPd1Z5bUU4RTJDK0NkNjUvLy9PN3dEZHli?= =?utf-8?B?ekp0dnAxeFhZTkp0VVlqUUU5K3JNV2oxUkl6RG8zMGFMV2JKSnYveWFKd1Ja?= =?utf-8?B?aXNOc25HNXQxd0FDSUJJWmZLVFZTRGptVFk1VC9Gem5pRXRNNlYzdUFjUXhv?= =?utf-8?B?ZCtqaXFGckpLVlg0aGVhRWduWnRaL3dubnhyREE4NnBNUy9sM3Nua2VlUXY4?= =?utf-8?B?R3lKTEFwcDd6em5zc3BLaXRwN2wrSDhEUWVGdG5WMGh4NGVUbXZOR1R2N1lZ?= =?utf-8?B?MFBaN1Zzei9XZklOakd2c3h5aFl4RWE3M3VRcUFYZGdUY3c2QTZhTGMyc2Z0?= =?utf-8?B?bXR3TFFYbGZnazl2SE0zbmw0TVdDeC82Z0hnSkc2MlRRZmpuSWg5RklveXRP?= =?utf-8?B?SmE2WGxseEZ1cWhPM3NtYytvY09mME1uV0wwWW1FRFdSY2RRakV3dmVnRm5K?= =?utf-8?B?cGtyc0trVUEyRzBwWXd6SmFRakZXWFVXd2pPQjBlRmFXdkUvR0ttd000aGRo?= =?utf-8?B?TVMxbHhnL0FjSzNGcFBCQTBiTTlqcTc5T0l5OUxNZ05WSjZJd1ZFVU9IR3lF?= =?utf-8?B?dXV3UXlESGJYQ21pSGZWQ3g4bXBvN3d2WXhWYlNDekJVOGprRnM3TU9KNVdm?= =?utf-8?B?L2dCMUJhSGZDdE1JRy9sUjJyVGFQeTVPSEVFSFYyejBDL25uNTFEaEprTTNa?= =?utf-8?B?L3I1NGNxZ08wWDA4UTV1anJpaWNtYmFOcm1ZK2tnSnpOanRMYjZFK0M1WnM3?= =?utf-8?B?RXpMNlg5VHJxaFFidW5IUlRNTWhtekF5VkJWTGIrRStaV3Q5VlVqVjl5dGpK?= =?utf-8?B?cW1hcFh0T09OK3BrNjFaMnZpakFMc3RhZlVyWVRsZU5ibnRSZW55dG14YlhN?= =?utf-8?B?bDdLeWZxYmMwOGN4OERJcnVGbFkwR3Uwd0pubGtrUWdJa2JLc29jZGZUeS9I?= =?utf-8?B?OWNKRmFjTndsa3Q3YWNjMSswMVgrYmJhYTk3RFZvQVJHQnJGQnJ1QnkzbE5L?= =?utf-8?B?KzBLV0JyeHN5OUFLTzYxR1BPTFFzYitZcWZOT0ZHd1M5SFlkUEZNWldOK0RN?= =?utf-8?B?cWtnak85bnhZN0NFOS92R0pCeUpocWFXZTA2NXFvS2MrRXZPR1BrbTVGcDE2?= =?utf-8?B?VkVhdmFEcFJhUzZaN2JYeGI0NlRkZUdoZURBY05Za2xYOXRyMGJuN1kxcWZS?= =?utf-8?B?UVBFR2tlV24rYlg1S3ZseldjNFpwalhiRFlRK004QkMvK1Z0S2dQK09DTVhN?= =?utf-8?B?enNKeUJDU0Y0Z0VZcjkxSVd2bXdUK0wvb0FRVDNKRlhIWU9tL2M5M0RZYnh0?= =?utf-8?B?UTMvRHhwY2k4NGFPeHJxbmhWUjdvUkpqc3V3dUdBekpHWmdKK3hlSjAraWFw?= =?utf-8?B?aXZVSmEycUk0TG93RG5vZC82NFVZY1dYbEJzbVZjanhOL0NBVnhQQnJUOU1h?= =?utf-8?B?Z2N4eHd1am9ybkJDcWxNTE03ZFNJOXNlU0dGbDRmZlJtMXU1T3k1YlU5aEt1?= =?utf-8?B?MFVJMjdvLzdpc2xCTkczMkhXY1JHRVQrcW8yUS9WTUxFa3o0RmtyaGtPeENZ?= =?utf-8?Q?InRw=3D?= X-Forefront-Antispam-Report: CIP:164.130.1.60;CTRY:IT;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:smtpO365.st.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(82310400026)(376014)(1800799024);DIR:OUT;SFP:1101; X-OriginatorOrg: foss.st.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Dec 2025 07:29:21.5373 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e0c560b1-8527-4c37-e383-08de362b816d X-MS-Exchange-CrossTenant-Id: 75e027c9-20d5-47d5-b82f-77d7cd041e8f X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=75e027c9-20d5-47d5-b82f-77d7cd041e8f;Ip=[164.130.1.60];Helo=[smtpO365.st.com] X-MS-Exchange-CrossTenant-AuthSource: AMS1EPF00000046.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR10MB6925 X-Proofpoint-GUID: 9A4Q2i41YPmhqrVMr2CCd4-aB4G8TN42 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjA4MDA2MiBTYWx0ZWRfX3TJMKH9HTzBE i2DsOHN6YZfPKN+GSugmcCVdjyJYMWP73c8yIcx3g5dSvc8wgXnAH1u9B213o5/nY8itllXmwW2 su5rXMeJia9mGjE85T7LJZ1wGqobFYni6ftEepuX6dzSFsIMnvsWHOl8R0gM5O5RhBE3XaR7PTg wJWbULnLU77qSq8Dpohj1YLVBL/uIIUmqjK739RLE1Dce3DfWDEaamzw+FIOYH9Re0VPhxV72FC ZC7tqmBIBsuS1MIv1AcnDxNA0+5bdNGM/J8jtDinoAP+Gk1IZZ2f5sqKNxjY3V2pn8Xwcvsxrgf GJ7rJR//Pq36xUIh+BA6IW/arQFxU4MLVxWk3VVbOy7CjLY7R1V4B/MsGDuvjml6d0F279QWsNi /p5bxBEVMeyEkFHPwUP4JWJoqE34MA== X-Authority-Analysis: v=2.4 cv=D4BK6/Rj c=1 sm=1 tr=0 ts=69367e55 cx=c_pps a=YWN1z1+lYnpGIt36WFtaVw==:117 a=uCuRqK4WZKO1kjFMGfU4lQ==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=XWp4PHTOCikA:10 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s63m1ICgrNkA:10 a=KrXZwBdWH7kA:10 a=VkNPw1HP01LnGYTKEx00:22 a=8b9GpE9nAAAA:8 a=WbBYHnI1PNLwm2dNkN4A:9 a=QEXdDO2ut3YA:10 a=T3LWEMljR5ZiDmsYVIUa:22 X-Proofpoint-ORIG-GUID: 9A4Q2i41YPmhqrVMr2CCd4-aB4G8TN42 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-06_02,2025-12-04_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 priorityscore=1501 suspectscore=0 impostorscore=0 lowpriorityscore=0 bulkscore=0 phishscore=0 clxscore=1015 malwarescore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512080062 Set src_maxburst and dst_maxburst dynamically from DMA capabilities. Signed-off-by: Patrice Chotard --- drivers/spi/spi-stm32-ospi.c | 27 ++++++++++++++++++++++----- 1 file changed, 22 insertions(+), 5 deletions(-) diff --git a/drivers/spi/spi-stm32-ospi.c b/drivers/spi/spi-stm32-ospi.c index f36fd36da269..d733e37f0435 100644 --- a/drivers/spi/spi-stm32-ospi.c +++ b/drivers/spi/spi-stm32-ospi.c @@ -278,10 +278,19 @@ static irqreturn_t stm32_ospi_irq(int irq, void *dev_= id) return IRQ_HANDLED; } =20 -static void stm32_ospi_dma_setup(struct stm32_ospi *ospi, - struct dma_slave_config *dma_cfg) +static int stm32_ospi_dma_setup(struct stm32_ospi *ospi, + struct dma_slave_config *dma_cfg) { + struct dma_slave_caps caps; + int ret =3D 0; + if (dma_cfg && ospi->dma_chrx) { + ret =3D dma_get_slave_caps(ospi->dma_chrx, &caps); + if (ret) + return ret; + + dma_cfg->src_maxburst =3D caps.max_burst / dma_cfg->src_addr_width; + if (dmaengine_slave_config(ospi->dma_chrx, dma_cfg)) { dev_err(ospi->dev, "dma rx config failed\n"); dma_release_channel(ospi->dma_chrx); @@ -290,6 +299,12 @@ static void stm32_ospi_dma_setup(struct stm32_ospi *os= pi, } =20 if (dma_cfg && ospi->dma_chtx) { + ret =3D dma_get_slave_caps(ospi->dma_chtx, &caps); + if (ret) + return ret; + + dma_cfg->dst_maxburst =3D caps.max_burst / dma_cfg->dst_addr_width; + if (dmaengine_slave_config(ospi->dma_chtx, dma_cfg)) { dev_err(ospi->dev, "dma tx config failed\n"); dma_release_channel(ospi->dma_chtx); @@ -298,6 +313,8 @@ static void stm32_ospi_dma_setup(struct stm32_ospi *osp= i, } =20 init_completion(&ospi->dma_completion); + + return ret; } =20 static int stm32_ospi_tx_mm(struct stm32_ospi *ospi, @@ -899,9 +916,9 @@ static int stm32_ospi_probe(struct platform_device *pde= v) dma_cfg.dst_addr_width =3D DMA_SLAVE_BUSWIDTH_1_BYTE; dma_cfg.src_addr =3D ospi->regs_phys_base + OSPI_DR; dma_cfg.dst_addr =3D ospi->regs_phys_base + OSPI_DR; - dma_cfg.src_maxburst =3D 4; - dma_cfg.dst_maxburst =3D 4; - stm32_ospi_dma_setup(ospi, &dma_cfg); + ret =3D stm32_ospi_dma_setup(ospi, &dma_cfg); + if (ret) + return ret; =20 mutex_init(&ospi->lock); =20 --=20 2.43.0 From nobody Fri Dec 19 11:49:32 2025 Received: from mx07-00178001.pphosted.com (mx08-00178001.pphosted.com [91.207.212.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 592A523B62A; Mon, 8 Dec 2025 07:29:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=91.207.212.93 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765179000; cv=fail; b=NLl55ywxn3nogv3oeBtHTcG/5rv965oh4lbUUjoZaqJHhpgNEAudQ/sFIHBdnKec53sFPoQpf5q4GcB8u6T/+GMMl+zKk1WsFY7BbIkOydz6A2QxO5cDfjjoqoHKD9Mb8ASbJ0A+84o/zpcogq2Wc9IpoUf2F8fG3+fqsqA9gIg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765179000; c=relaxed/simple; bh=ep3js4OiaotQ4ox5Rrl+kNuqCwYWyycqnEP2thZTTis=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=FPWazzW6zWwA1EdpLeNhYp8zfkgYv9JU3GL7S/YhwgeZLwRBaFS/BOcp82fp1xdXggdy5YMP3G4kJKPQworJw/53KF5ALYpyn+6Spy7Lox3pCypItcFfjAtO3+MHc6ZIvDGhpZZx1ipExs+TryAtLDp2kfVUUCUA6Q3Ul8HrIFs= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com; spf=pass smtp.mailfrom=foss.st.com; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b=XsABhI7j; arc=fail smtp.client-ip=91.207.212.93 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=foss.st.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b="XsABhI7j" Received: from pps.filterd (m0046661.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5B879FYh744500; Mon, 8 Dec 2025 08:29:26 +0100 Received: from du2pr03cu002.outbound.protection.outlook.com (mail-northeuropeazon11011050.outbound.protection.outlook.com [52.101.65.50]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 4avc8h4u35-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Mon, 08 Dec 2025 08:29:26 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=f12OfUSZ2XJj0TlMx741lRN5a8KvAY6GNI2O0InNiFVV8bmpYb886+YtUIV2+m146KCUo8U6dVZr9OKQRTBtW58PVYhFD46c3vPPJDqAWOjibc+GOUj4OUi88mAXVEjebK5VXPxxTBAAlLlpdPiMmD1LhZql06PlBAurSwqWbUu1V1TsJOPQox1U58R7lPkVEtNCc9N0cZDN/onRJQr6mfCMwIpLWztEiU85R/G0ybJn/Gt97R1y+gYt5ObxiYJlwe+NSJhKSMRnbDWXn31Dsd4TYk1gl1QcRn+u1dE/rDDNE832AMkKK46raW0UqZnYPdxfzKItOqQfyjq8U67PnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LzaeKJv5cANruTig0GzxEtqLPYtRnt4s5JNAJTzPQNY=; b=FyygFA1II+2i7aWKMV5zHA82GpcjDCk94qLBnu88rx6Flp3LHgDW29hy4KKD9r19zTkhpJWTUYvpY6cj9O8FvjXXccqGs2+L9iz/F4iHhs0JY0QQ4WgvYI8HC6kRXvfV0yBRWQbwS4IEVnmR80p6y6vhsgdD2pB2pedpPjj9yYOFKaHJ6vQ9oWeUaQtERYW+ucUjWwZegqZwFftdrfxiy+g3UE1MoZ7qqmm7Y+XuKt6cjyDZ+jtdTKPDXL458s5+WY5pCqUZ9Cg28hlH0YoshUAcf4zepqV/zpZpuF52ezYM1Oyu3xeqn3XmJjbATLYopS337zATux6g0G4ppojupA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=fail (sender ip is 164.130.1.59) smtp.rcpttodomain=st-md-mailman.stormreply.com smtp.mailfrom=foss.st.com; dmarc=fail (p=none sp=none pct=100) action=none header.from=foss.st.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LzaeKJv5cANruTig0GzxEtqLPYtRnt4s5JNAJTzPQNY=; b=XsABhI7jTih73Upjt6aKSV9tgVJHYL67FDpHCKB7knox2S/Jwdu4WTb5wfFh1VnAFzP4cB/VWzL/RnqX59BGbPrgwkDCXhhdzaUH7IbSL9pBqDtAtz3P2W0tYn43X5MGCMhQceoOG1Fug+qgh5g/jmx3c/+Fo0g1MTFiSm7BEamY7c8uPP8S1n9yYm5XDnMEJjsi27SXmvVnNo7vCmcDhVhT7hXwqPz3yANSObDSbCB6LPBOWwrSAzX3lweqnpyB4acV+E8UKmyCtLvxyFOCF79zbQhGrlT/OVjYdzZGtYrv1TzmHmc2Wufx69B7RYO/HH8KZDtrWuGBTn1aJzx5Gw== Received: from AS4P191CA0002.EURP191.PROD.OUTLOOK.COM (2603:10a6:20b:5d5::6) by AS4PR10MB5223.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:4b3::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9388.14; Mon, 8 Dec 2025 07:29:22 +0000 Received: from AM3PEPF0000A799.eurprd04.prod.outlook.com (2603:10a6:20b:5d5:cafe::23) by AS4P191CA0002.outlook.office365.com (2603:10a6:20b:5d5::6) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9388.14 via Frontend Transport; Mon, 8 Dec 2025 07:29:22 +0000 X-MS-Exchange-Authentication-Results: spf=fail (sender IP is 164.130.1.59) smtp.mailfrom=foss.st.com; dkim=none (message not signed) header.d=none;dmarc=fail action=none header.from=foss.st.com; Received-SPF: Fail (protection.outlook.com: domain of foss.st.com does not designate 164.130.1.59 as permitted sender) receiver=protection.outlook.com; client-ip=164.130.1.59; helo=smtpO365.st.com; Received: from smtpO365.st.com (164.130.1.59) by AM3PEPF0000A799.mail.protection.outlook.com (10.167.16.104) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9412.4 via Frontend Transport; Mon, 8 Dec 2025 07:29:22 +0000 Received: from STKDAG1NODE1.st.com (10.75.128.132) by smtpo365.st.com (10.250.44.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Mon, 8 Dec 2025 08:30:04 +0100 Received: from localhost (10.48.87.93) by STKDAG1NODE1.st.com (10.75.128.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Mon, 8 Dec 2025 08:29:21 +0100 From: Patrice Chotard Date: Mon, 8 Dec 2025 08:29:09 +0100 Subject: [PATCH v2 2/8] spi: stm32-ospi: Optimize FIFO accesses using u16 or u32 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20251208-upstream_qspi_ospi_updates-v2-2-62526c9467dc@foss.st.com> References: <20251208-upstream_qspi_ospi_updates-v2-0-62526c9467dc@foss.st.com> In-Reply-To: <20251208-upstream_qspi_ospi_updates-v2-0-62526c9467dc@foss.st.com> To: Mark Brown , Maxime Coquelin , Alexandre Torgue CC: , , , , Patrice Chotard X-Mailer: b4 0.14.3 X-ClientProxiedBy: ENXCAS1NODE2.st.com (10.75.128.138) To STKDAG1NODE1.st.com (10.75.128.132) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM3PEPF0000A799:EE_|AS4PR10MB5223:EE_ X-MS-Office365-Filtering-Correlation-Id: 6902f404-05ce-4324-2eaf-08de362b81ce X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|1800799024|82310400026|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?VmFjaUg1eTJxV2pxdHJFQzlRZkEvbTI0cEJZODI1cVVZQkRSRXA1Yy8wY0dK?= =?utf-8?B?WUlUNFI2K0RaM1FwZmowRUp6cU9DK2ZUM0NnbitRYVFkb2hnOW1tQ0FNSUVk?= =?utf-8?B?TnpxbXNzZlM4dkFqdFIwWkszSlhPd0dWV00xU3BVdjU2aGMzc0Z5UEl0OXpJ?= =?utf-8?B?Z0p1cG5IUkVtdWIyQUhJbHYwRFNMMSszRmMrN3g5VktHUjlsdktsM21TRFZl?= =?utf-8?B?ZVl0VjF6NmZibXgxSTRBTkI5RzRub1JBNG9SaVBlNVRCMGNmUm10VG9aOW1L?= =?utf-8?B?UzZQcisxUVF4eGlOQlRlUnQwWEEvOVcyTE5CREgwNXFGOXBVZ1FhbUtXZ3pi?= =?utf-8?B?S2pMNVVDRW93ZWFkZC8xT0N3TE5tZ0xqNkdXUkVlWjJtZjlKQUhad3MyNjlZ?= =?utf-8?B?Wm1pM09GeG1mNmZ5RkJjT2RlcUNBSnJqdFJvQ0Y1RWk3eDBoODh6Sk1XVGdW?= =?utf-8?B?WXZvYk00aDNZSTB0TWpvZE9WelZITjFyNExRaTlzT2RtM3c0Q1F2Q0svajhV?= =?utf-8?B?UEhwcDBkQjR0RGV3NVk4OEZtaVlyUnU2a1U2LzE0UHdmSFBucGQwdC9SU0Vu?= =?utf-8?B?bUEyOUZmdElLMHF2c1ZraTlqQTJmUzVmcW9JcWhBc1BHSFZleXZBWGwvV2N4?= =?utf-8?B?RTlVRXNrS0dBZ0NTMDJibnA1TDFZV3hOQ1ZGYzkrdE5PS2k3d2l4a1lmRStI?= =?utf-8?B?bDZCY3NIeXdOYlpoeWdSb1dKSjJLMlpmc2kvb25iN0FDR1cwekNWQjUrNjIw?= =?utf-8?B?YVE1Z2xIK2ZMbmd3RFVEOCtBM29xSy9HbFJxWHVGTVlXbTJxWnEzYnB3TGZH?= =?utf-8?B?ZUt6RU1HN21MUVlCMWQ2WWh2Mi9xL1QraFNMNE9lc3k0WHdyaldqY1QybUgy?= =?utf-8?B?ODBDRi8rVDZiVGFxVVRpTk1adkFrNm9mcFV4cU16dFVuZjFQQUE0cXpNQThZ?= =?utf-8?B?dVJOZlVsZ1dTZVN1UEJTY3lLNzhKMXEvK0RxNkxtZFlaa1FadVNxRHNTQTIx?= =?utf-8?B?SkZtanZMTTNyb2kwZm8weFIvV1MvM2M2d3lVUDJITlQ3TEs5QTlxRGQ1WU1U?= =?utf-8?B?U2F4Ky9ydDlPQi9HL0JYZVhiNFhyY2lSTVRKT0VpK3JQc3FrWjRqdWF1NmpS?= =?utf-8?B?SVVxMk0wRS9SV3pVR1doQllVcklsWmtGUkV0UmRFOGtaMW9YVHRRQWlHUHJt?= =?utf-8?B?d09FeURxeXFsdGhRcU15LzJmRXlqTUdCVjVycExtNGtpVWhnT1lQQmtUYjA2?= =?utf-8?B?L0NzKy9INm5RNUVMY1lVTlMrcnNHWGJubkdyZUtmWm03U2dXSEpkUXRydXBw?= =?utf-8?B?NVkrdDRuM3paQ2VTWWdhaXVSZWljdGxxMVVNb3Y4d05UYlEybC91OCtHUGdO?= =?utf-8?B?MnBFbTNVaHpRSE5QbWl0ZHpzSTBCMzkra25yN05tdDhnb1doMExxQWJZa0s2?= =?utf-8?B?VjBRVTYrdzJJa2liRlJrcnYxVm9SN2tQRFJKaE9xWHNkR2liOXJldFRnaHZi?= =?utf-8?B?RWVTbDlZMnNheUM0OS9BdTFZdkM3SVZJd3dGYmJET3RxejViVENCOVZzS2xX?= =?utf-8?B?ZTQ3M2YxZmFla29ZdWtZZ2lDKzV2RHR2TWlMY04zeituekNFM0wwWGgvWXNL?= =?utf-8?B?T09CNXMrTkhrR3pHVzFIUlZlVGJsRUYrYTBtWVlQUm5Ubjl3TWtGV0YzakJ4?= =?utf-8?B?bW1VRERzdFIvOHJRMml6M2EwWW5ldG5XT0N4UjJQT0cxaFYza1dIaGdNNk8z?= =?utf-8?B?dnFwSWQrS2M2NWowb0I4UGtaSFNPQzN4b3RsUXRXWGxzWllQS0dWNFYyQU16?= =?utf-8?B?eFB3VWFFQ0hzVEY1WWNKRFV3WEFCOEgyZjdmS0VRbGYvRHJrZ2lBam5xSkJ5?= =?utf-8?B?dStrei83Nm1YUmovWkh0VmpZdVYybzhoLzNUY0FwMGdkaXplUEx2alNpeDQv?= =?utf-8?B?RXA5eFJ1SGU4N2U4d255U1prdW81V0o3L29wUXpzK1VMdmZGZFdHS29DRUNw?= =?utf-8?B?SjR4QkIwTUtTQnlCc2oyNTR6Q2lvL0hiclBDOXpVbG85WTlGWlNaU2pDL3N5?= =?utf-8?B?VTNIUzNvRG1ySFZDUFBFL1JWS0NZY1FCWjhCN2JudlJGSmN5byt2MTFjR0k3?= =?utf-8?Q?xKUo=3D?= X-Forefront-Antispam-Report: CIP:164.130.1.59;CTRY:IT;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:smtpO365.st.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(1800799024)(82310400026)(376014);DIR:OUT;SFP:1101; X-OriginatorOrg: foss.st.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Dec 2025 07:29:22.1571 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6902f404-05ce-4324-2eaf-08de362b81ce X-MS-Exchange-CrossTenant-Id: 75e027c9-20d5-47d5-b82f-77d7cd041e8f X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=75e027c9-20d5-47d5-b82f-77d7cd041e8f;Ip=[164.130.1.59];Helo=[smtpO365.st.com] X-MS-Exchange-CrossTenant-AuthSource: AM3PEPF0000A799.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR10MB5223 X-Proofpoint-ORIG-GUID: 5OIS9waD2wmc3yXyiS43KMCUPbvplYLj X-Authority-Analysis: v=2.4 cv=JKk2csKb c=1 sm=1 tr=0 ts=69367e56 cx=c_pps a=YWPBmyF2ww8/fKl6NjReww==:117 a=d6reE3nDawwanmLcZTMRXA==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=XWp4PHTOCikA:10 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s63m1ICgrNkA:10 a=KrXZwBdWH7kA:10 a=VkNPw1HP01LnGYTKEx00:22 a=8b9GpE9nAAAA:8 a=dgGDXPkSZnP7Mkk4B0AA:9 a=QEXdDO2ut3YA:10 a=T3LWEMljR5ZiDmsYVIUa:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjA4MDA2MiBTYWx0ZWRfX7AzE2ol7acCy Yila/VWbBSjGvy7GR+r2t/tssJ93qgaSnOikSFIUjYBOhiDOJ3gSoRIo5oPEL8uG7DZP2ZRCdjP XIsjauXRDPG4rnRETZW2g1Kt8yhHDx/t/CTlgbW5/xlxKBtXOBecYCFYZtUBCHwlrpdqaKr/xa7 lsj/F4de80fagiFzZ6s0mu156F+f7tlqmrhPwIwTPsK9/OpbD+fu5bwp4lYU8a6LWHP8sUv04UU E/Ybu3oXKjO6CpvN/2WEuuyqdtdzRLKs+EwG6T0VoCGm5AkCcEOyyhkUt6vvtGZk5OM+gaWAN3m Kr0zRquzCuYQOREU4sEctwVHvMS3NA+XH+rmT/tBGpJCyuIT8irIzU1q3P4JxzqahneqVopBsJd 9R32myVS3OabF9jIUsxKbAN2oGEALw== X-Proofpoint-GUID: 5OIS9waD2wmc3yXyiS43KMCUPbvplYLj X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-06_02,2025-12-04_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 malwarescore=0 lowpriorityscore=0 bulkscore=0 clxscore=1015 adultscore=0 suspectscore=0 priorityscore=1501 impostorscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512080062 FIFO accesses uses u8 only for read/write. In order to optimize throughput, add u16 or u32 read/write accesses when possible. Running mtd_speedtest on a 4MB sNOR partition using a stm32mp257f-ev1 board gives the following results: before after gain Read : 5693 KiB/s 21139 KiB/s 371% Write: 765 KiB/s 910 KiB/s 19% Signed-off-by: Patrice Chotard --- drivers/spi/spi-stm32-ospi.c | 47 +++++++++++++++++++++++++++++++++++-----= ---- 1 file changed, 38 insertions(+), 9 deletions(-) diff --git a/drivers/spi/spi-stm32-ospi.c b/drivers/spi/spi-stm32-ospi.c index d733e37f0435..a6f53f06200e 100644 --- a/drivers/spi/spi-stm32-ospi.c +++ b/drivers/spi/spi-stm32-ospi.c @@ -142,14 +142,32 @@ struct stm32_ospi { struct mutex lock; }; =20 -static void stm32_ospi_read_fifo(u8 *val, void __iomem *addr) +static void stm32_ospi_read_fifo(void *val, void __iomem *addr, u8 len) { - *val =3D readb_relaxed(addr); + switch (len) { + case sizeof(u32): + *((u32 *)val) =3D readl_relaxed(addr); + break; + case sizeof(u16): + *((u16 *)val) =3D readw_relaxed(addr); + break; + case sizeof(u8): + *((u8 *)val) =3D readb_relaxed(addr); + }; } =20 -static void stm32_ospi_write_fifo(u8 *val, void __iomem *addr) +static void stm32_ospi_write_fifo(void *val, void __iomem *addr, u8 len) { - writeb_relaxed(*val, addr); + switch (len) { + case sizeof(u32): + writel_relaxed(*((u32 *)val), addr); + break; + case sizeof(u16): + writew_relaxed(*((u16 *)val), addr); + break; + case sizeof(u8): + writeb_relaxed(*((u8 *)val), addr); + }; } =20 static int stm32_ospi_abort(struct stm32_ospi *ospi) @@ -172,19 +190,20 @@ static int stm32_ospi_abort(struct stm32_ospi *ospi) return timeout; } =20 -static int stm32_ospi_poll(struct stm32_ospi *ospi, u8 *buf, u32 len, bool= read) +static int stm32_ospi_poll(struct stm32_ospi *ospi, void *buf, u32 len, bo= ol read) { void __iomem *regs_base =3D ospi->regs_base; - void (*fifo)(u8 *val, void __iomem *addr); + void (*fifo)(void *val, void __iomem *addr, u8 len); u32 sr; int ret; + u8 step; =20 if (read) fifo =3D stm32_ospi_read_fifo; else fifo =3D stm32_ospi_write_fifo; =20 - while (len--) { + while (len) { ret =3D readl_relaxed_poll_timeout_atomic(regs_base + OSPI_SR, sr, sr & SR_FTF, 1, STM32_FIFO_TIMEOUT_US); @@ -193,7 +212,17 @@ static int stm32_ospi_poll(struct stm32_ospi *ospi, u8= *buf, u32 len, bool read) len, sr); return ret; } - fifo(buf++, regs_base + OSPI_DR); + + if (len >=3D sizeof(u32)) + step =3D sizeof(u32); + else if (len >=3D sizeof(u16)) + step =3D sizeof(u16); + else + step =3D sizeof(u8); + + fifo(buf, regs_base + OSPI_DR, step); + len -=3D step; + buf +=3D step; } =20 return 0; @@ -408,7 +437,7 @@ static int stm32_ospi_xfer(struct stm32_ospi *ospi, con= st struct spi_mem_op *op) if (op->data.dir =3D=3D SPI_MEM_DATA_IN) buf =3D op->data.buf.in; else - buf =3D (u8 *)op->data.buf.out; + buf =3D (void *)op->data.buf.out; =20 return stm32_ospi_poll(ospi, buf, op->data.nbytes, op->data.dir =3D=3D SPI_MEM_DATA_IN); --=20 2.43.0 From nobody Fri Dec 19 11:49:32 2025 Received: from mx07-00178001.pphosted.com (mx08-00178001.pphosted.com [91.207.212.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5916D1DD9AD; Mon, 8 Dec 2025 07:29:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=91.207.212.93 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765179001; cv=fail; b=MgTrNwI8rMEkuz47e+ZOqfwtSmimUFsd+pybVhq/JHPTQGLq89NSQbRTyxM1xqUPu5t7qCftwMaXQtKtVKbjnzc6YmdMawXa9lORS9HlkARAhQoXqdpYZsfawozcoJ4LL1IM1C6Oo1DJH61BrOVEo0UU4TJDVPi1P2tB5mqaB1A= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765179001; c=relaxed/simple; bh=OHkYNYen9RPXchyTEhR7wD+4A3GE7157el6Gigpq/Yo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=BgjOynXltyS7iwifofdDpWAcoWAMUWebf514iwFGz2BSyyOdaUkv9picAh5N7eHDgTGCTwIspDsIZHVrxPxK9fzV9V0MzMmiia1TUyYSWTyXCnKmzKihJ5TWjVbOMRUGtDa8AC13GAP5AJDw6r79u8skUzWsFeumqXlAR+Gi/Ws= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com; spf=pass smtp.mailfrom=foss.st.com; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b=G8EAm6A3; arc=fail smtp.client-ip=91.207.212.93 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=foss.st.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b="G8EAm6A3" Received: from pps.filterd (m0046661.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5B87O0WF771933; Mon, 8 Dec 2025 08:29:28 +0100 Received: from am0pr02cu008.outbound.protection.outlook.com (mail-westeuropeazon11013008.outbound.protection.outlook.com [52.101.72.8]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 4avc8h4u38-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Mon, 08 Dec 2025 08:29:27 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=hYFj37/c3xyC9IFjJ72QlYYXyegtO8mV6dDkT4jvuUdPTOY3hedP2vkxelbFW7H9c7TRC3z1q8ZYyivU/4bZ/zcXvqw562q4Fkc2UXxJbxOxkOynIDIHRlkjqpV/MA2U4j2fRSzB6FAxGhvNxqTZqgevOnt4mzW2VKcbrbodt8G6eb/qxK3hK92dffg5axtk/YWX0m8K3JSVu01yLZfD5em1AYq4f1pe2YavPmPk/O75N0yDtmC5v6tXVWfVegONxXBfGjCrFUC9cwxNa7pdpwBdUdQ965ncQY/axITUNA3ZfJbVEDmuAHJvWbXoSuksfeXUET+VxL6Wz5ja0zygmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=v0vTwNjiY8bhTPslFOoMV6CyHWS6wLmqOceYoiEQltM=; b=uFGcgH8QII6r5Xfo6zT5FWqvD/sx0Asgwnigq3W+FC2hukhKoddDxy+4CybwW0zrPbeGGAdfnXUuvqLKSYDrgm1fUkk3iIEA/VFBSVtQKC3XLVZtL3/gR/GQ3CZzgFSE7N3xdGnQeSQCs04hmnImRn6WWNL3P8N4nKmXKLHJIMaBpWAiOEivPcRYzfgkZ4zKwOYd694rhOGJW63BvYjwRJYFAzz6YjzDBZZl26T1o7H+eBb49dJ6qg+jchb8u77EXh23NcOlGE1/ILnOiZeAJEmKUw/f8QPgKcuQhfGwY//KQLbQvtywfIqa7Y0xpW5djs/2QFcIpFFMDRdCVYk8xQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=fail (sender ip is 164.130.1.60) smtp.rcpttodomain=st-md-mailman.stormreply.com smtp.mailfrom=foss.st.com; dmarc=fail (p=none sp=none pct=100) action=none header.from=foss.st.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=v0vTwNjiY8bhTPslFOoMV6CyHWS6wLmqOceYoiEQltM=; b=G8EAm6A3WpmDrmG0/Z3JPRFar9HeAlMvwKPVYtAQJIT6sw5ib7/ApsJw2bj3SHwKFWZd+FiTWbE/dsY0ZSIvqlGNnyWEESYMyoD6sxv+RLRynp5dUC9ijMMd2gblSZAelj8EnslfDQhCPIlO9YtadHg2U/fZG3YqNc1BRJsOekQvV7Q814LIxTI42d8LqdA1P3Oa0j1sLyM5vUQTb0GzBDnMoYRkRofzBRTSq5AVZXXa4XL/Zg5QGXrNYxscQS1ZrXoQyORyLzmYc90fSLotcSOsUi7L5AwL1IrJ1zsQXMAKMz5PW/2onquPtfgfzr2e7O/h6fG7Jh9UPwY56VL5kA== Received: from AS4P189CA0027.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:5db::16) by VI1PR10MB3327.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:803:12e::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9388.14; Mon, 8 Dec 2025 07:29:23 +0000 Received: from AMS1EPF00000046.eurprd04.prod.outlook.com (2603:10a6:20b:5db:cafe::a2) by AS4P189CA0027.outlook.office365.com (2603:10a6:20b:5db::16) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9388.14 via Frontend Transport; Mon, 8 Dec 2025 07:29:22 +0000 X-MS-Exchange-Authentication-Results: spf=fail (sender IP is 164.130.1.60) smtp.mailfrom=foss.st.com; dkim=none (message not signed) header.d=none;dmarc=fail action=none header.from=foss.st.com; Received-SPF: Fail (protection.outlook.com: domain of foss.st.com does not designate 164.130.1.60 as permitted sender) receiver=protection.outlook.com; client-ip=164.130.1.60; helo=smtpO365.st.com; Received: from smtpO365.st.com (164.130.1.60) by AMS1EPF00000046.mail.protection.outlook.com (10.167.16.43) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9412.4 via Frontend Transport; Mon, 8 Dec 2025 07:29:22 +0000 Received: from STKDAG1NODE1.st.com (10.75.128.132) by smtpO365.st.com (10.250.44.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Mon, 8 Dec 2025 08:30:02 +0100 Received: from localhost (10.48.87.93) by STKDAG1NODE1.st.com (10.75.128.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Mon, 8 Dec 2025 08:29:22 +0100 From: Patrice Chotard Date: Mon, 8 Dec 2025 08:29:10 +0100 Subject: [PATCH v2 3/8] spi: stm32-ospi: Remove CR_TCIE and CR_TEIE irq usage Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20251208-upstream_qspi_ospi_updates-v2-3-62526c9467dc@foss.st.com> References: <20251208-upstream_qspi_ospi_updates-v2-0-62526c9467dc@foss.st.com> In-Reply-To: <20251208-upstream_qspi_ospi_updates-v2-0-62526c9467dc@foss.st.com> To: Mark Brown , Maxime Coquelin , Alexandre Torgue CC: , , , , Patrice Chotard X-Mailer: b4 0.14.3 X-ClientProxiedBy: ENXCAS1NODE2.st.com (10.75.128.138) To STKDAG1NODE1.st.com (10.75.128.132) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AMS1EPF00000046:EE_|VI1PR10MB3327:EE_ X-MS-Office365-Filtering-Correlation-Id: 4310b7e1-a271-49d1-6c13-08de362b8231 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|82310400026|36860700013|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?M1N6OHpNSnNoQ3BLLzJXRzFTT2JBd3RKb0JoSjlNZ0ZaVkxheU1QS1B2M1JW?= =?utf-8?B?MkdRUEZoTE50TzJhZXpGNEw0d1hLMHBBR3Yza01Tem9COHRLRnNvMUZHWVlX?= =?utf-8?B?NEdLQmNPUmo3T3NiRzlyOGt3bHBSWUJnVnJtazc2bGxxbGsycUY4azBFb3lT?= =?utf-8?B?akUwekFWMld4M2NaMmd3LzIxMXp6clc3QXZMUXE3cStpVW84NnN6Mk80U0hK?= =?utf-8?B?WWhOZFhGK1h2OC9LRnBLRFpGOExleXJKTlpXRE1QUlErZVdMd093bmVTdE1Q?= =?utf-8?B?S3lEY01yNk83WncvYmZoaEJxa2Z5My95b21kSE41Z1cwYzhCYzNYdTlhN2Q4?= =?utf-8?B?VEtmVXVyMk1tNTJLMEQyUHJYQi9PSnlxbVptaWZsRE5PTUxRZW9BZDQ2YWpr?= =?utf-8?B?ODFLeUQzZXlORVVhT0l1Tzl3bmdrVlVjWjExM1pFUGhXdXA5R2NUSjVYclFS?= =?utf-8?B?VmVlV2ZMazROKzE3YjdHT2Y5dHNidGZtZS9SYWRrYWZiL05VNzJkLzV4Z1BD?= =?utf-8?B?bjZLaGRIbi9DRUU2MGkydjVTaHFKYXQ3eTlwZEU3WDRlRWdzL0prVFp4UDZ0?= =?utf-8?B?MFZaL1M4ZExDbkNwcU5QSyswS042dFdOa2ZzUkgraG5Lell3VllKNFJCUjM2?= =?utf-8?B?b1hKMlEyUkJHc1l2VjMyVEdnZ1E2MjJLVzBNZzQwc1V5b2I0bmN4bEl2KzBs?= =?utf-8?B?Rk13anpLQ2pEbnhaTWM3UEN5NWVVVmRGYW1ibXplTnJvQmMwK2FWTkRxbVJH?= =?utf-8?B?aisrL0pOSVNxSGtsWHRPbFFXMWtZeEZZTlNKVHN4dG1YNUUwQmxnRWlyTHlw?= =?utf-8?B?UElSMjViTHdNNFhZRmc0b3dJMm5WY3QzUXdRYS91UzdiWStYbi9ScmxUT0Er?= =?utf-8?B?ZmN0L2xraTZiRVhOeHNYSmI5VnB3bmJialR1U0c2M09odW1QR2FqcytXTGN6?= =?utf-8?B?SUJCUHlLVEN4cmxJRmZhSUJUdDdxLzNFaGJjR2pPVEc4MW9zZHBhb2NZZ2VI?= =?utf-8?B?NkZmMlJmcUtQMUhYWGxYYjZLNEx0ZmRROER1RU8wWFZhcXNqSXlpcFlKeFJ5?= =?utf-8?B?aTBmUXdxbzJhNnVXMkd6ZHdpMUpZTUMxd0FnNFl2QVMzYzRvekgvV1Q1anh5?= =?utf-8?B?YUo0d0djcm85dWhEOFJoUkQxY2FlaC9iN21wTzNMOFA0VGNoWUZNN2dlenhz?= =?utf-8?B?bEttR1JMTVowMFBOaHJ5WmdLMi95WC9IU3cza1lJU2YxNk5sNldMRi91dXYz?= =?utf-8?B?N3k1YXovaEg1ZDdtV3ZGSEpJTzdYLzNqaEhTYlVUTEJOWU13THVOSlQyK2Nz?= =?utf-8?B?M3pZb2N0M2FsTEgycloydEdJdE44RkdZV2kxZG5rNVNtRGQySGpEd21lR2Rv?= =?utf-8?B?Y051aCt6SVd1UVcvVmtab1Fvb1IwS04wN2FPVDFqMm1hblZhQzJPRWhoY2pa?= =?utf-8?B?NFVUcTlPNjE5VTBNaldDaWtoakxhd2hlRllkZmhuRDFiYVFHVGZBNUY1UFVI?= =?utf-8?B?bW5haDRCeXJnd0tXdWRkdTVLZ1JqMTFOcFg0eElwRGR2SDJIOHk5eEYwaGNp?= =?utf-8?B?VEdmVDgrREcybnRtTUduMDJsVEwwVUVCV3VRbkoxOGtIZXYxZnJUU0N4cmJq?= =?utf-8?B?ZGlKc1ljRkxVSmFVUHEzb0tXRXZEWldiSk1kNDVnMHhnMXZSeEkyWWdUbkt0?= =?utf-8?B?a2g2UVpRQmdLOTZZcldQaVNEVjlyNlJJTzd2RjNQSTllclo4UG1DNDZoRGpE?= =?utf-8?B?Q0NrWWk3N2NCN2M0R3Qvc3UwTmtDNmJ4cmtOVFVnSVNUcHZWSVlkd0tUdUg0?= =?utf-8?B?d1NLSzZEbGNPZGJvaGlvd0grY0wyZ3JPREloZHo5OTlsTmpXN1R0OEw0dGZV?= =?utf-8?B?Q29tK0piaEtIVEIzaG16NXR4em5HdnZ5Zll5RnNxU1R2NWVCeEpXc3dUaVhD?= =?utf-8?B?azBJdjF5VGZDRkcvU0tHT2R2dC85V2R3dGpoSGVWYWpGUFJpSExFNTZBNEU0?= =?utf-8?B?Q094NVY2RlBSZW12Smp3YTVYcDk1SmZjUlNxNE5kUE1OTCtuT2tRWWNlalBI?= =?utf-8?B?clVMOUNGTzAwajJ0bmppVXZtcElWOUZRdSs5ZzNVOVZUcnllQjdtaDMrYmdo?= =?utf-8?Q?dZGM=3D?= X-Forefront-Antispam-Report: CIP:164.130.1.60;CTRY:IT;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:smtpO365.st.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(82310400026)(36860700013)(376014);DIR:OUT;SFP:1101; X-OriginatorOrg: foss.st.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Dec 2025 07:29:22.8071 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4310b7e1-a271-49d1-6c13-08de362b8231 X-MS-Exchange-CrossTenant-Id: 75e027c9-20d5-47d5-b82f-77d7cd041e8f X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=75e027c9-20d5-47d5-b82f-77d7cd041e8f;Ip=[164.130.1.60];Helo=[smtpO365.st.com] X-MS-Exchange-CrossTenant-AuthSource: AMS1EPF00000046.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR10MB3327 X-Proofpoint-ORIG-GUID: gyQg6iM8V09FYDdBX0QiwZQYROIPbLfV X-Authority-Analysis: v=2.4 cv=JKk2csKb c=1 sm=1 tr=0 ts=69367e57 cx=c_pps a=6Kf4RVHJovTFG9veQ3L6kA==:117 a=uCuRqK4WZKO1kjFMGfU4lQ==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=XWp4PHTOCikA:10 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s63m1ICgrNkA:10 a=KrXZwBdWH7kA:10 a=VkNPw1HP01LnGYTKEx00:22 a=8b9GpE9nAAAA:8 a=4C2JBV8IMr3zZ6XvoZwA:9 a=QEXdDO2ut3YA:10 a=T3LWEMljR5ZiDmsYVIUa:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjA4MDA2MiBTYWx0ZWRfX9iIEmpa9LPQ8 +PVdxFIJaMgT/x9OdiayxXRUqpyqXr19rTOgWrSzn4wMnpe0r/NbMCDzc5CAz/8zwKjjtzIhbMO gN8S9GNwZoWLS0FUvQ6Sz65ZbSmFvagTDtVQJOhpagGCPEd5UnUpCQP7aKNITnFraC5N4vrkDea P6b053S8BDJw39cv76pqphGr6AtKKHi7VP4KYlMOzYRd7WYlfbI67QZUDLKwZBdxpUCwyqnobtU krd6rZRzriPpMNKQWD3gFfs7BOPvatHA+QYH4t/BEiPVr1gZQ+LXYcRz5Ey8cn/tyKoexoOia3U sgSaPweebHj9cVVDFgnDl3SRDt7vgnQsIyy/W5YPJSt3y8D7IWgxdIUjcyuOg4n5z6Qd4Vs9NzS 1Wowie1wRLKRu3K/JOwyojXW1+DAIQ== X-Proofpoint-GUID: gyQg6iM8V09FYDdBX0QiwZQYROIPbLfV X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-06_02,2025-12-04_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 malwarescore=0 lowpriorityscore=0 bulkscore=0 clxscore=1015 adultscore=0 suspectscore=0 priorityscore=1501 impostorscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512080062 Replace CR_TCIE and CR_TEIE irq usage by a read_poll_timeout_atomic() in stm32_ospi_wait_cmd(). It will reduce the time waiting for TCF or TEF flags to optimize throughput. before after average time spent in stm32_omi_wait_cmd: 5685 ns 923 ns Signed-off-by: Patrice Chotard --- drivers/spi/spi-stm32-ospi.c | 31 ++++++------------------------- 1 file changed, 6 insertions(+), 25 deletions(-) diff --git a/drivers/spi/spi-stm32-ospi.c b/drivers/spi/spi-stm32-ospi.c index a6f53f06200e..06632cdd1630 100644 --- a/drivers/spi/spi-stm32-ospi.c +++ b/drivers/spi/spi-stm32-ospi.c @@ -34,8 +34,6 @@ #define CR_ABORT BIT(1) #define CR_DMAEN BIT(2) #define CR_FTHRES_SHIFT 8 -#define CR_TEIE BIT(16) -#define CR_TCIE BIT(17) #define CR_SMIE BIT(19) #define CR_APMS BIT(22) #define CR_CSSEL BIT(24) @@ -106,7 +104,7 @@ #define STM32_ABT_TIMEOUT_US 100000 #define STM32_COMP_TIMEOUT_MS 5000 #define STM32_BUSY_TIMEOUT_US 100000 - +#define STM32_WAIT_CMD_TIMEOUT_US 5000 =20 #define STM32_AUTOSUSPEND_DELAY -1 =20 @@ -116,7 +114,6 @@ struct stm32_ospi { struct clk *clk; struct reset_control *rstc; =20 - struct completion data_completion; struct completion match_completion; =20 struct dma_chan *dma_chtx; @@ -240,22 +237,16 @@ static int stm32_ospi_wait_nobusy(struct stm32_ospi *= ospi) static int stm32_ospi_wait_cmd(struct stm32_ospi *ospi) { void __iomem *regs_base =3D ospi->regs_base; - u32 cr, sr; + u32 sr; int err =3D 0; =20 - if ((readl_relaxed(regs_base + OSPI_SR) & SR_TCF) || - ospi->fmode =3D=3D CR_FMODE_APM) + if (ospi->fmode =3D=3D CR_FMODE_APM) goto out; =20 - reinit_completion(&ospi->data_completion); - cr =3D readl_relaxed(regs_base + OSPI_CR); - writel_relaxed(cr | CR_TCIE | CR_TEIE, regs_base + OSPI_CR); - - if (!wait_for_completion_timeout(&ospi->data_completion, - msecs_to_jiffies(STM32_COMP_TIMEOUT_MS))) - err =3D -ETIMEDOUT; + err =3D readl_relaxed_poll_timeout_atomic(ospi->regs_base + OSPI_SR, sr, + (sr & (SR_TEF | SR_TCF)), 1, + STM32_WAIT_CMD_TIMEOUT_US); =20 - sr =3D readl_relaxed(regs_base + OSPI_SR); if (sr & SR_TCF) /* avoid false timeout */ err =3D 0; @@ -293,15 +284,6 @@ static irqreturn_t stm32_ospi_irq(int irq, void *dev_i= d) cr &=3D ~CR_SMIE; writel_relaxed(cr, regs_base + OSPI_CR); complete(&ospi->match_completion); - - return IRQ_HANDLED; - } - - if (sr & (SR_TEF | SR_TCF)) { - /* disable irq */ - cr &=3D ~CR_TCIE & ~CR_TEIE; - writel_relaxed(cr, regs_base + OSPI_CR); - complete(&ospi->data_completion); } =20 return IRQ_HANDLED; @@ -884,7 +866,6 @@ static int stm32_ospi_get_resources(struct platform_dev= ice *pdev) dev_info(dev, "No memory-map region found\n"); } =20 - init_completion(&ospi->data_completion); init_completion(&ospi->match_completion); =20 return 0; --=20 2.43.0 From nobody Fri Dec 19 11:49:32 2025 Received: from mx08-00178001.pphosted.com (mx08-00178001.pphosted.com [91.207.212.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5924223373D; Mon, 8 Dec 2025 07:29:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=91.207.212.93 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765178999; cv=fail; b=oXZjjo+VXaQLhIZWkxhZSRqA5H7bMJ5kEjgn19PJfpi8zWIqVFfAFxYm4zx693Nvy3VRfn2ZdVgCsJJGGD1b1BGJZRRCRgS9wHH9Ar++7H3dxo8rUmodfjcHyRyhYquxbfvndEY7zjjsIXZs3RVHlDuNDU4C6JgZ+lJmUDkFW88= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765178999; c=relaxed/simple; bh=NlHkUdEyW4V34WpHwzzyCkAxXn11iQRYwRFpB8NVhDs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=m3rjLgHQHY+7q0okmao9JieCLPhk1TLGRc8RO7ZYzlX9b5w+fJD760paoY5qesMHhVbe78ZOKxM0e+2X9n1QrsrapDi5/p8IyA5Qwnumko7VDNuJsh2k6V74vUmoLGcDLDAPFA9Wf3SkvaRerlYtL0z2wXxMiDCSp3jbtI+wnlk= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com; spf=pass smtp.mailfrom=foss.st.com; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b=Ym6vjvAH; arc=fail smtp.client-ip=91.207.212.93 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=foss.st.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b="Ym6vjvAH" Received: from pps.filterd (m0369457.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5B87MbUR891586; Mon, 8 Dec 2025 08:29:26 +0100 Received: from am0pr83cu005.outbound.protection.outlook.com (mail-westeuropeazon11010011.outbound.protection.outlook.com [52.101.69.11]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 4aw0aqapnq-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Mon, 08 Dec 2025 08:29:26 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=sPkxO3DMsydwIGBuopTCUEmn69ygVBrPomazImqsPEMxtIECTwWg8V49LSUxNgyMIJlHymKC32/e2/ukGeH6Lr+KeryGJHGjlSQZeY/RddKpdAQzAO5Vy8hEpza/j/OAgOOWqc8ZN7JgYfHKS+HZL3vBgt5doMNyUTi0vjpY3mtGMpayTprgZ1uNFH2/e2HJqxfohDVSt49uGH1HCTxtWFU58QVb8i7Y9B88Z021TGKIyijh4DLmlyyT6PuvNOUz2ils2DK9cslwPhD+wMKmMCRsf+rokHnWa2cIAyic2kcx7NAHLoBfGPGfF1JZbQQ3RtOeQRzOTvXPRgigjKqo9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=m+MOtcmdw7mXYh2wwEOynwkAwFmeDCfRdG8vrF/NyeQ=; b=sbAJY8SZ9+k9pYGRdfFOrQitW6VXR1VDbA/BiJXCukl2PUMxX5l9ifTvjudZpF63nGxytJTK23BK8Z5+Bv7TwLMvl8aihPLBphqC6NOCrKd5ms5xbr9e7OHsGzJHg2XpVZrwgxI6DEvynsVn2qM47bXPdjugEr1W/r+jUHiKMOZ/5/O48T9sy2a6IiK1im1lXa6uYF24gV366vgg/w12WfFz36mlWV1Zo5ch+Z1KZa6kNMGhfrQuvGIdRWF0wEHAZ8eM4tOL8iRgP3INdEqANf4UZEyMwsk5mVELh4+Z3BJw/FMc6v1jd8T7vS59Xc2qzAFGz5YLubZdEBXa4g6Ltw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=fail (sender ip is 164.130.1.59) smtp.rcpttodomain=st-md-mailman.stormreply.com smtp.mailfrom=foss.st.com; dmarc=fail (p=none sp=none pct=100) action=none header.from=foss.st.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=m+MOtcmdw7mXYh2wwEOynwkAwFmeDCfRdG8vrF/NyeQ=; b=Ym6vjvAHIZXHap3Jwab/ynXMX8n6LP2U1jUuKwYfWYEETgPN8PtfF1z0eJ2oxjA5M/MM5/qMJ3vY79v/3U1KxKVJumXuGlc7fo+6kJ8YOZJtB9hq3ra+/N7XpS/Add4F1zWocVIhGZnr8Xoej49eSOfYN8BijLI+zlCKqyZSkXWhsCwf1ScEnw19+ZPPeZaN8xsnRg74s7jBahNi+kO9qbSpe8cyHCuMPpGt1KFhB8GkHXfw8prnwS8iZseobrcW+y5sCAOk6sxtCZ6wj5lXb12C57vPz19PEkAbImcMCxAzXK2CNuwiHsKULwv+QRGSI6lca/unNQDxPdNECOsDew== Received: from AM8P190CA0023.EURP190.PROD.OUTLOOK.COM (2603:10a6:20b:219::28) by DU0PR10MB7360.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:444::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9388.14; Mon, 8 Dec 2025 07:29:24 +0000 Received: from AM3PEPF0000A79C.eurprd04.prod.outlook.com (2603:10a6:20b:219:cafe::90) by AM8P190CA0023.outlook.office365.com (2603:10a6:20b:219::28) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9388.14 via Frontend Transport; Mon, 8 Dec 2025 07:28:48 +0000 X-MS-Exchange-Authentication-Results: spf=fail (sender IP is 164.130.1.59) smtp.mailfrom=foss.st.com; dkim=none (message not signed) header.d=none;dmarc=fail action=none header.from=foss.st.com; Received-SPF: Fail (protection.outlook.com: domain of foss.st.com does not designate 164.130.1.59 as permitted sender) receiver=protection.outlook.com; client-ip=164.130.1.59; helo=smtpO365.st.com; Received: from smtpO365.st.com (164.130.1.59) by AM3PEPF0000A79C.mail.protection.outlook.com (10.167.16.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9412.4 via Frontend Transport; Mon, 8 Dec 2025 07:29:23 +0000 Received: from STKDAG1NODE1.st.com (10.75.128.132) by smtpo365.st.com (10.250.44.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Mon, 8 Dec 2025 08:30:05 +0100 Received: from localhost (10.48.87.93) by STKDAG1NODE1.st.com (10.75.128.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Mon, 8 Dec 2025 08:29:22 +0100 From: Patrice Chotard Date: Mon, 8 Dec 2025 08:29:11 +0100 Subject: [PATCH v2 4/8] spi: stm32-ospi: Simplify SMIE interrupt test Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20251208-upstream_qspi_ospi_updates-v2-4-62526c9467dc@foss.st.com> References: <20251208-upstream_qspi_ospi_updates-v2-0-62526c9467dc@foss.st.com> In-Reply-To: <20251208-upstream_qspi_ospi_updates-v2-0-62526c9467dc@foss.st.com> To: Mark Brown , Maxime Coquelin , Alexandre Torgue CC: , , , , Patrice Chotard X-Mailer: b4 0.14.3 X-ClientProxiedBy: ENXCAS1NODE2.st.com (10.75.128.138) To STKDAG1NODE1.st.com (10.75.128.132) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM3PEPF0000A79C:EE_|DU0PR10MB7360:EE_ X-MS-Office365-Filtering-Correlation-Id: 6cea5549-0b12-43b7-f989-08de362b82a8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|1800799024|82310400026|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?ek8xelhqRW9rc1BEU2d4aGRFWDVaRlZiQW1nYnlTR3ZTR2JFcFc5WkEwTmZz?= =?utf-8?B?SkU4MFZpVk9vbWRYd3dUMlVDaWs3cXUyTGg3WEpwV28xVmluR2RlZTZPNDB6?= =?utf-8?B?bEZPa1haYUNkOWNxL2Y0TEVhcGZFaTl6RUNqODB1RGQxZUNubFdRSWxWQUFi?= =?utf-8?B?VTNEZGhGaVB6cTVIbDZYZlNNUXo4K0RINFQybXdaYzB4aEY0ZlcwOEdCY0Ft?= =?utf-8?B?QUdDby9JWnRURHJhcms5aENoanZlQmIyNDhjY3liS05xRHRFdVJEc1lQUVRG?= =?utf-8?B?azA4MDZ5QjRSU29LaFNHall6WmFOM05ndFk4eDk0WVVPdWo4T2RXV21ob1ZP?= =?utf-8?B?Z3lTcU5hVTFSN0pKQU1SM3dHTlJiZVlqNnl4Y0lJVzNSTEhrYmlvaTJXbzJx?= =?utf-8?B?RU9lc2ZsT2FLUDdVVG9Qejc4bEdtWnRuTXJBajBiRVlKOFZDTTlpVkp3MWF1?= =?utf-8?B?U2N4TVMvY0hmS2hXM1RNSlRGZGgwVWhacXl5RkM1c3BVRVBROVdRWTBhUzlS?= =?utf-8?B?U1h0WTBpcG5uajZCSXZpQUhQQkVyazhUUnRnZlh5QzZYV3IvbCs1ZmtyVEZI?= =?utf-8?B?T0ljWnRUUm1wZmRwSjM4NGtndDlUaFJ0WHdBQXlHOUowd0JXTjcrUVJ5amZK?= =?utf-8?B?Y240MzlpMnJQazJCd0VlRlhEODh4Z0l4U1pJbEFJVmo5dmt0eU1Ja2hjVGRZ?= =?utf-8?B?akYzK0JaTjJrQ3VFakF3VFJtS2pMREowT2RvMFpEcW5UN2VtOFdCcm1EUUJH?= =?utf-8?B?QzIxU1RoNkE4dTVUOHdzRmwwSXZlZzRGN0tjdHQwZ0craUdlclM5TXpqYWND?= =?utf-8?B?MEcxZzVnVGdYMnVWcHhrdzBmNjROZDdmZVMvS3ozQUdkRnlFSTdnbkUxNXVa?= =?utf-8?B?R3I3WG5nUldrc25aY0dKT1AzcmdxOE1IcnUxdmRnOERFZkNQMkNyeU9Dcm1W?= =?utf-8?B?Nm5ydWtobitXVjlYdStlcUphK25yWUg1YXVsazMrbE1zbER3L3IreStrRVBY?= =?utf-8?B?WHAxNEZNR043OUpNOFhyRW5WMlhUZ3JOWFJNakVKTEFnYy9FVjVKZmlISHFH?= =?utf-8?B?QWNmSTJFWmtldEw5V1YwNmh6bzg4YTYyOGNyMmdTbXBTdndqcjdyQTJCTVY5?= =?utf-8?B?aHZOcWZEcEU2MEVSUlMwMWhub3YwVlJwZWNzd1d6dHd3SHFHUlphZVdObkR2?= =?utf-8?B?andFS1JRWFFQZXlTbk12Mk9EMHpxamw5OHU2TGRPekg3VXB3MVF1NmNqWHBQ?= =?utf-8?B?TTVNUFBqcmVtNkVBVXBuUGthcHhZNnlHTUI2R2VBbnJvODliaHYvblAxbHEy?= =?utf-8?B?ZU5scU9vWlhZaTZmbnZPdmtMcE8wS00rcmhSemxrRzVkckNTWTRLeE5vaFkx?= =?utf-8?B?QS90Q3VnWVRFdlhmNlc0TThkb2k0ajdabnJIVms2ZEtYQUlWVks2dlJvdGJ6?= =?utf-8?B?L1RqSERycTI5cFI3dE1qVkhqbjJQejA1c05IS1hvbnRzZldlMVkwdGFsbURN?= =?utf-8?B?VGh3YVUrbWt1bGtvekNOYnFCQjdPdDhRY3Q4bmozSHBNZVJRckdCMFNOdFd6?= =?utf-8?B?MGI1cnQyNWdSa0pGb2p1WndScWZhbnlmbjRnTGJuRUF6WU13d0I0WnVPUEpN?= =?utf-8?B?V0VJNUZGQXB6MFlralZzL1FINGU2S0lkMC9LTEtvdkgzT1NpYlhCdGRkYyt3?= =?utf-8?B?NE9NNlB0c0U4aGlxN2RiQ1htVENTSnVmWEFianREa2JqejVOdWZCeWNRNHFs?= =?utf-8?B?Tko1azh2VHNFL0VlcWV5YkR6a1hod01meGQ1eTlFT3lrWCtqN0loWWc2U1o0?= =?utf-8?B?aFFHeVZCcyt6RG92MFlSWjZHSk5MQ2o3Wm85b3JXT3I2Tzl6ZUtLdHIxeWd4?= =?utf-8?B?KytqNDFzN2I2bnNldUs3TlZGMXNJaU1pZEpiZlBCOUgxeHhCMFNYSmhocHZM?= =?utf-8?B?Z3BBNmw5RFptTlJMNTkvdENQR1dXUGZkTmJBRnFxSkhjejNwOFAwTG4wUndQ?= =?utf-8?B?K2NDMWN6RlFqcTNsOGhRYkw2cllTV3ZKOVVLbmlCa3NnUE9DL2xJYTJzalNr?= =?utf-8?B?cmQrc2w0eWpBSVhXQU9GRHkzbUtzSzZKTGU1SFRuSDdESWZMMysralBGbHcw?= =?utf-8?Q?hwKk=3D?= X-Forefront-Antispam-Report: CIP:164.130.1.59;CTRY:IT;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:smtpO365.st.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(1800799024)(82310400026)(376014);DIR:OUT;SFP:1101; X-OriginatorOrg: foss.st.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Dec 2025 07:29:23.5998 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6cea5549-0b12-43b7-f989-08de362b82a8 X-MS-Exchange-CrossTenant-Id: 75e027c9-20d5-47d5-b82f-77d7cd041e8f X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=75e027c9-20d5-47d5-b82f-77d7cd041e8f;Ip=[164.130.1.59];Helo=[smtpO365.st.com] X-MS-Exchange-CrossTenant-AuthSource: AM3PEPF0000A79C.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR10MB7360 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjA4MDA2MiBTYWx0ZWRfX8mnwSOBFrNbZ OnCXctjNT/aCnOZfkEZdAAtET1TfFCb9TbioVv9rqsHmkj7rbc0aDZp5G9SSHeTA6krJ3P0aUQk m02tWGNAVSSPonD6Wbp3kNQgSX6H5F0bpvAkEB9tk0N7xZMeSDurkmXkRsLcao+unj+/qyEboMt zNiNnNxCZqe/ENdVdfz5npK9s5kAd22ZZCUWebFz5h5x8BdblG1G6QLl2UwbKvCXkoBHMD+thPD lReaB6xaScUVBV6ArLEfDswy1zAWRy6Tp/3aS3dI/wZDu/CovWVg/Zr4HiYKZOMZ7TJesqjpycw QqYOcy/qNybKQY3Q+C9vGIZODG/vWb+taVZuWB4nHQpI9+EBaC1sAv+se61GII5h3F4xJMKMOig U2i+0NxzKErqwp2YAhHVnRohCKKoOQ== X-Proofpoint-GUID: _pQxZNRF75LhDlhiYn5w8UnZikD60jfp X-Proofpoint-ORIG-GUID: _pQxZNRF75LhDlhiYn5w8UnZikD60jfp X-Authority-Analysis: v=2.4 cv=R/oO2NRX c=1 sm=1 tr=0 ts=69367e56 cx=c_pps a=47WbqJ5M7RG3CIq0ooiKZA==:117 a=d6reE3nDawwanmLcZTMRXA==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=XWp4PHTOCikA:10 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s63m1ICgrNkA:10 a=KrXZwBdWH7kA:10 a=VkNPw1HP01LnGYTKEx00:22 a=8b9GpE9nAAAA:8 a=y85xp1xkQ9wiHhBLIzMA:9 a=QEXdDO2ut3YA:10 a=T3LWEMljR5ZiDmsYVIUa:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-06_02,2025-12-04_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 suspectscore=0 lowpriorityscore=0 spamscore=0 clxscore=1015 impostorscore=0 bulkscore=0 priorityscore=1501 adultscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512080062 SR_SMF status bit can only be set if CR_SMIE was previously set, keep status bit check only. Signed-off-by: Patrice Chotard --- drivers/spi/spi-stm32-ospi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-stm32-ospi.c b/drivers/spi/spi-stm32-ospi.c index 06632cdd1630..c36df8d3f5cb 100644 --- a/drivers/spi/spi-stm32-ospi.c +++ b/drivers/spi/spi-stm32-ospi.c @@ -279,7 +279,7 @@ static irqreturn_t stm32_ospi_irq(int irq, void *dev_id) cr =3D readl_relaxed(regs_base + OSPI_CR); sr =3D readl_relaxed(regs_base + OSPI_SR); =20 - if (cr & CR_SMIE && sr & SR_SMF) { + if (sr & SR_SMF) { /* disable irq */ cr &=3D ~CR_SMIE; writel_relaxed(cr, regs_base + OSPI_CR); --=20 2.43.0 From nobody Fri Dec 19 11:49:32 2025 Received: from mx08-00178001.pphosted.com (mx08-00178001.pphosted.com [91.207.212.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8491F2566E9; Mon, 8 Dec 2025 07:29:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=91.207.212.93 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765179000; cv=fail; b=o9L/9/QEfBmtLMSNt3vyIpKT6XpuQgkpeHR24wKnvLveAkab+VQllh0IHEfyRBtijF06TycRDTB2BKtFl6yiZqLIRsWkdqgVxmmjzrnFNC255gPDQOdWLhsla5hQuJBGcUr9BQdBSxzqe3XBr/G6MRFBT7cARWjL+Z+7Cr2TwmA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765179000; c=relaxed/simple; bh=ymo8xZYUg77rVc0sLjSrp8og0ZhoLhT433KHxEFF9F4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=NvIglBmDxqjITuFi4YZ+mj+2uNgDhgO1ASTQNrutKKc9XzuH84IEiW/S+vP34A9Fc1RlY7OCwyQVOPupedQDZG65lR4vqQFTfwXFkar2rgiYtoDFC8Bpry6vX8ex3APYNyf7uuib+DtAX0QddhwoGZeUn9NuZHkatpcSrlH4j5Q= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com; spf=pass smtp.mailfrom=foss.st.com; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b=nuf6qmb/; arc=fail smtp.client-ip=91.207.212.93 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=foss.st.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b="nuf6qmb/" Received: from pps.filterd (m0369457.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5B87MbUU891586; Mon, 8 Dec 2025 08:29:40 +0100 Received: from gvxpr05cu001.outbound.protection.outlook.com (mail-swedencentralazon11013058.outbound.protection.outlook.com [52.101.83.58]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 4aw0aqapp5-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Mon, 08 Dec 2025 08:29:40 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Q5JrABIqwNJcULcNkTrDYRqDbI6+5Kdur4bocOOkTiDem/O0lfDbzaCmB00YWHFeAXCmgrAw5z+caALlSkQMpd1GJc4emx3toVKHW/CV+K3PI66goUEISrq7PSSq8U0FCIFZIgA0UXkiPBsd8wu6Q0Mw4FM5BzUlUHS8cJ3hbDFp5Ka2nqCsHakdJyX33OpNLru9ViW+KvMrPMfpyGwP+gpTUe5DsRiAWWJWosEpvpYUkmSyY0Y/Lgp19gOCITEtpPJIG7WWAG38GSnSNr3sEF9+oED7x8Y3hRtpFbJhvQFu01vc6HGAKsddxdYdNVOWyT6n0FYfbFvN3gSyAqkzXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pIPsugvH6/2RuNayya6SvcHqgg3UV2mz+DTzLtRGsVE=; b=bqqbmW9fcG+h3fPfQwjusIoEQDW5JuDsTKnAp/ceTC/+hxsEV+elAaerr+I9fb5VPSX4VVySZt4CDstEFc/eTXg9jo65wk8YG/dQoX8g/9qWJDbfhyBKI6AhOPJATKuVjhQPJsxozkOdKSgzxNu5P4Zm4hLLaiQdtcjJtDXI5x0u7172PVAGWn5ZeXVO/XXj8KIh7c2SsLBHWpKj19+oa9OlMNGT4eVIycWZVbwHBhDkJluQUXNhzBMD6t5WPXj/gQSL4xVIR7YtoWFM9squ1a6mDTNSharGLyWSIaYrTnaWkybi/K8RLjpVdc6Sos0NTssk5Wg6kN9szRm+sk36gA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=fail (sender ip is 164.130.1.60) smtp.rcpttodomain=st-md-mailman.stormreply.com smtp.mailfrom=foss.st.com; dmarc=fail (p=none sp=none pct=100) action=none header.from=foss.st.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pIPsugvH6/2RuNayya6SvcHqgg3UV2mz+DTzLtRGsVE=; b=nuf6qmb/1DlRQjM/oiuoUTuo8dlTaMxaXJvVXQrt4/o9kmsSL8j+4QwIejrOr0Jr1Xs768luhSUU0pYzWf6Ko0bgSU/Vm6xZW+BIKoW31uOP0UXqm35sJ5MBUaR4DEjvSQVtrTnpSOEJaWnLBUNafngCWko9sMZmk7+HLI/7UnkDI960KOt0qa6ntbDIqY35RQNjTTFLwxjsvXGnfXkIMhWan7iYIr7wJp/iMx0t6CwgIanPazXLQLqIezzG7+j/BbnX2Vk/G3GxYgByyl/ezO0Dq+pfEbb0tkqlJ1hyhebejC0m1SUiOS+nCwpe4NrSLJ2ge5OwyRbA3hwsIwmFjg== Received: from AS4P189CA0005.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:5d7::20) by DU0PR10MB5606.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:318::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9388.14; Mon, 8 Dec 2025 07:29:24 +0000 Received: from AMS1EPF0000003F.eurprd04.prod.outlook.com (2603:10a6:20b:5d7:cafe::6b) by AS4P189CA0005.outlook.office365.com (2603:10a6:20b:5d7::20) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9388.14 via Frontend Transport; Mon, 8 Dec 2025 07:29:21 +0000 X-MS-Exchange-Authentication-Results: spf=fail (sender IP is 164.130.1.60) smtp.mailfrom=foss.st.com; dkim=none (message not signed) header.d=none;dmarc=fail action=none header.from=foss.st.com; Received-SPF: Fail (protection.outlook.com: domain of foss.st.com does not designate 164.130.1.60 as permitted sender) receiver=protection.outlook.com; client-ip=164.130.1.60; helo=smtpO365.st.com; Received: from smtpO365.st.com (164.130.1.60) by AMS1EPF0000003F.mail.protection.outlook.com (10.167.16.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9412.4 via Frontend Transport; Mon, 8 Dec 2025 07:29:24 +0000 Received: from STKDAG1NODE1.st.com (10.75.128.132) by smtpO365.st.com (10.250.44.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Mon, 8 Dec 2025 08:30:03 +0100 Received: from localhost (10.48.87.93) by STKDAG1NODE1.st.com (10.75.128.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Mon, 8 Dec 2025 08:29:23 +0100 From: Patrice Chotard Date: Mon, 8 Dec 2025 08:29:12 +0100 Subject: [PATCH v2 5/8] spi: stm32-qspi: Set DMA maxburst dynamically Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20251208-upstream_qspi_ospi_updates-v2-5-62526c9467dc@foss.st.com> References: <20251208-upstream_qspi_ospi_updates-v2-0-62526c9467dc@foss.st.com> In-Reply-To: <20251208-upstream_qspi_ospi_updates-v2-0-62526c9467dc@foss.st.com> To: Mark Brown , Maxime Coquelin , Alexandre Torgue CC: , , , , Patrice Chotard X-Mailer: b4 0.14.3 X-ClientProxiedBy: ENXCAS1NODE2.st.com (10.75.128.138) To STKDAG1NODE1.st.com (10.75.128.132) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AMS1EPF0000003F:EE_|DU0PR10MB5606:EE_ X-MS-Office365-Filtering-Correlation-Id: 492ff047-38f3-4ce2-d6c9-08de362b8315 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|376014|82310400026|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?T0NiM1BWeGxPRTFxUmRvbjM3ZktpV0xMNitxSnkyOG16VnhtWWhJeTMxWGEv?= =?utf-8?B?SXpKL1ZFcmR4UEU0MzNPWEhzTTBBK0dlZGd6N25vMXhSaVJHSDFjQWtua3Ix?= =?utf-8?B?bFltV1hxamZXZVlwZzlTN1VRUmdKbjVzVS9oYmFVb296QWVaNWlPNDRvNFhB?= =?utf-8?B?Ky9DdHk1REtSUWdCa3lQMHJzTnB0NGVWd2IyUGNWQlJwaXErcnJkbzV4MUNV?= =?utf-8?B?NXNkdXpQeUE4bjg3Z2ZFLzRRT2dyTWhBM3ZSQ1F1ZjRDb3dvdE8xaWFGejh3?= =?utf-8?B?YVBhWmdaK1lodHd1L0s5cG1rcFNOSE1Nc1FnaXBjU0RlUU1UZTlrZTlXeUZi?= =?utf-8?B?OE1KaGd1Y1VkRkRNcFBpY3Q3NGxKZ21EeEo1R2U4dGdsS3F0bTJaUE43V2Jx?= =?utf-8?B?YytXVVljZHZFd3ZiOWdDcE9EOWFnNW1nM2hkeWZ0bEtyUkV0MENWRzdoaG55?= =?utf-8?B?cHNmRmhpN0liWHEzZDBWSlpLOS9mWU1SM3lMK2ZrZFFIWm1LYTI5b3BxaTdP?= =?utf-8?B?N3owV0xwT2Y4WmszQmc1cTNqSDVmNHVFMEJCcE0xeU1ibGdMbWcvYnJnZ1dl?= =?utf-8?B?YTdHZElFM0p2Q0ZhSElLZjFUdHJqd2daSnFqNzhXM0M1REI2eEVXSmNRckgr?= =?utf-8?B?WlUzRnUxeUFMN1h6VE9tUmRLNjlydTZPYm0waXpYbE5oaWtQOXArOUIxVTZU?= =?utf-8?B?YzZINGZpTGp4bklLNndSelJnVjR4dXdiSFVBUm53TktacU1mSklZQ3FGcU5q?= =?utf-8?B?SmE5dnNLS2dXd1VudDYrbWp1STVrV2hYRWdNNWNDN0F5WGdRNVB2K0NEaXV3?= =?utf-8?B?Q0J1dTkzaFFvQW5TeHpYZWVWbXdWZTRlL3R0ajMwcWxwUGFNRzZsK3dSZWdF?= =?utf-8?B?QU14a09GNmZ2eEZNRkNvMERBWTdUWmlhSk1ZSGZoTEp4dnk2dmdJdUNyWUx6?= =?utf-8?B?UGVQNnBSRVYvWDVQRk9FbmtOdyt6ZHpVcm5OdHJVY04vNDk3akVnUjBiYzBZ?= =?utf-8?B?clMwMndHalQraFV4SEFVUm1qWWErMk0vNzIxT3ByTHp1Q2NTajlLTktpbGJP?= =?utf-8?B?ME4rSnY4SWwvcWZOVHpPVjFId0ErWmd2dzJpQUgxRFNtMVMwR2Y0Rk1hODBt?= =?utf-8?B?MDlrTzY3dWxWVHBhQ3V4Y1F3RVFhTjViNDhHUUM0YmM0UTVWaGxsM1ZoMldN?= =?utf-8?B?K25QbVZCYmxWeWRNSVMwZUROMCtjWHVUK2RhR01wVE1VYk9wdVZQVTFybzdP?= =?utf-8?B?WlVKaThQeUp0d2phN3FrVGFwL0JxOWJUT2lGeVNFc1ExRVlnYmtuSDZSMG1W?= =?utf-8?B?S3RzVG1BbmtGWTZCMWh2VDkzWVZYeG54RHk3Ylc3RFc3L1FrQlZNdEJZd2xq?= =?utf-8?B?aXBSbk9UYnVkN0ZwM3RmNFd4YngyRUFLT1dkT283SEFScCs0NGZUQmlFZjRH?= =?utf-8?B?U2Jrd0dqRTM3N0VBaVgzbm9KbWJzKzRWVFYrN3hlZ1Z2WmJkemp0QW00YXR1?= =?utf-8?B?V2I4OXRqS0YrNERqSmxENU4zMWNhUmMvZlQ3d3JLc0szUTN5cnAvd2VaTU5Q?= =?utf-8?B?aVNybXljMlJwYnQyL3REeW5ZZThBbncwWDRpd2ZPT2tVRFNQQ1Bnei9sUHYr?= =?utf-8?B?Z2c3dDB1elZKWWdtY2dhZUhUckJTcVZ4Q1h1L0JWVEliQlUzZUlRWG5JaDAx?= =?utf-8?B?bTMxMW5yYk9MZ0xSdnc3djhucWs0U0V5MzNvR0FLTThqNyt2OWNScjhHU0dm?= =?utf-8?B?SFIzeEdET08wUzVsS0hJU2xWOTZWVGdKN1U0TGh4UXcvOVVwR2R4ZkRyd2dK?= =?utf-8?B?bVFkS3JvVmRTZ0pzMWdydWxsd3E5Qm9BdFdHZDJMV2p0TVdUa2laUWZzKzg1?= =?utf-8?B?QjJhRmxqVlZSWjk1d3lCbU4rd09MaEM0TkYycEdkM1kzQVdWOThKTmUrdDlD?= =?utf-8?B?dDJxVmo3SkpkVDl0am9JTHpSMWhYUkJEd3RVOE5kZitxLzlyNmhGaTVZMUF3?= =?utf-8?B?VUY5SHBwTmZDeEVGcnB4NU1KQTFocDMrZjZiT1pFcnJzUTEzM3pkK1dhYzBr?= =?utf-8?B?cTV3enhYK3pxM3VGV20xTzdZMmZzai83Z1FBRTBvQXVubUtJTXIxK3grbFpi?= =?utf-8?Q?6Qxk=3D?= X-Forefront-Antispam-Report: CIP:164.130.1.60;CTRY:IT;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:smtpO365.st.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(376014)(82310400026)(1800799024);DIR:OUT;SFP:1101; X-OriginatorOrg: foss.st.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Dec 2025 07:29:24.3182 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 492ff047-38f3-4ce2-d6c9-08de362b8315 X-MS-Exchange-CrossTenant-Id: 75e027c9-20d5-47d5-b82f-77d7cd041e8f X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=75e027c9-20d5-47d5-b82f-77d7cd041e8f;Ip=[164.130.1.60];Helo=[smtpO365.st.com] X-MS-Exchange-CrossTenant-AuthSource: AMS1EPF0000003F.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR10MB5606 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjA4MDA2MiBTYWx0ZWRfX74+Wtgqj2Q7Y 7R1o+NAMg3NwstfZ36ntKm47LArTEgEm0wdHPW+ZE5K4HrsQF5ELeqTuHM8d0sECFuhwGXxFmBw wp/rKLePDuo30M3oAHAMu3GwjWrfvivLFkAXoDlrVG8ftDb57jjYdpSutXB0v7wiobd0aaTdti+ 3nfV1LrnyvLibmyeXA5tsBA2pwARmzQ9gN9eEKfAAz8I5npw1bbbXEwyi71xT0ns2PiEI65aIC5 h4hVOKhMs3KfsD0MaOoFN+GVkMuZ/6CG4bJuPslJV8uGPFTfyp9PPhw1ilxTGyB2i1vkEANe+6U yDivZtra9sGXcrlaI6i1MuM/zK62miufL3W1tuHEJHxx27sGzA30ouURX68BNiubWvJPgN1++5J vSzqShd1iivJDOkQdHBJ/czRuFpuPA== X-Proofpoint-GUID: o1yhZQZuJZnLNuitvWLToWRRQAzoSASb X-Proofpoint-ORIG-GUID: o1yhZQZuJZnLNuitvWLToWRRQAzoSASb X-Authority-Analysis: v=2.4 cv=R/oO2NRX c=1 sm=1 tr=0 ts=69367e64 cx=c_pps a=xFT3qlHD+1xS+TaMy1FbcQ==:117 a=uCuRqK4WZKO1kjFMGfU4lQ==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=XWp4PHTOCikA:10 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s63m1ICgrNkA:10 a=KrXZwBdWH7kA:10 a=VkNPw1HP01LnGYTKEx00:22 a=8b9GpE9nAAAA:8 a=kdm6LiA3lqeN45Uv8g0A:9 a=QEXdDO2ut3YA:10 a=T3LWEMljR5ZiDmsYVIUa:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-06_02,2025-12-04_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 suspectscore=0 lowpriorityscore=0 spamscore=0 clxscore=1015 impostorscore=0 bulkscore=0 priorityscore=1501 adultscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512080062 Set src_maxburst and dst_maxburst dynamically from DMA capabilities. Signed-off-by: Patrice Chotard --- drivers/spi/spi-stm32-qspi.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-stm32-qspi.c b/drivers/spi/spi-stm32-qspi.c index f2d19f1c5ab1..c131441e4dd4 100644 --- a/drivers/spi/spi-stm32-qspi.c +++ b/drivers/spi/spi-stm32-qspi.c @@ -689,6 +689,7 @@ static int stm32_qspi_dma_setup(struct stm32_qspi *qspi) { struct dma_slave_config dma_cfg; struct device *dev =3D qspi->dev; + struct dma_slave_caps caps; int ret =3D 0; =20 memset(&dma_cfg, 0, sizeof(dma_cfg)); @@ -697,8 +698,6 @@ static int stm32_qspi_dma_setup(struct stm32_qspi *qspi) dma_cfg.dst_addr_width =3D DMA_SLAVE_BUSWIDTH_1_BYTE; dma_cfg.src_addr =3D qspi->phys_base + QSPI_DR; dma_cfg.dst_addr =3D qspi->phys_base + QSPI_DR; - dma_cfg.src_maxburst =3D 4; - dma_cfg.dst_maxburst =3D 4; =20 qspi->dma_chrx =3D dma_request_chan(dev, "rx"); if (IS_ERR(qspi->dma_chrx)) { @@ -707,6 +706,11 @@ static int stm32_qspi_dma_setup(struct stm32_qspi *qsp= i) if (ret =3D=3D -EPROBE_DEFER) goto out; } else { + ret =3D dma_get_slave_caps(qspi->dma_chrx, &caps); + if (ret) + return ret; + + dma_cfg.src_maxburst =3D caps.max_burst / dma_cfg.src_addr_width; if (dmaengine_slave_config(qspi->dma_chrx, &dma_cfg)) { dev_err(dev, "dma rx config failed\n"); dma_release_channel(qspi->dma_chrx); @@ -719,6 +723,11 @@ static int stm32_qspi_dma_setup(struct stm32_qspi *qsp= i) ret =3D PTR_ERR(qspi->dma_chtx); qspi->dma_chtx =3D NULL; } else { + ret =3D dma_get_slave_caps(qspi->dma_chtx, &caps); + if (ret) + return ret; + + dma_cfg.dst_maxburst =3D caps.max_burst / dma_cfg.dst_addr_width; if (dmaengine_slave_config(qspi->dma_chtx, &dma_cfg)) { dev_err(dev, "dma tx config failed\n"); dma_release_channel(qspi->dma_chtx); --=20 2.43.0 From nobody Fri Dec 19 11:49:32 2025 Received: from mx07-00178001.pphosted.com (mx07-00178001.pphosted.com [185.132.182.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 795CF2522B6; Mon, 8 Dec 2025 07:29:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=185.132.182.106 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765179000; cv=fail; b=WiP4Z4EaVFE17+sg8FvdXORDEOWp8k+6KN8FIGr20fGjZYre98HELxTaXzcKXz6Eszr9ZY7i4QerswT/2tIKzfBVs3YYxDPGmyrSWaHgXkQVmPYNavrZFvwenPja7tiiV8Hk+qPMIu4iPeblmnTTImpI9uVqzDSaLcSBYxajw4c= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765179000; c=relaxed/simple; bh=JTHC4Vw2LcFWfwD6Uki0JMnmf+zbeWhCAfnk2DPaeZc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=Agt+vXRbLMBl2JHBTrJn6SpCmPNZj76D4N53J9x+nsS3m3c0JRjVkhj0wWTNO/F8sJh/xdFS6I2KrSXsoRXm5jhQ5OcAcesqwbPu/WIB+uGVT9XgC++f67bOfHefqMX2S0AlP5KsVd5dcYOMHqgYKliTm6JQiDuTBw2A98gFfgs= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com; spf=pass smtp.mailfrom=foss.st.com; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b=GCQFIdP9; arc=fail smtp.client-ip=185.132.182.106 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=foss.st.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b="GCQFIdP9" Received: from pps.filterd (m0241204.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5B87KxJs708938; Mon, 8 Dec 2025 08:29:28 +0100 Received: from am0pr83cu005.outbound.protection.outlook.com (mail-westeuropeazon11010043.outbound.protection.outlook.com [52.101.69.43]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 4avcq2w157-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Mon, 08 Dec 2025 08:29:27 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=DD+uhKvhC9B8BFJg5hP1b5OYPLTNl1oNlB+8ej02Sycqv5pNWHNAkBPQcUpCJeBv5DiP5+1q1wWOMo3qfvoMXNFXAXoJmaqNxu5VvenKQt/2gHtgB1DAsLY50P/nUG7PWFKgdHOT6nmZm/m/bKD309RCRyKl/xbdRsaic49w7a8iUUB8tWHn4VuBPVDbKvb/LTizib2v3v9IovySp86NuzByg+lH0a6CNtFP5vPhA1lhx/61ukRXqbI9CiCRF06SG20zfsLkd0hUELne+9eN/xHCDEAMtEPBp5kTdoIurTQ72Ec4fAa+Fu0YqLqI560OTqanTkLxm+MeiqKmubqnCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RdhBenL80j2dBguqTXmCc8UJoMc6CxAzHvkJU7sqDx4=; b=KkFDEHfy0hjtKmAvk1zvyj2ZCsVzZHQBS3f4KY1195s1BDYLbM7UGD912RYhyhURfeXnUNyE7ZpOoLtcpwurNMCNvjIWsduIauLpmWr+q1mxbTDdDS77yX8NOb18i6BZje4l52y6AvBk9TkzuQpfAWPIC4yQTpNkgugDHrJd6ItBqFM1ud7yfSO5TUp4bNjlN1798HPWQ3FPp75AmttHAmq7jo1nFeu60QpLE7h4QgD2KrBPA90+LH3Djbcng3oQNephIspJ3pqgEeQfCTcsiu26CjukTowcA7JkJ0C9ZU6Jv/1Ds0fkWemjh5lkXKsXG2TKlbfe/HcXFT805jCLLQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=fail (sender ip is 164.130.1.59) smtp.rcpttodomain=st-md-mailman.stormreply.com smtp.mailfrom=foss.st.com; dmarc=fail (p=none sp=none pct=100) action=none header.from=foss.st.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RdhBenL80j2dBguqTXmCc8UJoMc6CxAzHvkJU7sqDx4=; b=GCQFIdP9gmkqPlRmtI2jKV9WRtdbX/yGbvRHY7XWHMUlsQ2raKBFdAkSZzYY4DIeNVOpCsY67UJpgnLYzU1S4oBwWB19g/6lbwFsqYx3rpsJ5PBFzPuAjMlNpb1RXFMNn5rEco2DMNOMR5s+DOWHAdUPQ9/qOM3+QdeeeTStuVKh89AegeQNbaiVMNg04gNAv7x5plfv8FzB+OhKfdEn2OhtMxpF3mx9arkdEJfLNdv+kJfz/V0GzRv9v6bscZnpY1pol8mjo8txKLMOBY6ERODehaNOXN+sldBt3+SzOnmWb/3faHiIVbvJpxZE0M3OPYyg38eFgGTZOvkydkaTkg== Received: from AM8P191CA0024.EURP191.PROD.OUTLOOK.COM (2603:10a6:20b:21a::29) by AS1PR10MB5745.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:47c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9388.14; Mon, 8 Dec 2025 07:29:25 +0000 Received: from AM3PEPF0000A79A.eurprd04.prod.outlook.com (2603:10a6:20b:21a:cafe::ef) by AM8P191CA0024.outlook.office365.com (2603:10a6:20b:21a::29) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9388.14 via Frontend Transport; Mon, 8 Dec 2025 07:29:06 +0000 X-MS-Exchange-Authentication-Results: spf=fail (sender IP is 164.130.1.59) smtp.mailfrom=foss.st.com; dkim=none (message not signed) header.d=none;dmarc=fail action=none header.from=foss.st.com; Received-SPF: Fail (protection.outlook.com: domain of foss.st.com does not designate 164.130.1.59 as permitted sender) receiver=protection.outlook.com; client-ip=164.130.1.59; helo=smtpO365.st.com; Received: from smtpO365.st.com (164.130.1.59) by AM3PEPF0000A79A.mail.protection.outlook.com (10.167.16.105) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9412.4 via Frontend Transport; Mon, 8 Dec 2025 07:29:24 +0000 Received: from STKDAG1NODE1.st.com (10.75.128.132) by smtpo365.st.com (10.250.44.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Mon, 8 Dec 2025 08:30:07 +0100 Received: from localhost (10.48.87.93) by STKDAG1NODE1.st.com (10.75.128.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Mon, 8 Dec 2025 08:29:24 +0100 From: Patrice Chotard Date: Mon, 8 Dec 2025 08:29:13 +0100 Subject: [PATCH v2 6/8] spi: stm32-qspi: Optimize FIFO accesses using u16 or u32 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20251208-upstream_qspi_ospi_updates-v2-6-62526c9467dc@foss.st.com> References: <20251208-upstream_qspi_ospi_updates-v2-0-62526c9467dc@foss.st.com> In-Reply-To: <20251208-upstream_qspi_ospi_updates-v2-0-62526c9467dc@foss.st.com> To: Mark Brown , Maxime Coquelin , Alexandre Torgue CC: , , , , Patrice Chotard X-Mailer: b4 0.14.3 X-ClientProxiedBy: ENXCAS1NODE2.st.com (10.75.128.138) To STKDAG1NODE1.st.com (10.75.128.132) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM3PEPF0000A79A:EE_|AS1PR10MB5745:EE_ X-MS-Office365-Filtering-Correlation-Id: fa08b7a2-206a-475b-2d25-08de362b8376 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|36860700013|82310400026; X-Microsoft-Antispam-Message-Info: =?utf-8?B?bmUrSSt2TkpYZWNDcXhGcGMzdk16UUNWcG9SR054N3hJc0dtTWV2T2hGSGhq?= =?utf-8?B?WUJXTDJ2K250ZDNQaE5WOHpHRDdIWkxyZWtRc1lMTk1VTkRGTDNDZUJzL2VH?= =?utf-8?B?RVErZ2NmaG5UVC9wblV2TlBQcWF4SHZHbUl2cE5yRWdpTGNNZ3hyS1Y1Ym1y?= =?utf-8?B?Q2tyWGdUQTB2cDhKVkFGeitEeE8rRlRqRUI0cXdSa3hTQ0E3aU9HaU9VbEdq?= =?utf-8?B?TVNBYTRLaktZaGRaQXpTN1RCOFlwM3FWQVZjTEExOVRGQzAzVDdtR1BpQWNN?= =?utf-8?B?NUt0dCtWWnBRUXFjTnZ5eElGRUVBNUIyRURjbXIrTnpoaUowbEMwL1pycDFO?= =?utf-8?B?M0I5UHhWK2ZZanZuc1AzNDM5akhTUFdRSVZ6TDloMllEMjJPS0VmUlVVVzdJ?= =?utf-8?B?UkVtMGprVzNhdVo1TmxDbnNSZ1JRQ0xNeVYzQWZrc1krVFVCT0c0cDFLVER6?= =?utf-8?B?Q0tYTC8yT1p4R2NyRXFpUXBFVjkvd1hQMEZ5cXlYUXdUd3NLaERrdXdXdjRI?= =?utf-8?B?YjdnTHpTRzh2UjlFWTQ4N3ZsMXk0VG5tQWlHMHZqVHhJUDB4ZUJmWGV2Ykh1?= =?utf-8?B?dFdlbFpPYUxJUlRuZmNQTDFCUWxqUzRaeXU4di9OQmU5L1ZYRktxdTVBL0M1?= =?utf-8?B?N05tOVltNnJvaXJiUXJWU3lEcHNZb2h2S0NFK2p1eDFjSXhocDFwKzhMRzY4?= =?utf-8?B?TnAyNEhmbWZ6MHVRY1RjK29Ld2tzTlpISCtrYVY4a0V6dE1TY3FkdmVXeXZU?= =?utf-8?B?R1Z3ZzgvNWVKR0xzMThCQUVjUVFQUmpBNmhZRURCNGVieDhXM3lWRG1PeEx3?= =?utf-8?B?UkF2SlNVTElzM1doQkcrVEwxYlRwdzF4TmEwT25GVC9IcVU0VEV4N3FFMG9y?= =?utf-8?B?VTV6TnpuZjY3QjNHamlPS01IKzNzL2Q5NEgzcXpXV05iS1JraHJwZlI4TlIr?= =?utf-8?B?VVRObUpacVhldTUwSUp6V3pJUC9sMERzRE5yenE5NGdTZzU0akQ2eStkdW9R?= =?utf-8?B?OSt1UXh4NGtDcGsxeDhWZXRlSG15TUZTWTE0YlNGczdGY3dxWFQ4U21TbElQ?= =?utf-8?B?UFBycWhJTmt0bmhsTm91WjM0M0VxM1VFVnY1dGMyc1VZeWJpU2Fqa1EvR3V5?= =?utf-8?B?TW9SR3RPYVNMOUxnUm55ZnlSYmxadm9Wb0V4SzdMdWxWL3hUUnJYTFprVHNM?= =?utf-8?B?WHYwUlN5aFJKSmlvdVlEUlArYUtPOElPVU5SM1pQN0Vtd0VZRmlLT3BiblFn?= =?utf-8?B?cnFZR2Uza3pZUlpCYm5ZR3RXVDFva2RjeUttVXlycGZqQ01hM3krZjZrdUVi?= =?utf-8?B?ZjZpLzVhYTdTclRFSEdSR3l4QVJiNmZlVGFLQ2RtSkF6UWZ0dlJrVHgzNnQ3?= =?utf-8?B?ZFpteHVvNWlTVkVWKytRTXp4ai9OakZLRy9xYWNtckZkdGVyeU5TTjRlc0pZ?= =?utf-8?B?Sitxc2JxSitnWDBISyt4TXYxQjNPWWs4YXBCbU1XUDE0ZGp0c05sTnFnbHJn?= =?utf-8?B?MlExVDdkcW9IK0VsVXFydTdUdjV2RlZhWmdOT0hBbm5mOWxJaTFMQlVIN0Qy?= =?utf-8?B?T2NReXNDVUlYUnhvK3hBcTZxQlBmYUVKMFBnS1o2MGhtcXNiOWoxRzRpd1l5?= =?utf-8?B?dlZZYWZDNmJ6cDZzOG9OUUZrQjJwSWwzTXQrRjVYQTh0WEhUODBNYzRmTTFV?= =?utf-8?B?UDcyNFFXOFYwU3pjZnVnQ2NlbldreXN1K2ZsdG16WXRwbFJvVnhUeWlEQzR4?= =?utf-8?B?UzNIdW83cFVMV1dHT3FQb0tDVlJCbjNGbTJzcmtXWHZibWpvMEIxUWpvQlVM?= =?utf-8?B?TTJYTnFjdmR0WnJhTEZPMEMwOXpzYkZLMFE3WTlaZE9QK3Y5bEc4OWR4M3oz?= =?utf-8?B?QVo3Tit6OEZwUGsxYUhndUhMRUxKbm0yQWtIZCsxbDZqS2MveWlodUxGZ1JQ?= =?utf-8?B?UFQ5cWE2QWJnMDZkWGRTZUx3Rm5VNTMzajJWbW1JK0o3cVJnTTllQ0VVSTJY?= =?utf-8?B?TytkY0ZsNUN3T0VYM1NMTFpDNWthdnVRdTF1MllxNWhWVHMyQWpYOGZUb3ky?= =?utf-8?B?TTk5T3pNZEswcGxsNVV5MTNVb1BwRUxnQ3JmbEFYNk9MSlgwa0hYaW1BUk9T?= =?utf-8?Q?lXp4=3D?= X-Forefront-Antispam-Report: CIP:164.130.1.59;CTRY:IT;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:smtpO365.st.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(1800799024)(36860700013)(82310400026);DIR:OUT;SFP:1101; X-OriginatorOrg: foss.st.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Dec 2025 07:29:24.9461 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fa08b7a2-206a-475b-2d25-08de362b8376 X-MS-Exchange-CrossTenant-Id: 75e027c9-20d5-47d5-b82f-77d7cd041e8f X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=75e027c9-20d5-47d5-b82f-77d7cd041e8f;Ip=[164.130.1.59];Helo=[smtpO365.st.com] X-MS-Exchange-CrossTenant-AuthSource: AM3PEPF0000A79A.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR10MB5745 X-Authority-Analysis: v=2.4 cv=fc6gCkQF c=1 sm=1 tr=0 ts=69367e57 cx=c_pps a=CrEM3l311luX7ryRsfSUgg==:117 a=d6reE3nDawwanmLcZTMRXA==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=XWp4PHTOCikA:10 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s63m1ICgrNkA:10 a=KrXZwBdWH7kA:10 a=VkNPw1HP01LnGYTKEx00:22 a=8b9GpE9nAAAA:8 a=H034yFGYOyrU3Mls5rUA:9 a=QEXdDO2ut3YA:10 a=T3LWEMljR5ZiDmsYVIUa:22 X-Proofpoint-GUID: 1G1HPBJRu4Ye5Kk9opIhZzUvejwleSRK X-Proofpoint-ORIG-GUID: 1G1HPBJRu4Ye5Kk9opIhZzUvejwleSRK X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjA4MDA2MiBTYWx0ZWRfX4iPJoxSOuPa2 42ZjNJCI5exvt0X76WdiZ6gYZybGb1GfeErRORxz3Df4S75zB5Z1+vHPM46Rhg0I3uF4Zs3dKU0 Pc52DYYIUlr+YdstZ2OrVwZBBXAUj8jUJL3Uhy61Me4JRicfCkyEmq597nDkVfjOhgmyqgdUPpL 4qiY0EMQU4uO4HQNjmLNe+lgSKbKWaBZ8DkPatdFltC0Wo9TzAIQ9jE9R/eTggEfv4Yq/7qfIKf 7V/umhEPlJ7o4tHLCJ6Yn7lNVMbuiwzijuhqDMl3j3+zgoKMexVLk4y8P3HuvfwEvQPkVx27doK z2icMmk9tOVvHenFeoTP24HxuOPVLLeVlL+0wtWhztXFdml881zI7HbeGMCWsw9rRfY9EVNGmah lxrZ8M9nfuugI1d/vzrW8SX8wLLNtw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-06_02,2025-12-04_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 bulkscore=0 impostorscore=0 lowpriorityscore=0 phishscore=0 malwarescore=0 adultscore=0 priorityscore=1501 clxscore=1015 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512080062 FIFO accesses uses u8 only for read/write. In order to optimize throughput, add u16 or u32 read/write accesses when possible. Running mtd_speedtest on a 4MB sNOR partition using a stm32mp257f-ev1 board gives the following results: before after gain Read : 5773 KiB/s 22170 KiB/s 384% Write: 796 KiB/s 890 KiB/s 12% Signed-off-by: Patrice Chotard --- drivers/spi/spi-stm32-qspi.c | 51 ++++++++++++++++++++++++++++++++++------= ---- 1 file changed, 40 insertions(+), 11 deletions(-) diff --git a/drivers/spi/spi-stm32-qspi.c b/drivers/spi/spi-stm32-qspi.c index c131441e4dd4..c7f2b435d5ee 100644 --- a/drivers/spi/spi-stm32-qspi.c +++ b/drivers/spi/spi-stm32-qspi.c @@ -153,34 +153,53 @@ static irqreturn_t stm32_qspi_irq(int irq, void *dev_= id) return IRQ_HANDLED; } =20 -static void stm32_qspi_read_fifo(u8 *val, void __iomem *addr) +static void stm32_qspi_read_fifo(void *val, void __iomem *addr, u8 len) { - *val =3D readb_relaxed(addr); + switch (len) { + case sizeof(u32): + *((u32 *)val) =3D readl_relaxed(addr); + break; + case sizeof(u16): + *((u16 *)val) =3D readw_relaxed(addr); + break; + case sizeof(u8): + *((u8 *)val) =3D readb_relaxed(addr); + }; } =20 -static void stm32_qspi_write_fifo(u8 *val, void __iomem *addr) +static void stm32_qspi_write_fifo(void *val, void __iomem *addr, u8 len) { - writeb_relaxed(*val, addr); + switch (len) { + case sizeof(u32): + writel_relaxed(*((u32 *)val), addr); + break; + case sizeof(u16): + writew_relaxed(*((u16 *)val), addr); + break; + case sizeof(u8): + writeb_relaxed(*((u8 *)val), addr); + }; } =20 static int stm32_qspi_tx_poll(struct stm32_qspi *qspi, const struct spi_mem_op *op) { - void (*tx_fifo)(u8 *val, void __iomem *addr); + void (*fifo)(void *val, void __iomem *addr, u8 len); u32 len =3D op->data.nbytes, sr; - u8 *buf; + void *buf; int ret; + u8 step; =20 if (op->data.dir =3D=3D SPI_MEM_DATA_IN) { - tx_fifo =3D stm32_qspi_read_fifo; + fifo =3D stm32_qspi_read_fifo; buf =3D op->data.buf.in; =20 } else { - tx_fifo =3D stm32_qspi_write_fifo; - buf =3D (u8 *)op->data.buf.out; + fifo =3D stm32_qspi_write_fifo; + buf =3D (void *)op->data.buf.out; } =20 - while (len--) { + while (len) { ret =3D readl_relaxed_poll_timeout_atomic(qspi->io_base + QSPI_SR, sr, (sr & SR_FTF), 1, STM32_FIFO_TIMEOUT_US); @@ -189,7 +208,17 @@ static int stm32_qspi_tx_poll(struct stm32_qspi *qspi, len, sr); return ret; } - tx_fifo(buf++, qspi->io_base + QSPI_DR); + + if (len >=3D sizeof(u32)) + step =3D sizeof(u32); + else if (len >=3D sizeof(u16)) + step =3D sizeof(u16); + else + step =3D sizeof(u8); + + fifo(buf, qspi->io_base + QSPI_DR, step); + len -=3D step; + buf +=3D step; } =20 return 0; --=20 2.43.0 From nobody Fri Dec 19 11:49:32 2025 Received: from mx08-00178001.pphosted.com (mx08-00178001.pphosted.com [91.207.212.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FFEE2517AA; Mon, 8 Dec 2025 07:29:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=91.207.212.93 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765179000; cv=fail; b=DV8oC3BKqEdlB2c3loDB5nazsKPaLjqhwjXBkeLCO8f3HhYXTkQFttaXgT45wtuLc2R+pSQ4nMNBVG85jZb5bBTV4C/Eqjqvdh+iY5aNoqusI2f7DstVPeiBtCJGwHzf987EcpjlMqHv9d/H1Mx1ZydWgluICat6h2AhsZSiTCE= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765179000; c=relaxed/simple; bh=KB8SeaJv9KC2JD4D/BJJoOV3rEmdcNd/02A/f2SpRn4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=WWqvhFgbjvNKws5Zue7nCOaWnmFiFLZuas3tAvjKYk2k2vyd3nNT1oeBBrCmm933M87qtepD/9w1hF9fqTgz8ao2EMYRayj/m6bNWc9J7Ozc+Ui9VjkgoFldqi/rQWGvfv9npGzgkuqR3cSzaGYhZz8cA/RjYkyOm/OR/GNK67g= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com; spf=pass smtp.mailfrom=foss.st.com; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b=YRkyKqHc; arc=fail smtp.client-ip=91.207.212.93 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=foss.st.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b="YRkyKqHc" Received: from pps.filterd (m0369457.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5B87LSQn889911; Mon, 8 Dec 2025 08:29:29 +0100 Received: from pa4pr04cu001.outbound.protection.outlook.com (mail-francecentralazon11013021.outbound.protection.outlook.com [40.107.162.21]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 4aw0aqapnt-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Mon, 08 Dec 2025 08:29:29 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=r/5g6IoynRzaQcBcb0t4CL/T3OyV9GtkdWSthmV3KP6H6TKp1J0cUmsyqwb8NMfjFgBCXDR2dXuiFvSCVYl+lzNiBMQTKJDYgg+tlCbtpG8oULmch96SGaQZ7AwWnRPYXB3+KQigmjGRKDRidD3byQ1oXDP70VXFqi8ka1SFExDLupJozsG+F/ztON/27RTG/rH7t1cdJVIViqZDec5JtVfcu8dDr51EYQqV+lg1snMv6qoAXOH16Z7fSp8ME9DeAw+kmA8a3PEagLdX7PdCw06JbtGQDfmots6wq/PPcdq6q0Y//AFa9tKjqTFUypsLzyNXYjKxm5dHDyZFytOsRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=T/h+ttQocpyxLUgaIlzx3iwhuSNneCP2ewSMetvTTdo=; b=HaTOaJEH0fB9jpLgmUMHXws4mUXzNtTXh5Lv/pVERK381UeuIHl/qWpn/kXQ02k6FuLhzMYuymNKdwiSfi6DgqNj2amrCzNfJNvnN31EZ2ym4jGfuvXG7tzu9eU0pYINBDbzvitZ1pxjxl3Lcw7tqLjqIfWp64HSfYnIqB3oUXDBOAe2FV7aY7DKmH0y0wnmN4IBgSDw73lHaEwhEQcFj7Fqi1j00S3PRMpTpQ0uB/QoQ3+H1WUd1LshQ6Tj/T4zhDwSunYYOsprwtN2rarjc2mHh4qHoQjxC19rtVkZIzsyQo9TVtD2aSKElF0dJjVMaFAcga7T1MxxfQziDckWmg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=fail (sender ip is 164.130.1.60) smtp.rcpttodomain=st-md-mailman.stormreply.com smtp.mailfrom=foss.st.com; dmarc=fail (p=none sp=none pct=100) action=none header.from=foss.st.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=T/h+ttQocpyxLUgaIlzx3iwhuSNneCP2ewSMetvTTdo=; b=YRkyKqHcHdEP/lbS0/jNA4Zelihgq/AP4KcESlERcbfQ3yaUfn4KXuxqqc485+UhH0w1Uw6AN05x7RqhoFhk8DL17laecNVKQV/GAO8r+GfTiowmSKKjbJq3tInnM2471N+oiwmYgPWDu1Wt6oWsN3VUKxfcZXw/rGlrFLE3GLobyd4qgUT03D/38IOFfIqK/sdwNvRNPoDcNzR1Iw9pfnynFJTHES3s0NR4F/COxOhFHiRcGaINkw5Dvg48aViKK1UU56jhOGKuwd58upfD0VFGAmHxWm/7LbEGBvt9nnzxhTsegMm1r69H/AfraZNC6li1EzAfp81SPEml2HmAyw== Received: from AS4P189CA0003.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:5d7::8) by GV1PR10MB8821.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:150:1d5::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9388.14; Mon, 8 Dec 2025 07:29:26 +0000 Received: from AMS1EPF0000003F.eurprd04.prod.outlook.com (2603:10a6:20b:5d7:cafe::c7) by AS4P189CA0003.outlook.office365.com (2603:10a6:20b:5d7::8) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9388.14 via Frontend Transport; Mon, 8 Dec 2025 07:29:24 +0000 X-MS-Exchange-Authentication-Results: spf=fail (sender IP is 164.130.1.60) smtp.mailfrom=foss.st.com; dkim=none (message not signed) header.d=none;dmarc=fail action=none header.from=foss.st.com; Received-SPF: Fail (protection.outlook.com: domain of foss.st.com does not designate 164.130.1.60 as permitted sender) receiver=protection.outlook.com; client-ip=164.130.1.60; helo=smtpO365.st.com; Received: from smtpO365.st.com (164.130.1.60) by AMS1EPF0000003F.mail.protection.outlook.com (10.167.16.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9412.4 via Frontend Transport; Mon, 8 Dec 2025 07:29:26 +0000 Received: from STKDAG1NODE1.st.com (10.75.128.132) by smtpO365.st.com (10.250.44.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Mon, 8 Dec 2025 08:30:05 +0100 Received: from localhost (10.48.87.93) by STKDAG1NODE1.st.com (10.75.128.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Mon, 8 Dec 2025 08:29:25 +0100 From: Patrice Chotard Date: Mon, 8 Dec 2025 08:29:14 +0100 Subject: [PATCH v2 7/8] spi: stm32-qspi: Remove CR_TCIE and CR_TEIE irq usage Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20251208-upstream_qspi_ospi_updates-v2-7-62526c9467dc@foss.st.com> References: <20251208-upstream_qspi_ospi_updates-v2-0-62526c9467dc@foss.st.com> In-Reply-To: <20251208-upstream_qspi_ospi_updates-v2-0-62526c9467dc@foss.st.com> To: Mark Brown , Maxime Coquelin , Alexandre Torgue CC: , , , , Patrice Chotard X-Mailer: b4 0.14.3 X-ClientProxiedBy: ENXCAS1NODE2.st.com (10.75.128.138) To STKDAG1NODE1.st.com (10.75.128.132) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AMS1EPF0000003F:EE_|GV1PR10MB8821:EE_ X-MS-Office365-Filtering-Correlation-Id: 1f647643-2cf9-47c1-4879-08de362b8442 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|82310400026|36860700013; X-Microsoft-Antispam-Message-Info: =?utf-8?B?SmcvNXh0ZC9zUk5Ob21NTDBUK1djV25RUS9YSzBOcXRsOUZNMUdlYlVsVHNV?= =?utf-8?B?QzJKQVRncXR0UzBDMEM3TW1sODZmRFJzdHFhbVFiYkhmemxlT2xjNkV0L0Vo?= =?utf-8?B?SU93aGYyZzgxWXNjQ2tQOXZFWXFKbmlCdG5yL3ZZNG5vQ2Iwc0lxWXJRdzQ5?= =?utf-8?B?ZHdoUE52SytFS09IZ3VCbnprWjM2RG1JNHU0eDZ5UVdwK0tnMWNjVkRjZlJC?= =?utf-8?B?ZmdjVHRadVBuRFlpOWZScGxlZ1pyOUtHUnBpR1JwSzFiNEtsLzFtWElDRG1n?= =?utf-8?B?TDEvTjJ4SHdzcXdVc0xWTWdyS1grUSt4NFJPWHhkQkdIS3JGVFEzOE1nS01y?= =?utf-8?B?NzR0VTFqT3ZFOFliZXVHZTBIOThYY2F3OGt1MnRTUWFvVlFuU0xDd0xtSkJ5?= =?utf-8?B?REFydktsMzY4UjZzdEw0UzNYQ3hBaU1FSEcvQlI5SUsrL3I2ckRyRnpldDVT?= =?utf-8?B?aUM0VE5hTXl4cFlPblVpejFPMmJ3cEVaY0pSN0pJb0FzS1pJeUk0cXdmQjBP?= =?utf-8?B?ZUdhMHdYTExGakFKQzkxeURnbG8wTG5ob2tLWUlUZXFFbEhnQlFKZ2EwbDhW?= =?utf-8?B?cVFyWFZtNFA5RUlSVXFiOUtyNkxCaEF1WkdtdDhVQ2hCc2M0Vjc5bE53cGJk?= =?utf-8?B?Um9tKzY1NC9tMnIvOTJ3dWJ2aUszcUs4eHEyWWdwR1FIVFZYSitveEJpVDJl?= =?utf-8?B?UDAvYWZwb1dNVUN6U0RYSU1vcmlreWNaNHRRSkFwUTBNcDVqdVVtTDNkRnp1?= =?utf-8?B?bVMrSGpYckN0UEwzSWZkNk1leWpPUzhFakxYVTJYS0dUeWYwL0VGdTNtVXhJ?= =?utf-8?B?ZFlYU1JYVFJyMDB0ekI4UHQxTnpGby90Y2tzeWl6dlVvNmhXUlNWbjFpN3ZF?= =?utf-8?B?eWhvRnA4aUJRVnA2Zmd0aDJTQUdCREdSc1VFOUpCYTlqNzVtcFNad05GNkRS?= =?utf-8?B?RTJ6aGNuMmtDSnQ4anIrYU5YcDJNT3hTeDJsajFRdmFoS2lOTnEwMER6R0l1?= =?utf-8?B?c3F0VGtOODU3NHkyYlBadHVOM3NYL2pvQStGdWdIbHJkZGJWZnM2OUVKVFdN?= =?utf-8?B?REpvaXRjdWtzWWpPL1YrN0Jhc2hXSFRiUkViRTdFNW5FS0RmWFhOL0FpYmpJ?= =?utf-8?B?N1Bwcy9GdXBFbjZNaStKaEhOLzhxWmlkRXhTZ1cxUitrcnZ0V3dHREU3ZFkw?= =?utf-8?B?cGdadkZXa1Z3bXR3TXUzTHA5ZVA1UWRIR2hrRWNZYUt0Z2NwOUtnQlB3cysv?= =?utf-8?B?b3ZVaUZwS2wrbytuNXNuT0FqT1gwdkw5Y2FMcTVoOThjQVJzZjNLTWRQSmlt?= =?utf-8?B?b0dYSEdCV29oRmVrZzhSeTFTQWtOYWx2c2MvNjEvL3lJRXpPcXRnZm95dndm?= =?utf-8?B?WUV0c2lxTmR0ODlabHl3TWhOaEdPRG5QaGkrK3VoM1NqZ0hEVFoxZk1kRmVS?= =?utf-8?B?RkZEYWRvVERkWnJDN3JJdXF2bWtVbHdzbHROWDFNaEVxVzZrbjVSM1RQUVlI?= =?utf-8?B?eW00Y0VHc2xrNHYweTFDenRtaGo1YkZHa0dvclhVK2k5MGlHcmcxbXBhMHRG?= =?utf-8?B?bUJyQlZYMSttQTFLOUwxNzBxaXpTdE1zaDZLalVCUkhOMWpSVFNTYWlWM1A2?= =?utf-8?B?czdEdE9abCtZYTVkYkFJY1UrbWxKb0hwT2FVQjZ2OFdHS1p6TWRMWWZzOUs4?= =?utf-8?B?M3FobFZCY0pXRk1scEtqUVExQ3ZzTmxjZWlGNHBnZDhxZ01vQXB1aVNGVitD?= =?utf-8?B?Wkl6MjR5K01lLzNLUjZuaHI5blVBd3FyRkVTZVBYZDM3ZnloQ201WUpLeEJE?= =?utf-8?B?S3dySzhTQW9sSk9EbStBSUtFQ3R4LzlzVkllTGxKbW0zZE1XbWZyU01ubnJk?= =?utf-8?B?ZndRaTFmOUF5UHJ0bk0wczRidTJCeEpiamdZNUV2K0NCUzlhRXUvRTFpcmt3?= =?utf-8?B?TWtLU3dnajJxVFVMUUh5Tms1NzVodWVVQ3ZkYjRZTjdBdDRUaHBsdWxXRVRu?= =?utf-8?B?RVBlcFRRMzdMRGk4czJHV2J5bFVyRGN2dSswdGVkRklscGNrVisxTStLT25O?= =?utf-8?B?azY2aUZDYmh1NnhWVkJObUVhY3lQNVpYSWMrVEQxR1p3MGllQ3ZqYklYWndM?= =?utf-8?Q?88lg=3D?= X-Forefront-Antispam-Report: CIP:164.130.1.60;CTRY:IT;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:smtpO365.st.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(376014)(82310400026)(36860700013);DIR:OUT;SFP:1101; X-OriginatorOrg: foss.st.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Dec 2025 07:29:26.2846 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1f647643-2cf9-47c1-4879-08de362b8442 X-MS-Exchange-CrossTenant-Id: 75e027c9-20d5-47d5-b82f-77d7cd041e8f X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=75e027c9-20d5-47d5-b82f-77d7cd041e8f;Ip=[164.130.1.60];Helo=[smtpO365.st.com] X-MS-Exchange-CrossTenant-AuthSource: AMS1EPF0000003F.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR10MB8821 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjA4MDA2MiBTYWx0ZWRfX19odKey+MD1n NHQSdDg8Nb3sczd2HLmo3mhIylivQ/3DpFcqUDbJnSE8sBzKfMGzOQxmEnNa7ivoNQSZ25qfx6G 1V8t60u6ZIdXJcu76GKXZusafrwvc1vKqLeqgettgOen/2GB2ZhElYoo0u4CFiOyey5G+eavB4L 2QJXioO5eZ8pqz1D6rMIYH9zbCMwJHqLmguuBfdnNEvVb3whbS/Rg/siq2k+ou4//3KvhRBTUIa pVZz+j6tr4e14edV5HBYtoqsw4P/jSvW/2XAnMDLIawzCaT3Mv/jztT5lcmXbak/0cmU+rdQDZj bMAcS7roW5Qqn+jQfRB8D5qx3tOSPGrx2qgCO+IzrrsVBe69T92eHRrJlA+sJgBQr0XXz7adIdR U98k9o0oPOcEwVjaS2IMiYiT6Nr5dg== X-Proofpoint-GUID: A4m34GgFhEgpQqGbF1ZA4dNBdZY8Wktb X-Proofpoint-ORIG-GUID: A4m34GgFhEgpQqGbF1ZA4dNBdZY8Wktb X-Authority-Analysis: v=2.4 cv=R/oO2NRX c=1 sm=1 tr=0 ts=69367e59 cx=c_pps a=lY8KjCQ9O7Y0HqcpAT++Bw==:117 a=uCuRqK4WZKO1kjFMGfU4lQ==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=XWp4PHTOCikA:10 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s63m1ICgrNkA:10 a=KrXZwBdWH7kA:10 a=VkNPw1HP01LnGYTKEx00:22 a=8b9GpE9nAAAA:8 a=RFtgH8DZu3AqK6r0WhsA:9 a=QEXdDO2ut3YA:10 a=T3LWEMljR5ZiDmsYVIUa:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-06_02,2025-12-04_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 suspectscore=0 lowpriorityscore=0 spamscore=0 clxscore=1015 impostorscore=0 bulkscore=0 priorityscore=1501 adultscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512080062 Replace CR_TCIE and CR_TEIE irq usage by a read_poll_timeout_atomic() in stm32_qspi_wait_cmd(). It will reduce the time waiting for TCF or TEF flags to optimize throughput. before after average time spent in stm32_qspi_wait_cmd: 2615 ns 712 ns Signed-off-by: Patrice Chotard --- drivers/spi/spi-stm32-qspi.c | 45 +++++++++++++---------------------------= ---- 1 file changed, 13 insertions(+), 32 deletions(-) diff --git a/drivers/spi/spi-stm32-qspi.c b/drivers/spi/spi-stm32-qspi.c index c7f2b435d5ee..d6f6f9d4e5be 100644 --- a/drivers/spi/spi-stm32-qspi.c +++ b/drivers/spi/spi-stm32-qspi.c @@ -31,8 +31,6 @@ #define CR_DFM BIT(6) #define CR_FSEL BIT(7) #define CR_FTHRES_SHIFT 8 -#define CR_TEIE BIT(16) -#define CR_TCIE BIT(17) #define CR_FTIE BIT(18) #define CR_SMIE BIT(19) #define CR_TOIE BIT(20) @@ -86,11 +84,12 @@ #define STM32_QSPI_MAX_MMAP_SZ SZ_256M #define STM32_QSPI_MAX_NORCHIP 2 =20 -#define STM32_FIFO_TIMEOUT_US 30000 -#define STM32_BUSY_TIMEOUT_US 100000 -#define STM32_ABT_TIMEOUT_US 100000 -#define STM32_COMP_TIMEOUT_MS 1000 -#define STM32_AUTOSUSPEND_DELAY -1 +#define STM32_FIFO_TIMEOUT_US 30000 +#define STM32_BUSY_TIMEOUT_US 100000 +#define STM32_ABT_TIMEOUT_US 100000 +#define STM32_WAIT_CMD_TIMEOUT_US 5000 +#define STM32_COMP_TIMEOUT_MS 1000 +#define STM32_AUTOSUSPEND_DELAY -1 =20 struct stm32_qspi_flash { u32 cs; @@ -107,7 +106,6 @@ struct stm32_qspi { struct clk *clk; u32 clk_rate; struct stm32_qspi_flash flash[STM32_QSPI_MAX_NORCHIP]; - struct completion data_completion; struct completion match_completion; u32 fmode; =20 @@ -139,15 +137,6 @@ static irqreturn_t stm32_qspi_irq(int irq, void *dev_i= d) cr &=3D ~CR_SMIE; writel_relaxed(cr, qspi->io_base + QSPI_CR); complete(&qspi->match_completion); - - return IRQ_HANDLED; - } - - if (sr & (SR_TEF | SR_TCF)) { - /* disable irq */ - cr &=3D ~CR_TCIE & ~CR_TEIE; - writel_relaxed(cr, qspi->io_base + QSPI_CR); - complete(&qspi->data_completion); } =20 return IRQ_HANDLED; @@ -330,25 +319,18 @@ static int stm32_qspi_wait_nobusy(struct stm32_qspi *= qspi) =20 static int stm32_qspi_wait_cmd(struct stm32_qspi *qspi) { - u32 cr, sr; + u32 sr; int err =3D 0; =20 - if ((readl_relaxed(qspi->io_base + QSPI_SR) & SR_TCF) || - qspi->fmode =3D=3D CCR_FMODE_APM) + if (qspi->fmode =3D=3D CCR_FMODE_APM) goto out; =20 - reinit_completion(&qspi->data_completion); - cr =3D readl_relaxed(qspi->io_base + QSPI_CR); - writel_relaxed(cr | CR_TCIE | CR_TEIE, qspi->io_base + QSPI_CR); + err =3D readl_relaxed_poll_timeout_atomic(qspi->io_base + QSPI_SR, sr, + (sr & (SR_TEF | SR_TCF)), 1, + STM32_WAIT_CMD_TIMEOUT_US); =20 - if (!wait_for_completion_timeout(&qspi->data_completion, - msecs_to_jiffies(STM32_COMP_TIMEOUT_MS))) { - err =3D -ETIMEDOUT; - } else { - sr =3D readl_relaxed(qspi->io_base + QSPI_SR); - if (sr & SR_TEF) - err =3D -EIO; - } + if (sr & SR_TEF) + err =3D -EIO; =20 out: /* clear flags */ @@ -835,7 +817,6 @@ static int stm32_qspi_probe(struct platform_device *pde= v) return ret; } =20 - init_completion(&qspi->data_completion); init_completion(&qspi->match_completion); =20 qspi->clk =3D devm_clk_get(dev, NULL); --=20 2.43.0 From nobody Fri Dec 19 11:49:32 2025 Received: from mx08-00178001.pphosted.com (mx08-00178001.pphosted.com [91.207.212.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5932623EA86; Mon, 8 Dec 2025 07:29:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=91.207.212.93 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765178999; cv=fail; b=aktrRccax7DN+uBSqhkrSxROFuX4K5V5zqCIVIpos0Pbbaqe87qnt+3KD/ISt87fsdT1L+2eQRWi/DgE0nuUp7sdGkmlu/WV7jF9/78gV3LdiP3I6QSV99TuY378fqfjnLkAKx9mt3a7mmbg/KQOlCRM/5VqoN/P+WIdhHFLOuM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765178999; c=relaxed/simple; bh=pWArF7Rl6DABaLrLmNIRTns3uzgvldlqMLrrGoV5CbA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=PTg45F4DMRo8cVHwX2Gf6VRGywx8+R8vDB0YO71ZAyUVEkenxzMXq5dp0d/601SWqNMx763HNrbcll8hWHsXRbnTLMsfUsg4uXWmAsHapVdFA4Fzqd3j75BxtUc+Fv0DUpwqGNqPtT+uDd4XHFHdF6DKQ1VIg9U9hu5PYBF0cLM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com; spf=pass smtp.mailfrom=foss.st.com; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b=C0YvCSk6; arc=fail smtp.client-ip=91.207.212.93 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=foss.st.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b="C0YvCSk6" Received: from pps.filterd (m0369457.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5B86pvmn833981; Mon, 8 Dec 2025 08:29:31 +0100 Received: from as8pr04cu009.outbound.protection.outlook.com (mail-westeuropeazon11011050.outbound.protection.outlook.com [52.101.70.50]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 4aw0aqapp1-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Mon, 08 Dec 2025 08:29:31 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=EuB57MyjnVgIqI73Y9O5ipSu6JmYJBKfaGHV1uSKdONCGsEif2maFYowcd7wfGm00K8i6Jmti5uyeEPr0FTMlkiUNCsaewCLBzsoLSt6wLhPP4fStw6QUmjZZaGLIszgI7GA+PkETtpoB7AKw2ZOx3Mbu6gA1+sH4nSESNsLWbLLFOTDmvzUVx5PJT+BylNLEfdC0BmAIacRb7IcuYmpJYfWPkFEMNRkHv8ON8MtJCB0DNGV7kJmpf4NzVDwq+isVPmRJwMQEcfVsT5WHnNK9m6vdOpyWn8K9wacRLfR5rsl0vTud2U5Jkg/nQPbjDDAa3V9IR3iOyT8akBESESZOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=u35wuCE7vol6K/ekR+LGiXYA9EvNk8QvRyP5wyyfImM=; b=jyOilSWFJM/Gd8e9dSWG+vdW/vbDZ7AzJTz5bS+ozn+w75uiYvcoF2QDrzpoTTp700TtI4nSJUHq+MTzyRs5lCe83u9mlP/HdsIpxnludKVcgP/NI9UEGgPfRBInhS9AmLENcHh2QzucHs3dQA9qYvcEiqqHRKNdMwI/627MauVibCF4sDkqaNYqeVjLUg64JoVJ6ISUVWWk21hJTudMiIPjc3vVZMhBNayfSY2tqQgRbZHhpky703Qc3CsN2m62DNF3QoeRVuc6KwOmibt58hRLZJdPNTQGgO8Tsj9qTH0S7RW/MRqgaloDXo0eoGrTMfhlLzIv/e2bsMGvfmezfg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=fail (sender ip is 164.130.1.59) smtp.rcpttodomain=st-md-mailman.stormreply.com smtp.mailfrom=foss.st.com; dmarc=fail (p=none sp=none pct=100) action=none header.from=foss.st.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u35wuCE7vol6K/ekR+LGiXYA9EvNk8QvRyP5wyyfImM=; b=C0YvCSk6zkHj40MgLiCDm56C8ux5CI1AeNMMCIkWDn12RGPjC1HttRVf7qGJ3jm0r2TdwaCw/07WoY5jZm7CbpVAVA8cUhH5Q4jbtbMqv0Evj9DvCWMCMQHBFS97iBRZLmC/yu77iwWk2INf2NIdwsQO8LaDKsJLPD7HW1t7SEy9Ro1ixVRRJ4XHrW6nETBVR/U2k0WQK4Ys1YfW/ZIuEJoBgh6gyCcVGBJ789OW0y5ApvQbmtq5A0dgzMGRiHyII4sJ/NQ+GN+635HFiA2sNV+hIJEpqcLcJb6hrI9GTc9AX9Ei0jqsiisLPTHWewCU1DKDu3bqouAqWauGTIYYNA== Received: from CWLP265CA0291.GBRP265.PROD.OUTLOOK.COM (2603:10a6:401:5d::15) by GV2PR10MB6959.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:150:d6::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9388.14; Mon, 8 Dec 2025 07:29:26 +0000 Received: from AM3PEPF0000A795.eurprd04.prod.outlook.com (2603:10a6:401:5d:cafe::b6) by CWLP265CA0291.outlook.office365.com (2603:10a6:401:5d::15) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9388.14 via Frontend Transport; Mon, 8 Dec 2025 07:29:24 +0000 X-MS-Exchange-Authentication-Results: spf=fail (sender IP is 164.130.1.59) smtp.mailfrom=foss.st.com; dkim=none (message not signed) header.d=none;dmarc=fail action=none header.from=foss.st.com; Received-SPF: Fail (protection.outlook.com: domain of foss.st.com does not designate 164.130.1.59 as permitted sender) receiver=protection.outlook.com; client-ip=164.130.1.59; helo=smtpO365.st.com; Received: from smtpO365.st.com (164.130.1.59) by AM3PEPF0000A795.mail.protection.outlook.com (10.167.16.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9412.4 via Frontend Transport; Mon, 8 Dec 2025 07:29:26 +0000 Received: from STKDAG1NODE1.st.com (10.75.128.132) by smtpo365.st.com (10.250.44.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Mon, 8 Dec 2025 08:30:08 +0100 Received: from localhost (10.48.87.93) by STKDAG1NODE1.st.com (10.75.128.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Mon, 8 Dec 2025 08:29:25 +0100 From: Patrice Chotard Date: Mon, 8 Dec 2025 08:29:15 +0100 Subject: [PATCH v2 8/8] spi: stm32-qspi: Simplify SMIE interrupt test Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20251208-upstream_qspi_ospi_updates-v2-8-62526c9467dc@foss.st.com> References: <20251208-upstream_qspi_ospi_updates-v2-0-62526c9467dc@foss.st.com> In-Reply-To: <20251208-upstream_qspi_ospi_updates-v2-0-62526c9467dc@foss.st.com> To: Mark Brown , Maxime Coquelin , Alexandre Torgue CC: , , , , Patrice Chotard X-Mailer: b4 0.14.3 X-ClientProxiedBy: ENXCAS1NODE2.st.com (10.75.128.138) To STKDAG1NODE1.st.com (10.75.128.132) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM3PEPF0000A795:EE_|GV2PR10MB6959:EE_ X-MS-Office365-Filtering-Correlation-Id: 4d5c5541-ff6e-462f-9177-08de362b845c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|82310400026|36860700013|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?T3VmWWVLem9tUThnRHo4NWtiRzJTZ2tRZmY0RzdURHZIdkNCdjNoT3RBcENz?= =?utf-8?B?TGRpL0NoRFlLYk8wWmRrYk5xQW8xbFB1cDdoMzVHUnZ1aGFqNmJYOENjTHdG?= =?utf-8?B?Zm11NHBDZmNwUFJMZHlxVzl2ZkJSR0VhdTJCU2F0SDl1WllwalQrZDBYbTRU?= =?utf-8?B?aEIwM2Q4Zm1qdUt2dVdTOG1nTHF4UnFwN1N2OHdrSk5ScnM4WUlTeFY1ekxY?= =?utf-8?B?VFgwY2JqcTNQZXhDdW03SFJuUzYyZjAybTdISEFSZ2tDbFdzRXVuM3dmMk11?= =?utf-8?B?Mm8wOC9jQkJoY0VtRkFJTTV6RnIvSUdUem9vVDFFcFhCZUo5Z1hBLyt2TVFn?= =?utf-8?B?cUFSSDNmb3I5RXptUTUreGVpTS9wUVF0Z21ZWUw3d0FpbnNneTFXbDlIdEY1?= =?utf-8?B?ZWIxN3k5NXlXc3VZN2M3dVhWUkZjT3V0eHJwMkFQUGwvYm9lZmRFeWR0ZmNa?= =?utf-8?B?VkljcFBYWXJ3d2ZSdmtZRUN2L1k4UVJxOVlQYktWVUFyemFJN040b1JMQU5v?= =?utf-8?B?NkpGblBiUDNsa2Qxa0R3N2JQWW5PSlViMUlFSGpIc1c4QSt5aHBybUtIcnp6?= =?utf-8?B?bHpoYjRJdHl5dUNObk5DTkVWN0ZKNkhjQUt5RnlpOTZGUmZQMDhSQWNPbnNB?= =?utf-8?B?THhZZkRsSlloR1pDQkdxN05KRzQvQjMwQkx6UTNxdWUyYVVkcjV1VUtQNy9l?= =?utf-8?B?SGxWYXJZOUROU0xlb2s0c2YwWmQrOE02QTluVW9yQmgxTUVNRXpWVjRadGU4?= =?utf-8?B?QlJDcUlWM1dURktDODliKzJrcm1vNWpaWnNVMndJN0NVMzdSUmVIekZibnZD?= =?utf-8?B?bkZBcDBxWWlpOWJWa2JqYzNpN1Z5aFRVeDZiWU1URndROXJSSGlId0NYME41?= =?utf-8?B?WjZhNjFzK3lMTENhTEswSmMxQU43SWZJTHVKTmlkT0JJUW9jQlJBZUx4SDZN?= =?utf-8?B?NVpkQnRraW0rZDRabHlOM0U4cUNlelF4Wk91M0NUOTMyZ01OT082OElXZVBs?= =?utf-8?B?VUdWSURiNDQxY0dPUzRZRnhNSzhUR3RqY0RES2QwVU8wNllpb0ZMK3EvZExU?= =?utf-8?B?M0RseklIOGtWQ1EzQVIwKzhNdm5XbVRRakNrTVYxUVd6a21DcC9tQUU4M00w?= =?utf-8?B?RUt4VHFoNzBTaG83MFRjT2FBLytGNlNnN1hyVkdtak44MllkdVpjZTZwWCt3?= =?utf-8?B?V0k1VisyUklIL3NZMlpaeDMzN2NlRmljMFNOMS9FNTlSejB0THhYVndoTzdW?= =?utf-8?B?K0NKeWk4MjFyZ3BxVityZGRQWEQzdTJ1SS9Nbm1mWHV1UGE5TzdXTy9KOHBK?= =?utf-8?B?N2RLc0x0dWVVUHQ1dmtod1V6eC9sMVVRWGs3TGgwdG92SjJFcTZJczNaZmky?= =?utf-8?B?RFNIdnozalNzWjJ3T3VCNFJtcDRaQVp1SktNTHJTV2lXNUxLYmZBdEVuUXUv?= =?utf-8?B?dUdpRzEzQ0QxY2w1UUROOXRoOU94bERYd2F4TWx4VFRuSnNNRnc0bXVNSktv?= =?utf-8?B?bEdFbVFKUVpvZ3Jkd0hualB5MllaYXFrbnBvZE5Nd3FOak13Q1RBeHZYQXVr?= =?utf-8?B?ZDREVnN2Rmc4RUExVU4wQ0Zmc0l1Skxva04wWU9FYXozcUtSb1dMbjdrc2ha?= =?utf-8?B?Rlp0anBpRjZyQ05aamJyY3VUYmRVKy81NzVGN0pvbm9LN0VGYW9LaXVlcVJw?= =?utf-8?B?SjRqRm1PV3NWRFBhclQ2dFZ3Qmx2dHBSMU1IZHN0SDQrRVc3ZnlwTUZySWND?= =?utf-8?B?Z3ZyMGh4UEt6TzQvVHh0SlRSRzZxS0xpRzhkbjBIWjUrSTY2Skt6eHJibllG?= =?utf-8?B?aDVmWVlVN0VhZ2czaTFlcFl1cEg4VmFuMzBQNkpUcGRsNHZ6SkRtYStkM3lS?= =?utf-8?B?KzJIUjREL1lUbnNiS3BYS1Q5THBKK0dtdXZQblVrUzM1ZE1SWStuT2Y4Nkt6?= =?utf-8?B?bzF5Y0VJT1NRRkxuTDJNaGRocHh5eDhKVU9ROXU2dWdKYjlvc2phb3ArVkFP?= =?utf-8?B?ZzJlUi9EcloxVGlTTHMyMEJIT09oVEdNOElodzN5Rzh5ditjNERub0RxR0Vh?= =?utf-8?B?cEJDNTZmaTRXRXc4VVNmN1lCbEdXSUlnZkxMUXBEdEFOYUdyZjF4cXNyN01T?= =?utf-8?Q?l5Qg=3D?= X-Forefront-Antispam-Report: CIP:164.130.1.59;CTRY:IT;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:smtpO365.st.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(82310400026)(36860700013)(376014);DIR:OUT;SFP:1101; X-OriginatorOrg: foss.st.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Dec 2025 07:29:26.4470 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4d5c5541-ff6e-462f-9177-08de362b845c X-MS-Exchange-CrossTenant-Id: 75e027c9-20d5-47d5-b82f-77d7cd041e8f X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=75e027c9-20d5-47d5-b82f-77d7cd041e8f;Ip=[164.130.1.59];Helo=[smtpO365.st.com] X-MS-Exchange-CrossTenant-AuthSource: AM3PEPF0000A795.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR10MB6959 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjA4MDA2MiBTYWx0ZWRfX/rcZY1J7M0gD CtDeZf6n66IMUiEjECgpq3iVZaQuUctRMR9naJwq/vjp+nNaFvxhg0l3ZXXnr3X5Xz/cxoY8rRl JZM74Xmweu6N8iUxx3W9GIO8eUy0F2RizOgZe5Q1qZXfxPFYNmsKIVBTO/gH625+Jshm+FuzVt0 vtDhm2kDkhDv4u8/teXoV9VPLRDmkNJrJGJo8doMglV1ZfsieqMZBTq2KPoPWxCq96ta+u3pw/c isHZW5pO4wC7bVChYDcYyWQacpHCxa2qNEJQH3b52MPbVpfrMgQLJbrKlIyTXSPT9h8eXdQmzUv JcBaCsY6l3l27wx7tyatddTRDZ/+RRj0rLvZ0cBxA1xXEC/gCBZW9je9sgVSQ/0hxUS2ImFmHKA Z66vD8ZsM9wyzFHn7K8gr3Jv3fpDzw== X-Proofpoint-GUID: xccogfr95m2zof4mOxUhvowkX-LUq2Dn X-Proofpoint-ORIG-GUID: xccogfr95m2zof4mOxUhvowkX-LUq2Dn X-Authority-Analysis: v=2.4 cv=R/oO2NRX c=1 sm=1 tr=0 ts=69367e5b cx=c_pps a=KHLnCchuSInU2gMlOa4qhA==:117 a=d6reE3nDawwanmLcZTMRXA==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=XWp4PHTOCikA:10 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s63m1ICgrNkA:10 a=KrXZwBdWH7kA:10 a=VkNPw1HP01LnGYTKEx00:22 a=8b9GpE9nAAAA:8 a=F6HTmrlUwN8psNLP8S8A:9 a=QEXdDO2ut3YA:10 a=T3LWEMljR5ZiDmsYVIUa:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-06_02,2025-12-04_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 suspectscore=0 lowpriorityscore=0 spamscore=0 clxscore=1015 impostorscore=0 bulkscore=0 priorityscore=1501 adultscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512080062 SR_SMF status bit can only be set if CR_SMIE was previously set, keep status bit check only. Signed-off-by: Patrice Chotard --- drivers/spi/spi-stm32-qspi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-stm32-qspi.c b/drivers/spi/spi-stm32-qspi.c index d6f6f9d4e5be..2a0ee96786fa 100644 --- a/drivers/spi/spi-stm32-qspi.c +++ b/drivers/spi/spi-stm32-qspi.c @@ -132,7 +132,7 @@ static irqreturn_t stm32_qspi_irq(int irq, void *dev_id) cr =3D readl_relaxed(qspi->io_base + QSPI_CR); sr =3D readl_relaxed(qspi->io_base + QSPI_SR); =20 - if (cr & CR_SMIE && sr & SR_SMF) { + if (sr & SR_SMF) { /* disable irq */ cr &=3D ~CR_SMIE; writel_relaxed(cr, qspi->io_base + QSPI_CR); --=20 2.43.0