From nobody Fri Dec 19 11:45:27 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A4F92F39BD for ; Mon, 8 Dec 2025 03:33:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765164830; cv=none; b=CgXB7XYrkBkCwMxwzq7lD2ufqMvAbG7pS7UkID1Vw7G62nu634xdmjg36apB9vitBYtmkK7Kqq0LIGExdCFYeEEZlpJNWOsEMeIk1nkTbq9Qk2ImihCwkrnh71Y6gVGHWmdifl0bO3cIJRuy2wCuB8F7vfYlYv1busGTrh+jPM8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765164830; c=relaxed/simple; bh=nrpyGRDbRTzil87p0IDZgBpYmVtwM1uvVSenw0xPFpo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=nfiXJV0tMPTn4RKQeZ9+Ycl3zAJHG2gD2nneirCUGqFSnRkBG6uvzDlpxRlDcp1iXvtuRxMVTXaSl9n6IoyURiZ59LgMmsenhPItK+uHtkGgH+pnRrxyfQzuywuTY+22p9aP3QKlwXQ2dKOV0qvn6blQ8wapI/0ABujnlgm0zII= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=SBMqLymv; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Y3zmyEfx; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="SBMqLymv"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Y3zmyEfx" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5B7LH5uO2737849 for ; Mon, 8 Dec 2025 03:33:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=vECANsRZAsv0+/HcW0Znhs Pk5JYhO1vf6Ev66v/SoT4=; b=SBMqLymvhsOYKX/Dp6GsGz/NNwmw9k6WlkTFah HJXtBL/gnW9hL2fZoAfiCxlg/ulRKdCNBfr5XPOU10HEXrPsR9Uncb/gNEhCmiXq cKllVQtfPYa9MfGH8s8ddbjWVMuZiMXx13cNA5uB43FNTd20qBmGnd6rKYvZYb2w LShJ/3EeZ2R4d5QdK0Slt1IBS/WIFH4zBbW0DwoJQOWrrzI0QZsJFokROsqeBXiW PThTvw45OHl7His0F4lwGG6UfnfSiWBd66Jz4HzAds9K1BsLP+b0TC7Sg/MsYvWc QR7ZpKtRhyUv9aK8+cQHDFxalDNSHoD3FWhERgECATHJqwyg== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4awhaqrgbr-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 08 Dec 2025 03:33:48 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-7b8b79cbd76so2464042b3a.1 for ; Sun, 07 Dec 2025 19:33:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1765164828; x=1765769628; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=vECANsRZAsv0+/HcW0ZnhsPk5JYhO1vf6Ev66v/SoT4=; b=Y3zmyEfxaKjqABqBmJROCituejoGW5BAhMop/eZHxkHwP6BAIInYDRWyw9xoHVSnQ1 Vi/GfGTDAzbU7fXxf/UWbJG7EiqpPg3lRaftv/1eytmCFr+pjgPigeCCH3VYkYkv/V2R igJG3pzBtJYPtYA61SymYzSM6KFkU0EFNK+NucdYwI9OmzfBizws9W910K8aivjXB4ru O6U8YXS6KB/T8mJ774+RjoOR5ZpJ+XgqYLoONohIYzKyJ3FbYzCYuP28BABWrhNsSetu xm+W2/C2vWA85Cg7tK0FOSYkRVjncyzcY1MSseXRc7OptNAohAWEZFew5ksJxBsD4O4T 8/QQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765164828; x=1765769628; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=vECANsRZAsv0+/HcW0ZnhsPk5JYhO1vf6Ev66v/SoT4=; b=FkokTs8kcRfA7pBWLf+nTng1GPyKfv/ZLF143KGRKL4vxVO8j3c/nSqAc5qGhKdjUm AEMFYnW4JrexmyjADg2iHJHVI+qFTOtHxoaY0tSbLNLWwhNcPIh+daOmKqQNBs0F/v+J Xq/l2ErJxZCOejUCzBWl3DlyZDksSRMC/gxL6KeuV761yafTqnrB2MT+UHS+XoqyjNKR 3uTruhsBhzbf/U01wh9p9yKNf4oyjCGLDH6LuIeCrLnNV02XOZqFKsUex29O3WOlY43D Fpra/WKlOOmwlwH0/Yh6JfajBp7Nbqz3f+Joqa6GmmTGnDYDSy8+WkYFyvH69g4c/9Gs hQ1A== X-Forwarded-Encrypted: i=1; AJvYcCUvDjPQHpSgT6yoVPOONzBnfeX7+h5MNa6g8dBEJ47Fdki6hbCdyeXHNv1gYv+OHjp9DU89zZ8RJe4yaqE=@vger.kernel.org X-Gm-Message-State: AOJu0YzIfI4dlZPUw5fqwoTpA+pY8cQ/GnANtoI6WkKScugBw8BU3azc ANwe8qbFCWb2eT2CL3WWEoLTH4OdbQBGm9aHbxmF1S/aZnOv18clNkgEV+WLITrWsLXQVzipinX RD7fEPjaxmDJR7lPEPaX0mjHzLEkTX6Z+TJE6bVTGQUwjBrkclZuXuqG/b9Z8NMB3Dqc= X-Gm-Gg: ASbGncvMOJAL/Tn9rF4NcSH1xA2E88PhXIVLspELE/QsdEzyjCJnF8mSLiNEFenYjcd kXV0I5LV1quiAgqZO8a+rsipSmwmSPFNVTLJZnEzEhRWYae9t+gWewuQIz1Wpc2GczbkBKpGpcI ll+HQC3bJHP8IovoL9b33RX7axlCF3zjr5+XxoW+oG8DWpDz6X/vofW/vn+yv4Jeyi+2JyWWyer XmGnIT0k6Uc8IAmn4UlTGXOc1usnrqw6UvQrAwcKA/u9JhN3ACsc/dNlePsDvedpascR2sgJQ+Q C18jHgxOAnWXj8ArjZPt+9EU0s0hNp9qQzMyhYT4gcJwDZj7YtavWzP1P13KqLHCzQczpmLIrDg kPn9n61LwR1yFadJRi/vdmVnMrAbh9Xg9+KgRS1nDKfpCum73D62WbAJ+ODg3YD4+pXto/Imiwl BfEIUwTpA= X-Received: by 2002:a05:6a20:72a6:b0:35d:b415:7122 with SMTP id adf61e73a8af0-36617f04261mr5397836637.26.1765164827913; Sun, 07 Dec 2025 19:33:47 -0800 (PST) X-Google-Smtp-Source: AGHT+IGOSp1CHXkk5vR8ZWGY1ypXn5YdHgRhkrIoj/QqBPGpdX2bidaEXrhd+8hg2OkcoU241CbTBw== X-Received: by 2002:a05:6a20:72a6:b0:35d:b415:7122 with SMTP id adf61e73a8af0-36617f04261mr5397816637.26.1765164827390; Sun, 07 Dec 2025 19:33:47 -0800 (PST) Received: from hu-renjiang-sha.qualcomm.com (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-bf6a36bbc60sm10545177a12.36.2025.12.07.19.33.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Dec 2025 19:33:47 -0800 (PST) From: Renjiang Han Date: Mon, 08 Dec 2025 09:03:42 +0530 Subject: [PATCH v2] media: venus: vdec: fix error state assignment for zero bytesused Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251208-fix-error-state-v2-1-255b62ee2eb6@oss.qualcomm.com> X-B4-Tracking: v=1; b=H4sIABVHNmkC/3WOQY7CMAxFr1J5TVCdpElhxT1GLJzGGSIBgSRUg 1DvTijr2Vj61vfze0HhHLnAvntB5jmWmK4tyE0H04muvyyibxlkLwdEaUSIf4JzTlmUSpWF1Dg qGgc1Th7a1S1zq6zEn+M3Z74/Grh+l+CosJjS5RLrvjNG+d4jBRWIAxurJnJBO+N6a1HvaLTkL Qb4sE6x1JSfq+yMK+xfrxkFCqXDTjc7h2Y4pFK29wedP6+3bcBxWZY3qVg0YAEBAAA= X-Change-ID: 20251126-fix-error-state-24183a8538cd To: Vikash Garodia , Dikshita Agarwal , Bryan O'Donoghue , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Renjiang Han X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1765164825; l=2033; i=renjiang.han@oss.qualcomm.com; s=20241001; h=from:subject:message-id; bh=nrpyGRDbRTzil87p0IDZgBpYmVtwM1uvVSenw0xPFpo=; b=IC8/VmvIE54k3bj645ATMZB3udCmokzu9hbG1W9b+tMkOGNvuINt92VLFFIqcI2LLFrbbLeMA V6Mt4cFi6NKB/m0ONAlpao34nsHn/8uar3tKZ0W1csimWAj437RUMxp X-Developer-Key: i=renjiang.han@oss.qualcomm.com; a=ed25519; pk=8N59kMJUiVH++5QxJzTyHB/wh/kG5LxQ44j9zhUvZmw= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjA4MDAyOCBTYWx0ZWRfX3n0YiQXgk5BA RrMJxdGjRjREWH3D5QSfN/Z/+aJq15Oio18PmDzxDGe5icprfFqI0X3Z2rkckIrW733QLso9L1V HVNdxAxe2pOUHrDqFqqpb/CtmbUZG+Qgqjr8CRim/BShpV5QJLt8ZcZN5cZcABu09EQD6VDGl3H R69C49aO0Si3dN6xPfi3gO5ddso3/B1v1udV7oIfuWt7BdmJCNg8QMjeVbDmUom3DS34+UD3WTG 5k/kSaT3XREleKt9t+FVZusXoTh3/YQhkZ0mXUE0sl5GTFS+AYvQPcRKN/6+IzKWzmbsL2PxBPU krnzyXDpODjVlcRDY0mj25MYBZUx9HyO34aQEoknkjCRRqpFVc9+s6mtZ0s1rxsut3fg6BMtxmd 49eVK2gxZGKNWg0IwhQZc3tpcxTc9w== X-Proofpoint-GUID: l8aIuVJCY5mgFWbe_Xv8NepmUeixwico X-Authority-Analysis: v=2.4 cv=ItUTsb/g c=1 sm=1 tr=0 ts=6936471c cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=2SL7H1QK8vwNC9hrVHQA:9 a=QEXdDO2ut3YA:10 a=OpyuDcXvxspvyRM73sMx:22 X-Proofpoint-ORIG-GUID: l8aIuVJCY5mgFWbe_Xv8NepmUeixwico X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-06_02,2025-12-04_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 impostorscore=0 bulkscore=0 malwarescore=0 spamscore=0 clxscore=1015 priorityscore=1501 adultscore=0 suspectscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512080028 When hfi_session_flush is issued, all queued buffers are returned to the V4L2 driver. Some of these buffers are not processed and have bytesused =3D 0. Currently, the driver marks such buffers as error even during drain operations, which can incorrectly flag EOS buffers. This patch moves the zero-bytesused check inside the non-EOS branch so that only capture buffers with zero payload (and not EOS) are marked with VB2_BUF_STATE_ERROR. Fixes: 51df3c81ba10b ("media: venus: vdec: Mark flushed buffers with error = state") Signed-off-by: Renjiang Han --- This patch refines the error state assignment logic in the Venus vdec driver for Qualcomm platforms. Specifically, it ensures that the buffer state is only set to VB2_BUF_STATE_ERROR for non-EOS capture buffers with zero bytesused, preventing false error reporting during drain operations. --- Changes in v2: - 1. Update commit message. - 2. Add a Fixes tag. - Link to v1: https://lore.kernel.org/r/20251126-fix-error-state-v1-1-34f94= 3a8b165@oss.qualcomm.com --- drivers/media/platform/qcom/venus/vdec.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/platform/qcom/venus/vdec.c b/drivers/media/platf= orm/qcom/venus/vdec.c index 4a6641fdffcf79705893be58c7ec5cf485e2fab9..d0bd2d86a31f9a18cb68b08ba66= affdf8fc5092d 100644 --- a/drivers/media/platform/qcom/venus/vdec.c +++ b/drivers/media/platform/qcom/venus/vdec.c @@ -1440,10 +1440,10 @@ static void vdec_buf_done(struct venus_inst *inst, = unsigned int buf_type, inst->drain_active =3D false; inst->codec_state =3D VENUS_DEC_STATE_STOPPED; } + } else { + if (!bytesused) + state =3D VB2_BUF_STATE_ERROR; } - - if (!bytesused) - state =3D VB2_BUF_STATE_ERROR; } else { vbuf->sequence =3D inst->sequence_out++; } --- base-commit: 663d0d1af3faefe673cabf4b6b077149a87ad71f change-id: 20251126-fix-error-state-24183a8538cd Best regards, --=20 Renjiang Han