From nobody Fri Dec 19 11:45:28 2025 Received: from mail-pf1-f201.google.com (mail-pf1-f201.google.com [209.85.210.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0514F4C81 for ; Mon, 8 Dec 2025 05:19:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765171194; cv=none; b=W9gZphSFmgw7jGDwOJOXaRVsbuNNxF8SvtSCN+vZGu2s2Z4EHl5nFxl/Sc8Ax01ZgUKiSPMU7CxoZpN6ckrgoe89CLbWDsnhZzVpaQBYgyzQc9wGinD9CinS2e3gvbkXHSt8/NbYCoQsODRnqFgFzLFm5Jk960XU6YGTHi/iMnc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765171194; c=relaxed/simple; bh=8+wF4Mb/g4BYLfo5XNMyGJvUQENR2b1y4hX4tUKj/A8=; h=Date:Mime-Version:Message-ID:Subject:From:To:Cc:Content-Type; b=nmz2kPfHyITcD7h/Su9mLQHVpGcaHGsXk2qCqsXN/s1S+bJzeiB/G7kF78jOwfDzr2rjQ8e1Ez6nHaszhwGdeIAwA5xPooivDcHmDfNRfMhAG1tf+hp8CtdnDu3lcZNDQDMUaXhJgGpvhgMXZ1yW+T2/gartqleFYn6idwKLJrI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=izrnsU3I; arc=none smtp.client-ip=209.85.210.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="izrnsU3I" Received: by mail-pf1-f201.google.com with SMTP id d2e1a72fcca58-7be94e1a073so7815661b3a.2 for ; Sun, 07 Dec 2025 21:19:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1765171192; x=1765775992; darn=vger.kernel.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=O7UnlqZp5/SsOXN8+FZw5E727rrgqLolPXcKhpWhG6I=; b=izrnsU3IftQp5+qLQwC2aTuM39iAEyFgjBtzlNTLALvq5dk3EVn1RpoleffWTamOWn 5v3CDMKCY0vT27K0qeE3TMYX7qI5Spf5yqpZ7jXfLQDpTbNVrsFiBoJEH8thtZhdQwCp lmGNNVYx2M1ky4yRG868G82MTcyEJNOzKpClVo8eLFbiU7CknqD88kGOPrJs2iW/8Tyh blGEqM9M+gDWHRzwcyeefqoLVkZQXdbedkKGs6+FZrtDJ5y+1ufuTW8y9XruiB/qOG2e TvbANj77rKwkRrKOOxZGR7Wl2XGT15AaH77U/ZTLThBc9EcgVWO6nyLpQBma76bGgjbm BeJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765171192; x=1765775992; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=O7UnlqZp5/SsOXN8+FZw5E727rrgqLolPXcKhpWhG6I=; b=axyzzM2ocO0ifBi/v/2YWI30kN4wTlC2j+zG4hdyB8dXAzrXSFdeMpUfo3k8WMPDfY tBiiELXiXsPncazuK28Z55WULADMyW/2WnpTvDNri4MLqAxuC0xV3xwsMHlP6vAk2kie EZZZFjP/0RVUJLZ+Uq8bg5QEeA5X/C3pm+TcT+2hxVo4t8AVk22T+Gfwv4PyiwZL9eZw EQpbOVO9usuC0H1m5ouKaIpX9Apwx+5yNZefrvXeGciXrXBM55bh/ujDfhJeyoF5YYDq 3xeYB1pVaAWUxvYtWpzlH9klZtJmsImz8K6o8wow3Lke4ZE20EoS5kLQ2Pjz9hw1Sg4E Keng== X-Forwarded-Encrypted: i=1; AJvYcCWzgNLLzX+3b+oFrFwKDc0rlcD67nMceDh7Bz75efBvEcscC4UIy5sH9Qt37zEcbRSuyodjF2lesnuDVAA=@vger.kernel.org X-Gm-Message-State: AOJu0YyR6P6GrNbZpqMsnCXmFa38mUYgDyUFBy5BcXKG6RE9FzYVk6jy h1FpWJpnp4ByH/ltvqcKNpPfI22qJI9UdfwbC0WFE/6DbCdy0JhiBJxT/T+NMeadDUU5UhOlsQW zN+3WvSnvNcnrRg== X-Google-Smtp-Source: AGHT+IGFL2y2uE0l1gR2kksUADBN/WD1xSApgUUsBRkgzcvvHK9GFS9UzGKDu1JX0VVjnQvvR6P2iD/uyZ96xg== X-Received: from pgbfq17.prod.google.com ([2002:a05:6a02:2991:b0:bd9:a349:94b8]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a20:2444:b0:366:14af:9bc2 with SMTP id adf61e73a8af0-366181421b6mr6673453637.76.1765171192210; Sun, 07 Dec 2025 21:19:52 -0800 (PST) Date: Mon, 08 Dec 2025 05:19:49 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-B4-Tracking: v=1; b=H4sIAPRfNmkC/yWMWwqAIBAArxL7naBi9LhKRFhtulAaGhFId0/qb +ZjJkHEQBihKxIEvCiSd1lEWcBstTPIaMkOkstKSN6wSbFr19vmZ7aTsef4c10pXbcCFQoOOT4 CrnR/4354nhdDPVPfaAAAAA== X-Change-Id: 20251208-b4-vmalloc-might_alloc-754a791e4e10 X-Mailer: b4 0.14.2 Message-ID: <20251208-b4-vmalloc-might_alloc-v1-1-94a9bb8ecb08@google.com> Subject: [PATCH] mm/vmalloc: clarify why vmap_range_noflush() might sleep From: Brendan Jackman To: Andrew Morton , Uladzislau Rezki Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Brendan Jackman Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable The only reason vmap_range_noflush() can sleep is because of pagetable allocations. This might_sleep() is accurate, but we have a more precise way to express this particular case, so help readers out by using that. Note that the actual GFP flags used to allocate here are arch-specific. But as long as GFP_PGTABLE_KERNEL includes blockable flags, it should serve as a reasonable common-denominator here. This also ensures there is an fs_reclaim_acquire() even no pagetables are actually allocated, which could potentially do a better job at catching filesystem bugs. Reviewed-by: Anshuman Khandual --- Signed-off-by: Brendan Jackman --- mm/vmalloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/vmalloc.c b/mm/vmalloc.c index a53c7462671bdd896f95712af71398ffbe22fb80..ff1876588b94ec69168324e9339= 9dbd117a6959a 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -305,7 +305,7 @@ static int vmap_range_noflush(unsigned long addr, unsig= ned long end, int err; pgtbl_mod_mask mask =3D 0; =20 - might_sleep(); + might_alloc(GFP_PGTABLE_KERNEL); BUG_ON(addr >=3D end); =20 start =3D addr; --- base-commit: ecc46e02e0abe025a6e840cba2d647f23fd1d721 change-id: 20251208-b4-vmalloc-might_alloc-754a791e4e10 Best regards, --=20 Brendan Jackman