From nobody Fri Dec 19 11:52:29 2025 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 80A621DE4CE for ; Sun, 7 Dec 2025 19:02:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765134146; cv=none; b=hcI8dTgsUjQ2KUUuKLjqOEsduhVPYpCa2Lg/3tS6cRHIwA0xy1v0p0BOQuYiWVNmR60j+LyPPZxJwaV0HqWT2D2rwkFAV/x279ViJfZrXjd14tiyqXiZK+5ZQCEEGO+QFDlw2rItAU4gJRbRhCWaujpYyscxEM0emxeGzyMzWNM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765134146; c=relaxed/simple; bh=lMT2knLw9NGhbbZA5OxXLR5tc4Ea/OwoHRiasKhKQDI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=BUfTx8v3Jv0wIgkq0DPEt+D8HlQWM6CsXxoWetLGfDUHPbvnzhf6zaVta0dWx4PcXha8JtcqSGTETk2RyvsmLvOGOivhYGi4IpCHfbP7w9Zu2r8ujK4BjwLuFOU4xe2YsyM3OdZsuYD+6fJHkuSXs+OSrwwIews7pD8DcC/veu8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TNVc0t5h; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TNVc0t5h" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-298250d7769so30369655ad.0 for ; Sun, 07 Dec 2025 11:02:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765134145; x=1765738945; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=CI7p9gBqBiOF+yyqZEH+5Bci1w311hgD/wpMcij+JiI=; b=TNVc0t5hJyrF8u2Gbv2MDIRyIj1a07OFLT2/a/LJvvLXfgzTpOYrTpHK3oDg9YCZLe W0DyN546Thq9hebpHLwYHhiP7ZlmcM0TmZzbJSZsGBqvajPe3UEr+hyyBIrkX7DTP1S8 dDO27A2HlG1Z9fLGJI0vsAnbr4JivAAGtUkRSGxofyyuDnfV4E03PRqLQDhi00PF87mm LlEr08utgc9fZYjGE3NmSoCj4r64G6jMX81A3lzQRIaDTfUsX+XOK53tYCV8AQoMyeeO aW5NLUt7VHR9+U4UhXIy8J1eLdLi+jqnJ2HlSwNfchEkcDjmeh2iPWQys9DIry2JR7ft /USQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765134145; x=1765738945; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=CI7p9gBqBiOF+yyqZEH+5Bci1w311hgD/wpMcij+JiI=; b=VqPYtb9tJudB+a0xIklHHmqfOfr1pyBkBFr2h7zjc0JINNhicVulF6kTyf3SQrlxER 5gmtXfXNhybnY16JdaNGVSlmlIMv51YJRLjheuoX36OdtIW5tBre20315gSoROpm9jPC J83nnP2iokc6Bn1LTUUYRUbr4EA5yZk7TdM0WGNLpyZvCeAkHmYnb6IDQ4HbBwPx8SAx pHaa5SHZpom3eftKGs1CoQdvaPJmPjnHubdiEuWFLn3dYgy78yzMnajeYWx7y7Nxj4P8 ye+RL+HnmuNhWNfeFqxR4xUnRuc9xJe7NHkWI9rsp7cgyOmTsAl9iFCmuNm/jgQXQ9c2 2kXw== X-Gm-Message-State: AOJu0Yz5DXjw271y8srLSjdTqBiDK2LNrCoS8AB2dYOOjcozcpdjw9IC g1aaAx5e3xyYu5NzgCLSxXToRx1jzq2GV/OPJFuwS39qqBGXys3n5fzf2EaoAXn7 X-Gm-Gg: ASbGncvA72sz3VQ0y7hlsiHgIYPOLLENgsc4RW0ewYL5JTnDPQbluGIo8mmmD1B3Zgf u6E3HjLJ7DDtT208gG51dpP9y2FeemEPs63U+CDIYTXhlc8ISLEVvWjEhxbqjDMd7LUbyFWay0m d52pullF12ifJ4NPsLLij1r787cxigz5aF07/oAhNqEbi9UoEG4APeXrhwfxI+BhbL5Gsmohf1D Cw0/xrmAJYUwZiIDq2vZtR5MhDHSm7t9xu8upo1rVjBdlkNflYqXNutd5OaMPSmtdKrUEJZlyOw 6lls53Dz29AX5uwjPY9ZpqRcKf3F5Y3DQuSCIeDfRo4XyYOwmgyy9Z5J8xHc+PglNyj2kjP3hSv OwzatArNafcTBTvNUc7THlK+f7BujsZJHeE5t2Z//JTthUwe/lksYTehn6iamItnd/1uJ8JDhXr aKwkMqLR+8WDpjatE= X-Google-Smtp-Source: AGHT+IEDhVQaUpOSWRwGaxKvQe7pJ6rQhPxNknTpuZ3iKLBDGZGnh89cvumtUerdaS+dn+fzRi1Xfw== X-Received: by 2002:a17:902:ccd0:b0:290:94ed:184c with SMTP id d9443c01a7336-29df56841c7mr45223755ad.15.1765134144675; Sun, 07 Dec 2025 11:02:24 -0800 (PST) Received: from gmail.com ([2402:e280:3e9b:22f:9a46:840e:e346:f56a]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29dae4cfaecsm101519405ad.27.2025.12.07.11.02.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Dec 2025 11:02:24 -0800 (PST) From: Sumeet Pawnikar To: rafael@kernel.org, linux-pm@vger.kernel.org Cc: linux-kernel@vger.kernel.org, sumeet4linux@gmail.com Subject: [PATCH] powercap: fix memory leak in intel_rapl_common Date: Mon, 8 Dec 2025 00:32:08 +0530 Message-ID: <20251207190210.471764-1-sumeet4linux@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The err_cleanup path in rapl_package_register_powercap() function doesn't free rp->domains before returning when child domain registration fails. Also, there is a missing the cleanup for the parent package power zone which was successfully registered earlier. When registration of child domains fails, now the previously registered package domain (parent zone) is being unregistered. This makes both parent and child powercap zones are properly unregistered before returning the error. Also, fix the rp->power_zone dangling pointer issue by setting it to NULL. Signed-off-by: Sumeet Pawnikar --- drivers/powercap/intel_rapl_common.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/powercap/intel_rapl_common.c b/drivers/powercap/intel_= rapl_common.c index b9d87e56cbbc..5ea31433abf2 100644 --- a/drivers/powercap/intel_rapl_common.c +++ b/drivers/powercap/intel_rapl_common.c @@ -1406,6 +1406,13 @@ static int rapl_package_register_powercap(struct rap= l_package *rp) &rd->power_zone); } =20 + /* Also unregister the package domain if it was registered */ + if (rp->power_zone) { + powercap_unregister_zone(rp->priv->control_type, + rp->power_zone); + rp->power_zone =3D NULL; + } + return ret; } =20 --=20 2.43.0