From nobody Fri Dec 19 11:48:15 2025 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 118A426CE3F for ; Sun, 7 Dec 2025 16:43:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765125829; cv=none; b=W685yy4a1e1icAramVxnotfPyfjn5P0kxje+qNW5XEEjS2yQbzcCJ73HxxbX+7VaeGOGyaUxUS/ouuSyKS5QFZot0rC49FV3lvl38FLw4T9dq/sxYA3pEfE1cCF89Nn2htXsw4I/AF7I1d7PoMkUjpV5C/EhdG5PWGtuw9OBaY8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765125829; c=relaxed/simple; bh=rwhCZkkLw3vwk1TFAStxf9y+lgxkE2sr5YH1FNclkSM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=eXAOV2W1CPlTd4Qebur1CshuChtX+6U/l15XKhJfxXX/rwbdp6f1vw5qfuYS70oel7iEQuuTCT3ndwRhGrFZpM1P40sZvKn7VftxwfRNIC0NPYIM6WXbkt7xPEI7fr9JaZMS/EIfWjOS7uUz8etkLw32eA4Jpkwfea4i2mG9IHo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eWFOxoOE; arc=none smtp.client-ip=209.85.210.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eWFOxoOE" Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-7ba49f92362so2013008b3a.1 for ; Sun, 07 Dec 2025 08:43:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765125827; x=1765730627; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=8XX5LTtkJfB9p2MjVfS1613FXxwOAuGBUTWB9MA6u2A=; b=eWFOxoOEg+yq980XElbl6l+yytEobSFVMAjPoRnzT5rv9pBjabd94pJwZ2OrsbUn40 6uEJB8WvIyd0p6DiQ+Af06czrtkRCS0YWq9khgpgz9KJ470tujxydqhZxpG3Tm/aIK8f VwzOKwrCQP+iiAygXTmA+1ukSU0MwanpLllJTpsUdpQEVVV4dyRhV85PQUG8zexHv0AN pWLJ2031uPqFvuMFmWE3Eruu/DPNLzokUhgJT+U7SFbMDhaa1n5KCXdFCs3TR8sFRWTo z1KegaPQNar2baDnDEBiDTzG2/4ZgluqECWO1MvHp05sI/hibPJU4S/VAYUpOTI0+dQd LiFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765125827; x=1765730627; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8XX5LTtkJfB9p2MjVfS1613FXxwOAuGBUTWB9MA6u2A=; b=hjRrwlNI2rceFwTCnbcIGOF4Q0BdA5dPUVLcDn3831CX+6pUvL+WmVv819n4seayFE 8NiGx/kpwSyBGzRIjRZYCXRt0xq6hx9WIBDwQDSQH8qWtN7EHCULi0I2Jea1RKu3ez/U FViDml/inzp5X/75H03PXucvc2AqEhwuIwiq7+idN7SgvO4+7YWmc2HJFDRvE4K/izdH zdljFrk+zxYl1KArSeiGJR1VeisrM8tODikCdf9upxRr2fXMjygNpn1lcw80NM1l8T0l OJn1GYkKLj3filbhBQGhp8dxkVM8WhNosVVKPIvJBJJOd1udxZDK1jpgRsWagq1dvicb iN5A== X-Forwarded-Encrypted: i=1; AJvYcCV10i5ExUJsq2m2Yb4u6m7Jw7S/FkNo3prKQ64t/yUS7fCIsJkoWOcnCoa1HTiFH8miwKzN6uy0pG4wAXM=@vger.kernel.org X-Gm-Message-State: AOJu0Yw+ZdJPoYuRpgYBO6K626bslPj3eiynM3Q+vGWNoLyVfem94pVz emuCimnCaW3tIPKdH44qEUFC7/P3/oQivvciErk9eNVMLrHa5aArieac X-Gm-Gg: ASbGnctlaAjopJCZPUX7KFR4b3z40Gdm3rS8nOmF1NHYkfKxAaTqNRb1burTGiMdLaI xdfqhZ5xOk7egASYmYkH7nkZ5RASCXgtJtCXb8qZKUVFD5TjWRvWgsvlN2UuKqHjjVCJQq9pxuf SGxtaFHM1KDnwXR6QSYneIfbjvAngKFVxAjeZsoOtsKRjQgrB1UVTDGJ7OLrUXcxn+skT93/zJi dUkm5EQLcM+e1zJKRP9JY76JVahhWYVjnCcs6M6UuhFAZAVmjyZxb8JwAl9BaWnrXpPWYiZM2Ns zN0v7/iOuxdRra9XFPe9AalJjAf6cYtMrQehJOSi/rCNQTsRguDhXrzAvJr7HlchcVSvGV+SWfV PRGkzY9sCov4euzKB5JTT1bP358RCFxWUyCeIz3kudHAbAsDNri5PVIJPoUfroXSOSBENMBgO6F MmzZuXZKM/pTv0zUlxfJLn31f8W3ISdq/f X-Google-Smtp-Source: AGHT+IHdH4XmI4hIo+FBoZVrnL+XFoqAh/bKrwaFHBEmbsavQyJYthDHroScXtzp+fiOHdBWvkM02w== X-Received: by 2002:a05:6a00:62c9:b0:7ae:b13f:37c2 with SMTP id d2e1a72fcca58-7e205c0d557mr8076285b3a.10.1765125827341; Sun, 07 Dec 2025 08:43:47 -0800 (PST) Received: from localhost.localdomain ([38.224.232.243]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7e29fb94567sm10625779b3a.15.2025.12.07.08.43.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Dec 2025 08:43:47 -0800 (PST) From: Dharanitharan R To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Dharanitharan R , David Laight Subject: [PATCH v2] staging: vme_user: simplify bus number allocation using ffz() Date: Sun, 7 Dec 2025 16:43:17 +0000 Message-ID: <20251207164317.4835-1-dharanitharan725@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" David Laight pointed out that the loop in vme_register_bridge() is effectively searching for the first zero bit in vme_bus_numbers. Replace the manual loop with ffz() and use BIT(n) for consistency. Suggested-by: David Laight Signed-off-by: Dharanitharan R --- drivers/staging/vme_user/vme.c | 15 +++++++++++++---------- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/staging/vme_user/vme.c b/drivers/staging/vme_user/vme.c index 2095de72596a..45381e677475 100644 --- a/drivers/staging/vme_user/vme.c +++ b/drivers/staging/vme_user/vme.c @@ -1765,16 +1765,19 @@ int vme_register_bridge(struct vme_bridge *bridge) int ret =3D -1; =20 mutex_lock(&vme_buses_lock); - for (i =3D 0; i < sizeof(vme_bus_numbers) * 8; i++){ - if ((vme_bus_numbers & (1 << i)) =3D=3D 0) { - vme_bus_numbers |=3D (1 << i); - bridge->num =3D i; - INIT_LIST_HEAD(&bridge->devices); - list_add_tail(&bridge->bus_list, &vme_bus_list); - ret =3D 0; - break; - } +=09 + /* Find the first clear bit */ + i =3D ffz(vme_bus_numbers); + + /* Ensure we have a free slot */ + if (i < BITS_PER_LONG) { + vme_bus_numbers |=3D BIT(i); + bridge->num =3D i; + INIT_LIST_HEAD(&bridge->devices); + list_add_tail(&bridge->bus_list, &vme_bus_list); + ret =3D 0; + } mutex_unlock(&vme_buses_lock); =20 return ret; @@ -1787,7 +1790,7 @@ void vme_unregister_bridge(struct vme_bridge *bridge) struct vme_dev *tmp; =20 mutex_lock(&vme_buses_lock); - vme_bus_numbers &=3D ~(1 << bridge->num); + vme_bus_numbers &=3D ~BIT(bridge->num); list_for_each_entry_safe(vdev, tmp, &bridge->devices, bridge_list) { list_del(&vdev->drv_list); list_del(&vdev->bridge_list); --=20 2.43.0