From nobody Fri Dec 19 11:49:59 2025 Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 362E929B8FE for ; Sun, 7 Dec 2025 12:49:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765111759; cv=none; b=jIP6EgHxtc19dcNT0rbnBwiDueeHM5u4WqNmJzanKU7M3lcQRnCl3ajdXOeJAY8XdMxrZVIiWcyTJkhJZOosoND+B1/mksD5zUhihuX9qHZ1ZwC/bktJLW34Bs+6kqW49OYFVWjlTp6LqH0dMWHa+/kyq31BI18RexattWZF4/g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765111759; c=relaxed/simple; bh=Lot9yyrysMIoFKrFBRyHq7ofMZNCgMG6b0MvoWmbSp8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=D7mMOIDvgWMURDFi2diTTgzvBSeCHlz7LxwwhYDjjZn2EXBsXQ0xtvcUrhnmLz1T27woAH8NbR86xp3qDmMUSWbRCWHg+gQfwBhKcW/YgRY6krHGIdry4JwLLuypMWOQsbu4X6IbDVgFQ1xkK5ZddLLH7JZjCcIWt/rKIUcwSZc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BwZRHrBA; arc=none smtp.client-ip=209.85.218.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BwZRHrBA" Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-b79af62d36bso584354566b.3 for ; Sun, 07 Dec 2025 04:49:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765111756; x=1765716556; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Iuw7MrNQpJ+liSkmkNaHY/c1VIRpuVgXZGRp2BUwU38=; b=BwZRHrBAZQ83JDV7Kqz5xfSF9eetL784lWA6BWjV+BhGR9ijthN2YNU+VOBR6/XL3T txMdI9AM3bTPBM5hrCSZS+RFNKNHqtFQ6JfDFZpRmP/irR5Wffv26/0xR8sk8Mr4o3Jg +4kMkXrIkB7uGWInp2H4w8zh7UzH6HzDzy/oKmKN/q2gPJofVxcglZecHXaiUdfNmvhp evPT00Kk2wFSdngrd45etEWYhGOYIPOHn1O7WCA6J/GXmaMs/ccjT3KKh35zOqpn9LMI 5BYdjn32FsZsDQq/TBSCs0Vm7Ofgyq1+thQ5YLotxUWF8aVT82tbTOj6J8PVK/gmAgun yvkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765111756; x=1765716556; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Iuw7MrNQpJ+liSkmkNaHY/c1VIRpuVgXZGRp2BUwU38=; b=ndn/8XgqiSI3uiy22IpBaBLZhTqMmt7n6Z1g6d8bsGHnQKkIQ5WAOm563a5sRIqTnt Y5SMTPnztCfSOPJ+obiwsz6KVkdrXuvNVsXxkqysAtJgIKofaGcpUkCmdf3I/q/huSe4 eAbuYfj20WEbDKQmPzYos0gcglANlmNPRpxcONXcaIiZ11HM5NqTCZrcBr9zKotEnf3+ Qv7ZUjvJA/6e4C3p782IIoka/i0PbOtR5b82qcS9u3k1nYB8+DZRu8hTxJhtsfCgMfTq qOto0KdZf5CkuF+9gJTpvCLqmjk4N5T7uPhe0OCmijauFdJVVVOkNbtueeyA4ke3kMII 6BSw== X-Forwarded-Encrypted: i=1; AJvYcCWSJuKnb6lFFNW+qp2Hiyv8rRQABBhYA+Xzyz4coqasi/LuEPUJ8uDMg0D5mK2FRzoU93UTE6iC2qjWuvA=@vger.kernel.org X-Gm-Message-State: AOJu0Yy4SRWUv/bfB/tdxfIazNZ8qxCirOpTbvhTrchG7bU4fSK3TFGe HTqvRrlmTVrcpzs5I0ARGPjWTwg4X2p6OFiGvnl7NtkISJBercxRG3LH X-Gm-Gg: ASbGncvSEPwa/BiEkbdlr9LZzPnp/sh2udg1M0/HmExCxaaSGvBUjl3ZVgEPPDORElE Mz1FqginRRMyQRZnZTpvaDh1nSI0PmX6Ksl9ROpSR9uNkPqQAMar1a6fdvDSIS/k7t0xaSOsxUT Yuywiz2v0Z48VL2EKsljJaeKxBnJUGXVu5WW74/sHzwmw7L58rEEIfAijsfRfMujkdQiGzCkoMB b9ywuWu9e1n1kznvghIsJef+1+PXanv2/jfSAHQvqo5XyJPjbCWkouHzPqIOK91TZsCNZD7LGTl NRCDY2MTieax9x8HHbwWfIEE0LE8BW8o2I3jdIoxazQSXE0vx5FfLZ9bXAkhiri50spT8ZqckX9 EVGXyGOVTxp5kHJKbVgxqrKwG5Tip03GINX7Tlcj5EzpNlSdSEb3zxwhZXifmRDKA+w/Ch0inNx iK+ELSYppb7k25s/grePzelAzH+c6TS0BeAphu6e8G8YYSeLd2NS5HL6X2aZC3evglvvJS9q0kC tBDxX5cyPm5FDv8 X-Google-Smtp-Source: AGHT+IHLzMKabsop3+vKMOfNa/2/F5jDp+SeGjf8fqwP0dHCFJSa+7kOwDVwH52EYDKJMBc3IQm3QQ== X-Received: by 2002:a17:907:d8b:b0:b76:23df:c993 with SMTP id a640c23a62f3a-b7a2481dccdmr511981766b.56.1765111756345; Sun, 07 Dec 2025 04:49:16 -0800 (PST) Received: from localhost.localdomain (host86-162-200-138.range86-162.btcentralplus.com. [86.162.200.138]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b79f445967fsm848078366b.10.2025.12.07.04.49.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Dec 2025 04:49:16 -0800 (PST) From: Biju X-Google-Original-From: Biju To: Alan Stern , Greg Kroah-Hartman , Philipp Zabel Cc: Biju Das , Claudiu Beznea , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven , Prabhakar Mahadev Lad , Biju Das , linux-renesas-soc@vger.kernel.org Subject: [PATCH 1/2] usb: host: ehci-platform: Drop ehci_resume from ehci_platform_suspend() Date: Sun, 7 Dec 2025 12:47:26 +0000 Message-ID: <20251207124742.96526-2-biju.das.jz@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251207124742.96526-1-biju.das.jz@bp.renesas.com> References: <20251207124742.96526-1-biju.das.jz@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Biju Das As per the suspend_devices_and_enter(), if .suspend() fails, it invoke the .resume() callback. Currently ehci_resume() is called in 2 times if the reset_control_assert fails in ehci_platform_suspend(). Drop the duplicate ehci_resume() from ehci_platform_suspend() callback, as it is called later from ehci_platform_resume() callback. Also, drop the other duplicate callbacks pdata->power_on() and quirk_poll_init(). Fixes: c31a401fe7ab ("usb: host: ehci-platform: Call reset assert/deassert = on suspend/resume") Signed-off-by: Biju Das --- drivers/usb/host/ehci-platform.c | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/usb/host/ehci-platform.c b/drivers/usb/host/ehci-platf= orm.c index f61f095cedab..253405efe50e 100644 --- a/drivers/usb/host/ehci-platform.c +++ b/drivers/usb/host/ehci-platform.c @@ -454,18 +454,7 @@ static int __maybe_unused ehci_platform_suspend(struct= device *dev) if (pdata->power_suspend) pdata->power_suspend(pdev); =20 - ret =3D reset_control_assert(priv->rsts); - if (ret) { - if (pdata->power_on) - pdata->power_on(pdev); - - ehci_resume(hcd, false); - - if (priv->quirk_poll) - quirk_poll_init(priv); - } - - return ret; + return reset_control_assert(priv->rsts); } =20 static int __maybe_unused ehci_platform_resume(struct device *dev) --=20 2.43.0 From nobody Fri Dec 19 11:49:59 2025 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A96902C1594 for ; Sun, 7 Dec 2025 12:49:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765111760; cv=none; b=crwGHP44bJMm6btFobSE1IrFGlKxUqaLNqgM9cvyhCsr2mFm3ynx24dfaGBo7eX0HbIOGqeHNtnnxPJirtpmhCi/0CrdXn+/RW8AsfANgAGYJ3HCtKnEQe+V/uRKqfhdw33bq5d3VbvlA3aghJKAoeMZqUhma7kBNQWkH9uw/i4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765111760; c=relaxed/simple; bh=bQFpEG3o9LQ536f6JxBdq8z7Y1JAJhEjOJQfUO1giYg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FC4Vr8g3XpmorkQ7WfvIHUSOrs2RtVRtSRATaS41vtPYtQ8cHKD6AEWHHfzY4Xugmh38ORXd2tERugAJ6LSiLN+aB/s/wCx8yMbcs5R8KJIhrSpgCjGjAvzwkJRHnXSZAeVuKAzv+T+6FFka3uH2lF6wwWt5UFiamkQHTkwBQ3I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=K/p2mTnO; arc=none smtp.client-ip=209.85.218.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="K/p2mTnO" Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-b73a9592fb8so841092166b.1 for ; Sun, 07 Dec 2025 04:49:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765111757; x=1765716557; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=v+8cllFdmmZn50x4l8XYZK9RXQXxmWBAkLfGXs7iEf0=; b=K/p2mTnOjDFUbX8/I2xpJm10EtLnLD8QLDQvtpy8kyIhN4Ejetp8vQF8g22nI/Plhj SeZ2TPtUYVjktIIC8GNr4bbUe11bcxCSHrIadLm4dYu2jx808hzOtw7O0twqYqsTPDPs p3mY6tU/OSl1kZMgEIm2lkLRncky9bf24MSpRZPmJ1DG/bUyUWAhUQq6ImTlNF4OFH0W Bmo+6ej4h8lDxUt0REVbr/Xvu1e1rUBNhnOLnxaw0XkS3rHuS1D5Sp2KFs44hRCK+rCF bWxLFU2KHGuohLT2rQxKTOq7IoA/n8JGlpDH59FpIrvrsCSdV+s+KQPii7RvOJ+G/2/1 ES0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765111757; x=1765716557; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=v+8cllFdmmZn50x4l8XYZK9RXQXxmWBAkLfGXs7iEf0=; b=gBubjfjWv2EU+n2zKBaywZjXcHQV0F/0yOH6yulFbjWGhu2CFqdAxoZGPwNOcOmuXB 1jf9RXRnHsQGWS7/1+xCifzpqf3sdCOGl93uspPBz4lBNrZnVFrPyVGAAhTzJruqll3G xd8j2VnJzJEO+mEPst57JAh/ic1qCPcurHlIaiZrFGsebBrSmL+PVoGy3thjtAbwFLe0 TdbHsUEWvuWDNkGwVVEAmvNXsMrup/4ZYxLv5E0SKvwJSQ++3f/W49iHfndDN2L+eNRB z0LMcuukqTMINrfvfGVfH/L0uVd2vlYr1RDAonVwoPN/eCELKuC5nDqgUMDo4RVx6B24 8B+g== X-Forwarded-Encrypted: i=1; AJvYcCUAJMVD8O5hB0h4TkVfHDSorD8+x4pT2TWEJSwsiXXKgvwrwmsmiq1X53sLPtY+Lv6i+YaA51NPeVlv46U=@vger.kernel.org X-Gm-Message-State: AOJu0YyF79FS+X2IKQaM61QbLeledUBVqBmw82rP3ieoiWS0PDq3ve9/ WV7DohRpJvoeS8qKhp8cxwy+ALhHSUFadbkoKdMeKF861+QYUqTba7tY X-Gm-Gg: ASbGnctP4xBVlemLU7Iw0e+a5lfW2Do4hOitGAb1neKMvZDpaL8AGkfUTpFyueTm2tE OADfPhc4RDQch9MU1ruuXL556DJi+hVyD7CWuPBpDNB7yrfZ+9x2RteXPGDOkYX11AmBmW0tTAS 8t8AJhJuYL7idE1IeT1fCkn8qpCIIrKnrq1M42oLVVDuyO8rKCbskkDiZgipRTjdO4h2afrY3br 5tuzxJtrXjyc/UdgiCTURcf1QOCaCCBWrYZpqu1PvrzS3rq/j9SZCQpoh+HEnoH3izwd5cr7HGy qOzRa5Iy8aHLiEzLNpRQUj1ujD9uujC/Xn7JY4riOEXYMGp/AcENHAV/XZRSQ/IFzIaQR5YyZTj +wXVZcKi7FThraEq1vd7tp1LsLN30eOxgitM8P8b6qc9ybeUi5n7r2gfPLj5e6YFJReMpzgy+OX ocd0vRubYVNgVM+OSIIH9j6xqfFcU7NyU6tmGX8O5cyi70YyJLEAlF5jfhtFcvjy9CLoReB+rRg BRiAFohiXjHhBVe X-Google-Smtp-Source: AGHT+IE8fOENHVwPtQI3pGjpRrNOqeblBeyp2cP1u+Su1TipXnFYjjo9bgkVLkCyRo2mgZyc5c7Cfw== X-Received: by 2002:a17:907:3f8e:b0:b71:60a3:a8b9 with SMTP id a640c23a62f3a-b7a23b7f165mr540412066b.29.1765111756891; Sun, 07 Dec 2025 04:49:16 -0800 (PST) Received: from localhost.localdomain (host86-162-200-138.range86-162.btcentralplus.com. [86.162.200.138]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b79f445967fsm848078366b.10.2025.12.07.04.49.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Dec 2025 04:49:16 -0800 (PST) From: Biju X-Google-Original-From: Biju To: Alan Stern , Greg Kroah-Hartman , Philipp Zabel Cc: Biju Das , Claudiu Beznea , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven , Prabhakar Mahadev Lad , Biju Das , linux-renesas-soc@vger.kernel.org Subject: [PATCH 2/2] usb: host: ohci-platform: Drop ohci_resume from ohci_platform_suspend() Date: Sun, 7 Dec 2025 12:47:27 +0000 Message-ID: <20251207124742.96526-3-biju.das.jz@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251207124742.96526-1-biju.das.jz@bp.renesas.com> References: <20251207124742.96526-1-biju.das.jz@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Biju Das As per the suspend_devices_and_enter(), if .suspend() fails, it invoke the .resume() callback. Currently ohci_resume() is called in 2 times if the reset_control_assert fails in ohci_platform_suspend(). Drop the duplicate ohci_resume() from ohci_platform_suspend() callback, as it is called later from ohci_platform_resume() callback. Also, drop the other duplicate callback pdata->power_on(). Fixes: e4d9da32bf60 ("usb: host: ohci-platform: Call reset assert/deassert = on suspend/resume") Signed-off-by: Biju Das --- drivers/usb/host/ohci-platform.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/usb/host/ohci-platform.c b/drivers/usb/host/ohci-platf= orm.c index 2e4bb5cc2165..5342cffbee47 100644 --- a/drivers/usb/host/ohci-platform.c +++ b/drivers/usb/host/ohci-platform.c @@ -281,15 +281,7 @@ static int ohci_platform_suspend(struct device *dev) if (pdata->power_suspend) pdata->power_suspend(pdev); =20 - ret =3D reset_control_assert(priv->resets); - if (ret) { - if (pdata->power_on) - pdata->power_on(pdev); - - ohci_resume(hcd, false); - } - - return ret; + return reset_control_assert(priv->resets); } =20 static int ohci_platform_resume_common(struct device *dev, bool hibernated) --=20 2.43.0