From nobody Fri Dec 19 13:25:50 2025 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D38112C21D4 for ; Sun, 7 Dec 2025 12:21:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765110114; cv=none; b=i+BKBHMZLOI68TaiEDtETfqE1h09DgwWf7r0/A3ZjBv556hm58lRDuegskAS4LiqUDBWn1KiLO44lTnD06dzlRcN7Z7/tF7+mJu7AtH1IEN5QpJu9z0xf2/UivscNjAXrA1zbCizI+JR99Wrp3TFce3vtKEBTkVguoV9YekwKvM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765110114; c=relaxed/simple; bh=54Xh/j2WhG2Ei4a1qEnIpkmDGonn8ZggrBoCMAcXO3g=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=bQktSDH8G25FcelRs3zGtEqbUjYYaea/qP9q8Nks2DKZKetd0TCkfR+UhuEOV8TxH/CZvp/Q1UGGni7Y0SxuXGvuIF17Sa8cIECXXRez30uHFJP0IzKU+gyTVOogyhfIef5nQfPPc9EFecOmCzYFji2uJ1R+imlqlKLpgiMJrQ4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lIps9MXg; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lIps9MXg" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-29568d93e87so33314735ad.2 for ; Sun, 07 Dec 2025 04:21:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765110112; x=1765714912; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=i/7vzy1FUoDsUfjpWUzueUpIzsuHBaOImPA4L+Mj+ZI=; b=lIps9MXgArmN91wavXUc49twuZy+fZdUvCItADOejMyZFcw7TxXGTVflAC0WSqz8yK K46EEucCKjjKQgXMDkX8wFF63Flc3R3ycovlyUIe22SSr6NrkjwFEV0JgMxzZ3umKlwp eyHn59khjfHUiY3+axufKMjbF0wl4fG/ZCsO0HW9THHMEYUJNEgiPJ8cTgiYglnQ+Xnw XREz95pgqYBZ5TSeQddJOvdqfpvKMRjN5sK8exIz0P3RBG60iI+K9Q4TREmlU+imLGQU +4OwGhDRhAPQ6uPKdCXeDM47Gmp8cius5zfZdEdGUNYhGikxV08seuV5GRvssIDLS3dX V4Yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765110112; x=1765714912; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=i/7vzy1FUoDsUfjpWUzueUpIzsuHBaOImPA4L+Mj+ZI=; b=aO1znPCsc63W9lFKafeVErQXabi7D1ZlPPcxBnW1zkuuiVA7QFp2FXSxAT5qWhH7kZ 9jHBsNUyHM7OCOzLeYqoQDELi5L5o97gGCjPrwTo0x2oUdsZ1PnR3o7L0e/3FMfnyWFO CsQmeURaZz38g7eI5UPM8GxrLQzZa4Qxkfj+CL0Vd/k2QYCkQe0/bFtfE3ORJNPl0sVb ztalKV+N0RK8BPua2B5CdHaOTIDIxBfmzyOO0L51MHMGFvJ3Ma0Hza0pzfU0T0oj5Cdg /eEhruyB7kdZs2NCZTLMco8n4J0qQchqcUdarNvp1FeFebT0xNhc7Q/35e7srOe8dfPM aA9g== X-Forwarded-Encrypted: i=1; AJvYcCUhdRUyAOwR+xl5P4QYP4yMKxauNLFTZBfdwRhe6fh+IXSHM3cLjm8aQqFYDmM67MGD1lMHX+0J7gbX0co=@vger.kernel.org X-Gm-Message-State: AOJu0Yy+1cObMbm0oIQARYTr+80B/c4SaTJUIMpm5x4Y098nSnvVCsOa VQY9q14It28qwqxHEnaWwdUie/4kIRVt2lwO+NzdEpWH7HihoyJoNW5I X-Gm-Gg: ASbGnctzvnbU2n0fCiISraQrTUEwPR1bj1XkQKJrxXmuUc/XXpPGbF7eGRbdGjzYBZN H6cFFGKtIjSdeSvamGeSrGUmjUqZrHWQr8efxh6IhPIy6NcLe1VT/VRuZu6teUuP7azTzbtTj8Q q2gp6oWXY3FjIs4mtDxKzqQj5NHZLHh4ZqqbF5xTILmx0qETM4QGXeHZ49ou06QRUAfdi/iluhX gouVxD6t1bxwpjBJCNBHzWC6QBYYjXf/covFJ+xaeP7DD9jTexooq5Uo3BXkslOeOQPAMGLXbIm mPedO5zcHPI9a7/bchxL68tEd7VTgtF/n0FftXZ2OrZMcHnsTRBLkDUqEB1aRFJ8gRFlPBq8brx 8G5Pt4BoNcim0GphCXizmNnCgP3coCwGruCVCcPQQBX9U4bwt4OFP3Xrp2NgpFsg44eacUtMnEk +5QcQgmWfzl+U+zAka6t3Sw/hu+Q== X-Google-Smtp-Source: AGHT+IFnUgbCbzWKaHX3DgU1C71Wvw3pYFn2ma/gYdiJLLhx9hJu0uDqdIfBQDxlroW91cHZjfSAcw== X-Received: by 2002:a05:7022:21d:b0:11b:9d52:9102 with SMTP id a92af1059eb24-11e0315b334mr3249541c88.6.1765110111933; Sun, 07 Dec 2025 04:21:51 -0800 (PST) Received: from localhost.localdomain ([104.128.72.41]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-11df76e2f3csm38598822c88.5.2025.12.07.04.21.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Dec 2025 04:21:51 -0800 (PST) From: zhangshida X-Google-Original-From: zhangshida To: Johannes.Thumshirn@wdc.com, hch@infradead.org, agruenba@redhat.com, ming.lei@redhat.com, hsiangkao@linux.alibaba.com, csander@purestorage.com, colyli@fnnas.com Cc: linux-block@vger.kernel.org, linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org, zhangshida@kylinos.cn, starzhangzsd@gmail.com, Christoph Hellwig Subject: [PATCH v6 1/3] bcache: fix improper use of bi_end_io Date: Sun, 7 Dec 2025 20:21:24 +0800 Message-Id: <20251207122126.3518192-2-zhangshida@kylinos.cn> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20251207122126.3518192-1-zhangshida@kylinos.cn> References: <20251207122126.3518192-1-zhangshida@kylinos.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Shida Zhang Don't call bio->bi_end_io() directly. Use the bio_endio() helper function instead, which handles completion more safely and uniformly. Suggested-by: Christoph Hellwig Reviewed-by: Christoph Hellwig Signed-off-by: Shida Zhang --- drivers/md/bcache/request.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/md/bcache/request.c b/drivers/md/bcache/request.c index af345dc6fde..82fdea7dea7 100644 --- a/drivers/md/bcache/request.c +++ b/drivers/md/bcache/request.c @@ -1104,7 +1104,7 @@ static void detached_dev_end_io(struct bio *bio) } =20 kfree(ddip); - bio->bi_end_io(bio); + bio_endio(bio); } =20 static void detached_dev_do_request(struct bcache_device *d, struct bio *b= io, @@ -1121,7 +1121,7 @@ static void detached_dev_do_request(struct bcache_dev= ice *d, struct bio *bio, ddip =3D kzalloc(sizeof(struct detached_dev_io_private), GFP_NOIO); if (!ddip) { bio->bi_status =3D BLK_STS_RESOURCE; - bio->bi_end_io(bio); + bio_endio(bio); return; } =20 @@ -1136,7 +1136,7 @@ static void detached_dev_do_request(struct bcache_dev= ice *d, struct bio *bio, =20 if ((bio_op(bio) =3D=3D REQ_OP_DISCARD) && !bdev_max_discard_sectors(dc->bdev)) - bio->bi_end_io(bio); + detached_dev_end_io(bio); else submit_bio_noacct(bio); } --=20 2.34.1