From nobody Fri Dec 19 11:45:24 2025 Received: from mail-ej1-f74.google.com (mail-ej1-f74.google.com [209.85.218.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 858C7242D67 for ; Sun, 7 Dec 2025 03:53:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.74 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765079603; cv=none; b=oitwQO2x2/jC7LOvF7WhWQd6qxAxk+C1bf8fJ/j8PD36sEbF8VSRUppqYnw3aIv73Wk4oBr0W6YMJEvndwvUrMZN3c6Ov8YD9pPV2wuxv++Fo1GbKatR//VngFWolV3A6uTJnUkIfldCfHGiDhiOX8v/2SFEZNBgIaXll3s0BbU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765079603; c=relaxed/simple; bh=/bRLZwn0MpZd47mx4ZKFo7RQV5+rS0Wvg5LTomnFM6g=; h=Date:Mime-Version:Message-ID:Subject:From:To:Cc:Content-Type; b=E1dYAPgR8Gv+ZNa+Q7ueBvgevqcI6MG8aOTOXI1XDdex9FpPbyU0JTdBHk5nAZ17krSQnlk/pgzLf6aj4ztXJJKZmjFXAVSqchKG8By/BBkFDpe3w1ExhAcD7gJ8/vzKW+oHYCaHeZKWNA3cUhLtpBe1u9UpNGrEaOMhQyssJaM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=fU6v44XG; arc=none smtp.client-ip=209.85.218.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="fU6v44XG" Received: by mail-ej1-f74.google.com with SMTP id a640c23a62f3a-b7270cab7eeso271187566b.1 for ; Sat, 06 Dec 2025 19:53:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1765079599; x=1765684399; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:from:subject:message-id :mime-version:date:from:to:cc:subject:date:message-id:reply-to; bh=JntZtQimafQAhusKbPnuwY5cgOI0Vb1BCc/hilWIYOw=; b=fU6v44XGY2FzY5WLGs9/6ClebyLGynweIkv906e8JgTzYYBUvfVqEwCI4qCFMUYczQ CWeHwR+8D/g2czH6Zyn50tdBzOqp9tUNNADM8MhZd3N58oZHx6VOshgsFgqV6Fg+MrVg rxczt7Ip5VjDtMIxBm8nkHnHCXQ8vexZm//xy6nMI4UKe6D3Uu75qYy23hJ90uG1TbD+ ij3lu6OtLPSTBUEFgFit5yNhwoWYor+UhAzFlDo6IRtB02IW6oaIQ6/k4Z8mNs64/JQF S0H8OyAsQo/Qh/hZvljSJjJrOYrLmmL1pc3TtuDof3ZS7V8tSGdAtUdblbrPZVx5RwaP 1HMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765079599; x=1765684399; h=content-transfer-encoding:cc:to:from:subject:message-id :mime-version:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=JntZtQimafQAhusKbPnuwY5cgOI0Vb1BCc/hilWIYOw=; b=ZFuLqBNAlw/PMz4MCK19h490+gC5sB7iVzhQFPr7BO4CVk6B47Q7vKDGlQ5JEss28r JbMk+OoM6V7gE9wDT1otXhQFhmDyzsBRZGNTbW5W9c8C3Tuy6uN8T4HkYY33KRP2rsa+ 9+oNWcDuL8nAXPHxYyvHwQCtqSOt+47Eor/rA7b0tiZAxpgYluvWkCjawH3vn2V0YIGY 05Op211auglFokrbWOy18N7St8hDYscN5ZfZo1r1RXknhnyjHa3rBcGm8FGxzuKYzYHn DTH2iC/2GMAf/FuaMvJxf1OHabjdLkFMOLbU8Q2M+a4R5aDlEAz40L0OlvtyWFc4Gznt GUvg== X-Gm-Message-State: AOJu0Yxi1rZ+Cs8JdSbX+HFLkV6aVayHacX5XsyK8LGzKhe1VRIVeeHf mNYfo0M+Bil2OfT4DjZNylH7wuKYpN/zZ6E2J6hMm9KCvX8yx8+Hsqo+gwyOKDv6w1upnHAEB0R ygOfabeaGLk3FZw== X-Google-Smtp-Source: AGHT+IFqo+QdI6a1g5zHh+DqZIuBkHxsx11KY9PJnuKwhKTpbRPxMI2hpsYLHB5VLcPdkZDxiwdXmS8CahiU/Q== X-Received: from ejcun6.prod.google.com ([2002:a17:907:cb86:b0:b6d:6b6d:d49f]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a17:907:3d06:b0:b74:984c:a3de with SMTP id a640c23a62f3a-b7a242ea410mr435197866b.28.1765079599618; Sat, 06 Dec 2025 19:53:19 -0800 (PST) Date: Sun, 07 Dec 2025 03:53:18 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-B4-Tracking: v=1; b=H4sIAC36NGkC/x2MQQqAIBAAvyJ7bkGFKPpKdJBttb1YrFGB9Pek4 zDMVCiswgUmU0H5kiJ7buA6A7SFnBhlbQze+t55O+AdNOOhks+IiQjHNdiRmiRH0KpDOcrzH+f lfT9nl0yXYQAAAA== X-Change-Id: 20251207-warn-printf-gcc-8da08c251c1c X-Mailer: b4 0.14.2 Message-ID: <20251207-warn-printf-gcc-v1-1-b597d612b94b@google.com> Subject: [PATCH] bug: hush suggest-attribute=format for __warn_printf() From: Brendan Jackman To: Andrew Morton , Peter Zijlstra Cc: linux-kernel@vger.kernel.org, kees@kernel.org, acarmina@redhat.com, jpoimboe@kernel.org, mark.rutland@arm.com, maciej.wieczor-retman@intel.com, Brendan Jackman Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Recent additions to this function cause GCC 14.3.0 to get excited and suggest a missing attribute: lib/bug.c: In function =E2=80=98__warn_printf=E2=80=99: lib/bug.c:187:25: error: function =E2=80=98__warn_printf=E2=80=99 might be = a candidate for =E2=80=98gnu_printf=E2=80=99 format attribute [-Werror=3Dsu= ggest-attribute=3Dformat] 187 | vprintk(fmt, *args); | ^~~~~~~ Disable the diagnostic locally, following the pattern used for stuff like va_format(). Fixes: 5c47b7f3d1a9 ("bug: Add BUG_FORMAT_ARGS infrastructure") Signed-off-by: Brendan Jackman --- lib/bug.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lib/bug.c b/lib/bug.c index edd9041f89f3aa613af71e4f107b52a4f4dc71f4..051891f874439d66f907e043cf5= 2b954b3ea564b 100644 --- a/lib/bug.c +++ b/lib/bug.c @@ -173,6 +173,9 @@ struct bug_entry *find_bug(unsigned long bugaddr) return module_find_bug(bugaddr); } =20 +__diag_push(); +__diag_ignore(GCC, all, "-Wsuggest-attribute=3Dformat", + "Not a valid __printf() conversion candidate."); static void __warn_printf(const char *fmt, struct pt_regs *regs) { if (!fmt) @@ -192,6 +195,7 @@ static void __warn_printf(const char *fmt, struct pt_re= gs *regs) =20 printk("%s", fmt); } +__diag_pop(); =20 static enum bug_trap_type __report_bug(struct bug_entry *bug, unsigned lon= g bugaddr, struct pt_regs *regs) { --- base-commit: 5e8f8a25efb277ac6f61f553f0c533ff1402bd7c change-id: 20251207-warn-printf-gcc-8da08c251c1c Best regards, --=20 Brendan Jackman