From nobody Fri Dec 19 12:50:27 2025 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C5D41381C4 for ; Sat, 6 Dec 2025 15:55:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765036537; cv=none; b=lrSLidlU45SCE7+WuJvhuAgtvUPkkdObdKVbHWo1XfRJE89xsqR6YHXneeVDZ+szZxY160gjXt4E/w6xLlVMlDm9B0rVcLK7a2V6ETKfH2YldGFs7qj0gzJmDnCqh21E6HK3fNMZkPXXJogBiPIwAqxhtoxl947JbycoxtvHXkM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765036537; c=relaxed/simple; bh=N5bZ5/M/apt763HXHMVaDwyrRtjmP3lGJpgcB5XWnqs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=BJ6/wStoN6RYstemWNYrpS2imB3EFIlk8DgKzdG4mykZFcpil0YZ1RObGrVsF1mxWagOSaTReYXfvrgKPdQk7NwZpS7QVEra4kjKHYB1l8bp4C4WquiT2CSJexLzdzIrPIs/HkIIYJVvla6Q8wSjZXSy3Dm8Mdy2GNNUU8tdM50= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NbSbYJyI; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NbSbYJyI" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-297f35be2ffso47663965ad.2 for ; Sat, 06 Dec 2025 07:55:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765036535; x=1765641335; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=8svgkf5k9hykANPOqA4bu5CMkkqiRkEaY+OOQpE+1tM=; b=NbSbYJyIrpGz4IuTKmy4YS3dveUcomu1uXnAnVzay6Dqgc0+Pm0hPXQwvdMTpCma9y X1ztMKFSjrLvRsJEv2uYQdrM5pZGQrsIHLDDpDhXJe3b1V8Jf5cip6xe/3GyFdtsUtRG Y6S3C+A5agFSrgLwtm0lbSOGvEqqfTu4bFa/BW2qnxt8JyU13oKg7gvE7cCMSI5sUrsn TDCRoHO4HBtDHMqpDgTLLj58CZ4Mh4ZVNeQHtuvCelyMqObff7OsjBX6qa+81VNhNnPu DVsS3bC5KQpo4B1AdjpcAO+eUwsD/RjGLVtQ0kEzIwQC/FvcbAKT2r8NkoF49PS0cdbN VIUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765036535; x=1765641335; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8svgkf5k9hykANPOqA4bu5CMkkqiRkEaY+OOQpE+1tM=; b=SIyOZAV1p45oWobQVX5lFV+q5Di912F4AXP3V1PcYUcwo+2akF96bcl+3PdZLQZVgJ 4xSl+Kh0LZzSXn4pG5gijhWPCA6yGJgichQu+/l7k1Y1ZunRbxkK7LdliqEtwAwJqJx9 o+NEtsVZAdxpqk0pfA5Z/m6pySqhz7CQoMQJPevfIZVmEYjSZyooZ0mvEzLIfG53lBFv g7bvnVEDPGlFmdzeN1ChAQPgkmZ4z2qJ0pZPmvQo8+7PCi/wPhkObYOVnLeH5KoO1HFn GxFYS06xPlhrPhIq5SsuvWRb1HtVwlHcIvyCtcn7WrMeKeN6PxSnM+U7oX5kUTheWUYf l6SQ== X-Forwarded-Encrypted: i=1; AJvYcCX3TkK4NVj7gyPyliFzDf0+dif1CiZBvhdpYYf8Giuim0XlwUNRDVmd1TVuKywqVcEXidIUYYlD7InU+Qw=@vger.kernel.org X-Gm-Message-State: AOJu0YydV3uL3fHVjiw0jqO45i2XBDBxYvVak5A4uZGFum6vLqX/bRqD dYGgCQ9S46CGTwcjoelWS7juK9Ff/8kvFxGVDcW7Io6KJOrTQLfGtdZ/WFRNZTCr X-Gm-Gg: ASbGnct+jmMaj8KJYItPdzVCWhx1HQSOhuS+fvBdz5I1i2seU1Pr5IlC5ab1UrtZkqT /KoNaJ9l1zW2QriZHYEhJRMKdAg/9F0R7EAm9mzoQdQ0UrUTGgzTQF+KEXCHxr0apx8tLhExA8+ 0UDn1P33HAHXeQgOk8E9szvsEbXBQrzEqRbMJp4TwWH4h6Q1M7DttpvIpqZgoVkgvQyHl9345VJ 6GLu+no8B8fJKs9sYuqzlmCavGQ7f7J1y02Io9oZEbDuX8r+sbTTwiNUsKIROjkRUTTpKOw+0Pg argbsGdakfSvDMTeqMkEPGM+ddsjaFXYXAya4YAbJYOva1onI3r74KGYaA4CEnrXPD1Ypa0OnAj 0LnAck1s1szj+Tq22FuTrjzNp6gu6oiQByiqqArdnzlQGOtqqzu2m8B0F+TkOWmdDi+bwb7DGJN Jw4eSfOfQkmInoDfIwgpI= X-Google-Smtp-Source: AGHT+IGcibiXjgN3pirHA6BiALCM8gpyUnD/IO4wpVviy21vWvLy9TTW9ZXgimz2WY8dDzOrXdKk2g== X-Received: by 2002:a17:902:d48f:b0:295:62d:5004 with SMTP id d9443c01a7336-29df5695ff4mr24346885ad.26.1765036534848; Sat, 06 Dec 2025 07:55:34 -0800 (PST) Received: from LilGuy ([2409:40c2:1158:3276:f6f5:8cbb:933c:2c2d]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-29dae49caa4sm80281445ad.15.2025.12.06.07.55.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Dec 2025 07:55:34 -0800 (PST) From: Swaraj Gaikwad To: David Hildenbrand , Oscar Salvador , Andrew Morton , linux-mm@kvack.org (open list:MEMORY HOT(UN)PLUG), linux-kernel@vger.kernel.org (open list) Cc: skhan@linuxfoundation.org, david.hunter.linux@gmail.com, Swaraj Gaikwad Subject: [PATCH] mm/memory_hotplug: Cache auto_movable stats to optimize online check Date: Sat, 6 Dec 2025 21:25:06 +0000 Message-ID: <20251206212507.135503-1-swarajgaikwad1925@gmail.com> X-Mailer: git-send-email 2.52.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The auto_movable_can_online_movable() function currently walks all populated zones when nid =3D=3D NUMA_NO_NODE, Since adjust_present_page_count() is called every time memory is onlined/offlined and already updates present page counts, we can maintain cached global statistics that are updated incrementally. This eliminates the need to walk all zones for the NUMA_NO_NODE case. This patch introduces a static global_auto_movable_stats structure that caches kernel_early_pages and movable_pages counts. The cache is updated in adjust_present_page_count() whenever pages are onlined/offlined, and is read directly in auto_movable_can_online_movable() when nid =3D=3D NUMA_NO_NODE. Testing: Built and booted the kernel successfully. Ran the memory management test suite in tools/testing/selftests/mm/ with ./run_vmtests.sh - all tests passed. Signed-off-by: Swaraj Gaikwad --- mm/memory_hotplug.c | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c index 63b9d500ec6c..ba43edba8c92 100644 --- a/mm/memory_hotplug.c +++ b/mm/memory_hotplug.c @@ -50,6 +50,8 @@ enum { =20 static int memmap_mode __read_mostly =3D MEMMAP_ON_MEMORY_DISABLE; =20 +static struct auto_movable_stats global_auto_movable_stats; + static inline unsigned long memory_block_memmap_size(void) { return PHYS_PFN(memory_block_size_bytes()) * sizeof(struct page); @@ -851,9 +853,7 @@ static bool auto_movable_can_online_movable(int nid, st= ruct memory_group *group, =20 /* Walk all relevant zones and collect MOVABLE vs. KERNEL stats. */ if (nid =3D=3D NUMA_NO_NODE) { - /* TODO: cache values */ - for_each_populated_zone(zone) - auto_movable_stats_account_zone(&stats, zone); + stats =3D global_auto_movable_stats; } else { for (i =3D 0; i < MAX_NR_ZONES; i++) { pg_data_t *pgdat =3D NODE_DATA(nid); @@ -1071,12 +1071,13 @@ void adjust_present_page_count(struct page *page, s= truct memory_group *group, { struct zone *zone =3D page_zone(page); const bool movable =3D zone_idx(zone) =3D=3D ZONE_MOVABLE; + const bool early =3D early_section(__pfn_to_section(page_to_pfn(page))); =20 /* * We only support onlining/offlining/adding/removing of complete * memory blocks; therefore, either all is either early or hotplugged. */ - if (early_section(__pfn_to_section(page_to_pfn(page)))) + if (early) zone->present_early_pages +=3D nr_pages; zone->present_pages +=3D nr_pages; zone->zone_pgdat->node_present_pages +=3D nr_pages; @@ -1085,6 +1086,12 @@ void adjust_present_page_count(struct page *page, st= ruct memory_group *group, group->present_movable_pages +=3D nr_pages; else if (group && !movable) group->present_kernel_pages +=3D nr_pages; + + if (movable) { + global_auto_movable_stats.movable_pages +=3D nr_pages; + } else if (early) { + global_auto_movable_stats.kernel_early_pages +=3D nr_pages; + } } =20 int mhp_init_memmap_on_memory(unsigned long pfn, unsigned long nr_pages, base-commit: 3cfeff1d2304237b1c14628d695a6df44daff48f --=20 2.52.0