From nobody Fri Dec 19 13:24:57 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 91B9A2F7AA7 for ; Sat, 6 Dec 2025 13:39:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765028342; cv=none; b=Xfa2jIZaYVhXxEEZsIjH95F0r47I/bdF5RdNA3F2GfWl+uuAIKPCUYPe/yGw6dytckXPmW+1OWf+e1742e4iuhDM7vH2D3ZHa+9SwXGX3Q06Cyc5dbaiVHvaSlmP1JYtG2DJCzgZ7eLANxvz6vbw+2ffwaAjbU2C/32KGQiItGg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765028342; c=relaxed/simple; bh=b5IgoR0twCWiviYQH3Grz/xTbzraoHaR2KLRP76V/zk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=uFh89qSYeEE1q56707qSx/v5tovYLNNnjUz4NhdRytNtp6vrOx4tVrbrmXKhzCRvtcDXUiXhqt0EAJ00Yj8AZLnd7fyn3l480gE0AQ1/qkLJsJM7EEM1k/uJvPz7XiMDeuyF/cz6NAIDL/W+B9fvzJ/S1IWxycEkHZ4G0glj/2k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Frudjgt9; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=btq2+SjZ; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Frudjgt9"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="btq2+SjZ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1765028339; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=QC70i/lfryfDMLlz9PR/W22hsTXwtyfjKxX5Z38dT/M=; b=Frudjgt9YD3pWx2g7yGjnsA09Y90Tf0Q5xReBTcFSrUW5MW9hcnXgKmbGrFWc8A3c/w4iQ kPvuFLB7Igl/vF/EfIy2VcWhu8g6W3pUbj2qdbcinNd+G91DgMQsX7a4gO8vlfjCUn25NC I3xobSCKSDuqO1HaEpItaotRW+u+Whc= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-342-WEy1OZ83MEueIvhGlzg0fQ-1; Sat, 06 Dec 2025 08:38:58 -0500 X-MC-Unique: WEy1OZ83MEueIvhGlzg0fQ-1 X-Mimecast-MFC-AGG-ID: WEy1OZ83MEueIvhGlzg0fQ_1765028337 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-477cf2230c8so25433775e9.0 for ; Sat, 06 Dec 2025 05:38:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1765028336; x=1765633136; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=QC70i/lfryfDMLlz9PR/W22hsTXwtyfjKxX5Z38dT/M=; b=btq2+SjZ+uC+G1apbKz0GX0QRdIT370gNYJJoAYzhyMk9mQMwRJ7he3qXF7iDrJ+MI 7kRATb7PkJg7+g/C4PaKJWM29ozNfrfm/yf4wqrZWmx+gw1uAff0PyYwKSncqek80Bze 7++iAc3gzAI2bB5wS7sziql0rQeVMOaAd4vp9yHKnurcqIz4peQFjAUZxcUcz0t4J6XB ZOZS8gC+DrCJuZk9+UWqwCf6sxMOSPZPJFO6mC4gfzgx3JJo6AVlnenYvmdiFeldpI5n 0CxHK1U8Sf2Su0NSb3K1nLahP7L5X22KTV0KHrOjjI3D6OfJilYkYnmUyhVx5NlWB0YS Thzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765028336; x=1765633136; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QC70i/lfryfDMLlz9PR/W22hsTXwtyfjKxX5Z38dT/M=; b=LW/qbL8/1461rZ4U0AlZm0xiN6SdyrtO/lagOeAzalDjrlDIlGNLycD1ugA99p/2hc zCdWQLhYT4+sAFgPP4+sxJgAbZgB+0khVAOJdirnT2j7h819C0HPY/DzzOf3TUVzUias +8pQ0XQev0kgC38MJl0nEGKH9kfvvfucIC5/4c6D+0NMOB2za/KwsJ5g72iUV6auzqbG 2mXQ3NwT4IRQWFFZUGJHjIksbEa2PvpsejnnvcspFtPMEUYiqFw+tmMscw1p1C+g0Zyy cJIN8AkBayY+Tu0r0iTXGhmI9Bs7PplTGCGQ8glsMWhVY4iIy3KZ4BEVJdjT2P7hiUL9 Nkvw== X-Gm-Message-State: AOJu0YwLHcq1uGX1/GuXDkoz9VwTtjkTn9D96PYZC6XLV/breBOU2Avz y5v3dLlnjMhiEn0iI5uusZ3J30f1MB25E6ARBZfR49b52WVphxvOHoAKENCTs8QwvBtHwE/tlw4 xoi40q+8M7mOxKxcN4X0QoV1fGiLSP3QRlsQKSO38tAG1vYu67nu5iRSU2p1FZLEhI4F6MhlWvn RVKCHpULr4S7QZ54Qk9ebv4sv7rDz9/0xCxCPHMkOC+QcxORb4 X-Gm-Gg: ASbGncu9voy+saGzWBoMY/xC41cjah9bMaXDUsqgUBSiiudlqYdQ5pUerh4C0478+02 +zW9AWtVPGKa6L3hnqJwFZgRSo9DkjOLPrl7GGmZeOFYl/G6s1eOqMVHPwcYaQz12FM7zVenxvT b5/FbUBdYeJCAh8liopM4ycIrhib+YOpF8NqVO2VxoI63ccfvToj/22WM7lC6rEuWttvTj8NYyf qf91aeGNg3JFdrjrUWy7CEIpGUQNqcafYUR1rBRmJRPWinBqUxIr/+rbvNHmTNnycIK1JKbCtqy h0kKcYwEevMH9FucqZLptNu4sE4ID/K92S4/pViHtPkk/AP+wYQdLWsVL5JkMplBUSiB5r0iShj 3ZFhtMKMEeK9Hh1tXigv5dR2oI+8uJtqldF0= X-Received: by 2002:a05:600c:1e28:b0:477:7a53:f493 with SMTP id 5b1f17b1804b1-47939e38284mr26973585e9.23.1765028336603; Sat, 06 Dec 2025 05:38:56 -0800 (PST) X-Google-Smtp-Source: AGHT+IHt+JYoskz9q0dOZUvI2zbL7PpqoIgzpl9VZcFu80JojTUue0FS/d/Bo0yeWUR73XDazyVsPw== X-Received: by 2002:a05:600c:1e28:b0:477:7a53:f493 with SMTP id 5b1f17b1804b1-47939e38284mr26973345e9.23.1765028336171; Sat, 06 Dec 2025 05:38:56 -0800 (PST) Received: from localhost (62-151-111-63.jazzfree.ya.com. [62.151.111.63]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42f7cbfeae9sm15157012f8f.13.2025.12.06.05.38.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Dec 2025 05:38:55 -0800 (PST) From: Javier Martinez Canillas To: linux-kernel@vger.kernel.org Cc: Alex Elder , Javier Martinez Canillas , Liam Girdwood , Mark Brown , Yixun Lan , linux-riscv@lists.infradead.org, spacemit@lists.linux.dev Subject: [PATCH] regulator: spacemit: Align input supply name with the DT binding Date: Sat, 6 Dec 2025 14:38:48 +0100 Message-ID: <20251206133852.1739475-1-javierm@redhat.com> X-Mailer: git-send-email 2.52.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The Device Tree binding schema for the SpacemiT P1 PMIC defines the main input supply property as "vin-supply", but the driver defines the supply name for BUCK and ALDO regulators as "vcc". This causes the regulator core to lookup for a non-existent "vcc-supply". Rename the supply from "vcc" to "vin", to match the DT binding and ensure that the regulators input supplies are correctly resolved. After this change, the regulators supply hierarchy is correctly reported: $ cat /sys/kernel/debug/regulator/regulator_summary regulator use open bypass opmode voltage current = min max -------------------------------------------------------------------------= -------------- regulator-dummy 1 0 0 unknown 0mV 0mA = 0mV 0mV dc_in_12v 2 1 0 unknown 12000mV 0mA 1= 2000mV 12000mV vcc_4v 7 10 0 unknown 4000mV 0mA = 4000mV 4000mV buck1 1 0 0 unknown 1050mV 0mA = 500mV 3425mV buck2 1 0 0 unknown 900mV 0mA = 500mV 3425mV buck3 1 0 0 unknown 1800mV 0mA = 500mV 1800mV buck4 1 0 0 unknown 3300mV 0mA = 500mV 3300mV buck5 3 7 0 unknown 2100mV 0mA = 500mV 3425mV dldo1 0 0 0 unknown 1200mV 0mA = 500mV 3125mV dldo2 0 0 0 unknown 500mV 0mA = 500mV 3125mV dldo3 0 0 0 unknown 500mV 0mA = 500mV 3125mV dldo4 1 0 0 unknown 1800mV 0mA = 500mV 3125mV dldo5 0 0 0 unknown 500mV 0mA = 500mV 3125mV dldo6 1 0 0 unknown 1800mV 0mA = 500mV 3125mV dldo7 0 0 0 unknown 500mV 0mA = 500mV 3125mV buck6 1 0 0 unknown 1100mV 0mA = 500mV 3425mV aldo1 0 0 0 unknown 1800mV 0mA = 500mV 3125mV aldo2 0 0 0 unknown 500mV 0mA = 500mV 3125mV aldo3 0 0 0 unknown 500mV 0mA = 500mV 3125mV aldo4 0 0 0 unknown 500mV 0mA = 500mV 3125mV Fixes: 8b84d712ad84 ("regulator: spacemit: support SpacemiT P1 regulators") Signed-off-by: Javier Martinez Canillas --- drivers/regulator/spacemit-p1.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/regulator/spacemit-p1.c b/drivers/regulator/spacemit-p= 1.c index d437e6738ea1..2bf9137e12b1 100644 --- a/drivers/regulator/spacemit-p1.c +++ b/drivers/regulator/spacemit-p1.c @@ -87,10 +87,10 @@ static const struct linear_range p1_ldo_ranges[] =3D { } =20 #define P1_BUCK_DESC(_n) \ - P1_REG_DESC(BUCK, buck, _n, "vcc", 0x47, BUCK_MASK, 254, p1_buck_ranges) + P1_REG_DESC(BUCK, buck, _n, "vin", 0x47, BUCK_MASK, 254, p1_buck_ranges) =20 #define P1_ALDO_DESC(_n) \ - P1_REG_DESC(ALDO, aldo, _n, "vcc", 0x5b, LDO_MASK, 117, p1_ldo_ranges) + P1_REG_DESC(ALDO, aldo, _n, "vin", 0x5b, LDO_MASK, 117, p1_ldo_ranges) =20 #define P1_DLDO_DESC(_n) \ P1_REG_DESC(DLDO, dldo, _n, "buck5", 0x67, LDO_MASK, 117, p1_ldo_ranges) --=20 2.52.0 base-commit: 2cf7bc86f10d99b72707b1c1c654f78b103f2105 branch: milkv-jupiter-fix-reg-driver