From nobody Fri Dec 19 13:31:37 2025 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 765B213B284 for ; Sat, 6 Dec 2025 03:53:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764993224; cv=none; b=bC5iDST9kVbgpLeBO+wYbWW048UOy868Fr+Q6BBMj5qck8/FKfhcktSMlRdYyju1spBjbJa9qUb44P+gckL8xFwgy4ySpngO3nznOsxFdgicPdRrNvbMkhoywj+7sTzcxlfciPcsLBX12vFAbfy0uQ3+lthljQKZOjDUVcZ2tEk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764993224; c=relaxed/simple; bh=e88JmBFGImF+bgRumpfD8s9T66tebIKlmD57rN2GFO4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=czEZw6BYhdWnd5uIpvw7l31XSyU/jipkVAMErN1Ispg1Hk66cjF2kXEeu6g44Qwu3d95vQ8/TsdXkOYxcselzkjRbz9STAm5Mzov2Na7mRwS2ij3xrzoW6h5JmRGIPCj7DyKkEYNOuoIxQkFxNwz/FkIG1ln0SuJ+PmouCcWD7k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=c6sk1mhl; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="c6sk1mhl" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-297d4ac44fbso21184075ad.0 for ; Fri, 05 Dec 2025 19:53:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764993223; x=1765598023; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=xp4habiAbNow2Q2nLJqK4WvF0gGCPqnNUANZfkwc1F8=; b=c6sk1mhl7uuwt8hY/OX1fFbOhBt+R9Ftg4UdxmGxTh+Ahl9go5JnTSnPzApA4IRgvR UXAUMDMdGiOvmnbjSyzCYom5zNopmAf/YCTHBQrdJNm7NszGsiQGflWJc+AWptK/y9GI HzNUTwqB021EJzpmJw6QRE/oEN4++Jt0mtL87J/9KyIdDUjMxMAi4D0MRTlWGdqwWMDH +lqdj5rVipSA4Pg0MeoKm5L/y+DGDiWWxAl1RZ87v5x+GKX56379WbXpGoUDsZRbhHTX aeO0XNkoLPdPvEcbVPo0GB3uXodwP7UASmGLRhDcTSryNGfRKzw1nAjLg4Q9XWaBTL0f JqmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764993223; x=1765598023; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xp4habiAbNow2Q2nLJqK4WvF0gGCPqnNUANZfkwc1F8=; b=mlbxbcDuoCPIQVtUiTYxkaUYoTZtHLh68zj1cHpj3yp/0rlom5Zd/1YLtDZEBgvIBv SdzO7g2wfhogyI0i1xXLglATNb53WSQsgtY+PqiXPvbMUkL8Ew8LfnkE3G4keY2sbEM2 4drIiJjHmveAtvkTdv5lCJmg9c0fTycYFxL6dVXxIACkZvV52ITx6zwU3Ga5TM7gbpBx Ui0nYYv8syrS+nEsg9R52BU5g3qX0OrB5o7phcXT51sGVPV8NnpK2TrvdPFQZrUG3ZDi Q4bpB9feXxmEHLZQwOFwdN6BrNR9DoJfDKK8LbSda0lCXtJBUtE+6rU9SKZgKn2At+0S 7NEA== X-Forwarded-Encrypted: i=1; AJvYcCV4AL4WWbhFQ9Ac5M0QE84Sa/NhmS3r/TcY5iKGSPpGjbhw6I3+D8hGyw8OPnepCW4QamVnwZO1/1aPezU=@vger.kernel.org X-Gm-Message-State: AOJu0Yx6a7/NOhaQu/PBqtP659r/WMQm4Lxr0hBVzm2fL+MSv+2xnIgY rXIM6Us1hNwQdDu5nIZhqB/iXp8udNOXLWfqMFA8uVV75fcIynzRG6TaNzDUIA== X-Gm-Gg: ASbGncsLnD8P5s9ioWjYQcN9RjPjWF9DBPa+KzsPFT20UvjwADssPxTgUFq5flMvejD Kjg7lQr+JffsLY6VUUWHOL6oxCgZ31fGvJu07/siZ1mr5LRoaLrSE8lc7nVDFOb7NQR983Q0D9s rsDdBK0Y00pYtRXrtWY3cp7ZCYYGDlZO731D5NgsBu+/G1REAW6Q5iLNtiKxBiNnevxF63axzxn hHAZTquJZd8gdmA+9nuayri8wj9kzHJRpJ8FMakAv2hoOo57MPeBWc1z3wkzDHB0QbWSZKUrLVF wqMmFog0b+pklTAunqBMaHsTfPgMR2JgPSqJnljWfoGrm/0D9b2qdNq1LfJlRid3DMJVUL3644G RUgSQrsQaQIhXDjQ/zaOBAJiF4WhUpQmRgqvAxXJnK5BscJMY5aD1Gsxh3j5uzv98A7o+EBc4kV /GEaiB9MMdI5YG6nxL5QTZccW+7Qj4TK0Q+mzcGtUwfg== X-Google-Smtp-Source: AGHT+IECHCzvg2dPpQMNfR3Ad6XNxcN8LiBrxGsedR08VJUQWMTAG662Cl4arK396Ch6yaQqZcEyew== X-Received: by 2002:a17:902:c946:b0:267:8b4f:df36 with SMTP id d9443c01a7336-29d9eda6c2fmr113818695ad.29.1764993222583; Fri, 05 Dec 2025 19:53:42 -0800 (PST) Received: from localhost.localdomain ([103.98.63.195]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29daeaabf5fsm61995125ad.78.2025.12.05.19.53.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Dec 2025 19:53:42 -0800 (PST) From: Dharanitharan R To: Miquel Raynal , Richard Weinberger , Vignesh Raghavendra Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Dharanitharan R Subject: [PATCH v1] mtd: sm_ftl: use strscpy() in sm_attr_show() Date: Sat, 6 Dec 2025 03:53:13 +0000 Message-ID: <20251206035313.10190-1-dharanitharan725@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In sm_ftl.c, the sm_attr_show() function currently copies attribute data using: strncpy(buf, sm_attr->data, sm_attr->len); return sm_attr->len; Using strncpy() can be unsafe because it does not guarantee a NUL terminator if the source length equals the buffer size. Although sm_attr->data comes from internal structures and is NUL-terminated, it is cleaner and safer to use strscpy(), which guarantees NUL termination and avoids zero-padding. The destination buffer is PAGE_SIZE bytes, which is sufficient to hold sm_attr->data without truncation. The return value of strscpy() matches the expected behavior of sm_attr_show(). Replace the strncpy() call with: return strscpy(buf, sm_attr->data, PAGE_SIZE); Signed-off-by: Dharanitharan R --- drivers/mtd/sm_ftl.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/mtd/sm_ftl.c b/drivers/mtd/sm_ftl.c index abc7b186353f..229fdc4a754a 100644 --- a/drivers/mtd/sm_ftl.c +++ b/drivers/mtd/sm_ftl.c @@ -44,8 +44,7 @@ static ssize_t sm_attr_show(struct device *dev, struct de= vice_attribute *attr, struct sm_sysfs_attribute *sm_attr =3D container_of(attr, struct sm_sysfs_attribute, dev_attr); =20 - strncpy(buf, sm_attr->data, sm_attr->len); - return sm_attr->len; + return strscpy(buf, sm_attr->data, PAGE_SIZE); } =20 =20 --=20 2.43.0