From nobody Tue Dec 16 14:49:54 2025 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0D8192DCF46 for ; Fri, 5 Dec 2025 20:28:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764966505; cv=none; b=I1VwAgyQnvKXFUVdG/aSs4gA4w1eZ5DbBL/eqpUQJtjBMB4V7EtlL+L8LvhLlaGTKoX2CClhIcBg84PQEbVTZ/FH1tDQtpNv+2ll0mlpMXMsGyumZ7jolAgwPEfecdHlKSSfPhCw7dR3hOPokqPiVL0aVeoj40cDo9ZjJlbGszs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764966505; c=relaxed/simple; bh=VhjRdW4KfUHyNC/C+mtuazEPEEU4C1nG1wSKWcNKCz8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=u5R6gHAm6whbuNKEmU/9sp3gtT0dFlfJydzXakcTuH/0MAlcIkjd5k55L95+uE6Z2Y8qwXlUs0HTjx30aqrcDuTBpXPJrO2a82zW80DFP3WkaB4ToLqiH8iovcw07ZYfguZisUEzbg/QggDjZX6NK+RvwnhUiyqbE+8Ez4AG6Dc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MKn1o3tU; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MKn1o3tU" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-29568d93e87so25668725ad.2 for ; Fri, 05 Dec 2025 12:28:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764966502; x=1765571302; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=E1kT6K3Ob3aEghOazhmPBd7i4Md15BQDt3Jsih2JLy4=; b=MKn1o3tUnHf9twNB9HPSWc72dHvYzvEZMSPZXLxM5ktt1RAM41qAwCqwxXhlebs4Ua 2WzKVwjK4gnZYZ9e+DIURGJu3+tUZXvcwhFdML7bZ8z6nlfkU+9Fbp1ubJfxPf6OYQ9z JeN38YGOB7XOYh7TM9m9GkhKFTQZqX8yWUlT0kX992xjHPeRadtGqsqNbvnHgPbdjrYD dLx55JDxe+nJiklEk0yA0RzMKLx8tzMpIiEDWC4oMgzlv/H7kfaoDgFXdqTRApxemIn+ mMwuYcCMPgIjEKBTZMklSXLAPRWNOD6K95SbBph6c+XKJbzajGvBI5p5zVvof40/ESLp YWlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764966502; x=1765571302; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=E1kT6K3Ob3aEghOazhmPBd7i4Md15BQDt3Jsih2JLy4=; b=ggcNBaycOe9gcxi9YdDHWdVOcGYltXuXzIMYk+NImB5CFMEv806UHut1wTDZiHilk5 2oNmuFHIDmqqHLfl1SaTpFt1eB9+aPQ9aRKU5UoZ6tv6UXrTAz9TG2WdYOGUTBHPgTG6 foXLO4pAO4PyCr7RIdGcifvhoQ/DMKCDR4d7wrLPnQAUU9eyZWG/v208HxBx2Fp5hfc2 +xQr8JDXrZVZmeMsISLRDU8dXjAx0jRlxkT+iO9/nh2bN7nb7YYdMti4jhCX9f7HdLSf Yrs8AiN/Hw6J9ZLV0uZy6lCPcFjaaLw51pWaM/Z2Jp+YrcIeLjaR2g2j9uRIR8QPtPC4 KVPA== X-Forwarded-Encrypted: i=1; AJvYcCUUpsGtEfRjX62YS2pETnL0fkEyvY5kv/eXKHzhtbJ3IAxwk8ciOpSbvNdkUiIfmnNdjX6ryhlA/vJaycM=@vger.kernel.org X-Gm-Message-State: AOJu0YwHvLtaLlrcinwj0QhZTRpt+7UtXnNavttgF57VTllc75Ff1JNX PVQDd60E2BfP+zkuHqWEnsJkLo5fKhqP5NHQkhd6sH8NxR8vCiXP7+my X-Gm-Gg: ASbGncuZOmLdzBOYRj0nrcjyQkTA2b1VmwQavmM3X9kaxhOW9l3RXoa/IKI2Oq2MwMO NDxAMh1oMQoOvABqv1ztBR9F/glKmh0Ck7ksdOFvgMI9gnY/0Qpu0YWfj0G1Epf5chzRm3gMDGf Db/cpIhVFLvVK1Y4TRL2nbC1Z7I/F4oJXHDU60uH4ZghR86Nn87DJ2LKEsqzYtYPa+SX0JCIEnH NDmiYrdF1Fy1wAdd9f0kICQJ0x3DMj/TyaTHRv22pMpcgy33wriK1JkxDAWueSu4awKL4XyK2y+ KAgcYA3qNdmcj4zW5/X/IuMkoawLWkLMq1BnRJrRbSAE6FRc/Wt3vraoHxfqD3b+E1YJCUA0eTM oKjjB3eZhTvTpc8/2cJnUYcsQWWau8nzIhv2ZIpigdDB3jqez0dE4pdN669D/asdKbbZ2aS95Ge QTsb+uVZEaWncgQ1cbvCYbvGt/X6xuKNtxsZ2Vo9BDJsvKAVOFyU0sPhormX3zd3dsuS40v2zbn LkGTbL6V+Gzcz/FhGtoOtKtvDRsBj+zDVmNI0br8uWSRGEwQdez7InezBQhTczcyOCjRN18 X-Google-Smtp-Source: AGHT+IFTMT5Gqt3zxUUZz4Uief0KidTbdHtVVj8Bdg+zDGW3adOU9RZX8JRZKLTJtpJNPMg3XEQQqQ== X-Received: by 2002:a17:902:e783:b0:296:3f23:b93b with SMTP id d9443c01a7336-29df5a9d23fmr1726475ad.2.1764966502353; Fri, 05 Dec 2025 12:28:22 -0800 (PST) Received: from Lewboski.localdomain ([181.191.143.42]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29dae99fa59sm57256845ad.58.2025.12.05.12.28.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Dec 2025 12:28:22 -0800 (PST) From: Tomas Borquez To: Jonathan Cameron , Lars-Peter Clausen , Michael Hennerich , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Greg Kroah-Hartman Cc: David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, Tomas Borquez Subject: [RFC PATCH 1/3] staging: iio: ad9832: remove platform_data support Date: Fri, 5 Dec 2025 17:27:41 -0300 Message-ID: <20251205202743.10530-2-tomasborquez13@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251205202743.10530-1-tomasborquez13@gmail.com> References: <20251205202743.10530-1-tomasborquez13@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove legacy platform_data support as there are no in tree users and this approach belongs to a long gone era. The policy decision on what to output is a userspace problem, not something that should be provided from firmware. The driver now initializes the device to a safe state (SLEEP|RESET|CLR) outputting nothing. Userspace can configure the desired frequencies and phases via the existing sysfs attributes once the device is ready to be=20 used. Original discussion started here [1]. Link: https://lore.kernel.org/linux-iio/20250628161040.3d21e2c4@jic23-huawe= i/ [1] Suggested-by: Jonathan Cameron Signed-off-by: Tomas Borquez Reviewed-by: Andy Shevchenko --- drivers/staging/iio/frequency/ad9832.c | 32 ------------------------- drivers/staging/iio/frequency/ad9832.h | 33 -------------------------- 2 files changed, 65 deletions(-) delete mode 100644 drivers/staging/iio/frequency/ad9832.h diff --git a/drivers/staging/iio/frequency/ad9832.c b/drivers/staging/iio/f= requency/ad9832.c index 49388da5a6..e2ad3e5a7a 100644 --- a/drivers/staging/iio/frequency/ad9832.c +++ b/drivers/staging/iio/frequency/ad9832.c @@ -23,8 +23,6 @@ #include #include =20 -#include "ad9832.h" - #include "dds.h" =20 /* Registers */ @@ -299,16 +297,10 @@ static const struct iio_info ad9832_info =3D { =20 static int ad9832_probe(struct spi_device *spi) { - struct ad9832_platform_data *pdata =3D dev_get_platdata(&spi->dev); struct iio_dev *indio_dev; struct ad9832_state *st; int ret; =20 - if (!pdata) { - dev_dbg(&spi->dev, "no platform data?\n"); - return -ENODEV; - } - indio_dev =3D devm_iio_device_alloc(&spi->dev, sizeof(*st)); if (!indio_dev) return -ENOMEM; @@ -379,30 +371,6 @@ static int ad9832_probe(struct spi_device *spi) return ret; } =20 - ret =3D ad9832_write_frequency(st, AD9832_FREQ0HM, pdata->freq0); - if (ret) - return ret; - - ret =3D ad9832_write_frequency(st, AD9832_FREQ1HM, pdata->freq1); - if (ret) - return ret; - - ret =3D ad9832_write_phase(st, AD9832_PHASE0H, pdata->phase0); - if (ret) - return ret; - - ret =3D ad9832_write_phase(st, AD9832_PHASE1H, pdata->phase1); - if (ret) - return ret; - - ret =3D ad9832_write_phase(st, AD9832_PHASE2H, pdata->phase2); - if (ret) - return ret; - - ret =3D ad9832_write_phase(st, AD9832_PHASE3H, pdata->phase3); - if (ret) - return ret; - return devm_iio_device_register(&spi->dev, indio_dev); } =20 diff --git a/drivers/staging/iio/frequency/ad9832.h b/drivers/staging/iio/f= requency/ad9832.h deleted file mode 100644 index d0d840edb8..0000000000 --- a/drivers/staging/iio/frequency/ad9832.h +++ /dev/null @@ -1,33 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0+ */ -/* - * AD9832 SPI DDS driver - * - * Copyright 2011 Analog Devices Inc. - */ -#ifndef IIO_DDS_AD9832_H_ -#define IIO_DDS_AD9832_H_ - -/* - * TODO: struct ad9832_platform_data needs to go into include/linux/iio - */ - -/** - * struct ad9832_platform_data - platform specific information - * @freq0: power up freq0 tuning word in Hz - * @freq1: power up freq1 tuning word in Hz - * @phase0: power up phase0 value [0..4095] correlates with 0..2PI - * @phase1: power up phase1 value [0..4095] correlates with 0..2PI - * @phase2: power up phase2 value [0..4095] correlates with 0..2PI - * @phase3: power up phase3 value [0..4095] correlates with 0..2PI - */ - -struct ad9832_platform_data { - unsigned long freq0; - unsigned long freq1; - unsigned short phase0; - unsigned short phase1; - unsigned short phase2; - unsigned short phase3; -}; - -#endif /* IIO_DDS_AD9832_H_ */ --=20 2.43.0