From nobody Tue Dec 16 07:33:20 2025 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B04413B8D77 for ; Fri, 5 Dec 2025 19:01:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764961316; cv=none; b=J/Z5cCSJSkJ3Fx+ITEXSKrTVPb6hGLatJT5c6/wdFIaJK4Br8UiU2IfSDefr9IAdCPtQpYirQTTcsZMyxBZFx7gLMm+Mye5Wi65/NtlGNOjquAxaO90YZqY9sOaCLgb53cbPnCAnhDWzfg0OgrljqQHJNs+Vs64lKwLAMmBsDEQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764961316; c=relaxed/simple; bh=BZ40Qr+VCK0a19X541gPydfySH8VknjOkzRAW0odqYE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=kJj7wfk1uECbPh81VDUYWdkEB1mJXmF6ttFIEPyfq0xnLV6KJXwnPps44iiN4yhQMXBrkxAqC7UD8km9WcQsnd25msHqgyr+R2p2jPSQBDCxdO0SqLQE3RUVNGcoV8cGkZ+1WmkbCRlCpRmB+MXnswq4r74wVcU4oc1w9MvJblc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IWJfVcLN; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IWJfVcLN" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-29853ec5b8cso31589145ad.3 for ; Fri, 05 Dec 2025 11:01:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764961314; x=1765566114; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=UVgkDGLlp+gBx2zQWaI190FEJKwlN+nT2HtV4xsm0D8=; b=IWJfVcLNAk0oU6vj4UyzrjoT0XuUC4vH4IGmhLrT/Zcg9Onsu6oiawZ7p8oeK/8N6Z 5mVQUXJSRdEuLJs1YVPxtrESAfhIxMY4J/4ytps5jTJfqanQmQxcuGkd8xBRBroZ5hwR 5XKmY6/H3mytooukvatMlL8yrstILNsuNEzCCh/YARsNk9zuvi9b7mxuvjTb2xeaXqxP cYtiWjL6opqLgG87hPSAX3d4OaooXxEWsuNHlzDPYsSLVA27UgmObBowtgTOk/HVsOCv fY4VT8vDgd2f5gwUpvb+oygQd4XWUg+qlKa4lPfXCrD5ZTHjp06krPWiRFaYrqXtc9c3 7p1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764961314; x=1765566114; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UVgkDGLlp+gBx2zQWaI190FEJKwlN+nT2HtV4xsm0D8=; b=e+IfY758W9esMkC1E4h/imL79ddtX9wsfbyCz2tOXPWwXPIYxYBEJVl88v0ne4L4E8 wGAe4rf5DKL6bEjI99vUo7Xl8cww7Q4MZy/2UDG6ST7eIBHGJ9oA9sizl4bOTxLXJzWu 13eMd7PXbh/SYei2m+FxFAKMkYsjr5LCm7CoIzTmT3GUmaKPe8Ajj3xVV3ETS7e+im8Z ASqiFSjIpoGBao/g1g6zmWxeg9FU2uq+3YYm3aS0qEDJSdiAZ1LfPvhc3mXeSNJz+V5V tuCer8tojBwHM5mQAlLyQZ3qbrp0/syuWOmSg7B1H9Hrgn40SC1gDcS7ED9U1CJg88c9 H9uQ== X-Gm-Message-State: AOJu0YxUuzYrLQ92UTKMZQy9pjQgimjcMqd4xG8D/z6UA+N7+AI4x8ET XFijSl7PWBuvM6BDI18rNqmccdQSrfZp8Zia5jqDjPeHN4tBl5sp/TLeYuxUKQ== X-Gm-Gg: ASbGncu0HOmgzZfX9y+iQgisMj3J38v+dcVbpE8yZq0h1kL06M/4qmhAISx37nX3WO+ LHNUxkW3ytFjYmthJosi4131r59D52lqjyxK98IPHdb4pdXwYdKxIn84rfU7yQHD+JTvqBhKR/R fDCwpZXmJbWgn4rOzyjEr5hs3nlrYy8+y4dvh58BagdBtOGrwEZwK3n8L8bD2hYoSNc/N2SoPC0 HKc9gig9TwI7/nnYifA2jpLa2cJt6O3RF29ihwt2woyG+2PUKSIb+4Ul2bywegu3HUyUUe45Zq8 vnfn4UWUY5g6N1SzTo+DkGefMhLylZA2T9Vnm6C0abcWMMzdAPLwN1TxCwObCHtpQxrPhYt2ptZ +gkerLWrZVwYAFxhTShLrkrRoxrEq4GQFNM0H5mE0REkkr7AvN6cIweXFbU3iYw2OCxjn5+2Ue6 P2CXf7ulWVYOTrkHo= X-Google-Smtp-Source: AGHT+IFzR53Ern/nINk3emm3RcXTvAQL5FcoDjTxvSgQk/Qa1f6BD8l6sskfhvqR/S4xbTIA0lp9rA== X-Received: by 2002:a17:903:1b65:b0:295:5668:2f2e with SMTP id d9443c01a7336-29df5da6e4dmr92405ad.37.1764961313822; Fri, 05 Dec 2025 11:01:53 -0800 (PST) Received: from gmail.com ([2402:e280:3e9b:22f:e515:8350:8116:2469]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29dae4eed2csm55183075ad.45.2025.12.05.11.01.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Dec 2025 11:01:53 -0800 (PST) From: Sumeet Pawnikar To: rafael@kernel.org, inux-pm@vger.kernel.org Cc: linux-kernel@vger.kernel.org, sumeet4linux@gmail.com Subject: [PATCH] powercap: fix race condition in register_control_type Date: Sat, 6 Dec 2025 00:31:33 +0530 Message-ID: <20251205190134.5012-1-sumeet4linux@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The device becomes visible to userspace via device_register() even before it fully initialized by idr_init(). If userspace or another thread tries to register a zone immediately after device_register(), the control_type_valid() will fail because the control_type is not yet in the list. The IDR is not yet initialized, so this race condition causes zone registration failure. Move idr_init() and list addition before device_register() fix the race condition. Signed-off-by: Sumeet Pawnikar --- drivers/powercap/powercap_sys.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/drivers/powercap/powercap_sys.c b/drivers/powercap/powercap_sy= s.c index 4112a0097338..bdc65e040d17 100644 --- a/drivers/powercap/powercap_sys.c +++ b/drivers/powercap/powercap_sys.c @@ -625,17 +625,22 @@ struct powercap_control_type *powercap_register_contr= ol_type( INIT_LIST_HEAD(&control_type->node); control_type->dev.class =3D &powercap_class; dev_set_name(&control_type->dev, "%s", name); - result =3D device_register(&control_type->dev); - if (result) { - put_device(&control_type->dev); - return ERR_PTR(result); - } idr_init(&control_type->idr); =20 mutex_lock(&powercap_cntrl_list_lock); list_add_tail(&control_type->node, &powercap_cntrl_list); mutex_unlock(&powercap_cntrl_list_lock); =20 + result =3D device_register(&control_type->dev); + if (result) { + mutex_lock(&powercap_cntrl_list_lock); + list_del(&control_type->node); + mutex_unlock(&powercap_cntrl_list_lock); + idr_destroy(&control_type->idr); + put_device(&control_type->dev); + return ERR_PTR(result); + } + return control_type; } EXPORT_SYMBOL_GPL(powercap_register_control_type); --=20 2.43.0