From nobody Tue Dec 16 15:10:42 2025 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B6EAA319848; Fri, 5 Dec 2025 18:22:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764958959; cv=none; b=JwPAmtENWD/D2CtI2onOxye6j01S8pzmLhrJBFL3LmVVbDcvpX6UChuthDmR/XZK/5lhvIOWjMtRii0kyrsEN3FFcqpzIWvG+pdEGRyi++Vzhxme8Dp38zDIdB8xQEkkBFHUg6mad+Oddlz3MVhmbCQNcdJ421evRrArx6qkZVk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764958959; c=relaxed/simple; bh=YS8/vqBJoLcfbhBEgaog8sdplpPEafy556rfQqhGLYk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=O4H4/ZIhxLorhfCJbwsfbbs4OrayyYKu7uI1MRHyMj1B2gWoAKUXJlgtkYztoV6YC43nkCK9rlO68LADGUGDJFzYXOjlRGNPVEUWHd4DaGEh09RwjvJGB3CsvPxdEgpn0qcay2HI+siA9BVkgIHAo8pp0c90AKxScF2XOUaNLPc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=gJVyk8Gw; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="gJVyk8Gw" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1764958955; bh=YS8/vqBJoLcfbhBEgaog8sdplpPEafy556rfQqhGLYk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gJVyk8GwvhhWGI54AEpETBCfNvxuL9VMECU5vNSrm/yMQXGJV1gX41FydeCCopRib ioHw6GjLJkmPFw9zccEHJLrdlHlYRpcUUrDC2CoC90ofWBMi7WvhjICUUZrWwFVbHU hcWcKMB0ADfve5PF97EdkHoVtoWzPm/Jfmxp2Vw0Vnf6ao6g98tx8HfhJ8CWG5yFf0 Q7XMahxXIxOdD1+koHUm5Yk8mJT/2IMd0AGwObl1L8/ofN8/TEbyoVhcQq2xE0iSra oPW7sRdgdDowTSuY+S9wgABe7PCUj5uzC8V6kc+gClg3uAGVZ7L7Arl1Ar7j3krcOU gZB9rvJDz246w== Received: from debian-rockchip-rock5b-rk3588.. (unknown [IPv6:2a01:e0a:5e3:6100:826d:bc07:e98c:84a]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: loicmolinari) by bali.collaboradmins.com (Postfix) with ESMTPSA id 15C9017E1155; Fri, 5 Dec 2025 19:22:35 +0100 (CET) From: =?UTF-8?q?Lo=C3=AFc=20Molinari?= To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , Boris Brezillon , Rob Herring , Steven Price , Liviu Dudau , Melissa Wen , =?UTF-8?q?Ma=C3=ADra=20Canal?= , Hugh Dickins , Baolin Wang , Andrew Morton , =?UTF-8?q?Lo=C3=AFc=20Molinari?= , Al Viro , =?UTF-8?q?Miko=C5=82aj=20Wasiak?= , Christian Brauner , Nitin Gote , Andi Shyti , Jonathan Corbet , Christopher Healy , Matthew Wilcox , Bagas Sanjaya Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, kernel@collabora.com Subject: [PATCH v13 01/10] drm/shmem-helper: Simplify page offset calculation in fault handler Date: Fri, 5 Dec 2025 19:22:22 +0100 Message-ID: <20251205182231.194072-2-loic.molinari@collabora.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251205182231.194072-1-loic.molinari@collabora.com> References: <20251205182231.194072-1-loic.molinari@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable For a fault at address addr, the page offset is page_offset =3D (vmf->address - vma->vm_start) >> PAGE_SHIFT =3D ((addr & PAGE_MASK) - vma->vm_start) >> PAGE_SHIFT =3D (addr - vma->vm_start) >> PAGE_SHIFT Since the faulty logical page offset based on VMA is vmf->pgoff =3D vma->vm_pgoff + ((addr - vma->vm_start) >> PAGE_SHIFT) We can slightly simplify the calculation using page_offset =3D vmf->pgoff - vma->vm_pgoff v11: - remove misleading comment - add Boris R-b Signed-off-by: Lo=C3=AFc Molinari Reviewed-by: Boris Brezillon --- drivers/gpu/drm/drm_gem_shmem_helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_gem_shmem_helper.c b/drivers/gpu/drm/drm_g= em_shmem_helper.c index dc94a27710e5..e47ab3ebb5c2 100644 --- a/drivers/gpu/drm/drm_gem_shmem_helper.c +++ b/drivers/gpu/drm/drm_gem_shmem_helper.c @@ -577,8 +577,8 @@ static vm_fault_t drm_gem_shmem_fault(struct vm_fault *= vmf) struct page *page; pgoff_t page_offset; =20 - /* We don't use vmf->pgoff since that has the fake offset */ - page_offset =3D (vmf->address - vma->vm_start) >> PAGE_SHIFT; + /* Offset to faulty address in the VMA. */ + page_offset =3D vmf->pgoff - vma->vm_pgoff; =20 dma_resv_lock(shmem->base.resv, NULL); =20 --=20 2.47.3