From nobody Fri Dec 19 15:00:26 2025 Received: from mail-lj1-f176.google.com (mail-lj1-f176.google.com [209.85.208.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A682311C1D for ; Fri, 5 Dec 2025 15:59:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764950367; cv=none; b=JAKHmgFypjJk5PpkezrGwS7iLGn9a9aTtvVD4D5jsfaa6v6PAg3rsEAFKQGpAGGTHJ7wlS/XtrdlhgYoiHDy7OMlbT39WKrkC4EU828/JG6QlIcZN0t4lBmIoLZc8jFpCOVbkVzQ+ePWdp0WRDsU7Z3EdDAgPdgOO1Hfz/JM+zs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764950367; c=relaxed/simple; bh=fMkh/+GORKDOO8v8Ui/IcVECRqz4+4A7C8qVk+4Iogk=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=W/CJca1L0YHLDMDCGMU4Xoi45IKmR9N2eY+8K96qguqd7LsC57+mrACHRiHk00smLt8Jr3J8S4JnpXF97/94T0NkVbQa3a+Ox3cO9evtuXYiPIeqDlLuwrjy7wcU16J4/SQPfDeHlxqjg1IDtl3sY0xr7fsnldLUNCNsaPxz/JY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=aqxx1j/9; arc=none smtp.client-ip=209.85.208.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aqxx1j/9" Received: by mail-lj1-f176.google.com with SMTP id 38308e7fff4ca-37a2dced861so28368491fa.1 for ; Fri, 05 Dec 2025 07:59:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764950358; x=1765555158; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=A8YFHFQMYLs67LBd0r3P2eo50fmHGqT7+PYNyYmOU5o=; b=aqxx1j/9Ryjc2mVTKKZrWkWF3N3i1UBwhTlEtvFzaoBX/lHKmiVGsv00QJrKTxd2Ii Hps9WUtNGnmLH61dlxApWPSfosfrYvqAalB31u3tj/zsIftr/YtsslctvvCIs6ZpdLxr gM7KwXcptUthEM/n6jEP8LAXBe1vtxXautrOX261+p1SIO0kU9FUglIJlW2c/VursQp3 H8+Xzeq2voToXN4/gxyp24OFG6mHTQ1qLHORfBZCAGlUIR85r8Xkqcid+ieAeZg1YQVp q8cHED8RctvYBiFKIEeVOf8lXDO5eiIjG//rdt+Mj5Mqmjq8fV5E12l2STt2qxoVe/nT gX+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764950358; x=1765555158; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=A8YFHFQMYLs67LBd0r3P2eo50fmHGqT7+PYNyYmOU5o=; b=q6+oRlBFG6AnXPeuMLYUaljfBlUc9rMPPTFoOD8GaV1kIXib8CqAQNYqAxLr/3yfeP hc6ZUHcEVv9E0lrsaRSjWee3chbsSHn06Fc716CD65QK3cwZrPO9/xqJ0EFICCov30qF gEEWQqqBbedoDODPxpW/KJ634RjIa/naE7DwhASNXAaciChtpjtKLQ10WP/K35IdDb5O LrrHzjFWn2AzzUtslvaYrPjHeC3JkZTij3McKTyPGir0QVegf0UIqCvyKrs9a0x9u+Bg kGgDC9b9GUQ0hmSPf2kfWD6e9g3zWZUTrdj8Sn4mIIvTZLRfEfiuc4iTNDTL1rijBE29 zLgw== X-Forwarded-Encrypted: i=1; AJvYcCXOGLN60uMC3RGLnKbb5VbeMos672kB/PSKken9ZpWADQQr0ADeV/lLGWUzrgTQQwMDGy+wfYz+Hqy0LMY=@vger.kernel.org X-Gm-Message-State: AOJu0YzsCYy7Xr8etbjWMyo/4dFwGxH9efzrGkCHnhNXjhZfnXAjFHr8 xY+6x8DarGtKc7nnlCqfBghN6ViLwq8XKwYOFqYeAv/cUP32zFSQOvCNoh35uLhVGCs= X-Gm-Gg: ASbGncuvf6uFdq4VGrDWwFJIfZVx45oQDW4WylXPoMaFpUqQSvh6CnZe3MhRrI9PIgt aEjUALifR3ZOs6FyapVj1mGUVmybugrRb5FDr6+kJyJahx9Y9dyWwhhn2YfNR0rmyQ5vS0poxSS mFLG5lAAXtZpIM42vgQzXvbvnr1/ki8F9c1uJqvzpZKhgJW3J+ocKy65GVBol1cTY+Ks78ssGKF X6s0tp8AaNDBKlpCOTNFJ2pm+o6FGB5fnFjLfUSF1zZMDg6d3o2D73X7BeVG/MUZ/TYxzth4lDL orK3yEeqPZ/yppywvFzgBPea2a7oQ/lgJoPTxCsaW/ucjby6HPuJjUbLL5cdnaUBSI5YepK1e7e h4G9NDwHiS+bzaGKhFoMb1v4LVc3yXS5sTKb0b2VreM6QFq57CXrthXHtr8i2CZvZ5klyb7RIyL V0FwzZPs5deZRvmCUIL8Hz0R0n5OgmXoPDPiSIm/w5s79Yuq0G X-Google-Smtp-Source: AGHT+IH4gweIrhcwKcKDplfWvPWfFrwQ1eXB+3kFy4WFEYx92+052G49Yb9690eCjEjjdGrPb4UtLg== X-Received: by 2002:a05:651c:2226:b0:378:e3a7:5dfa with SMTP id 38308e7fff4ca-37e6ccc9f5cmr22155491fa.20.1764950357756; Fri, 05 Dec 2025 07:59:17 -0800 (PST) Received: from home-server.lan (89-109-48-215.dynamic.mts-nn.ru. [89.109.48.215]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-37e6feb97c9sm15444501fa.20.2025.12.05.07.59.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Dec 2025 07:59:17 -0800 (PST) From: Alexey Simakov To: Michael Chan Cc: Alexey Simakov , Andrew Lunn , Jonas Gorski , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , "John W. Linville" , Michael Buesch , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Andrew Lunn Subject: [PATCH net v3] broadcom: b44: prevent uninitialized value usage Date: Fri, 5 Dec 2025 18:58:16 +0300 Message-Id: <20251205155815.4348-1-bigalex934@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" On execution path with raised B44_FLAG_EXTERNAL_PHY, b44_readphy() leaves bmcr value uninitialized and it is used later in the code. Add check of this flag at the beginning of the b44_nway_reset() and exit early of the function with restarting autonegotiation if an external PHY is used. Found by Linux Verification Center (linuxtesting.org) with Svace. Fixes: 753f492093da ("[B44]: port to native ssb support") Reviewed-by: Jonas Gorski Reviewed-by: Andrew Lunn Signed-off-by: Alexey Simakov Reviewed-by: Michael Chan --- v2 - add restarting of autonegotiations by phy_ethtool_nway_reset(), instead of returning with 0 code (suggested by Jonas Gorski). v3 - add needed mailing list into Cc. link to v1: https://lore.kernel.org/all/20251204052243.5824-1-bigalex934@gm= ail.com/ link to v2: https://lore.kernel.org/all/20251205071759.5054-1-bigalex934@gm= ail.com/ drivers/net/ethernet/broadcom/b44.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/broadcom/b44.c b/drivers/net/ethernet/bro= adcom/b44.c index 0353359c3fe9..073d7d490d4b 100644 --- a/drivers/net/ethernet/broadcom/b44.c +++ b/drivers/net/ethernet/broadcom/b44.c @@ -1789,6 +1789,9 @@ static int b44_nway_reset(struct net_device *dev) u32 bmcr; int r; =20 + if (bp->flags & B44_FLAG_EXTERNAL_PHY) + return phy_ethtool_nway_reset(dev); + spin_lock_irq(&bp->lock); b44_readphy(bp, MII_BMCR, &bmcr); b44_readphy(bp, MII_BMCR, &bmcr); --=20 2.34.1