From nobody Fri Dec 19 15:01:46 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 21C8531619B for ; Fri, 5 Dec 2025 15:35:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764948966; cv=none; b=rC9Y/M0/yHHlfFRkcGEel+DpnNhXxHmO00NMU6e5rpeEF5FvB4An7WD0S7LOo0X7bzzyqEKq28t3itnAMwgd0WAXm0t5iJNpYb2lSwP/gdIB7hdTKVODHlbuUZgydgKI25aa0kJdkjY5hHfWr18mwhhS+gb7JX7TKQNpyFsjRUg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764948966; c=relaxed/simple; bh=STzMJwI116rmgDpdpGII/++01lS4bYjJuQi2WMakzRM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=QbwGOYHW0arZd1AXiqehu2oG0T0JJ6q0seGMR/WZuvGceWg/P5DxQzvm/BxiemqlVdXR0JrWEZAITvrYEOslMxuQu60RgtT2oH/23qpVKUfywl3K8PcJyr9lti1ldDTeY7z56qoAQlBQ7EXxsGVIHJw1ZUayPgsknPKopmVwMMM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=LAWzzH4j; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=rdMzc6aP; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="LAWzzH4j"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="rdMzc6aP" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1764948955; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=JNWJCQXgH5bvny3UA4Fk9m23vdbcsYt/2+E6QHsu8TY=; b=LAWzzH4jl+MdWnVeIdAkmO/WlIbs2pSRHF4rET16Z2yYm1ljUa7AuGnwZFQEhfS+C4/Oll DyyVHinyM/WCiXrdFqSZnVLJe9mPXQJYvbtlSrcxJn56eAaubVHbUl/3Yt+F9AmOMg6NnC oV4pBXIN6HsmoqwtBFYjEXHOtdVckK8= Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-590---3E2UGvMaGEvmM_lwGHMw-1; Fri, 05 Dec 2025 10:35:53 -0500 X-MC-Unique: --3E2UGvMaGEvmM_lwGHMw-1 X-Mimecast-MFC-AGG-ID: --3E2UGvMaGEvmM_lwGHMw_1764948953 Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-7b952a966d7so4334235b3a.3 for ; Fri, 05 Dec 2025 07:35:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1764948953; x=1765553753; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=JNWJCQXgH5bvny3UA4Fk9m23vdbcsYt/2+E6QHsu8TY=; b=rdMzc6aPzuvd322lLfPESmDYzA7lioQPiL2n5RZZBIbLBhO4Zjl+CdlpyZSZIIuyNf TIaq09jnx5fwsMfvrpED/0oVWsnsJO9JiDfNrw5UmXW3yfJZ84RroQrl2ieEo82EWF/V bUyvuFLzT4gTp0VmSEREGMS/6o2LAIjJ+QFK4wY8uAtQyIFGxGt/ClbTKpL9aLjnz6Wj giELsBvc5L2DJQFrKKUnNgvxgOgl3npL9ZXOhLKyQL9NSVY6W7jt0kIOfUiOuG4X0oFM 5pVQeHeuzGoVFo7Q7TzCMKTlL/G11X2DnOBAv4EaDYPYWAwee9lpXTS2n5GCBj0eJ4bv vHCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764948953; x=1765553753; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=JNWJCQXgH5bvny3UA4Fk9m23vdbcsYt/2+E6QHsu8TY=; b=GFZTCl7nus9hSpcRnPrY5a1d1Y0K4CMYzWlD3qxvBD0q/y/+CgmmwVtJRgnzJrqYJ9 aAVSVU/epINIXrW6cS3X+mLw09I52WZnYiaFREbg08zbgOL7hn+CHwlXG/XSfp0ugiSy xknYozMQIxiFxHpPJ+0C+W6FgViFENlVOg1ZjHewaxedRUiW0qOh5Z3jzf+4pOcW4lFr wFjfLVmis9WFJOyzghHd3Y/UE+xzzSXA7DRPSQaOYmKY5rHP4CVD1AgyEun0zBIt2LOB +tZ/+EQKbC3uNi43xEWIMibbHjx8sOn98hHv2q6j0qbmy6fjpoJF+KlOoqaGK6Ef6Vmu HHUQ== X-Forwarded-Encrypted: i=1; AJvYcCXOMl21YDYc/J2sMBAQOHu2Tg60XRhhZ8ysT/0LHJxAv7KLRCAT4rqxq8B52Jw0Tcnb6G0O8WzeT5Vh6dc=@vger.kernel.org X-Gm-Message-State: AOJu0YzPFSrYVzXa3ynEwlJjNxi8uYBN7yHFRga2wwO7BfnRnjcdacNK 3WhNGgcFF3l+M5SzN8Gt62liR99WVP6xkIpnleBCTt2XQCPETvWbT7lCZpNiU8FwlSKsRitKOnw GKZM/Wi+neK2oDJNMvqr1QKZ53kB/tyzbfYkFuWGV/IqJsgcO9/+32bptx6CfgDxv X-Gm-Gg: ASbGncubcxe6NGwwV8iTDmu/Dr/9KYCCGcnObZmf0eTATt7V+78lIpcMY9ERipRm5ZB n2cOOnyw6bAbBA2X3YU+xgzGS+2yEeGTJHGXENbCtHP2NlkHdSw5euvQR3RWCu+obgmIEA5Si3x IZjQTx8r4pYI7T9Cl/Os871ZUYL3aWJ9p+EG40HQZiQ0p/uI1o77N4hy3ixoqIwoRzKvxPMq5IE BOyQECplicDqfmF6K2wuhC8Njlz25K20ny10jHX0vtK1ihopjHIjmXcorKPhcLpD5HUfn0bwSZZ DpQ1HpzU6lKwVbwCgEhb4lPZbiF48AdLcCn5Kw5/fQgFSUY68aY85dPaQ4gLmfvTgLVEPU5GByG DYAIUywdxbcN2es+TMHKmQ+It51QoAgFrdwoOLw== X-Received: by 2002:a05:6a00:1d16:b0:7e8:43f5:bd30 with SMTP id d2e1a72fcca58-7e843f5c53fmr442947b3a.69.1764948952716; Fri, 05 Dec 2025 07:35:52 -0800 (PST) X-Google-Smtp-Source: AGHT+IGibYUsuTvgSXgBChTk0AFwQw2BX4f9n6aUflTsFibE6nucBaMW0HHA+YsiEu06MWKun2Rnog== X-Received: by 2002:a05:6a00:1d16:b0:7e8:43f5:bd30 with SMTP id d2e1a72fcca58-7e843f5c53fmr442914b3a.69.1764948952222; Fri, 05 Dec 2025 07:35:52 -0800 (PST) Received: from dkarn-thinkpadp16vgen1.punetw6.csb ([2402:e280:3e0d:a45:3861:8b7f:6ae1:6229]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7e2a07213b6sm5641875b3a.26.2025.12.05.07.35.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Dec 2025 07:35:51 -0800 (PST) From: Deepakkumar Karn To: Johannes Berg Cc: Shaul Triebitz , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Deepakkumar Karn , syzbot+5bb5f06f99924ea0cf86@syzkaller.appspotmail.com Subject: [PATCH] mac80211_hwsim: fix divide error in mac80211_hwsim_link_info_changed Date: Fri, 5 Dec 2025 21:05:02 +0530 Message-ID: <20251205153502.273426-1-dkarn@redhat.com> X-Mailer: git-send-email 2.52.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Prevent a division by zero crash when userspace provides a zero beacon interval value. The crash occurs in the beacon timer setup code path when info->beacon_int is 0, causing bcn_int to be 0 and triggering a divide error in the do_div() macro.The issue can be triggered from userspace via nl80211/cfg80211 when configuring a virtual interface in AP mode with an invalid beacon interval. Fixes: e57f8a489c29 ("wifi: mac80211_hwsim: send a beacon per link") Reported-by: syzbot+5bb5f06f99924ea0cf86@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=3D5bb5f06f99924ea0cf86 Signed-off-by: Deepakkumar Karn --- drivers/net/wireless/virtual/mac80211_hwsim.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/net/wireless/virtual/mac80211_hwsim.c b/drivers/net/wi= reless/virtual/mac80211_hwsim.c index 5903d82e1ab1..e67e2c989ea6 100644 --- a/drivers/net/wireless/virtual/mac80211_hwsim.c +++ b/drivers/net/wireless/virtual/mac80211_hwsim.c @@ -2595,11 +2595,14 @@ static void mac80211_hwsim_link_info_changed(struct= ieee80211_hw *hw, link_data->beacon_int =3D info->beacon_int * 1024; tsf =3D mac80211_hwsim_get_tsf(hw, vif); bcn_int =3D link_data->beacon_int; - until_tbtt =3D bcn_int - do_div(tsf, bcn_int); + /* Proceed only when bcn_int !=3D 0 */ + if (bcn_int) { + until_tbtt =3D bcn_int - do_div(tsf, bcn_int); =20 - hrtimer_start(&link_data->beacon_timer, - ns_to_ktime(until_tbtt * NSEC_PER_USEC), - HRTIMER_MODE_REL_SOFT); + hrtimer_start(&link_data->beacon_timer, + ns_to_ktime(until_tbtt * NSEC_PER_USEC), + HRTIMER_MODE_REL_SOFT); + } } else if (!info->enable_beacon) { unsigned int count =3D 0; ieee80211_iterate_active_interfaces_atomic( --=20 2.51.1