From nobody Fri Dec 19 15:06:20 2025 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id EA9863321BB; Fri, 5 Dec 2025 14:55:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764946521; cv=none; b=B7AR2Ki2Z9zOYouq/05Oj8qYAcEn43UAfkYF010rqKiXbP/dLbWiLN11AL5udv2NNBZSMBaPCPHcWE2mbdlixwxoZry+gUvy+3oaFR6MX0ma8q3Fuu1nO+2qr66mQczn5EWDy/KTD05JTjJs5fUf1mSB5SINh8pvPvvcrSxJSlQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764946521; c=relaxed/simple; bh=3SVo4KltT5zARibswhVjRpCnw5g+Ckij9RsDBfvJtjw=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=YPwS4Yi3//TIRKbS9tJXUTXEDTenAq4ZA7EK/MLwiPMBscgIEWdjtHmA13ocmwe5zneKP+VcfRj5138KBTHewyjn789gApnSbm1o1mg9OpNkXIcj8LsLZt10oVU4RFdPfsFTfYRIGM7wAgd2U8cjYsZoNQ4GY7ftXGk+YsAguwU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8E8C01758; Fri, 5 Dec 2025 06:55:08 -0800 (PST) Received: from e132581.cambridge.arm.com (e132581.arm.com [10.1.196.87]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 7B4013F59E; Fri, 5 Dec 2025 06:55:13 -0800 (PST) From: Leo Yan To: Quentin Monnet , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Leo Yan Subject: [PATCH] bpftool: Fix build with OpenSSL versions older than 3.0 Date: Fri, 5 Dec 2025 14:55:06 +0000 Message-Id: <20251205145506.1270248-1-leo.yan@arm.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" ERR_get_error_all() exists only in OpenSSL 3.0 and later. Older versions lack this API, causing build failure: sign.c: In function 'display_openssl_errors': sign.c:40:21: warning: implicit declaration of function 'ERR_get_error_al= l'; did you mean 'ERR_get_error_line'? [-Wimplicit-function-declaration] 40 | while ((e =3D ERR_get_error_all(&file, &line, NULL, &data= , &flags))) { | ^~~~~~~~~~~~~~~~~ | ERR_get_error_line LINK /tmp/build/perf/util/bpf_skel/.tmp/bootstrap/bpftool /usr/lib/gcc/x86_64-alpine-linux-musl/11.2.1/../../../../x86_64-alpine-li= nux-musl/bin/ld: /tmp/build/perf/util/bpf_skel/.tmp/bootstrap/sign.o: in fu= nction `display_openssl_errors.constprop.0': sign.c:(.text+0x59): undefined reference to `ERR_get_error_all' collect2: error: ld returned 1 exit status Use the deprecated ERR_get_error_line_data() for OpenSSL < 3.0, and keep using ERR_get_error_all() when available. Fixes: 40863f4d6ef2 ("bpftool: Add support for signing BPF programs") Signed-off-by: Leo Yan --- tools/bpf/bpftool/sign.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tools/bpf/bpftool/sign.c b/tools/bpf/bpftool/sign.c index b34f74d210e9..c98edd6d1dde 100644 --- a/tools/bpf/bpftool/sign.c +++ b/tools/bpf/bpftool/sign.c @@ -37,7 +37,11 @@ static void display_openssl_errors(int l) int flags; int line; =20 +#if OPENSSL_VERSION_MAJOR >=3D 3 while ((e =3D ERR_get_error_all(&file, &line, NULL, &data, &flags))) { +#else + while ((e =3D ERR_get_error_line_data(&file, &line, &data, &flags))) { +#endif ERR_error_string_n(e, buf, sizeof(buf)); if (data && (flags & ERR_TXT_STRING)) { p_err("OpenSSL %s: %s:%d: %s", buf, file, line, data); --=20 2.34.1