From nobody Fri Dec 19 17:19:56 2025 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C49CE3358BC; Fri, 5 Dec 2025 09:12:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764925938; cv=none; b=XRb1yukAg6GIx/Mp4EMcrQg/k4fiIhQEewTjmhhuZsFt9lwGE+erJxWqkz1nAFIV8CDIcg6tdxpRE8onDhQgoZTQnPpGJh7rqcYu2J8BJsL5WONfIMPJxlX4VdsBXUS5Q8V0FVY1joJyZjNge7CZ4MTweZdeg5ZxP5HZ3An7BV0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764925938; c=relaxed/simple; bh=YS8/vqBJoLcfbhBEgaog8sdplpPEafy556rfQqhGLYk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=MGGOaH+xJouPSHLK7h9y8ZKRHtvqZh8oc5Gruxx1Hu9VPFz3pvjw2uVFgZEheCtGj2XTc9WuvpL7pUH1Up3wJlcdAZv8CVbx/7MW2o48B+noTGXWEH3LjAcNt3MAzvWRtDKHbeY03519mgiFLzuJYIA2qqP+8Rl/r8ah53r2cMI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=m7o7ziM6; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="m7o7ziM6" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1764925927; bh=YS8/vqBJoLcfbhBEgaog8sdplpPEafy556rfQqhGLYk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=m7o7ziM6r3aamXx4xy12t/bf1O+7Hv6cfTYIazu5sTd9fF7DkjNIntugcB+x4G5XW KtRtgsw36Nn1W0OnKAKH3yL1KNsL15c35rx6KQTaWpKQj9V9xl1dtZSUHyKCy2fSqo AYcgyS9Lj2G+AyZsNGs6VH+hzCHXZzoBph1RjiA31lMDXlY37QCPWu1eemASbQmcjY ik8mSA08i3B0l37mY4bPqqxBeErwKqahaHfGYVq11Q22F+x2VZP1MWEyradZbGQSD+ XsbE6SbF90VCwWQYU7toxingweUsDYNAgJwX29+RiTIZ2fNguewTEfvHdxixs01tQX lAemEUBa11JXA== Received: from debian-rockchip-rock5b-rk3588.. (unknown [IPv6:2a01:e0a:5e3:6100:826d:bc07:e98c:84a]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: loicmolinari) by bali.collaboradmins.com (Postfix) with ESMTPSA id D136017E1154; Fri, 5 Dec 2025 10:12:06 +0100 (CET) From: =?UTF-8?q?Lo=C3=AFc=20Molinari?= To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , Boris Brezillon , Rob Herring , Steven Price , Liviu Dudau , Melissa Wen , =?UTF-8?q?Ma=C3=ADra=20Canal?= , Hugh Dickins , Baolin Wang , Andrew Morton , =?UTF-8?q?Lo=C3=AFc=20Molinari?= , Al Viro , =?UTF-8?q?Miko=C5=82aj=20Wasiak?= , Christian Brauner , Nitin Gote , Andi Shyti , Jonathan Corbet , Christopher Healy , Matthew Wilcox , Bagas Sanjaya Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, kernel@collabora.com Subject: [PATCH v11 01/10] drm/shmem-helper: Simplify page offset calculation in fault handler Date: Fri, 5 Dec 2025 10:11:54 +0100 Message-ID: <20251205091203.150895-2-loic.molinari@collabora.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251205091203.150895-1-loic.molinari@collabora.com> References: <20251205091203.150895-1-loic.molinari@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable For a fault at address addr, the page offset is page_offset =3D (vmf->address - vma->vm_start) >> PAGE_SHIFT =3D ((addr & PAGE_MASK) - vma->vm_start) >> PAGE_SHIFT =3D (addr - vma->vm_start) >> PAGE_SHIFT Since the faulty logical page offset based on VMA is vmf->pgoff =3D vma->vm_pgoff + ((addr - vma->vm_start) >> PAGE_SHIFT) We can slightly simplify the calculation using page_offset =3D vmf->pgoff - vma->vm_pgoff v11: - remove misleading comment - add Boris R-b Signed-off-by: Lo=C3=AFc Molinari Reviewed-by: Boris Brezillon --- drivers/gpu/drm/drm_gem_shmem_helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_gem_shmem_helper.c b/drivers/gpu/drm/drm_g= em_shmem_helper.c index dc94a27710e5..e47ab3ebb5c2 100644 --- a/drivers/gpu/drm/drm_gem_shmem_helper.c +++ b/drivers/gpu/drm/drm_gem_shmem_helper.c @@ -577,8 +577,8 @@ static vm_fault_t drm_gem_shmem_fault(struct vm_fault *= vmf) struct page *page; pgoff_t page_offset; =20 - /* We don't use vmf->pgoff since that has the fake offset */ - page_offset =3D (vmf->address - vma->vm_start) >> PAGE_SHIFT; + /* Offset to faulty address in the VMA. */ + page_offset =3D vmf->pgoff - vma->vm_pgoff; =20 dma_resv_lock(shmem->base.resv, NULL); =20 --=20 2.47.3