From nobody Fri Dec 19 15:48:09 2025 Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com [209.85.208.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 210FC139579 for ; Fri, 5 Dec 2025 07:18:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764919098; cv=none; b=Kf8kkrIPTVqhnG5QkRl5w7cKon49gznTDrjiIGAJeXiaWDev5paubLfMscJyAYOMNQmSeF8grtx4b5AXMRG0UJ904pkYbWddOvqYIHjJ0zR39Ddcper0NUxv4F83jk/ZOjtC9L6YKnChVC35qP29aMSDC1lN2N1qe3C1tPXYh6g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764919098; c=relaxed/simple; bh=5dq9TTQjH2iXzaEk30XqEkI02HDwy2EAceO83jmArC4=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=SOuPq0+zrAtqZgulJU6Pn0r3wSg5KAtcpQqsegNCP3HpBSz91fI1k1sj7asY9PS62Qgi8wcDVSo7dG3xBMN7Md0dbuXEErZOsboqDpe/RWyQDOHMy67dfuB0VvZcrjBgx2s72rIKAbR8a6crYsH1j5HUc+EkH4r90B1gVPG8ds0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FuCrbQPO; arc=none smtp.client-ip=209.85.208.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FuCrbQPO" Received: by mail-lj1-f179.google.com with SMTP id 38308e7fff4ca-37d056f5703so14987431fa.0 for ; Thu, 04 Dec 2025 23:18:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764919095; x=1765523895; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=XFqGEQv16wW7jHEpOPi7jfV3U70khKpmR2kuB1CpJq0=; b=FuCrbQPONdmBaJ3bszYR5muCWD8O/AH/xtlzQh5NxHEoLLtVvQlAjDiPJOAeW+ZiMC IOHnilez639VQs3qHDWGUSHAGaDlwUZKWGfL3Gh+bFpSyeNQrMNki0ODfDORqsMwmQB7 0G0wLTLqBB+80KDAJy7UskrB26BeEg8ae6EE10XTtC2WrHHkLm7jdWjAlnw5Gm6GAJEI VJHmoFqjrvOkjkDr50I4UjtTkmQS7feTBmQG3SkV1pkW4NbBEn2Pc1RsozhFP4XHgug2 isKVbba0z1nT1B9MB5s9qQ5+J2SjhrZcsh9S409ItY4X+4kU6N9xF/YG5AJibrT38Trt Luaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764919095; x=1765523895; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XFqGEQv16wW7jHEpOPi7jfV3U70khKpmR2kuB1CpJq0=; b=KyhOTtWwSSTcL+YJSJqOLQmvb3ued4SRVopJ6uPnDxIXeY3BlkZPJOL3UVP3wFwdbP DBdbSi+80i+x6Gmpa9YgpiY5zvdAJV+oGVf+ArQWSdCAGDZwDnrUR1sIlx3isLPFTLz4 0AlDJiKToT+DvPWEhubgvB028d5iRVIsrcbVHIUxgIa7O7Yb+ZiwwaZCoR4XKV8gSbGV fg3/zwlXpsHVMsdVh5dnFS1SfWOXhSeFf8/KFak0A6uWoo0IBERV/Hp8jfT3bb3wtP6Z /EfkJIb+qwu7UHJDTalgpgIhpz2OvBdfAm+gsajuTJQVY9girDG6MYsfp65DDTd9pGIX gMHw== X-Forwarded-Encrypted: i=1; AJvYcCWOyWOV9BzUwpJSrvavr519KedYZeS4GzWMceb8jUl2CieCcbWD9IeGKBCQuoGPERoVUUJ8RfgX5QkdiWE=@vger.kernel.org X-Gm-Message-State: AOJu0YwVHKFU4BsxSQnn7kXVG14TVM6Zr2h956fBBQpHGRC1Bkf2+Rr+ KJd1DNTaHHWxGFFgJdDauWkCRygPawp2p2eMK+iwUMzMSBoUFQRaaGPa X-Gm-Gg: ASbGncvYfSUjHB/7JB3fU47Fieo4tsl8sKCwYSEvjpnAgeafo/NyzhApHC/7RU03g1e Wtja7m7aV3ZulP9bQ5fcInhMvvtpJeMZeJuda7LafLhLDDaQ+Shh24WobpEWDKhDC0txGQhkbM5 zSTh50513wlfdbalxxBz8C1meIQTGSbXwaoeYvA49/xrL8evkWyohTa6h57UEEJokPSZyM6FQWD hL2OAXW+qlcMMacky7WtzCvp6DtJ8f1xmKVwi19RN6yAk1Tns7GkljCEd7e1oOsb1TL+1u+zVt5 4hDq+SSAiicdWUKZ4RBiGTM/IGkRAx+CRTd/i5tYNuV3ATr7fmBg1yq0w1rKjIHMWHMoI/oc44t PnFNyEsext6eTSxsCx6OweoyTjkbuJ5bEGcymzWFrUORyOUweqyV6MzJki/LKioyt8VsoCQ2m7R TWp1z7j/c6Kz1DDqpkx3Po0lV7fnLHbZJcgo6HZO8nZQYCA1Q+ X-Google-Smtp-Source: AGHT+IHF7yIzhvBvuOfo41T817BaS1lLRYmd0DjdyWYdC+6THwqm7YZOujAh9pE15SBFaaDopaIO/w== X-Received: by 2002:a2e:8784:0:b0:37b:b2a0:cdd3 with SMTP id 38308e7fff4ca-37e638b0398mr21820691fa.19.1764919094952; Thu, 04 Dec 2025 23:18:14 -0800 (PST) Received: from home-server.lan (89-109-48-215.dynamic.mts-nn.ru. [89.109.48.215]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-37e7060f2d4sm12464411fa.40.2025.12.04.23.18.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Dec 2025 23:18:14 -0800 (PST) From: Alexey Simakov To: Michael Chan Cc: Alexey Simakov , Andrew Lunn , Jonas Gorski , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , "John W. Linville" , Michael Buesch , linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org Subject: [PATCH net v2] broadcom: b44: prevent uninitialized value usage Date: Fri, 5 Dec 2025 10:17:58 +0300 Message-Id: <20251205071759.5054-1-bigalex934@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" On execution path with raised B44_FLAG_EXTERNAL_PHY, b44_readphy() leaves bmcr value uninitialized and it is used later in the code. Add check of this flag at the beginning of the b44_nway_reset() and exit early of the function with restarting autonegotiation if an external PHY is used. Found by Linux Verification Center (linuxtesting.org) with Svace. Fixes: 753f492093da ("[B44]: port to native ssb support") Signed-off-by: Alexey Simakov Reviewed-by: Andrew Lunn Reviewed-by: Jonas Gorski --- v2 - add restarting of autonegotiations by phy_ethtool_nway_reset(), instead of returning with 0 code (suggested by Jonas Gorski). link to v1: https://lore.kernel.org/all/20251204052243.5824-1-bigalex934@gm= ail.com/ drivers/net/ethernet/broadcom/b44.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/broadcom/b44.c b/drivers/net/ethernet/bro= adcom/b44.c index 0353359c3fe9..073d7d490d4b 100644 --- a/drivers/net/ethernet/broadcom/b44.c +++ b/drivers/net/ethernet/broadcom/b44.c @@ -1789,6 +1789,9 @@ static int b44_nway_reset(struct net_device *dev) u32 bmcr; int r; =20 + if (bp->flags & B44_FLAG_EXTERNAL_PHY) + return phy_ethtool_nway_reset(dev); + spin_lock_irq(&bp->lock); b44_readphy(bp, MII_BMCR, &bmcr); b44_readphy(bp, MII_BMCR, &bmcr); --=20 2.34.1