From nobody Fri Dec 19 16:20:43 2025 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B1C0C1B6527 for ; Fri, 5 Dec 2025 06:47:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764917272; cv=none; b=YQMGdZ2kaq0J6or6zo152VSswWZ5TbYKYy5cSUKH7clNVvh/+kPCFBl2fsQISSdXVr4j2hJjEr9XCeD4yHtPbzX1Of9oSKxVEi86dgBCw4ywCTIsiEpyJo2VVQuYsY20exrDY21Pvwyz2UIpWnoO1SVDZBiU/vTuN5u0hseUA4A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764917272; c=relaxed/simple; bh=HYWa7sYqo/+IWEhKErinEtaCB2smT0RLRWd4UNd8vSc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=JPUZj4nwpZkJyHpWER6dwj5IxvZDDID+XZpemOT86LK/IEx8bDEMFyGTzitzT1bQcpOVPG3+JYdy4QnBrTdBYgnNtZYkj1bBbCZ0DnzWtVYQbLzOlj2+AX1+CoEQeVI8+8vP8vkoNndY4ePTFuo220Gie5KlZV4W7VNLYkLWAwQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KlwA4+8j; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KlwA4+8j" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-297f5278e5cso3908375ad.3 for ; Thu, 04 Dec 2025 22:47:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764917269; x=1765522069; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=cQCqvOs+rmxg5luABnNgFbGK2aNywkYQWiXVFeR2OFE=; b=KlwA4+8jMvxIhGFbDORUTFtZpNCoSzpr6d204ogvZx2XnH0+p5T3Nsr3go0P0V4nMD lBJjBjsvDQf7M+tB3DnEUTHCTA8d7D6K6quQtpL4xZUsjxVVkVuZW+H9xrQMb68XShwZ xSA/IJD1Pn3FBcFq1sBjL3Rnrc744tipqH0nZQqEF/ErtYw5D8QllyNt1EhMc0NaXXh8 GdI4Hp4OM8DWc00efTjPQznX5zJyPuGheScoQAHTKWiz9AN+RS/d906C6LRReLKe7LRs OaSLsaUczoZ/aNHnqZuoknCNUGoGenR+V5PcR/CwlwjK4F4ekVQQGtu3aXD1/GhVHG11 i3fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764917269; x=1765522069; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=cQCqvOs+rmxg5luABnNgFbGK2aNywkYQWiXVFeR2OFE=; b=c8iqSgA4SL3T9G2hD80YQ41Dep+SNKZQE/03WVsKG+HBKHOjFmzTdPWyToUXXtyUWK 85qCrgRLM10oCPDEikXnKHEvRGsR+w+M6W/D0QpoA/DYrjP8UDpKrdi6axQbotWt/HR5 ixbumlntqlU9Pq2gocgmX4T9Zb+WjZDPGk/QjzbyJoTEBkoU69Yq92pH+7AB6uWk6Ron bxU/wzvLP1/IzhRsgJ/vI4lwRjfQXArujokKH7kNHlPvFW2JU7GJsTkEiYcVGL/7DDsK LWN3aIY+EH/1NmfdaIGrSmk6eLMNkR7ygPag5vhr0dTUBB2hhho5slkF8+EDoUDuiJJX z5QQ== X-Forwarded-Encrypted: i=1; AJvYcCV4He9gkCQRJmRr9JuE0GeeI+yvL0tuMaPxIhlJGd63z37af2imRSDAkNOwbo3anYQppj+IWrW4t2vuY+4=@vger.kernel.org X-Gm-Message-State: AOJu0Yw32XQmR96RIVdpVdZ9b2Igw4/b4e87plBZWhK17kecrC90B1l5 fG92HPmXzj2mo4AvYcCLBh5s0amSVXu4Eek8pK1VTPUKH+f/qXEWENdn X-Gm-Gg: ASbGnctZKq+jMB2QaP90oyIoByO+IxA/wXyKXjgkgmJgh3EddE9JKJrJY1sKPRgFr1p DWqrxtVKDZOUXHrPQoOdiJeok20S7HS6Px8ZlCj3PdWdqjzK2Xuvv3RgqtCvN3hLWTN3xti/nTm jFs5OddIVaxqfglsuM4v94UuOXNwQynPQuIhghORWrqLK6xlfCXa21e7ncMYJT9sqTYBhAYncVU BGMnSH9ztMIxhvWyRmxryKONgxZ5qtL/5g1zl0Tybt7Qs0MPp5dApm4xLqeo1R37Ky6Q5xASs6X 8vyZvt2N/XRMXDkArp2dU55tQW65yR0gIV74kPcI7z0hMosFNw/sUtfD/OjGuiguFz/LBsKfv1I EuaBQ63TkKwqth7Fq2u/sLXaNUwFssuN4bUrfMm87RU6MAsDSMzHSEf3lznPreF+bBtJna8oO1i q7pG/VfA4cm5p5ublZxqGLXlMLOiZ0SnzLsc8fhes= X-Google-Smtp-Source: AGHT+IGRKM8BQrG2ZI8dHPnVSfWZ2b0YQ8no5vBvlYxduzRFOFHV5uKsY+yIJjsLzz4NB9mnoBzUQg== X-Received: by 2002:a05:7022:252a:b0:119:e55a:95a3 with SMTP id a92af1059eb24-11df25cac52mr5909504c88.5.1764917268841; Thu, 04 Dec 2025 22:47:48 -0800 (PST) Received: from localhost.localdomain ([183.14.133.3]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-11df749f8ddsm10664692c88.0.2025.12.04.22.47.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Dec 2025 22:47:48 -0800 (PST) From: Frank Zhang To: ulf.hansson@linaro.org, heiko@sntech.de Cc: linux-rockchip@lists.infradead.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Frank Zhang Subject: [PATCH] pmdomain:rockchip: Fix init genpd as GENPD_STATE_ON before regulator ready Date: Fri, 5 Dec 2025 14:47:39 +0800 Message-ID: <20251205064739.20270-1-rmxpzlb@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" RK3588_PD_NPU initialize as GENPD_STATE_ON before regulator ready. rknn_iommu initlized success and suspend RK3588_PD_NPU. When rocket driver register, it will resume rknn_iommu. If regulator is still not ready at this point, rknn_iommu resume fail, pm runtime status will be error: -EPROBE_DEFER. This patch check regulator when pmdomain init, if regulator is not ready or not enabled, power off pmdomain. Consumer device can power on it's pmdomain after regulator ready Signed-off-by: Frank Zhang Tested-by: Chaoyi Chen Tested-by: Quentin Schulz # NPU on RK3588 Jaguar --- drivers/pmdomain/rockchip/pm-domains.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/drivers/pmdomain/rockchip/pm-domains.c b/drivers/pmdomain/rock= chip/pm-domains.c index 1955c6d453e4..bc69f5d840e6 100644 --- a/drivers/pmdomain/rockchip/pm-domains.c +++ b/drivers/pmdomain/rockchip/pm-domains.c @@ -659,6 +659,11 @@ static int rockchip_pd_power(struct rockchip_pm_domain= *pd, bool power_on) return ret; } =20 +static bool rockchip_pd_regulator_is_enabled(struct rockchip_pm_domain *pd) +{ + return IS_ERR_OR_NULL(pd->supply) ? false : regulator_is_enabled(pd->supp= ly); +} + static int rockchip_pd_regulator_disable(struct rockchip_pm_domain *pd) { return IS_ERR_OR_NULL(pd->supply) ? 0 : regulator_disable(pd->supply); @@ -861,6 +866,15 @@ static int rockchip_pm_add_one_domain(struct rockchip_= pmu *pmu, pd->genpd.name =3D pd->info->name; else pd->genpd.name =3D kbasename(node->full_name); + + if (pd->info->need_regulator) { + if (IS_ERR_OR_NULL(pd->supply)) + pd->supply =3D devm_of_regulator_get(pmu->dev, pd->node, "domain"); + + if (!rockchip_pd_regulator_is_enabled(pd)) + rockchip_pd_power(pd, false); + } + pd->genpd.power_off =3D rockchip_pd_power_off; pd->genpd.power_on =3D rockchip_pd_power_on; pd->genpd.attach_dev =3D rockchip_pd_attach_dev;