From nobody Fri Dec 19 15:51:35 2025 Received: from mx07-00178001.pphosted.com (mx08-00178001.pphosted.com [91.207.212.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 51A42196C7C; Fri, 5 Dec 2025 09:05:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=91.207.212.93 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764925544; cv=fail; b=KuX7GKaVCf6QahuGuJkzkJIjQdt6hQQ9t3+kaw06shRczkyDDxG7f69CVJE33YOF6VdM1A3ZZ6Bll8N8C8/oEE5Y4FyKnaWBtpTttZZWCG5jobc3E3IJ5F4SozWksc24i7g8rh9S6rYsMXi9JdcjKZ9ExURN8wKfrdLJQo6Y6gs= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764925544; c=relaxed/simple; bh=wzCkZzPbWhj39oG9eKu97XakUMXNooBsQoajHNemf1c=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=YG//rxOIKFjnlpzjG+2uLn38yIGG4gQlwe8LHHIKZgnKGwUXVSrvvJKiSxVh3GhaXRPA/w478KNt/6MYJFi5OSL60dTiKTxguLfqT6hryR7rEPk/VoVHK18vlTVTsk+hY5ME3l1D/AazHUXh9/VrqQJYSFCRhK0U9hf9kF7Jbts= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com; spf=pass smtp.mailfrom=foss.st.com; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b=VkzRu0RG; arc=fail smtp.client-ip=91.207.212.93 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=foss.st.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b="VkzRu0RG" Received: from pps.filterd (m0046661.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5B593s242054553; Fri, 5 Dec 2025 10:05:09 +0100 Received: from duzpr83cu001.outbound.protection.outlook.com (mail-northeuropeazon11012071.outbound.protection.outlook.com [52.101.66.71]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 4aub8nb59u-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 05 Dec 2025 10:05:09 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=zGlH2HqMf8n2YzProh7OaU55edPvRkHjHunZU3M7T1xiLDQS4UQHTOwh43sqSWqpLupEYotSzQaVqZO7S58j+NaVkI5eAMq/u3UChowOXjA1PhdgyutvJbPkpLNbArfMK3bHBFKxL2JY93REIzwkqyNXZVcm5rygUkl+074Q85oQjD1f6qjMFHaIpaoXjIhL1hGBt+QRC2rqhK1H3XurYuYvPVLIefPo9b87BT/oRwxtZE8LagTq7fz4vQej08CEFd9LmBpbQujNX37Q2ZneFdoTp9iI/jc0hYTbzPBIyXDut3rANjoH9Oa0nB/QgalNNjV7SCc6RZvy0Z5v+8JDjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sFifFDVVPlmakVLPtIWQFBDHLcEXcpKDiqB76TIJ8pg=; b=arFCsu1vartFhSn8tRAxlnnqtHe2VharU6bqnir3NwHbAv+yFJTrUXYq8SL9x8btF62zXgoSsu6Lac57Eg/cGSYqvsf2jq1Owcl9sqvIRXQx0p08k57VlLKRgfJWO2F2lj8noIs3XciFIbhGV5i7OWBRiNwB9E3jgZVW12aDzLOmHtJcOGnCePGKJEMGFHov/UZlt8n/uWVERtuqIyuQglAvdBL7pgkma22Lm/+WSoCcm9Pda5NRrFZja2xwVKod5BLV5ZOLYmONjv3WGUYAn21Bzai4s9DsvJi4s4nkPFekSOx0qTN8sHXL4tSjve5Q2bibaSoP//bfA/hoR0scyA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=fail (sender ip is 164.130.1.60) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=foss.st.com; dmarc=fail (p=none sp=none pct=100) action=none header.from=foss.st.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sFifFDVVPlmakVLPtIWQFBDHLcEXcpKDiqB76TIJ8pg=; b=VkzRu0RGSEqM0gitiUBYa+mc0PUwwQ69nfYWsQKKKE5D2SDDj4fIZpvqTfI+41dTyeIgEPBxodDnbzzIQb5P5hctJSe67SOb3dWXte7RPP8k8kZshFQ+lnpMcPNjwX1c7XHDa7Xjf9PWu2M9Hft/fZAyjv5MtzkrQWx0uvXFpADWwYtobe6F05NEHI8SRXndaDnYqZNxEdmOsSFzjajMDU4Vwx5f3bYD6chIwYgV4RKM6YBtZFrhPb0NN177Q3sV3hcOgREVO7usFDDt45NIxYNWfT7R9ENzjHVsv0VGgav3nSErJM55cjVaTLtJxMs+boGKHLXj6Vr80hRT4PF1sg== Received: from AM0PR02CA0119.eurprd02.prod.outlook.com (2603:10a6:20b:28c::16) by AS8PR10MB7451.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:5ab::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9388.9; Fri, 5 Dec 2025 09:05:07 +0000 Received: from AMS1EPF00000049.eurprd04.prod.outlook.com (2603:10a6:20b:28c:cafe::5c) by AM0PR02CA0119.outlook.office365.com (2603:10a6:20b:28c::16) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9388.11 via Frontend Transport; Fri, 5 Dec 2025 09:05:07 +0000 X-MS-Exchange-Authentication-Results: spf=fail (sender IP is 164.130.1.60) smtp.mailfrom=foss.st.com; dkim=none (message not signed) header.d=none;dmarc=fail action=none header.from=foss.st.com; Received-SPF: Fail (protection.outlook.com: domain of foss.st.com does not designate 164.130.1.60 as permitted sender) receiver=protection.outlook.com; client-ip=164.130.1.60; helo=smtpO365.st.com; Received: from smtpO365.st.com (164.130.1.60) by AMS1EPF00000049.mail.protection.outlook.com (10.167.16.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9388.8 via Frontend Transport; Fri, 5 Dec 2025 09:05:07 +0000 Received: from STKDAG1NODE1.st.com (10.75.128.132) by smtpO365.st.com (10.250.44.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Fri, 5 Dec 2025 10:05:44 +0100 Received: from localhost (10.252.31.202) by STKDAG1NODE1.st.com (10.75.128.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Fri, 5 Dec 2025 10:05:06 +0100 From: Patrice Chotard Date: Fri, 5 Dec 2025 10:04:51 +0100 Subject: [PATCH 1/8] spi: stm32-ospi: Set DMA maxburst dynamically Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20251205-upstream_qspi_ospi_updates-v1-1-7e6c8b9f5141@foss.st.com> References: <20251205-upstream_qspi_ospi_updates-v1-0-7e6c8b9f5141@foss.st.com> In-Reply-To: <20251205-upstream_qspi_ospi_updates-v1-0-7e6c8b9f5141@foss.st.com> To: Mark Brown , Maxime Coquelin , Alexandre Torgue CC: , , , , Patrice Chotard X-Mailer: b4 0.14.3 X-ClientProxiedBy: STKCAS1NODE1.st.com (10.75.128.134) To STKDAG1NODE1.st.com (10.75.128.132) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AMS1EPF00000049:EE_|AS8PR10MB7451:EE_ X-MS-Office365-Filtering-Correlation-Id: c981fb4d-5fc0-4dfb-d750-08de33dd62f8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|1800799024|376014|82310400026; X-Microsoft-Antispam-Message-Info: =?utf-8?B?TmZkb0RIdzJnUWhpZ3dVOGMzQ3BjWkwybUdHN21xWGxFdEdGNWMvSzUrSEtu?= =?utf-8?B?T2FRSllpSDRyeUk4T1NzU2JZM3NGT3pJRjBzL3p0WkFzT3NQMXhPODlrSWhO?= =?utf-8?B?K1FMWlEydjRQbTNXVVFQT1JOWE5DNHU5dUhQQ0VRd0tuN01Cdmtlb3JLdXlH?= =?utf-8?B?YXRsQVhVZ2FDQ2xUYWRaVXBHWGQwNlpqOW5reDg1MzNWY3pNVkl2R2ZjYngr?= =?utf-8?B?ZnFEbFY0SWdDbDlCVzNKR2VFMVlCdUZuSmZEb2o5NVdubUZENmlkeWkxNFh5?= =?utf-8?B?U3pGVzZhNmQ4M3RuUGdtMW1jN0dBckx3Z3BULy9aajE1aG5DWjBrM3IwYldI?= =?utf-8?B?WTJCNTNIOUlheDFod0oveGtwRUJrWm1INmFSc3pFRy82UE92TEtkNzNBbDE0?= =?utf-8?B?TDI3UEZQbTRKNzVsc2tFVzFMR2U0TVQwcldsVmlqdTBpd1YvNmU2VkpDeEV6?= =?utf-8?B?NWlUSWJrUncwMjNnV1BYLzBMaSsyam1FT1pIeGRGQm0ydG1ORk95WmpUMlR2?= =?utf-8?B?WUg4MlBFNWh0QWZSVFdFVkpFRDZhQmwvbnZtMUQ1dXVhcTNrTWYvZ0YxUGJ1?= =?utf-8?B?TCthL3FlZTJaZzRxTFh0b0cvQTE4TU9VNm1oRGtHeDlnQ09pSzNFMW8ybngx?= =?utf-8?B?ZDkwQXBJbzZMdjFaMElpWFRGc3p4aVlubDhJVHNBcTcvYWpIeStZYjA4cm5L?= =?utf-8?B?akJlWE52ZXRkcWFxcThybVpLWTdjSCtuTU8rejlOMmhOM3JoYkUvdXV0L3gz?= =?utf-8?B?Um9Cd0ZBWFBpU205WEx5N1BGZ1V3NXlwUXFhMTE4b1BmTi9UYWl3UE5SUW9R?= =?utf-8?B?WU92QVRGMWNDeTRFWnAxenBpOTk3V2JaaFdLRGF2eU1mMWxUd0dBaVZidVlk?= =?utf-8?B?Z1prc1dCLzBWbk5MZmp5TjNJRDZUUlo2d2Zxbk1JbWdVR252YWFvWExPaUty?= =?utf-8?B?YWNIMGpMMnBYQUJQUVRRMGxTaUtTTzlGWmpTaFBha1pUQUFpU21ra2JCQ2RM?= =?utf-8?B?UEV3RFd6Tmorck81a1dTN0ZOZWhZN0dJNk52amRidkFYQnZNQ1lscWtoMUhI?= =?utf-8?B?ellNb3FKOW5UUkMwajcxQ0VRMlBTTEtQY2Z0cDlSZEcvdHphWUNXamw5NGQ4?= =?utf-8?B?YWptaDdnazdXLzkxSEZTSm1wYnlxTEVQUmZEOVBUaVZWTmMwaU4zdWJ3SWtl?= =?utf-8?B?UVBIZk81RkNUQUtVTE5SNG9JT3VVSG1RMkJidXRSUVZRNDRNT0tPMkw0VWJx?= =?utf-8?B?b0xGcXlNSmdRZS9iYTUweEQ2VC90bHdzTW5kb3ovclA5NUZlbGlLamtSdXVN?= =?utf-8?B?b3BiNEVyTHE0aWVzNjFTQzNaV1VKMHVWQURtdUdZRWVnY0g4SVk2WEc1clQ4?= =?utf-8?B?S2xlNXBCeHloL2ZLNHpxOFFUZDJnaGFLTC80c0NHaUI1SEVmbGdDQkZLTDJo?= =?utf-8?B?WGVwWVZhb2JFeldwbTBWWnVtMUlpZ01JaEZOVXFYTWVpclZJN0JxcmhNYy9z?= =?utf-8?B?VTRKSFlQQTBsSC9UNjJpaDV0NWtZTUl6SFlkblBiczhXWUs0alZMTXBRQkd5?= =?utf-8?B?a1BVZ1VhS1JEd1NYSEhBVjBiRldTQ0ZrTCtiSWQ2Y2Q2UnBOREV4WWhOSjgy?= =?utf-8?B?WnI0amJMemVIQTNaajZjZThzRjZNNStCY3dpZTUxT0YwZldSVDNncWRaS0hR?= =?utf-8?B?V0tHdXMwbDBOQjB3dlY2TklTN2xac1hQU2Yzc0NNREkrU2M2TEtjVnVnaGlr?= =?utf-8?B?RnB5OUgwU20razVXSS9qN2RLMWQ0bUZNWmsyU2tBWDF2UEd5UTRYencxQmwv?= =?utf-8?B?YUEybjJ2NUpTMFpoOElCNk83Mnp1OU9kQUpEUzgvNVh0SWYyYmkxV2JiaUlk?= =?utf-8?B?Uzd0MVI0am5hNTZmWGRkS3lHYW0yVHpxSy93TXZFWlArRkQ5U0d1RjZUT0Iw?= =?utf-8?B?c3ZuSUpkVUtRYUx2bmxhWUEvdUtqMXJBT0RCc3JCYkRLaXU5dGNybk1Bbjdv?= =?utf-8?B?QlhZOUNmUkJRd1FBOWVRNm1td1B0ZGFHYjZEUWV6ckdYSE1rNnZXK2MyYXFz?= =?utf-8?B?U0tRTnNQdXhDeHY0UzVtc1NEOUZKbkRQZ3ZGaW9EQkFZTlRNUHJDOFRKcXk1?= =?utf-8?Q?4mFM=3D?= X-Forefront-Antispam-Report: CIP:164.130.1.60;CTRY:IT;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:smtpO365.st.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(1800799024)(376014)(82310400026);DIR:OUT;SFP:1101; X-OriginatorOrg: foss.st.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Dec 2025 09:05:07.3667 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c981fb4d-5fc0-4dfb-d750-08de33dd62f8 X-MS-Exchange-CrossTenant-Id: 75e027c9-20d5-47d5-b82f-77d7cd041e8f X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=75e027c9-20d5-47d5-b82f-77d7cd041e8f;Ip=[164.130.1.60];Helo=[smtpO365.st.com] X-MS-Exchange-CrossTenant-AuthSource: AMS1EPF00000049.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR10MB7451 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjA1MDA2NCBTYWx0ZWRfX+PrmxCXoLnhJ HV227ar3E7VWE5qD9N7bJKYdj9z90cRtnCx04VKL7O+CZkcAg01HTrroRDk7OwHNr3uCrylcWRs a5lzMC5bpP6/WxX5pV6pj64ZrbdWXFpRMMpMGooZh0BBLQCtotKyX3imNkvkEm5Qd5d0vNRW/BX GUSYtxYqEBXbsR73wxy/YmhbPegSAEowdo2BO6Svkntqfc2Qkm1JNDxPr5+zoRgrIl5Ql8AzCBa FxayvZBSGcYLXE2QkgBQh2GFWYdzkzVWjg2h/OL03LvOtEAFKW+8xftLXaY608RFAdBXFOo98L9 i/9PSrVtIjWMKeJz6CxfGr5Ewon4OpMWGbWz/fN2CzFUyXAGLuqITD60IxOwkDHdq+hfNgneQF3 oDbR08fkdSJ1hU9s/RxMTnKjXSpcKg== X-Proofpoint-GUID: s1_y8IfCxYMHFR_DWyxu3rvho_XoxwYe X-Authority-Analysis: v=2.4 cv=X99f6WTe c=1 sm=1 tr=0 ts=6932a045 cx=c_pps a=zZ2aAuEz6FT5R9GdLdvfGA==:117 a=uCuRqK4WZKO1kjFMGfU4lQ==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=Uo5EeBN78AAA:10 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s63m1ICgrNkA:10 a=KrXZwBdWH7kA:10 a=VkNPw1HP01LnGYTKEx00:22 a=8b9GpE9nAAAA:8 a=WbBYHnI1PNLwm2dNkN4A:9 a=QEXdDO2ut3YA:10 a=T3LWEMljR5ZiDmsYVIUa:22 X-Proofpoint-ORIG-GUID: s1_y8IfCxYMHFR_DWyxu3rvho_XoxwYe X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-05_03,2025-12-04_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 impostorscore=0 malwarescore=0 priorityscore=1501 adultscore=0 clxscore=1011 bulkscore=0 spamscore=0 phishscore=0 lowpriorityscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512050064 Set src_maxburst and dst_maxburst dynamically from DMA capabilities. Signed-off-by: Patrice Chotard --- drivers/spi/spi-stm32-ospi.c | 27 ++++++++++++++++++++++----- 1 file changed, 22 insertions(+), 5 deletions(-) diff --git a/drivers/spi/spi-stm32-ospi.c b/drivers/spi/spi-stm32-ospi.c index f36fd36da269..d733e37f0435 100644 --- a/drivers/spi/spi-stm32-ospi.c +++ b/drivers/spi/spi-stm32-ospi.c @@ -278,10 +278,19 @@ static irqreturn_t stm32_ospi_irq(int irq, void *dev_= id) return IRQ_HANDLED; } =20 -static void stm32_ospi_dma_setup(struct stm32_ospi *ospi, - struct dma_slave_config *dma_cfg) +static int stm32_ospi_dma_setup(struct stm32_ospi *ospi, + struct dma_slave_config *dma_cfg) { + struct dma_slave_caps caps; + int ret =3D 0; + if (dma_cfg && ospi->dma_chrx) { + ret =3D dma_get_slave_caps(ospi->dma_chrx, &caps); + if (ret) + return ret; + + dma_cfg->src_maxburst =3D caps.max_burst / dma_cfg->src_addr_width; + if (dmaengine_slave_config(ospi->dma_chrx, dma_cfg)) { dev_err(ospi->dev, "dma rx config failed\n"); dma_release_channel(ospi->dma_chrx); @@ -290,6 +299,12 @@ static void stm32_ospi_dma_setup(struct stm32_ospi *os= pi, } =20 if (dma_cfg && ospi->dma_chtx) { + ret =3D dma_get_slave_caps(ospi->dma_chtx, &caps); + if (ret) + return ret; + + dma_cfg->dst_maxburst =3D caps.max_burst / dma_cfg->dst_addr_width; + if (dmaengine_slave_config(ospi->dma_chtx, dma_cfg)) { dev_err(ospi->dev, "dma tx config failed\n"); dma_release_channel(ospi->dma_chtx); @@ -298,6 +313,8 @@ static void stm32_ospi_dma_setup(struct stm32_ospi *osp= i, } =20 init_completion(&ospi->dma_completion); + + return ret; } =20 static int stm32_ospi_tx_mm(struct stm32_ospi *ospi, @@ -899,9 +916,9 @@ static int stm32_ospi_probe(struct platform_device *pde= v) dma_cfg.dst_addr_width =3D DMA_SLAVE_BUSWIDTH_1_BYTE; dma_cfg.src_addr =3D ospi->regs_phys_base + OSPI_DR; dma_cfg.dst_addr =3D ospi->regs_phys_base + OSPI_DR; - dma_cfg.src_maxburst =3D 4; - dma_cfg.dst_maxburst =3D 4; - stm32_ospi_dma_setup(ospi, &dma_cfg); + ret =3D stm32_ospi_dma_setup(ospi, &dma_cfg); + if (ret) + return ret; =20 mutex_init(&ospi->lock); =20 --=20 2.43.0 From nobody Fri Dec 19 15:51:35 2025 Received: from mx07-00178001.pphosted.com (mx07-00178001.pphosted.com [185.132.182.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 99C09322A26; Fri, 5 Dec 2025 09:39:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=185.132.182.106 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764927615; cv=fail; b=dIOuSzvlrqpjpY7Rr7d+s6tBVJeNF2GrYteMLdb2ufQPj1zI7pVAUqq9W85d8JGvbK4k6nB9pE37d2AUD9bLLBCUEXHxw8jMRnNapi2ouNJgKrIpu4/hpWnoqTLRZ2DVKngqdAjZC33UJcwzn9KElJSM1J98uSXZYUXOUxd9RFQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764927615; c=relaxed/simple; bh=ep3js4OiaotQ4ox5Rrl+kNuqCwYWyycqnEP2thZTTis=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=K8V9/93zvdPexbUOvMyWadFDgHu4VIMUcUundLzaOsyamJ0uHDScgCNkbzi5Rs3Qfc3HzbXPPk9VNLafIwKgPZ0MWP7vCn+RDByTHBd2W3nhgfWU2SL3U+emx9o6ii3mzttHduzw78fT6pevhqfvGXxc5+0iBkbkECnoC9eBviQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com; spf=pass smtp.mailfrom=foss.st.com; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b=fAfyxhY4; arc=fail smtp.client-ip=185.132.182.106 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=foss.st.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b="fAfyxhY4" Received: from pps.filterd (m0369458.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5B58wgxi1827295; Fri, 5 Dec 2025 10:05:12 +0100 Received: from am0pr83cu005.outbound.protection.outlook.com (mail-westeuropeazon11010017.outbound.protection.outlook.com [52.101.69.17]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 4au1yk6gkj-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 05 Dec 2025 10:05:12 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=KN8jtjcG3jGD4HvBLE6LBQESY/REQH/I+27lS3DBtlZrOSAApPxqBTxep/zeYfYge8kgqO01Zeweq5ZiNRHtyMEzuGeU8Q2fyJdh3t3grCT/kH3ySwfny1DamiSSViT/qRdCcYG/Tq9N+hdDipaHM7xXgjv3ihiG12YifFS4yqsfj+i0rXyw6gASoJMZFx6MdYYQG+jqp1nKdM7uriWGEXD4QFLZUZ5sWgggEvMaVLeKkcN0+bkJUkC91C3LZCY2bLB1VcOJXLsLowpmLvu0GmajYj2Gpv1TY0Kwj4WbppI+ntJRDiTmxyBp6xb3DxExI0K0pY4J2DM2lFeNIaTVqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LzaeKJv5cANruTig0GzxEtqLPYtRnt4s5JNAJTzPQNY=; b=HRX5KOyNXfOAZwbqG2eAQm67OW/oX0qShTJUDsugKSpoMYOVUHBy0oa59HuzKDoS5VorrRBB1QFKPaobT95mt5n3InrwV3fpfzxN4f7JSU/0d6Ke2GgNQ8vBDkido/khqXp/8ze3oWcXABEYKe5JRDlk7efpBUap/lfdt6oK/1odldMnY/YrixRvCzmXqoEPMmC4zhlWRsOz6nMWy3QWzSDrn+qN0CvGF232Y8GKm2SZhXKk3CmwocOx6jhvdT0MUoyVtd9933srDU7K4kw6fRJ0suwsfjIE68Oa+TkBHjeoe6kdCXbwbYPEmfMiag6/9lrPSPyHNP/sf2qMbumR8w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=fail (sender ip is 164.130.1.59) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=foss.st.com; dmarc=fail (p=none sp=none pct=100) action=none header.from=foss.st.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LzaeKJv5cANruTig0GzxEtqLPYtRnt4s5JNAJTzPQNY=; b=fAfyxhY4JDq5XiTUQ+pPQcutgR2KesCeaCnqKwcS/Th+JrEBMQlA/KMXdLq/cj7aaOEWA9e6uiswzN9khNI3IW53kbUQAave8k+eQTGGsTCCM4KfqF5++No9uVIUx8+dP11Mrru5C5B8iZaihzYYZDhWq9z5Mzdfg/UpnO5oI1pcniB82ds8NAZlI7enPNXePZiBq++6B4Y5VVCbfK26j1KGANCKLFWbHdcYpFoLYon10TYBDSGJj/hsSxjHja27Smj49xrIxyh83mg2ewHr2oLZ7e2B9Wu3olb8A4nUR3VDFsZwgbxE/P8nBOVxOq2iHJq2doZ4DOnUP0NVOkrPAg== Received: from CWLP123CA0271.GBRP123.PROD.OUTLOOK.COM (2603:10a6:400:1d5::19) by DU0PR10MB5387.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:329::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9388.11; Fri, 5 Dec 2025 09:05:09 +0000 Received: from AMS1EPF00000045.eurprd04.prod.outlook.com (2603:10a6:400:1d5:cafe::19) by CWLP123CA0271.outlook.office365.com (2603:10a6:400:1d5::19) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9388.12 via Frontend Transport; Fri, 5 Dec 2025 09:05:08 +0000 X-MS-Exchange-Authentication-Results: spf=fail (sender IP is 164.130.1.59) smtp.mailfrom=foss.st.com; dkim=none (message not signed) header.d=none;dmarc=fail action=none header.from=foss.st.com; Received-SPF: Fail (protection.outlook.com: domain of foss.st.com does not designate 164.130.1.59 as permitted sender) receiver=protection.outlook.com; client-ip=164.130.1.59; helo=smtpO365.st.com; Received: from smtpO365.st.com (164.130.1.59) by AMS1EPF00000045.mail.protection.outlook.com (10.167.16.42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9412.4 via Frontend Transport; Fri, 5 Dec 2025 09:05:09 +0000 Received: from STKDAG1NODE1.st.com (10.75.128.132) by smtpo365.st.com (10.250.44.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Fri, 5 Dec 2025 10:05:47 +0100 Received: from localhost (10.252.31.202) by STKDAG1NODE1.st.com (10.75.128.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Fri, 5 Dec 2025 10:05:07 +0100 From: Patrice Chotard Date: Fri, 5 Dec 2025 10:04:52 +0100 Subject: [PATCH 2/8] spi: stm32-ospi: Optimize FIFO accesses using u16 or u32 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20251205-upstream_qspi_ospi_updates-v1-2-7e6c8b9f5141@foss.st.com> References: <20251205-upstream_qspi_ospi_updates-v1-0-7e6c8b9f5141@foss.st.com> In-Reply-To: <20251205-upstream_qspi_ospi_updates-v1-0-7e6c8b9f5141@foss.st.com> To: Mark Brown , Maxime Coquelin , Alexandre Torgue CC: , , , , Patrice Chotard X-Mailer: b4 0.14.3 X-ClientProxiedBy: STKCAS1NODE1.st.com (10.75.128.134) To STKDAG1NODE1.st.com (10.75.128.132) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AMS1EPF00000045:EE_|DU0PR10MB5387:EE_ X-MS-Office365-Filtering-Correlation-Id: 8bc6f242-6deb-4cf6-8b6c-08de33dd640f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|1800799024|376014|82310400026; X-Microsoft-Antispam-Message-Info: =?utf-8?B?MUdYZlRRK3hhc2c3ZUUvemJGWVk5TFBYenNHZUJIbU9UZ2tyQUcwTjMzSzcw?= =?utf-8?B?SnNOVmtnVHJSQXhjS3dlYnUxRmFtSzRnMUxtWmpKZXNhRHYrZTAwMUZjMFVL?= =?utf-8?B?Q05lTXFCQXZPSXFKcDh5cEJKdWg2Qk15bVpiTXIwdUZ3VDYwMlJUbVFkdWNP?= =?utf-8?B?Yld3dGU3elVoeGUyWmZ5WEdFQUQyUzk4Umt5TUQ1QlFFd2k0L0RQV3hxS3Nv?= =?utf-8?B?TFJGTFNkQXV1ZWV4WWZRaWtVNUhZUE41c1UxcmZWM1VSeGVTUFo1di8zUWRP?= =?utf-8?B?U0tKM0JVbzdqQjJPWlRtQjhlenpOM1VKK3BCUVVwR0RJZ3l6QzM1S3dFVGd1?= =?utf-8?B?QmV1U3RhYW00ejUzRm1uR3BpbkhCNHF3QUYwMmE3SlJwWXAxWFZDaFZDSEpn?= =?utf-8?B?QTBCWUZabWhDOVNtSmZXTEhRd3NMSzRobkFQR24yc0wyWlhPNTdKaHlaWUVM?= =?utf-8?B?OTVnZ2FNaVQxOWw1Qy9wTkczbWd0Z3o5QUk5aGE0YkhOemlXd29EZWIwQXNX?= =?utf-8?B?b2M0WHE2U0VGMnd1NEJrM3V1dFB3bUNySFlvOHdRQXdMbytIZURsbFpoUVNy?= =?utf-8?B?NlhnQ3ZQeWIvMTd2NzM5b1luSE5kbElSWUxkcjUrUjNURXVzZngzaGV0Qnp5?= =?utf-8?B?YVp4aGhJYVZYUlRHVzN5SWxQeFdMa3pxRFdQYm5sdWttaGpwTkxHbGlXMEYz?= =?utf-8?B?OGZvQlltbmRDZnduRmdwUEp4blF4Q2loSVYvVU5IckVyTGR1MWdGMjdxL0ZS?= =?utf-8?B?VUl6WTNJVW1VZXFCSE9Ka296N2t4Q2hYRzU3dVd0cmRPU0xMM0kwbGpQeGhL?= =?utf-8?B?ek9DVjJiMk1mQURJN2lMYUVPQkFUTDZ1RXJLaFliTXNBU2RROWZyYTRMTnBY?= =?utf-8?B?ZVdyNHNOTy91SnY5dEcyVlNHMUxTZmQzNXA1RmQzY05sUzVNNHBWZlJEK0pa?= =?utf-8?B?L3h0ZllzMVVPazBEVUU5SnB1KzJocEhCSUVuQldta1NJei9QTUZzQ2g1RzRM?= =?utf-8?B?REZtZEN2SFlmTktZOGErUTVGU3dlV3RkR1lacCtiamdUN0tnOUxWOVIrZ2hH?= =?utf-8?B?TlFqbHh0SHB2NXU4dzVZV1B0QUxGS3dvVjdHZjlZZHB2VUEvT3pDR2ZoN2to?= =?utf-8?B?UjVOcXVmTkFkSGJaVDIwaXZkcHRVK1VUZkNqT2Q5Q3RIVGdHaDhTUUJNVW04?= =?utf-8?B?YkhLSFJsMFhUMk1SVkRJZlRvZ0JyWWRyYm5ZRE1lb2pOcmY2K013Rmx3d2N2?= =?utf-8?B?MldrczhGdUxzVDRsNnhPYTc0TlFnenE2N0ZFSk56MjlNbUorTW0yOEQwNFdt?= =?utf-8?B?TG95THYyQ3RVWUxJcjRITXUySnJkc1pBQ1dxTFJEc1ZUT1M3czUyY0hkbWtp?= =?utf-8?B?WUZYVlpuQ3ByZmRtMFd0UmdLcU1XRllwV0ViTWhKd2RBc0lEb2gwT1B6YnpW?= =?utf-8?B?R25RK0FINzNCL2lMejdxNWdMRkdhUFdyN2FzakprWEpuR3R4bmtrVGg0M0Fo?= =?utf-8?B?WTJZWkYvK1l3K04zTWtuN2hGK2RmaU1zUFJYYzN3ck9CSktHaTRsYm5FY2Y3?= =?utf-8?B?N1Bzc2wydmJRT1hpUVZiTEFNK0ZmcDc2SitwWE9mbE5YNmNtMDdCQmoxdlE4?= =?utf-8?B?UFBnL3kydk5HZ0JjMzdZcmkxZFB0S0NuZXhvWDRaeGppZTlKOFlKaTVISWpZ?= =?utf-8?B?aGIrdFM2bk12czFyemVJUjRUSGRLd3VVUzJqWTBqUjlqOCszdlNaUGtNaTA0?= =?utf-8?B?ckpIWEo2OGd3TVVBMnZRbU5wM2RoRHJySFc3c2xhZzk5ZVc2aTVHdUNZRkJ1?= =?utf-8?B?cUlSM1RHQTNKZlBEZWpwMVFUMFRTUndRaGZnZVBRSEE2bEtCcUw3WjZvWVBQ?= =?utf-8?B?KzBBakFNcXh2dUgwUDNUNy9PUVp0TDIwR2NYY2dJc1BJRk95NVJNb2lkYjVv?= =?utf-8?B?c3hyOHRMSzdSYU1pc0g4MFhoZzB1R3VuL0pkOUV1VlQ3Q0t1MmdVa0VXd3FT?= =?utf-8?B?V1dBV2xWa3RHNmZiZlB6RjAzQkdvWHVPWCs1dDlwRGV1Qk1zSHhRbWlSNVFh?= =?utf-8?B?bGZvS3p5SUIwVXF3Yk9SeFpod0NtL1BGK0orNVJtT3Yxa1JyZ0UwZ2diQWtF?= =?utf-8?Q?Afuc=3D?= X-Forefront-Antispam-Report: CIP:164.130.1.59;CTRY:IT;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:smtpO365.st.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(1800799024)(376014)(82310400026);DIR:OUT;SFP:1101; X-OriginatorOrg: foss.st.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Dec 2025 09:05:09.1901 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8bc6f242-6deb-4cf6-8b6c-08de33dd640f X-MS-Exchange-CrossTenant-Id: 75e027c9-20d5-47d5-b82f-77d7cd041e8f X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=75e027c9-20d5-47d5-b82f-77d7cd041e8f;Ip=[164.130.1.59];Helo=[smtpO365.st.com] X-MS-Exchange-CrossTenant-AuthSource: AMS1EPF00000045.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR10MB5387 X-Proofpoint-GUID: FtXUnQgIL1RYz_jJuP5xLxKKHWIx0hUi X-Proofpoint-ORIG-GUID: FtXUnQgIL1RYz_jJuP5xLxKKHWIx0hUi X-Authority-Analysis: v=2.4 cv=eobSD4pX c=1 sm=1 tr=0 ts=6932a048 cx=c_pps a=67JRAVsqNSV96jld/LUi8w==:117 a=d6reE3nDawwanmLcZTMRXA==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=Uo5EeBN78AAA:10 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s63m1ICgrNkA:10 a=KrXZwBdWH7kA:10 a=VkNPw1HP01LnGYTKEx00:22 a=8b9GpE9nAAAA:8 a=dgGDXPkSZnP7Mkk4B0AA:9 a=QEXdDO2ut3YA:10 a=T3LWEMljR5ZiDmsYVIUa:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjA1MDA2NCBTYWx0ZWRfX9i9iiFuHvluU piZ2MeXg4Wsh5qyKXm9YKzEM+XmXPcneSYsLFBvAKb+SB7p7+L1UyAz06waZsq0/HTncq0J+FqG LAzzBU9BaFVQmPsvfzSFVrjt+U0ZpKg1p+zj54rjx9IVxwyidanPyOPS0bBvq5NuBGRdlOb+0Sd wSwzDeNa0RnCJH4Kzly46ECl913UNrP04wmNgV6AGVQgVufRlwzSl+npJv9V0CRJkPbcGdPbJmu ZvhzAMLMGzV+2y8oShLM9y9BLO3BSmfc2i4b0j9s4BCGmhbepFIF7e2pdzERJi/s77ka3/1JPZ/ A6ZqbSlegPj2RlLXekSiRCpuhBvJ/j0PQKk4FQkQ5tmLMoI/Qyc6Q/YeFkvb8OibwzKIVe5PIry pvbV3xgm5G0iTY7tFK6PnMYxP2vm0w== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-05_03,2025-12-04_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 priorityscore=1501 malwarescore=0 lowpriorityscore=0 clxscore=1015 impostorscore=0 adultscore=0 spamscore=0 suspectscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512050064 FIFO accesses uses u8 only for read/write. In order to optimize throughput, add u16 or u32 read/write accesses when possible. Running mtd_speedtest on a 4MB sNOR partition using a stm32mp257f-ev1 board gives the following results: before after gain Read : 5693 KiB/s 21139 KiB/s 371% Write: 765 KiB/s 910 KiB/s 19% Signed-off-by: Patrice Chotard --- drivers/spi/spi-stm32-ospi.c | 47 +++++++++++++++++++++++++++++++++++-----= ---- 1 file changed, 38 insertions(+), 9 deletions(-) diff --git a/drivers/spi/spi-stm32-ospi.c b/drivers/spi/spi-stm32-ospi.c index d733e37f0435..a6f53f06200e 100644 --- a/drivers/spi/spi-stm32-ospi.c +++ b/drivers/spi/spi-stm32-ospi.c @@ -142,14 +142,32 @@ struct stm32_ospi { struct mutex lock; }; =20 -static void stm32_ospi_read_fifo(u8 *val, void __iomem *addr) +static void stm32_ospi_read_fifo(void *val, void __iomem *addr, u8 len) { - *val =3D readb_relaxed(addr); + switch (len) { + case sizeof(u32): + *((u32 *)val) =3D readl_relaxed(addr); + break; + case sizeof(u16): + *((u16 *)val) =3D readw_relaxed(addr); + break; + case sizeof(u8): + *((u8 *)val) =3D readb_relaxed(addr); + }; } =20 -static void stm32_ospi_write_fifo(u8 *val, void __iomem *addr) +static void stm32_ospi_write_fifo(void *val, void __iomem *addr, u8 len) { - writeb_relaxed(*val, addr); + switch (len) { + case sizeof(u32): + writel_relaxed(*((u32 *)val), addr); + break; + case sizeof(u16): + writew_relaxed(*((u16 *)val), addr); + break; + case sizeof(u8): + writeb_relaxed(*((u8 *)val), addr); + }; } =20 static int stm32_ospi_abort(struct stm32_ospi *ospi) @@ -172,19 +190,20 @@ static int stm32_ospi_abort(struct stm32_ospi *ospi) return timeout; } =20 -static int stm32_ospi_poll(struct stm32_ospi *ospi, u8 *buf, u32 len, bool= read) +static int stm32_ospi_poll(struct stm32_ospi *ospi, void *buf, u32 len, bo= ol read) { void __iomem *regs_base =3D ospi->regs_base; - void (*fifo)(u8 *val, void __iomem *addr); + void (*fifo)(void *val, void __iomem *addr, u8 len); u32 sr; int ret; + u8 step; =20 if (read) fifo =3D stm32_ospi_read_fifo; else fifo =3D stm32_ospi_write_fifo; =20 - while (len--) { + while (len) { ret =3D readl_relaxed_poll_timeout_atomic(regs_base + OSPI_SR, sr, sr & SR_FTF, 1, STM32_FIFO_TIMEOUT_US); @@ -193,7 +212,17 @@ static int stm32_ospi_poll(struct stm32_ospi *ospi, u8= *buf, u32 len, bool read) len, sr); return ret; } - fifo(buf++, regs_base + OSPI_DR); + + if (len >=3D sizeof(u32)) + step =3D sizeof(u32); + else if (len >=3D sizeof(u16)) + step =3D sizeof(u16); + else + step =3D sizeof(u8); + + fifo(buf, regs_base + OSPI_DR, step); + len -=3D step; + buf +=3D step; } =20 return 0; @@ -408,7 +437,7 @@ static int stm32_ospi_xfer(struct stm32_ospi *ospi, con= st struct spi_mem_op *op) if (op->data.dir =3D=3D SPI_MEM_DATA_IN) buf =3D op->data.buf.in; else - buf =3D (u8 *)op->data.buf.out; + buf =3D (void *)op->data.buf.out; =20 return stm32_ospi_poll(ospi, buf, op->data.nbytes, op->data.dir =3D=3D SPI_MEM_DATA_IN); --=20 2.43.0 From nobody Fri Dec 19 15:51:35 2025 Received: from mx08-00178001.pphosted.com (mx08-00178001.pphosted.com [91.207.212.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7410C30C62F; Fri, 5 Dec 2025 09:05:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=91.207.212.93 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764925542; cv=fail; b=Aa+J73/YqrrCUKFVZrDi6U7VtC0YVBXZr+/G2g0W6XWhZF4CHQ2/MZVAGm1N+83ZRE4yVeDR0xLskqlGOzTNQF0pYAwhtdkQTHgGsD9Q8xnsvrXJalNz6alhfaa4aYjhxzpS6GXEP7ApDE2MccUspaISdYJzuMbbjClNLuUxUzg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764925542; c=relaxed/simple; bh=U4fdL//Ro5ba5O9mohI/SeiZMv74IRBK0ONiAeKLtME=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=o7niV1RR2ywx3rXVeGAC3RMmXaQmJYGkfkYQYKC4b3i4L/tuiMR2ChyO78UvMmucZtbHQEOa96mO3Y29r5xbolXjmah4B06jCbDIDCJh6Pai8Itld9QJ9ExHDDi4rs3b+GtmT2PAyNi3wZvotj8eotIre2n7IrNnWT+WG+pOOmk= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com; spf=pass smtp.mailfrom=foss.st.com; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b=ZvtxcN6F; arc=fail smtp.client-ip=91.207.212.93 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=foss.st.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b="ZvtxcN6F" Received: from pps.filterd (m0369457.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5B592Gk22157980; Fri, 5 Dec 2025 10:05:15 +0100 Received: from duzpr83cu001.outbound.protection.outlook.com (mail-northeuropeazon11012005.outbound.protection.outlook.com [52.101.66.5]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 4autdg0m1q-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 05 Dec 2025 10:05:14 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=EuIne1W3Fbj/1K2weCr2TNIITtgRq9JLNQsEblX0SNQ436mEW/5nSfWkGSJlMX1lP7nDi2Phry7TiJeqeSdQQHcK9L4tDjhXEldv47Y5jgxF+HrgjBp+GQlKHPzIKVGnTUfjYymZAYakLj8AfzwwwP18YQXsePkJSVzkrNNoIJ7ZIWUkS+cEvZ6llGJo9fI3EWk78aTTFS1xm96bQZ1wa5+jtakggEP/Izfrhwj3y6CreJaMUUR1V6/pWF5FIih49CyxZgv+tYfLrCGoBRPpIDZDeiYL+yXdYnHSLs1Kol+O3sIcXY+J27xMvuQ+N4ZINx2mLpowAVUYE0uExD3v/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Y7xfu084263Ypn2kZRG6hJqxbJ5zT/SCoUnS/Qv6sbQ=; b=dTcxFYgDtejoH+UDU+MVLM8xezVFnieIALxfZbzJBWTNKZ/5SMYNoG+rji7OsoLeZ+FCMaQnHhB6h0kzaW6mkW0PHoMxGv759ITZltDTqwyjQA2jH5lC3HsF3E8qmhCurndYsF32UStAjOg72CUIUkYUBbwiE/EjPRTilYwgPEIomYb2H+XPZdx2b3De6r6HPL5ghUCLAZtd5dtxo/b2tGxNs7yF9P4zLViFTuM3IFJrABPztomfOBrIVZK41oxDf06BNwK6E+UqWhSzYSVaRZSnTqqbf0MJaQ6n6FiCAVcpVcGsMpgF6on2nW5Bc25sdJlDg8RuEVh+j9LFrK/CHQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=fail (sender ip is 164.130.1.60) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=foss.st.com; dmarc=fail (p=none sp=none pct=100) action=none header.from=foss.st.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Y7xfu084263Ypn2kZRG6hJqxbJ5zT/SCoUnS/Qv6sbQ=; b=ZvtxcN6F4IX12OdD6mZ6a4g4rC4qF3aLogPWTL+qDbbcrpQlq9CgM1xfN6OYbwqHKpeuBIxOCQ0QJD6jKogJ4xUOsyUQOV8YrU4DV29e+vFA2cIZH7UuCWovWMFkJ4iF5tXtEp5XKObp1vp55K19icGjlk0Yc6vz85YUe1jWgxo5q0D0YR+dKKCUVDEAPZc51XO1vdEgkrjf32EieGDdqMojCMcBQFrnEA4udNHGNTdeyrL3cE2JKIkaUrb6XN/0mA1oQRssce7dtCo3Gx/uq0pQ68BTLz4obf27h2rdpypP3GLVpN134bblVVHR/utZSVkPSQULMBJzd0sEFCSNxQ== Received: from AS4P192CA0047.EURP192.PROD.OUTLOOK.COM (2603:10a6:20b:658::19) by AS8PR10MB7328.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:614::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9366.17; Fri, 5 Dec 2025 09:05:10 +0000 Received: from AMS1EPF0000004D.eurprd04.prod.outlook.com (2603:10a6:20b:658:cafe::a8) by AS4P192CA0047.outlook.office365.com (2603:10a6:20b:658::19) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9388.12 via Frontend Transport; Fri, 5 Dec 2025 09:05:08 +0000 X-MS-Exchange-Authentication-Results: spf=fail (sender IP is 164.130.1.60) smtp.mailfrom=foss.st.com; dkim=none (message not signed) header.d=none;dmarc=fail action=none header.from=foss.st.com; Received-SPF: Fail (protection.outlook.com: domain of foss.st.com does not designate 164.130.1.60 as permitted sender) receiver=protection.outlook.com; client-ip=164.130.1.60; helo=smtpO365.st.com; Received: from smtpO365.st.com (164.130.1.60) by AMS1EPF0000004D.mail.protection.outlook.com (10.167.16.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9388.8 via Frontend Transport; Fri, 5 Dec 2025 09:05:08 +0000 Received: from STKDAG1NODE1.st.com (10.75.128.132) by smtpO365.st.com (10.250.44.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Fri, 5 Dec 2025 10:05:46 +0100 Received: from localhost (10.252.31.202) by STKDAG1NODE1.st.com (10.75.128.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Fri, 5 Dec 2025 10:05:07 +0100 From: Patrice Chotard Date: Fri, 5 Dec 2025 10:04:53 +0100 Subject: [PATCH 3/8] spi: stm32-ospi: Remove CR_TCIE and CR_TEIE irq usage Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20251205-upstream_qspi_ospi_updates-v1-3-7e6c8b9f5141@foss.st.com> References: <20251205-upstream_qspi_ospi_updates-v1-0-7e6c8b9f5141@foss.st.com> In-Reply-To: <20251205-upstream_qspi_ospi_updates-v1-0-7e6c8b9f5141@foss.st.com> To: Mark Brown , Maxime Coquelin , Alexandre Torgue CC: , , , , Patrice Chotard X-Mailer: b4 0.14.3 X-ClientProxiedBy: STKCAS1NODE1.st.com (10.75.128.134) To STKDAG1NODE1.st.com (10.75.128.132) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AMS1EPF0000004D:EE_|AS8PR10MB7328:EE_ X-MS-Office365-Filtering-Correlation-Id: 5cd0d7eb-866c-4d71-b3e7-08de33dd63d5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|82310400026|36860700013; X-Microsoft-Antispam-Message-Info: =?utf-8?B?eHl0WUJqck96SGJEeDUzN2RYRmhwd2JEVGsvcy9nY3BVc1JJRkExQmIrTlIz?= =?utf-8?B?SU5mWFBoeHAyMjBPOGRna2VLYW5UVVovd3NENFpXTjF4M0Vvbnp3VFJ5WmJG?= =?utf-8?B?Mkt2am1BNG5HSlRpZEJTLzIrTm14UGwyYnhpNWFueUhXbXltSFVFV3pIYXZ3?= =?utf-8?B?d3BLUjlyN0pTOS9PdE1udC91WmZ3aC9nYXJvYkhyMkhHazQvajNydlYxYXk2?= =?utf-8?B?WEhiRWRpUUNmZmNOdVlTR2Y2NWJLSEErVkhwNDk2OW5jNEhlb1VNbWhLWjVV?= =?utf-8?B?MENuMmdQczVaNDRtZ3g2MS9BZ1hHdHdtcXNESE5vNWdpY0VIN3dzSUhlRlpM?= =?utf-8?B?WlZIWGwrL0xOdG1wK3BwQkdUbVoraUs3ZnMzSWVZTFg5dzUvQTV4MWpkZDg0?= =?utf-8?B?Wm5KZzFXV0M2YWFPU0JJMlkyMkI2eUlZMnF1aXJCNWVsWFNJZ0pzVHVzZGJi?= =?utf-8?B?TGNYYTVDMlJCeFpUTEdhcE0wOS9uTk5JNmg4UVBKVmJ3ZHJoLzd6QzhBdEp3?= =?utf-8?B?UGNyMkhOZXA5NFdMbzR2VlhTb0Ywd0JYV0V6R2lWRWppT29GOTYzUjhLWFpJ?= =?utf-8?B?Rk9vVHZJTkE5cTZSQSs4QldqNVpUZ1RkWks5cEJBcnFqOC9LbW5UOUFJY20v?= =?utf-8?B?cStlRzVyYkN0bkh1RElWdlFicE92SjRiWk10NjkrRndPcDVWQTh5ckpGTm93?= =?utf-8?B?NkJmWGhraUVEQld5YkhURkM5UkZrVGR6ZDAxNUEwY1REZDVyZlY4azNGZmM2?= =?utf-8?B?YUZ6L29RRDdYL1VvUlJJd3pwWkJNOGJKNkdFSjhDOFpsczVLWFkrc0RwM3RZ?= =?utf-8?B?VVVSNkVBOW1DcXlwV2tkcFdrZ09EZFFsQ3RYYjMrdVFlTGthS1AxQzVGZ0Ru?= =?utf-8?B?ekVFZ3B0cyt3azVPSmx0a0llOFhSMytjMkpLSWtkVWdLNVVVNmNIWndUTEdT?= =?utf-8?B?S3BaNWhoTEJzM29PeU9qNHBhWWpoQ1RoMjFoK3pGa25OMnNnUE44UnI3ZlI3?= =?utf-8?B?MnByV1NLY1BZWFVSMy9MUCszOTdlV21udjRKQnNwRU50dmMxNTd0ZDlPMVFV?= =?utf-8?B?cFB0KytnWit4VzhKZ0o0TVFpTnJBTnh1TitxUTdQY2lyUWQ5RHYvK2dWVGpK?= =?utf-8?B?Nk5FcFFQZVdhWlhTRkZVTjJRSW5IR3B0SEtiUEkzaHV5M1lhTEJ4bjhkYlU1?= =?utf-8?B?d203Vmo4VGZtVk9yZjZiRDQ4aWNSY3FFZzM5VnowN04yTS9BVlpyNzlMcXBD?= =?utf-8?B?YzhiZjFjbDdwaE8rTlA2QmdRQjFCemNIWGFTVDdwWTJUVmJnMXlseXFYRjAr?= =?utf-8?B?NC9TMHlBcGIvSlBaZkMvNm9ZZkR4M3dFWUc0N0ZoNzNJRmk2VUlid3paTXZW?= =?utf-8?B?d0FJaVpNTTdzSzNQc0JKYmhxMklLdldrOXU3RE5yUG51THBEaDdGYWZoZXZi?= =?utf-8?B?VGtZR05aZ21uTXJZaXptN1Noam1VN3hvM3luREEvQ3JjTmh4dlJaa2p4dzZy?= =?utf-8?B?dGR5M2p6c3pyaDlGWEdrUG5ySzBFZmpLT3ZreGxIcmVQM1JKamxJenB0QzYy?= =?utf-8?B?QXV0MTl2MHlMdithTXE3OU53VThZc05lVExpZm92c2Fsd0ZMR09pclJtV1Rl?= =?utf-8?B?TGwzMy9pWDlNbHlEZWVMeWxpNmh0ZUR6VWsweHBFRlJualU2ckVGRkdQeWxQ?= =?utf-8?B?a2tUcGllQUc3S2VPVWdKZlBibTRLeTU5Z2VRd1lFbjJQcVNTVHZtRERzOWNu?= =?utf-8?B?OC9neHFPQnBHWkN3aHRlenJzUkkwWWpEMk4vQnhVTHJnd09rdU85TlV0QlNx?= =?utf-8?B?WThOUmYvOHhNcTFrODNFNDNwcjRlcXhkam96NDJOYmEwZlRwaE9BcmMzVkty?= =?utf-8?B?Ums5L2tTN0x1dXNSUmU0NHI0cTMxVlFrcnRDcXExb2NtK0tVUlJaYTVzU0JC?= =?utf-8?B?K0FGY21STGNHN1hxV1ltSlhiQTFuUWNPdmRubFFicy8zMnlCL0lmbndmRm1J?= =?utf-8?B?UC9hb2dTM2sxRW9SZnlKTUdrNU1ER3NuLzhWd0VubEFLOEZkWkxLSUhzMEJv?= =?utf-8?B?UEwyN081bXBSVzhsYUdwZFhUa0lzK1hlZzNtY2cybHk2djVaT05HSjBrODBG?= =?utf-8?Q?cKM4=3D?= X-Forefront-Antispam-Report: CIP:164.130.1.60;CTRY:IT;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:smtpO365.st.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(376014)(82310400026)(36860700013);DIR:OUT;SFP:1101; X-OriginatorOrg: foss.st.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Dec 2025 09:05:08.8118 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5cd0d7eb-866c-4d71-b3e7-08de33dd63d5 X-MS-Exchange-CrossTenant-Id: 75e027c9-20d5-47d5-b82f-77d7cd041e8f X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=75e027c9-20d5-47d5-b82f-77d7cd041e8f;Ip=[164.130.1.60];Helo=[smtpO365.st.com] X-MS-Exchange-CrossTenant-AuthSource: AMS1EPF0000004D.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR10MB7328 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjA1MDA2NCBTYWx0ZWRfX4YRYXaOoVEnd 30rWjvuK2tGfoKbfuxzZ5K8QNRBAOQKOYm8QGlBeAEypGVgtwdQuIndtnxXigkFP8dlFJ6O1qDi tXNQY4oOyH/Pd/r1f2xoPdDcaJOKWeFRLwP2BBYnyA/HFk/hqmHUOE0RgnP/oT/TEdENZvai+mU ZHx0xhYf/iVKKoNswXivgrAK6Iz1b8KJ2vQCNy9t7l3FGexWnIhpo1htBOFLoYGYoqyvPEK1q5s ATzKLbXJzVig9DdTv+NCcPn6uessrWNI0CQcOD/42uF+ttR1C9FwJDrTDNuse41s2xiyaAum90I ltrSRPH/5emg7bL/PSuO9CA9lOAgKSJPf9vwg5JkpBAI+u7gmdodC58hZxMtTwvdKZnb9Wz2HqK QwQB3knt2EDHRgLxaGKPlZiHSWYjTQ== X-Proofpoint-GUID: 9W2QPuuPdIAK5N4EUZlZsDUJqBO8yOjy X-Proofpoint-ORIG-GUID: 9W2QPuuPdIAK5N4EUZlZsDUJqBO8yOjy X-Authority-Analysis: v=2.4 cv=YrEChoYX c=1 sm=1 tr=0 ts=6932a04a cx=c_pps a=4X+iVNKrLEFvYFcl14eRNw==:117 a=uCuRqK4WZKO1kjFMGfU4lQ==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=Uo5EeBN78AAA:10 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s63m1ICgrNkA:10 a=KrXZwBdWH7kA:10 a=VkNPw1HP01LnGYTKEx00:22 a=8b9GpE9nAAAA:8 a=4C2JBV8IMr3zZ6XvoZwA:9 a=QEXdDO2ut3YA:10 a=T3LWEMljR5ZiDmsYVIUa:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-05_03,2025-12-04_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 impostorscore=0 adultscore=0 malwarescore=0 suspectscore=0 spamscore=0 clxscore=1015 bulkscore=0 lowpriorityscore=0 priorityscore=1501 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512050064 Replace CR_TCIE and CR_TEIE irq usage by a read_poll_timeout_atomic() in stm32_ospi_wait_cmd(). It will reduce the time waiting for TCF or TEF flags to optimize throughput. before after average time spent in stm32_omi_wait_cmd: 5685 ns 923 ns Signed-off-by: Patrice Chotard --- drivers/spi/spi-stm32-ospi.c | 31 ++++++------------------------- 1 file changed, 6 insertions(+), 25 deletions(-) diff --git a/drivers/spi/spi-stm32-ospi.c b/drivers/spi/spi-stm32-ospi.c index a6f53f06200e..d8d72e2fb4bd 100644 --- a/drivers/spi/spi-stm32-ospi.c +++ b/drivers/spi/spi-stm32-ospi.c @@ -34,8 +34,6 @@ #define CR_ABORT BIT(1) #define CR_DMAEN BIT(2) #define CR_FTHRES_SHIFT 8 -#define CR_TEIE BIT(16) -#define CR_TCIE BIT(17) #define CR_SMIE BIT(19) #define CR_APMS BIT(22) #define CR_CSSEL BIT(24) @@ -106,7 +104,7 @@ #define STM32_ABT_TIMEOUT_US 100000 #define STM32_COMP_TIMEOUT_MS 5000 #define STM32_BUSY_TIMEOUT_US 100000 - +#define STM32_WAIT_CMD_TIMEOUT_US 5000 =20 #define STM32_AUTOSUSPEND_DELAY -1 =20 @@ -116,7 +114,6 @@ struct stm32_ospi { struct clk *clk; struct reset_control *rstc; =20 - struct completion data_completion; struct completion match_completion; =20 struct dma_chan *dma_chtx; @@ -240,22 +237,16 @@ static int stm32_ospi_wait_nobusy(struct stm32_ospi *= ospi) static int stm32_ospi_wait_cmd(struct stm32_ospi *ospi) { void __iomem *regs_base =3D ospi->regs_base; - u32 cr, sr; + u32 sr; int err =3D 0; =20 - if ((readl_relaxed(regs_base + OSPI_SR) & SR_TCF) || - ospi->fmode =3D=3D CR_FMODE_APM) + if (ospi->fmode =3D=3D CR_FMODE_APM) goto out; =20 - reinit_completion(&ospi->data_completion); - cr =3D readl_relaxed(regs_base + OSPI_CR); - writel_relaxed(cr | CR_TCIE | CR_TEIE, regs_base + OSPI_CR); - - if (!wait_for_completion_timeout(&ospi->data_completion, - msecs_to_jiffies(STM32_COMP_TIMEOUT_MS))) - err =3D -ETIMEDOUT; + err =3D readl_relaxed_poll_timeout_atomic(ospi->io_base + OSPI_SR, sr, + (sr & (SR_TEF | SR_TCF)), 1, + STM32_WAIT_CMD_TIMEOUT_US); =20 - sr =3D readl_relaxed(regs_base + OSPI_SR); if (sr & SR_TCF) /* avoid false timeout */ err =3D 0; @@ -293,15 +284,6 @@ static irqreturn_t stm32_ospi_irq(int irq, void *dev_i= d) cr &=3D ~CR_SMIE; writel_relaxed(cr, regs_base + OSPI_CR); complete(&ospi->match_completion); - - return IRQ_HANDLED; - } - - if (sr & (SR_TEF | SR_TCF)) { - /* disable irq */ - cr &=3D ~CR_TCIE & ~CR_TEIE; - writel_relaxed(cr, regs_base + OSPI_CR); - complete(&ospi->data_completion); } =20 return IRQ_HANDLED; @@ -884,7 +866,6 @@ static int stm32_ospi_get_resources(struct platform_dev= ice *pdev) dev_info(dev, "No memory-map region found\n"); } =20 - init_completion(&ospi->data_completion); init_completion(&ospi->match_completion); =20 return 0; --=20 2.43.0 From nobody Fri Dec 19 15:51:35 2025 Received: from mx07-00178001.pphosted.com (mx08-00178001.pphosted.com [91.207.212.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A50A02FD1AE; Fri, 5 Dec 2025 09:05:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=91.207.212.93 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764925543; cv=fail; b=JjhumZiJ4X1CCvjvf4GVQjDwdYeqlVRTCQn4vTpasL7mqixSk2ixyr0cEiHJ8ntJmfdd6QOyiQ20cxpR049Kx4vil/MmhVSbVy1jPvs+Wvy/AkXSgSOERv/TZuuHK+RvnN5wfXxRKOeuHBCNdH3bc7QfOJbO5/vI18nkjW/G1ss= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764925543; c=relaxed/simple; bh=KyuJVyemZVrEHX7JOqhlg47dhunWk1UfGwz4fr0NHPg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=mMU4abhD4OHXbMmapAUBIQHpn2BuB3aLWlJDm8bmOFO2Y/7VJ84eKcjc9wy8RLDG4zY0Z6Ocs3PRgTb3/o/rV7FaewjI+wOB4RNmPDAemryuSyv5KH/P4UEp96KfUcBpZIdaWvEMhRphmWQXQKKxtWOnaqHPNHKfHYnl7rlM+Fw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com; spf=pass smtp.mailfrom=foss.st.com; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b=SLBLarON; arc=fail smtp.client-ip=91.207.212.93 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=foss.st.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b="SLBLarON" Received: from pps.filterd (m0046661.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5B58p11F2028714; Fri, 5 Dec 2025 10:05:11 +0100 Received: from am0pr83cu005.outbound.protection.outlook.com (mail-westeuropeazon11010051.outbound.protection.outlook.com [52.101.69.51]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 4aub8nb5a4-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 05 Dec 2025 10:05:11 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=mjCvGJYFUJ+Gary1OC4VoEyndE0SqcprN2z9C5mp45cEgxNbv2z3SfLA0jSzLy83Lj0X9mF41fCOW0F2qbcfyCvt9uszCZOGenA1dTIqPNEhjozXClzrOLNsFCoU52f4j3a2fc7QrI/4lF4cTQR0B/05QbUJ+KgWjkuHakGi0PZz+BH/Ipgwc+HWIbPkjL0D7gGhH/12eBCiEtWwXRS1/pyCrci3ZWpVjUE2Zj3MkjwS0kHK52GQEySgg1QHlaFpHBoxM+8A4JrVzPXU7ns9FihdX3RrswwwfVOiWfYd4PiDpasdgOx7nNAW2ri0g0KVTdqdio91g8oJjAwtUiv0Hw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=W7Adm03ZmolD+QGZ9Jra6lR7ymFqBARLsD1zWwfnScM=; b=aIMxRfKIYBQahUaXeqKJCRtNF9FnCLB1Je7DeGOb5MdbyVqKfxyQ79EY1UFECXorQrMebJkeofxHfd8MD2udNDWAT0UrsqJAsGZHezMmOfkKFCQYuz6SYK7LP6VSoJwo9BqIDS8rVgoXI0dXQlqscPgR4izETRwfsYyBAOy2o9z0avnkp+s+Pvbe+S9CqmilddG7m3Nhuy1Nr3ljbaOLd2OEpXOhNinILotfNx1rZ4HMloxeIhX18h4W4OqnWh7ZV9GaCgKJ1eP91j/lTdSisxtyiUTRYtgXJTXYsn0bYuiLbhgfJ3TG1NW1ieqYOI3DCi0RBFqhLRPPxiIJZPpMTw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=fail (sender ip is 164.130.1.59) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=foss.st.com; dmarc=fail (p=none sp=none pct=100) action=none header.from=foss.st.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=W7Adm03ZmolD+QGZ9Jra6lR7ymFqBARLsD1zWwfnScM=; b=SLBLarONya4im4AcHRhkINp9C/6yGONlLiDqfNHMunX1KUOTcpnAhMuGia9GKsgjnBiS/z4HwJXk0c8p9JYRd5lPwfKkDXpDw9PqVrfhBC5rweoKsxCzUb2Rp0E7hoPrFxx7Je7a/4qq8ndva7+ycKdiKI+xSK9sy+o3UmhQA8pvtgzSSgVVM5CFJBVqkIfiAhcVZVUwnodeg5yqUFUpRPoN3n1R78pzFGqffiiWGkShty4bQFQbdf8pj4Pc50zbYmgQHpTOyvefIYvoB+sUo5FJFg+mFRuR3RgRQZbSs8fJ2i6W935rnHRttGxBcw/sg2aQ+c+yu18NVb9BO3itdA== Received: from CWLP123CA0270.GBRP123.PROD.OUTLOOK.COM (2603:10a6:400:1d5::17) by AS8PR10MB7499.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:5ae::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9388.9; Fri, 5 Dec 2025 09:05:09 +0000 Received: from AMS1EPF00000045.eurprd04.prod.outlook.com (2603:10a6:400:1d5:cafe::2f) by CWLP123CA0270.outlook.office365.com (2603:10a6:400:1d5::17) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9388.12 via Frontend Transport; Fri, 5 Dec 2025 09:05:09 +0000 X-MS-Exchange-Authentication-Results: spf=fail (sender IP is 164.130.1.59) smtp.mailfrom=foss.st.com; dkim=none (message not signed) header.d=none;dmarc=fail action=none header.from=foss.st.com; Received-SPF: Fail (protection.outlook.com: domain of foss.st.com does not designate 164.130.1.59 as permitted sender) receiver=protection.outlook.com; client-ip=164.130.1.59; helo=smtpO365.st.com; Received: from smtpO365.st.com (164.130.1.59) by AMS1EPF00000045.mail.protection.outlook.com (10.167.16.42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9412.4 via Frontend Transport; Fri, 5 Dec 2025 09:05:09 +0000 Received: from STKDAG1NODE1.st.com (10.75.128.132) by smtpo365.st.com (10.250.44.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Fri, 5 Dec 2025 10:05:49 +0100 Received: from localhost (10.252.31.202) by STKDAG1NODE1.st.com (10.75.128.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Fri, 5 Dec 2025 10:05:08 +0100 From: Patrice Chotard Date: Fri, 5 Dec 2025 10:04:54 +0100 Subject: [PATCH 4/8] spi: stm32-ospi: Simplify SMIE interrupt test Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20251205-upstream_qspi_ospi_updates-v1-4-7e6c8b9f5141@foss.st.com> References: <20251205-upstream_qspi_ospi_updates-v1-0-7e6c8b9f5141@foss.st.com> In-Reply-To: <20251205-upstream_qspi_ospi_updates-v1-0-7e6c8b9f5141@foss.st.com> To: Mark Brown , Maxime Coquelin , Alexandre Torgue CC: , , , , Patrice Chotard X-Mailer: b4 0.14.3 X-ClientProxiedBy: STKCAS1NODE1.st.com (10.75.128.134) To STKDAG1NODE1.st.com (10.75.128.132) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AMS1EPF00000045:EE_|AS8PR10MB7499:EE_ X-MS-Office365-Filtering-Correlation-Id: 73961098-46de-40d0-c972-08de33dd6448 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|82310400026|376014|36860700013; X-Microsoft-Antispam-Message-Info: =?utf-8?B?QytkTU1EdDJaSFFwQjlTUXQ3MGRXb0ZkKzNpd1dUeEVTZXVMcU5MUGxLY1dq?= =?utf-8?B?N0ZoSkFtWW5ES3N6dlRMc2NuR05KTHJOak96OHBFdllGTTltbzJtMnpJVUJG?= =?utf-8?B?Nm00dWhoYjJJZW5BNU9oTldhTFJWaFh3ZFo5Z2pBTGJYQVlUOWZuSzJac1ls?= =?utf-8?B?SVhOSkZ1UjNMeUpaOGExaDVpVGJxYm9uQXFnZWFOYnc3UXpRT0FGOFpiUlJ3?= =?utf-8?B?ZGZ6NFVrb0Q1UTFkYm1rY1VzU1QwanVxazYxdnNTcmV5TTRZSFdqQkFPOWZh?= =?utf-8?B?S05HY2EwaUR6c2R3UnNicEJ6aFV6bjJETi9ualhXYlNDNGJmM2VOb3grWWp5?= =?utf-8?B?bjJ4SmhHTkovTVh0NjljbzRiMStzYlRzOXBDMlpoMHlaeXZNT0VmMlBXWkNW?= =?utf-8?B?VklwcnpFdDAxRjQvU2xFSFdsdU5BZUpDazBoQy9WMCsyMEZLWWFjd1JtOS9T?= =?utf-8?B?RFNnU2tiN2ZHMHNNb3JqMjhFaG9kaEhMcWpPallxVlJhOGRtMm5QbjhtRUV6?= =?utf-8?B?QmI1SmJhNmVLWlFTeENiakRiMEpONTloVytqRHlmYmZjM1V2anFqUHQ0Zmpt?= =?utf-8?B?YzZnR2xRRzREY0FyRThtT1JEWVBwOFNtdXhSL3lCVit0dlAyQUoybmUwbEsr?= =?utf-8?B?RmZkVGtaUHo5YkVuSXArQ3MrSW9jZlJuc09QakxsbGxDbnNCUU5mMWtUK2RU?= =?utf-8?B?YVBrWnlUODRTbjUzd1dIWng5ZWtFUlhlekEzMnkxK1VsQVVVRTJFaVdvS3gw?= =?utf-8?B?RlYvVWd6cDVBcVhKOXhSbGVvUmZwbEF5WE9HQ0d0SzNVeVNIVnVIY3JSQW9w?= =?utf-8?B?SE1xUmx3ZFhtMjF3V0pJWGc2eDRRbXRIaXZoNUtVSEpzZWwyM2lyUk1NRXFk?= =?utf-8?B?WUhrc1BYZnI2MHBxanRuY1I2QXZxekhiZzMzYmU4ME1YcmdqdWdJdUg0Z0lD?= =?utf-8?B?SldQQSsxVzJSQTVZM3B3N3UrK1MzSzdPUDRTbmtxbWQ3dVcvaFVodmpiZUNa?= =?utf-8?B?QjdJK2JFY0FEYVlLREV6M21YbmdSK1c0SXQ5N1p3TlQ1SzBQcVhzNlErUUdq?= =?utf-8?B?VFYyQ1ZWQ0IvdFh3WU1XUXVibW1kZzk5WE5PVXpkbWRScXpqZWxhRTZ0K08x?= =?utf-8?B?Z1ZIUXhva0lHckJZU1ZIOU1odk85ZmRia2tCWVc1em4vVVFuaTdZQ0Irb3FU?= =?utf-8?B?eDRZMzZnMWdTa05OYUdDbXRGandUMDBtb2lLUGJ4QUgyVE1KZXUya2ZJZWxv?= =?utf-8?B?ZFAyS3I5MkFVTG0wVERUa3l0c1BFYkpnYWF0R2ZueHJ1NzhZYi9xSEw2U0ZI?= =?utf-8?B?bHdzR2ZjeXZHMUxuTjkweDBGMHd2L2tQbHZKSzJFeENpSENQWXFNUmFzR1JK?= =?utf-8?B?QjZxdWRVL1pwL2NwazVEVWRQMWhtZk9MTWhjcVFXenZycHA5S0krOUhMRkJ3?= =?utf-8?B?TERVNngwQWlBY3V2bUlqbVdDUGd6MU9LczVVN011RmpKblFLQi9nUENqakZI?= =?utf-8?B?eHZQVFZkck9KRUxXWFlaNm1SZUc1b0tHQU41dTNIQTJMUmRsdXpyb3lKQjZC?= =?utf-8?B?MHZIWjU3YVVaL05TWXpwUnVGazBIRUZTNVBYSk92QzhWSEVsTDc3dnJkaVR4?= =?utf-8?B?M3NXWXl5eU9iNmtzUEtMQXNDcGlVbXRaN2pVd0VLNnlzZ1JrM3VISlVNMUtF?= =?utf-8?B?ZmVNa2xaRzllNjBBRzV0Qmk2NFRhUkxRUytMYk5LM1ZrUmpvWlRaM3FBMGNx?= =?utf-8?B?eEp1ek1MUjl5MEJmOEJuMUsxMnVXTUpJM0NzZ3g5WlBRVGl1TlhsY0FJWWhS?= =?utf-8?B?NlpSRTlUUlgzUGJFaHBKWGMxZURXb05Wd1ptL05ZMjhodDI4ZDgyY2F5R0JR?= =?utf-8?B?V0Nua3lsQzVaQjAzcnR5SjIzMTArZzNVY1ByQk0ybkc0QU1IVDh2QVhNL0lK?= =?utf-8?B?VWVraUlnbldvM1R1V0ozcmdwVmxuRVNnVXBhaTByejAyZC80K3JOLzVDNkU5?= =?utf-8?B?VEc4Z0xYSG9lWm1hcDRZVTVVUmRqTWJVS0FpZHg0S2gwNEhQTUUxb0dvMmRF?= =?utf-8?B?ckovWXdOSWlHVVRNWlRvaTFxS0JNNDY0WFNDOGtCZXlValJpM3B6amFHMGZH?= =?utf-8?Q?/rH4=3D?= X-Forefront-Antispam-Report: CIP:164.130.1.59;CTRY:IT;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:smtpO365.st.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(82310400026)(376014)(36860700013);DIR:OUT;SFP:1101; X-OriginatorOrg: foss.st.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Dec 2025 09:05:09.5691 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 73961098-46de-40d0-c972-08de33dd6448 X-MS-Exchange-CrossTenant-Id: 75e027c9-20d5-47d5-b82f-77d7cd041e8f X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=75e027c9-20d5-47d5-b82f-77d7cd041e8f;Ip=[164.130.1.59];Helo=[smtpO365.st.com] X-MS-Exchange-CrossTenant-AuthSource: AMS1EPF00000045.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR10MB7499 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjA1MDA2NCBTYWx0ZWRfX8PPqrrS0Nhqw +iPFMweJCfaco3HkxG/CgA4Qczl7gb3c5ROgnqozo3azW8+f34kP1E9VolYiEeiF3gUspV/xoDw AWZgii2x4z1vMFV2QeKng1MNqsaXRcUIkhznXdcwqEAL83285h4RU20CxDjKLcOEQLEhjmBjsAE Ad1hjxvFq3NpLsqhOm6nj4pvtAqCFtc+OZtkOEemQnWXjtbyGRqqZUbyQZ9kcSs3mHuI2ZCe1y+ IE2H07g2nkGJb71Kk9eTnUeijz1/Am5WgC78yuRANk7UjtaqGETvlGTaDKNqafoLewi6RYGEe2c YJRzTfP6cwn9yW9xSBdGF6A6KihSW8MNqqrTGR/oozq8eqPZ/GEv24DoRo1v5rsDj7pgVT4T4dG L5MBNyhjIQVn4GHUyAvuoDdH9nd40g== X-Proofpoint-GUID: fi9edONVHQTIuB6RIZYSNk4OinXSFjFe X-Authority-Analysis: v=2.4 cv=X99f6WTe c=1 sm=1 tr=0 ts=6932a047 cx=c_pps a=QfNz7WxyfdFdmo+E+Fz36w==:117 a=d6reE3nDawwanmLcZTMRXA==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=Uo5EeBN78AAA:10 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s63m1ICgrNkA:10 a=KrXZwBdWH7kA:10 a=VkNPw1HP01LnGYTKEx00:22 a=8b9GpE9nAAAA:8 a=y85xp1xkQ9wiHhBLIzMA:9 a=QEXdDO2ut3YA:10 a=T3LWEMljR5ZiDmsYVIUa:22 X-Proofpoint-ORIG-GUID: fi9edONVHQTIuB6RIZYSNk4OinXSFjFe X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-05_03,2025-12-04_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 impostorscore=0 malwarescore=0 priorityscore=1501 adultscore=0 clxscore=1011 bulkscore=0 spamscore=0 phishscore=0 lowpriorityscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512050064 SR_SMF status bit can only be set if CR_SMIE was previously set, keep status bit check only. Signed-off-by: Patrice Chotard --- drivers/spi/spi-stm32-ospi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-stm32-ospi.c b/drivers/spi/spi-stm32-ospi.c index d8d72e2fb4bd..8f7bf6c582c9 100644 --- a/drivers/spi/spi-stm32-ospi.c +++ b/drivers/spi/spi-stm32-ospi.c @@ -279,7 +279,7 @@ static irqreturn_t stm32_ospi_irq(int irq, void *dev_id) cr =3D readl_relaxed(regs_base + OSPI_CR); sr =3D readl_relaxed(regs_base + OSPI_SR); =20 - if (cr & CR_SMIE && sr & SR_SMF) { + if (sr & SR_SMF) { /* disable irq */ cr &=3D ~CR_SMIE; writel_relaxed(cr, regs_base + OSPI_CR); --=20 2.43.0 From nobody Fri Dec 19 15:51:35 2025 Received: from mx08-00178001.pphosted.com (mx08-00178001.pphosted.com [91.207.212.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 906593164C1; Fri, 5 Dec 2025 09:05:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=91.207.212.93 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764925543; cv=fail; b=Vj4s6aOgd2XRA7gA3+yYrvd/VQAyvFcZL4gXfpZYFnIAIe/rX/nWs/d4XuHWzzOELvJpiI8/NB8rtzJ5h8GQj/6QAexeqUlZimfiHGGOImrpjyDPdgbKQEr86ns8fj5O+YpTb3NfJQa3frDIU0N+PUcHkiZVdLAq3shyoyRmCdU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764925543; c=relaxed/simple; bh=ymo8xZYUg77rVc0sLjSrp8og0ZhoLhT433KHxEFF9F4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=AaGJ28BcB8qsKewDG+4YsDiG04n/Zawwksr80SheUCuu1fH0UE0fA6kHFgcSSuOFV8w0V0gjV2JXItIwAE+IYubJkbtfMIiFNNJXU3HKB2m0bLTIYk8OOBCLZjFJswRjjXIrZ8nuIWs8t58ly9XQieHLU2QrGInY/dzfTRj3yTE= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com; spf=pass smtp.mailfrom=foss.st.com; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b=YVXZ+6An; arc=fail smtp.client-ip=91.207.212.93 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=foss.st.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b="YVXZ+6An" Received: from pps.filterd (m0369457.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5B593u8w2161975; Fri, 5 Dec 2025 10:05:16 +0100 Received: from osppr02cu001.outbound.protection.outlook.com (mail-norwayeastazon11013006.outbound.protection.outlook.com [40.107.159.6]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 4autdg0m1w-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 05 Dec 2025 10:05:16 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Dcxmt4tfDhFHpS926pjTtgVome7le854qoda3GYN2quF3iVhKK0GaTrPRM/eLHG+ERpLYqXhfnJcfu1jVkip19hQABUQLmDHKo4HMntmKPvYvPSq/nB7OOnXBBqUzSQ/mZrw/BW2dANDbVS6BB+mjJbD5kUc66nIBhjezt9gK+PbNbEqML1GQ3Pn9O6O1ZTI+9yN0gVlvomANApTl+RrJXeSyc//YHzkIh87Q9McIwwG6/nnJrEbgnqlU16mAmabYGc8+nHnn57YbiHILRZkYhiBOw6x0NqQM9zeEeLbf3KJ9nTd2W88+YXaPITJ2J9i5LI3QCfUl3Qnm4FT0jVF4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pIPsugvH6/2RuNayya6SvcHqgg3UV2mz+DTzLtRGsVE=; b=WHI+cHJnLfwODnhXFHDtattcAbQeIfbA7wtClU+8S6+KPt20vA9X5GI1D8TS8liSkdOOtYEufPtIbQcwCdGtCj9+cN3z9Bsj8bGJiXH6YT3GwyU9F7ImyE1+jylXNYoa+POGfuq7T9zagoIBakrMnxIZSrsNxPyKyEV1eacs07h3egt7LUacLdfK+UdrE1sCqdtoUOMfuTqpWiaZf8kBCCwEUvdgDtQGzCYRFD38rgWvwVII4Sr9XvpZGVH0WwU8mSpctLGA0tlqMk3hFfdckIicxgS/8we385ApJWl5fITPaeobUkWzw0j3FstOQJ55j4bZAq8vJS5dr+qcTB7pAg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=fail (sender ip is 164.130.1.60) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=foss.st.com; dmarc=fail (p=none sp=none pct=100) action=none header.from=foss.st.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pIPsugvH6/2RuNayya6SvcHqgg3UV2mz+DTzLtRGsVE=; b=YVXZ+6AnnxpWjnNtrDknnd0MZ5Q0AKTNuDbZMcp13VqOVDLkCdYBDJfYoQg7GGpoAN2EblAfyHQ6GTk/SggY6vge9n9KXvly7iI1UsWOszmjGonXIQ+LuCGL3RLEDEpiYmgecSQBZuka1+CLkZmtXFTlXF/OSREDJNF6Q+2lkHj7xDZ5IhIWx0wZAZUIudU6A7Y9SrNzFwYuNFhaWQjF/Ae/fK3Hw3y7yaj/+mtlykXWa7BOL+whXbzCtKpMFQ3Q7pKl/ltBvkqDJSiNBqGhHwDosbGhRlEfG26vPuJ42z7hjEmNkCEp9fVIg8FohmIcHpvy4JM2A1jK/RHzkx4n4g== Received: from AS4P192CA0045.EURP192.PROD.OUTLOOK.COM (2603:10a6:20b:658::25) by GVXPR10MB9106.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:150:1e1::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9388.12; Fri, 5 Dec 2025 09:05:11 +0000 Received: from AMS1EPF0000004D.eurprd04.prod.outlook.com (2603:10a6:20b:658:cafe::38) by AS4P192CA0045.outlook.office365.com (2603:10a6:20b:658::25) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9388.12 via Frontend Transport; Fri, 5 Dec 2025 09:05:11 +0000 X-MS-Exchange-Authentication-Results: spf=fail (sender IP is 164.130.1.60) smtp.mailfrom=foss.st.com; dkim=none (message not signed) header.d=none;dmarc=fail action=none header.from=foss.st.com; Received-SPF: Fail (protection.outlook.com: domain of foss.st.com does not designate 164.130.1.60 as permitted sender) receiver=protection.outlook.com; client-ip=164.130.1.60; helo=smtpO365.st.com; Received: from smtpO365.st.com (164.130.1.60) by AMS1EPF0000004D.mail.protection.outlook.com (10.167.16.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9388.8 via Frontend Transport; Fri, 5 Dec 2025 09:05:10 +0000 Received: from STKDAG1NODE1.st.com (10.75.128.132) by smtpO365.st.com (10.250.44.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Fri, 5 Dec 2025 10:05:47 +0100 Received: from localhost (10.252.31.202) by STKDAG1NODE1.st.com (10.75.128.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Fri, 5 Dec 2025 10:05:09 +0100 From: Patrice Chotard Date: Fri, 5 Dec 2025 10:04:55 +0100 Subject: [PATCH 5/8] spi: stm32-qspi: Set DMA maxburst dynamically Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20251205-upstream_qspi_ospi_updates-v1-5-7e6c8b9f5141@foss.st.com> References: <20251205-upstream_qspi_ospi_updates-v1-0-7e6c8b9f5141@foss.st.com> In-Reply-To: <20251205-upstream_qspi_ospi_updates-v1-0-7e6c8b9f5141@foss.st.com> To: Mark Brown , Maxime Coquelin , Alexandre Torgue CC: , , , , Patrice Chotard X-Mailer: b4 0.14.3 X-ClientProxiedBy: STKCAS1NODE1.st.com (10.75.128.134) To STKDAG1NODE1.st.com (10.75.128.132) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AMS1EPF0000004D:EE_|GVXPR10MB9106:EE_ X-MS-Office365-Filtering-Correlation-Id: a44cacc7-9934-409f-dfcc-08de33dd6519 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|376014|36860700013|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?MWNnUHllTXdYRTU2RHNJZEVmaVZISlg4alJIMTUxM0I4YSt0MHFwY2xFQUdy?= =?utf-8?B?N25DSC9EaDZKNnlTSHhrK0JEYWJMSnYzejgvdWRSNDhlYWZXNzNsMUxNdng3?= =?utf-8?B?UzdQWTh4UnF2ZUVyNnkrcXJ2em5mbW5FOU1qZTlBWVg1UktoNW5Qb3gwQ05J?= =?utf-8?B?cVdUaWNOa0dyS2ZaY2Z4aWtSVmdnTkgzdStDc1owOXZ0U0dzREZFNmhNQjYw?= =?utf-8?B?ZXQ0a2ZWTXd4RWtSVFEwekkrd0NKdG1FS1l5cmxRUVlzbkVxV1pEV0prZ2lt?= =?utf-8?B?Y0JJK2NiNjFsbGZGT1JCWVhKckhHdm95RXZBb2txOUV1MkVsU1pyYUxoTitm?= =?utf-8?B?Z3lVRWpTRC9MK0w5ZElFK3l1eUdaNVdPK0p0Q3FzNzU1YVV4QlVVeTVtUlpE?= =?utf-8?B?bVd6NEllM3FwK2JFQ2VJc3ZTbFhWeElxT05KMFhNaEdOOHMzU2F1SThxekpp?= =?utf-8?B?L3RJekdpVldxcVh2QmxncXgwTGt1MERlZTJibUFhdnpZeVE0cU5VSmZUQmN6?= =?utf-8?B?WVZ4dFJkUG15ckk3OEcrNnpHbkgyUW1LWmZWeHRhSnpiQjkveE1uWVNpU2U3?= =?utf-8?B?QjVhYitSUGFRZ0Nzbms2T3VYaWR3NjdNRWxERXpBa3pSU1UyTVJOSFRISlYx?= =?utf-8?B?VWhQUW1QeFQ4ek1nWnNnaFh2Z3RHNkZ6Qm9oQU9keWxlWXBlazM2VStuODk2?= =?utf-8?B?d0lxb2xmYlBpMy9yQ0dNMUlnYkF5cDN4b0dqMVIxTk0rdDBtZk1SWldYcjVS?= =?utf-8?B?dmd0Ny8zUWpJS2hTalEyU1lMRUdUdW5YQ3FlbjNjQVBKRmsxQXY2WDdvcHl6?= =?utf-8?B?MForTjdqbnlzeXlGYkpmZGZaNi8ydGJOdXhzVHhWYjBJaGNlS1FjS0dSdElh?= =?utf-8?B?emlGRGVVSDNySldEd2FIcU1OTjQrcU0xTWd3bUFvZUNWcFRkcnBXc0p1cjRv?= =?utf-8?B?UVlwZ1crN3V2ZUQ1aFdVUXZoWGlBazFGcFgxS2xxOFJOck5QSmN1a2xtRXBM?= =?utf-8?B?ZUFuR1FyZlV0WHdmWXBraVVoUlVER0pkc0tueFZCUlRia3B5TlNqSzBaU2Iw?= =?utf-8?B?N09KZjB5d2NJaDA4bS9PemEyVWxXYmlaQjlTc1Q5c1FoUk5QTE5hMnlpSW0v?= =?utf-8?B?UXJ0anVzY3hrQWwrS2h0ZENUaDJTOC9Odk40UFhwd0pYejR1YWZtUTVWK1hv?= =?utf-8?B?RFRNWTIxWmQ3ZWU1dTcxOGl5bTUzVVVJTXNOMDNHYmtWbTl6ZE5mT3lNVVht?= =?utf-8?B?VVF0M1VKd2RCa1kySTFDQXM3aGlTRWZTOVRPc253YWpNSUhMZjdmeHozaXA2?= =?utf-8?B?bGgyZFpVTVF5Tm5abGVWdFd2YXc0Q1FkOHVXNnpoRnVjVzRIL3JnMXlvOHp6?= =?utf-8?B?MFM3WUprVk1wcTVPMUZyNi8zMmNMUy9xcVBXUlhLRmhxNTlTM0trS2dmaE1E?= =?utf-8?B?MmlDOUE3RU9oWEh1bisveDF1SlUra2hkWDlWeURyalpvMHRPTjFSNm9hbE5m?= =?utf-8?B?azU3L3pWYkZIbzk4amxBbnEreG5pSjlBclErbXh3Wmg4MFlpUU5OY01ETStr?= =?utf-8?B?NXlxb0xUL2xkaFo4QUpENHFwNzZwRVBhS2pqbjNRNzdTd2pQNzA3eVNGY0Fu?= =?utf-8?B?ZnA4RHA1aU12Tk5sbytWZHJVOExlMHNqSU9BaFhDMkFjS0Y3TFliRWJnaGVr?= =?utf-8?B?Q0VvOHVITGZYYWV0U25GMWtVcS9NamRpS3A4RjVSSTI5Mm5GdzFCSzQzb1RE?= =?utf-8?B?YVpSejgrQVBicE1EdE42VElUcDRDQzdrNFQ2QUxlQ1pLR09lUEN1Q1MzN0F2?= =?utf-8?B?QWI1YU41QVdvK1RRWTI2MTBETWRqYkdQQ0E0UTFKWmtxa3lnTDhUdzZDZERm?= =?utf-8?B?VCtEMDlEUVBFVmpDVkxJNmtGVlpRSlhLM2Q5dTR5cXV6d3A4UE93dVpoMG9O?= =?utf-8?B?LzlEZ09sVHgwTEFxc2tlZElYOHlQcnVhWFNVemVjaDFTSGpIM1hTQjZ4ZVMz?= =?utf-8?B?RmhCVDNhYlRnYkxsZ09pdUk4c2xGOXI1Y0F6cmUyZFFJSHlNZ0dNb3VsMkIr?= =?utf-8?B?Q1pVTUY2ejFsWElNUjNDRjJwMHNxZWRYWlRBdkQzcHlLY3h4eHhINmRGZW9r?= =?utf-8?Q?N9JI=3D?= X-Forefront-Antispam-Report: CIP:164.130.1.60;CTRY:IT;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:smtpO365.st.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(376014)(36860700013)(1800799024);DIR:OUT;SFP:1101; X-OriginatorOrg: foss.st.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Dec 2025 09:05:10.9392 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a44cacc7-9934-409f-dfcc-08de33dd6519 X-MS-Exchange-CrossTenant-Id: 75e027c9-20d5-47d5-b82f-77d7cd041e8f X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=75e027c9-20d5-47d5-b82f-77d7cd041e8f;Ip=[164.130.1.60];Helo=[smtpO365.st.com] X-MS-Exchange-CrossTenant-AuthSource: AMS1EPF0000004D.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR10MB9106 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjA1MDA2NCBTYWx0ZWRfX4JUPiNmrHH9b 2K35vGzn+4QX5KcXDm/+/rw9CWMVDBZpY6sX1RcdjzUuFRE3J1wc2GsFp3phRC1z73ORj6jXBDu +IkwOGEeiKnVhGFLblzjRht5bcRr/9/JMCdK3Qkotkw922CSn5Q8om55/4EcQ0SC2GQ8bkkoNXI Hrk4NAXn6185GGfzU/5jYcJ4gJIoEf2ny+TzbUE8k4BFKVlr5Cb718lmkfeHH5LYs1YJhuYNjJX ONUzMGyGQxPXnAXmBkMHW66IKfuy6IIHE34mRTqqQZL7GZS9LCXWDWs/+7keKl3qkuUDElFuYOa A4NYo1/HerpY73Dxyh5/kvZGg/wuIoX1sx9gFFURL1wF9Fob1frSLbHMiUvA1CZgxycOekzc6BM rKhSvUjI++IwYk68ZJ/corw7DNKHAw== X-Proofpoint-GUID: bLOwz3FsOvfnGgJvobAgaAzsC2U-Nl-C X-Proofpoint-ORIG-GUID: bLOwz3FsOvfnGgJvobAgaAzsC2U-Nl-C X-Authority-Analysis: v=2.4 cv=YrEChoYX c=1 sm=1 tr=0 ts=6932a04c cx=c_pps a=V7bJpFG2U8+55D0nNporPg==:117 a=uCuRqK4WZKO1kjFMGfU4lQ==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=Uo5EeBN78AAA:10 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s63m1ICgrNkA:10 a=KrXZwBdWH7kA:10 a=VkNPw1HP01LnGYTKEx00:22 a=8b9GpE9nAAAA:8 a=kdm6LiA3lqeN45Uv8g0A:9 a=QEXdDO2ut3YA:10 a=T3LWEMljR5ZiDmsYVIUa:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-05_03,2025-12-04_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 impostorscore=0 adultscore=0 malwarescore=0 suspectscore=0 spamscore=0 clxscore=1015 bulkscore=0 lowpriorityscore=0 priorityscore=1501 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512050064 Set src_maxburst and dst_maxburst dynamically from DMA capabilities. Signed-off-by: Patrice Chotard --- drivers/spi/spi-stm32-qspi.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-stm32-qspi.c b/drivers/spi/spi-stm32-qspi.c index f2d19f1c5ab1..c131441e4dd4 100644 --- a/drivers/spi/spi-stm32-qspi.c +++ b/drivers/spi/spi-stm32-qspi.c @@ -689,6 +689,7 @@ static int stm32_qspi_dma_setup(struct stm32_qspi *qspi) { struct dma_slave_config dma_cfg; struct device *dev =3D qspi->dev; + struct dma_slave_caps caps; int ret =3D 0; =20 memset(&dma_cfg, 0, sizeof(dma_cfg)); @@ -697,8 +698,6 @@ static int stm32_qspi_dma_setup(struct stm32_qspi *qspi) dma_cfg.dst_addr_width =3D DMA_SLAVE_BUSWIDTH_1_BYTE; dma_cfg.src_addr =3D qspi->phys_base + QSPI_DR; dma_cfg.dst_addr =3D qspi->phys_base + QSPI_DR; - dma_cfg.src_maxburst =3D 4; - dma_cfg.dst_maxburst =3D 4; =20 qspi->dma_chrx =3D dma_request_chan(dev, "rx"); if (IS_ERR(qspi->dma_chrx)) { @@ -707,6 +706,11 @@ static int stm32_qspi_dma_setup(struct stm32_qspi *qsp= i) if (ret =3D=3D -EPROBE_DEFER) goto out; } else { + ret =3D dma_get_slave_caps(qspi->dma_chrx, &caps); + if (ret) + return ret; + + dma_cfg.src_maxburst =3D caps.max_burst / dma_cfg.src_addr_width; if (dmaengine_slave_config(qspi->dma_chrx, &dma_cfg)) { dev_err(dev, "dma rx config failed\n"); dma_release_channel(qspi->dma_chrx); @@ -719,6 +723,11 @@ static int stm32_qspi_dma_setup(struct stm32_qspi *qsp= i) ret =3D PTR_ERR(qspi->dma_chtx); qspi->dma_chtx =3D NULL; } else { + ret =3D dma_get_slave_caps(qspi->dma_chtx, &caps); + if (ret) + return ret; + + dma_cfg.dst_maxburst =3D caps.max_burst / dma_cfg.dst_addr_width; if (dmaengine_slave_config(qspi->dma_chtx, &dma_cfg)) { dev_err(dev, "dma tx config failed\n"); dma_release_channel(qspi->dma_chtx); --=20 2.43.0 From nobody Fri Dec 19 15:51:35 2025 Received: from mx07-00178001.pphosted.com (mx08-00178001.pphosted.com [91.207.212.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E6573176E3; Fri, 5 Dec 2025 09:05:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=91.207.212.93 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764925542; cv=fail; b=XGNGbZlbSTBn+p0fgs589NkAPMaAil6rRFL+6Fn2q7GAsONyc2Pkkf6ofKNxbP1QV2PhfUiRDEDcPsnhXJf9MzuESqDFNc14QeA46U82udUSYLS+z7rd1/Ioq/zZibNBHmhkb/LusCbWSJy8WzoCeCcY5WaalCgpj/1un1kyq70= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764925542; c=relaxed/simple; bh=JTHC4Vw2LcFWfwD6Uki0JMnmf+zbeWhCAfnk2DPaeZc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=YXAS+w8788Ijrt1/SuwwYCOxMiKnTSQs6GLBemANYo2M/sXBLqntfJWGvUK5ZYTVEyScNd0xucpU0gTY7SjGDTAntZIZwQ6KOyVU6IyWsjIEMd1A/ujJkC1I2I+GIbYP2ZG7VPn2/fPuDIqFtJaWPLFkE+UaVhAKvckIxs2J/jU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com; spf=pass smtp.mailfrom=foss.st.com; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b=kURNmpe6; arc=fail smtp.client-ip=91.207.212.93 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=foss.st.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b="kURNmpe6" Received: from pps.filterd (m0046661.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5B58o2Ds2026658; Fri, 5 Dec 2025 10:05:14 +0100 Received: from osppr02cu001.outbound.protection.outlook.com (mail-norwayeastazon11013026.outbound.protection.outlook.com [40.107.159.26]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 4aub8nb5ab-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 05 Dec 2025 10:05:14 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=BWKRoZSs6UYy4gXZyBdzYozmRuBJhQRw3qvfK4ilvw0Y9KqGM/4mJdResOXt9lAziZmGzuMk79V7ImKV21olNkJFMxs8FqAW/9RJfZ1c13EihRiW9xllyZsNGk+/dVl81AWKQvFaUeg4bfWPkrUU8i8N44NWNmyAn0mR+16M1GNPg5N/sYXQfDd1UkXFqy8pvKlx4gChCzCTtCnP0wsx052d2V/rrOt+uvAh33bW8IO0TLJdj63/y9bANNC1/UUbPBbRo4/zl+4dsfKKma1cC8djV93cIvnheWQ7sKD3LckddNHMrprBefgoSw4gFz2DI85CSQVyZAZsu0vGuVnQkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RdhBenL80j2dBguqTXmCc8UJoMc6CxAzHvkJU7sqDx4=; b=dkFdLuKcWU0/NmXpXR/fZ57jB0cKoWB1NDPG9XDAy10GgxUZ4R5nzJfl8YBjM5CywSVU9Xe6Vdm2Vc11Et09ObVbQzvIVWwSQACwsbVWBlQZqZhObdZ5COyo6Y4fGq80KCUcAwwBDrs3lK0lnp/Zj5fxP+y8l9gwvcAL+i4zG9M75PavBQ7d6ZhOYD4treH8Kp2SHFzSu2saXO4zS643BesStPEgNTpS9SSl5pP037mIa3cLbsp73O1GmhyAFKyP8QLzt8NBC8UJrk8PdJ5yLlIif/22421vAK6R9gbhVcsusCXp1Yn9nDhock0xoGwBq/ahUEdxKKtBZ8m+NEpZFw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=fail (sender ip is 164.130.1.59) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=foss.st.com; dmarc=fail (p=none sp=none pct=100) action=none header.from=foss.st.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RdhBenL80j2dBguqTXmCc8UJoMc6CxAzHvkJU7sqDx4=; b=kURNmpe6TPfv7IkBBQ4ngtG9/C5Pvia6HCYCJQ8x2dMbuNc1/Dr+XjpCBbj7G0ZE56zS6tbjpQsViY7nPrKbS3lw8ltUd+jI1bTc7NKJKrWDawMfY5MECU9DV4QLnlemHZ3UMWKGsOmQF0Yls0j3RrulimYQnCwrZBuBlE5UTpgEeXo224diSM3d1gaRc33UxKW5437Pa6HdjRoptcKDy2fKcyN5sppJBHcMpdywb7K9zNRK521Djcc1W1F+o/iHJDmx7WxZb/9zV/NCcEQwjBGIaPEGVBQ1vYeZ3yI+cz6QgnhSqJ9AL7FhzObLZ2+AmHKL6X1IcNeqTiaa2gQIdw== Received: from AS9PR05CA0032.eurprd05.prod.outlook.com (2603:10a6:20b:489::30) by AM7PR10MB3828.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:17c::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9388.11; Fri, 5 Dec 2025 09:05:11 +0000 Received: from AMS1EPF00000042.eurprd04.prod.outlook.com (2603:10a6:20b:489:cafe::cc) by AS9PR05CA0032.outlook.office365.com (2603:10a6:20b:489::30) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9388.11 via Frontend Transport; Fri, 5 Dec 2025 09:05:11 +0000 X-MS-Exchange-Authentication-Results: spf=fail (sender IP is 164.130.1.59) smtp.mailfrom=foss.st.com; dkim=none (message not signed) header.d=none;dmarc=fail action=none header.from=foss.st.com; Received-SPF: Fail (protection.outlook.com: domain of foss.st.com does not designate 164.130.1.59 as permitted sender) receiver=protection.outlook.com; client-ip=164.130.1.59; helo=smtpO365.st.com; Received: from smtpO365.st.com (164.130.1.59) by AMS1EPF00000042.mail.protection.outlook.com (10.167.16.39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9388.8 via Frontend Transport; Fri, 5 Dec 2025 09:05:11 +0000 Received: from STKDAG1NODE1.st.com (10.75.128.132) by smtpo365.st.com (10.250.44.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Fri, 5 Dec 2025 10:05:51 +0100 Received: from localhost (10.252.31.202) by STKDAG1NODE1.st.com (10.75.128.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Fri, 5 Dec 2025 10:05:10 +0100 From: Patrice Chotard Date: Fri, 5 Dec 2025 10:04:56 +0100 Subject: [PATCH 6/8] spi: stm32-qspi: Optimize FIFO accesses using u16 or u32 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20251205-upstream_qspi_ospi_updates-v1-6-7e6c8b9f5141@foss.st.com> References: <20251205-upstream_qspi_ospi_updates-v1-0-7e6c8b9f5141@foss.st.com> In-Reply-To: <20251205-upstream_qspi_ospi_updates-v1-0-7e6c8b9f5141@foss.st.com> To: Mark Brown , Maxime Coquelin , Alexandre Torgue CC: , , , , Patrice Chotard X-Mailer: b4 0.14.3 X-ClientProxiedBy: STKCAS1NODE1.st.com (10.75.128.134) To STKDAG1NODE1.st.com (10.75.128.132) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AMS1EPF00000042:EE_|AM7PR10MB3828:EE_ X-MS-Office365-Filtering-Correlation-Id: 04a42ec9-a43c-48b8-df7e-08de33dd6566 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|36860700013|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?WE1rRStQc1hmaU5QVHp1dHYvT2V1VjlOUkFWN3dUZWdQUmIvK2d3SmF4Mzc4?= =?utf-8?B?d1RQNU9la2RXZ1ZZNzgxck8wdUZFZk0rMVJac2tmT0Jxa0krRXRpSDZVVFQ3?= =?utf-8?B?OVZNTy9ZcFZCUWdnelVNTDQyOVhVK1R2UmdGakRRYnNzZnhCU013eElKcmhz?= =?utf-8?B?bUFLaDY3blg2bUQyZnVxY3hKaGlKQXcwaXdjTVU5bERsQjJZUDRwRDZKNWVR?= =?utf-8?B?R3E5ZHJGVUF0T2lhb1RuVThUWDlFVFFLUlg3dkZNK05HN0M3aEcyWmRkWVdr?= =?utf-8?B?OVgvTGo2OHl0eDZpNFVid1JFdm01eldEZlRTclc0L3hPQk1qZHlWRGxrS1dS?= =?utf-8?B?eEtDUmpGZ1NJUTlldlhEWkFWL2orVmlPUnJUVlc4VzRma2kxWGZuM2F1czdO?= =?utf-8?B?VEVjRUhNWTBEZU12aFlnakNNc2ZYbU1FQkNKTHppblVsNGNzOHJTQjY4ekgy?= =?utf-8?B?L2RnZ3hwNkhWZE84K0JhUkJWbUhHaUZLRFFCZ1RsTm9jd3ZBQUxsWEd2bXpB?= =?utf-8?B?QUVOYU5YVDVwK3krZUJPcjFwWXJrMDA1Qlk0TGxJQ096UXROeVJuMG9Ka09u?= =?utf-8?B?clYxUmJaWm1PUmNTcElzbTJiS05zaUdocW9vRVpFOWJEU1BLUllSZjg0emhy?= =?utf-8?B?T0c4dUV3TTNUdEVKNW4yZjA2RXZua3hvRXVQc2ZUd0g5OW42cjZVYmdxcmZD?= =?utf-8?B?cDA2eWRDKzVIUUdMUnpVUUpOMDM0eUx1QStTWHFGSjJHUHZJTHYyMDRGQTJH?= =?utf-8?B?cFB2TFdibE80Mkc3THFCaW1nQlR3bzBqQUFZTXg0QWZqamkwWU9zSUd3elBl?= =?utf-8?B?aTI0Q0dwQUt5UEY1ZDhsU3NMaWxkSUN5UHRHNjJ2M3Z5cTZ2amY0K0VZMTVI?= =?utf-8?B?Ym5LT3EwNU01YkIyZ0FIbEp5bmNkWitzRXVBc3BIcUUxS0JEUy9pTUd2eXFF?= =?utf-8?B?K3ZOYmd2aUhyN2pqVUpUUTZxQnpYaVNRV2JxRnRSWFdTU3BUVys1VTNtVHZv?= =?utf-8?B?WnRSQVBEY2FTOXRQNDRSWU1TMzB2MDByZkUza2FvTTZObFJVV3NwakszemUw?= =?utf-8?B?eHhZN2tLbWwySVBFa0J5QkFDdTFJZ0MwLzRqMXkyTWtvKzk0Qm9HWG5kSW82?= =?utf-8?B?VmRncjZwKzlkWDFiYUFwNXQwNFVDZUJRQVAvckdoUTFMUGZzcFZNL1QrV0E3?= =?utf-8?B?WDZYNnNmZ2xTcWxGMGJXT0NHTG00MXVCQW50VVIvUWFlaWF2YzU5YlZRWEt5?= =?utf-8?B?NUZtNzRmT2lQaVJPc2l5QWp3NThKd21DaHR0M0l3b1lGUW8xV2hyQ1E1Z0pU?= =?utf-8?B?VkdKUjhOZGtPSEZUaDR5QkdTd0VONi80eUJxVW41SjlrSTk0RXhNaEhXN084?= =?utf-8?B?TjhFQlVEVHU0aUVCOWdycFkzWFhMOUlZbysxZWhxQ3pQRWlxOGRWRzdzbzgx?= =?utf-8?B?S2hlM2pSZ1kzRERJVUhyMTM2ZHpDazNLS2lBNGgySXA3VEFWMkx3MS9aYnFL?= =?utf-8?B?YXhuRjlRQjY3YjBGWG81M1N2eUNveDRNRXdWbW4xR205cHp6ZXZtRkhuUGgy?= =?utf-8?B?ckdEa2NZR1FYQUgwU0Q0L3ZsbVU3aXFRTDlSSGt1VmdjUkVDc2wvMUhObEJy?= =?utf-8?B?TEppU3BSeVRRdy9QOGNNK1hINnR2cFllSFZLSTVWZ0hjVGEySEpqUWppTkFi?= =?utf-8?B?R3dVcDM4dDJweU82Ykc5RVpud1UzYThOS2ZWOUNTTUpJemZuUk1tbmVOVEM2?= =?utf-8?B?VXV3eXFtZFRiRnVmaG05ejZyMTUxZVE5U3lJbUNWeHJVVTA1enpVL0hpcU01?= =?utf-8?B?a2xNYzBSVkltK0VHQ1VFd2ZZWVpvOG00d0trb3FkaERZcGZ5MWJqdzVFOVFj?= =?utf-8?B?T0lKNFJPNzNzMXRVM3I0SGZvZHp1bzBuNnFWL0FLSjM3RllCbHMrYWtwVFlD?= =?utf-8?B?TWZnR0o2Kys5U2lHRHVpSTU5QnBNWDBMUDYyZVQ5QjNsWU0xajZYOG1FdTVB?= =?utf-8?B?cWhIazgvcStTMEFXOEpKRjZKZjhzaWozcE5yMERJZjFHUGFldFFFNzU3Q1dD?= =?utf-8?B?YjdReXpOa2JnRGUxV1hjbVp2QXZDY1RJdm93RXV1S0Y0ZVE3eGdra3VEaEsx?= =?utf-8?Q?XcRU=3D?= X-Forefront-Antispam-Report: CIP:164.130.1.59;CTRY:IT;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:smtpO365.st.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(36860700013)(376014)(1800799024);DIR:OUT;SFP:1101; X-OriginatorOrg: foss.st.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Dec 2025 09:05:11.4352 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 04a42ec9-a43c-48b8-df7e-08de33dd6566 X-MS-Exchange-CrossTenant-Id: 75e027c9-20d5-47d5-b82f-77d7cd041e8f X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=75e027c9-20d5-47d5-b82f-77d7cd041e8f;Ip=[164.130.1.59];Helo=[smtpO365.st.com] X-MS-Exchange-CrossTenant-AuthSource: AMS1EPF00000042.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR10MB3828 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjA1MDA2NCBTYWx0ZWRfXzWpGgwBUYMY/ ZG8ezPiMyJ/WdH2eH+2RleU8QQi/duuWkLW5hnmQxS3gzhZRdKh6wfaDHlmcYdX831toBHWnEz3 bfwHlMLTl2hUsa9wmfQcvR63772pyOzSeRYjIusl0Zo+XDhEOlQ8XGcf8/Pk6EaCMjqN71vbAX0 h+Lo6QtSGJxzBgArRJGd2XuF8/U5hQbADOw2QVekTugeZnrjIyPnT2MkjytUv/MEIShQBJikyhQ S9z6jQ8X0/6jX4zFVvscRgkkIXJyPk8OL1VQ/b/r8yS/hlaXi2R7STGjOBkhl/NF85Ou88ziCSv t3EcywMS8t/G6vFI1Rr8H49Xmeh+rFXGm+kP3K9q3hDW8bIE0LJiNJX1YBpwl/Qom/Nl3pCDhGC YI+eTpV0AFjE+SP6U7DCnJBCtPteLQ== X-Proofpoint-GUID: OMwyM47jobvnKVghnr_ZPQsJlWBNgMwe X-Authority-Analysis: v=2.4 cv=X99f6WTe c=1 sm=1 tr=0 ts=6932a04a cx=c_pps a=lo7lgCOeVt8OyxGStfpnzA==:117 a=d6reE3nDawwanmLcZTMRXA==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=Uo5EeBN78AAA:10 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s63m1ICgrNkA:10 a=KrXZwBdWH7kA:10 a=VkNPw1HP01LnGYTKEx00:22 a=8b9GpE9nAAAA:8 a=H034yFGYOyrU3Mls5rUA:9 a=QEXdDO2ut3YA:10 a=T3LWEMljR5ZiDmsYVIUa:22 X-Proofpoint-ORIG-GUID: OMwyM47jobvnKVghnr_ZPQsJlWBNgMwe X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-05_03,2025-12-04_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 impostorscore=0 malwarescore=0 priorityscore=1501 adultscore=0 clxscore=1011 bulkscore=0 spamscore=0 phishscore=0 lowpriorityscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512050064 FIFO accesses uses u8 only for read/write. In order to optimize throughput, add u16 or u32 read/write accesses when possible. Running mtd_speedtest on a 4MB sNOR partition using a stm32mp257f-ev1 board gives the following results: before after gain Read : 5773 KiB/s 22170 KiB/s 384% Write: 796 KiB/s 890 KiB/s 12% Signed-off-by: Patrice Chotard --- drivers/spi/spi-stm32-qspi.c | 51 ++++++++++++++++++++++++++++++++++------= ---- 1 file changed, 40 insertions(+), 11 deletions(-) diff --git a/drivers/spi/spi-stm32-qspi.c b/drivers/spi/spi-stm32-qspi.c index c131441e4dd4..c7f2b435d5ee 100644 --- a/drivers/spi/spi-stm32-qspi.c +++ b/drivers/spi/spi-stm32-qspi.c @@ -153,34 +153,53 @@ static irqreturn_t stm32_qspi_irq(int irq, void *dev_= id) return IRQ_HANDLED; } =20 -static void stm32_qspi_read_fifo(u8 *val, void __iomem *addr) +static void stm32_qspi_read_fifo(void *val, void __iomem *addr, u8 len) { - *val =3D readb_relaxed(addr); + switch (len) { + case sizeof(u32): + *((u32 *)val) =3D readl_relaxed(addr); + break; + case sizeof(u16): + *((u16 *)val) =3D readw_relaxed(addr); + break; + case sizeof(u8): + *((u8 *)val) =3D readb_relaxed(addr); + }; } =20 -static void stm32_qspi_write_fifo(u8 *val, void __iomem *addr) +static void stm32_qspi_write_fifo(void *val, void __iomem *addr, u8 len) { - writeb_relaxed(*val, addr); + switch (len) { + case sizeof(u32): + writel_relaxed(*((u32 *)val), addr); + break; + case sizeof(u16): + writew_relaxed(*((u16 *)val), addr); + break; + case sizeof(u8): + writeb_relaxed(*((u8 *)val), addr); + }; } =20 static int stm32_qspi_tx_poll(struct stm32_qspi *qspi, const struct spi_mem_op *op) { - void (*tx_fifo)(u8 *val, void __iomem *addr); + void (*fifo)(void *val, void __iomem *addr, u8 len); u32 len =3D op->data.nbytes, sr; - u8 *buf; + void *buf; int ret; + u8 step; =20 if (op->data.dir =3D=3D SPI_MEM_DATA_IN) { - tx_fifo =3D stm32_qspi_read_fifo; + fifo =3D stm32_qspi_read_fifo; buf =3D op->data.buf.in; =20 } else { - tx_fifo =3D stm32_qspi_write_fifo; - buf =3D (u8 *)op->data.buf.out; + fifo =3D stm32_qspi_write_fifo; + buf =3D (void *)op->data.buf.out; } =20 - while (len--) { + while (len) { ret =3D readl_relaxed_poll_timeout_atomic(qspi->io_base + QSPI_SR, sr, (sr & SR_FTF), 1, STM32_FIFO_TIMEOUT_US); @@ -189,7 +208,17 @@ static int stm32_qspi_tx_poll(struct stm32_qspi *qspi, len, sr); return ret; } - tx_fifo(buf++, qspi->io_base + QSPI_DR); + + if (len >=3D sizeof(u32)) + step =3D sizeof(u32); + else if (len >=3D sizeof(u16)) + step =3D sizeof(u16); + else + step =3D sizeof(u8); + + fifo(buf, qspi->io_base + QSPI_DR, step); + len -=3D step; + buf +=3D step; } =20 return 0; --=20 2.43.0 From nobody Fri Dec 19 15:51:35 2025 Received: from mx07-00178001.pphosted.com (mx07-00178001.pphosted.com [185.132.182.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 678FC3195EC; Fri, 5 Dec 2025 09:44:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=185.132.182.106 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764927905; cv=fail; b=I1rN/2ZJ1ynb0UXiS8L2xYvHRY8swOUZlOQJiMIYz5/2KoxbbGgn2dkos9xwZZF7W4dX0fPpFz4akGd7+URrrr4+6/CmBr7ITOfZx0gzNgG5vR3rPo92cl33Sh8FgY/Ljyeq2YR63ve6nD8JwwN07xIWddrs3ng8utWcgtqv+c4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764927905; c=relaxed/simple; bh=KB8SeaJv9KC2JD4D/BJJoOV3rEmdcNd/02A/f2SpRn4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=W978yQ/yRp6ptYsbHUh+wWWuvUJWp3MxWCUrBkbK7kWI/s5ppEYnEQ/7L1q1HmQx8kj7W84MzRjKb4ItCUnwxlwMe7ndNBQW/ScXeIXo5Us/Et8FAHepw5xTGAsVnZ2mq/UaRjrkQS6JQY7B1FDoA0Y/aszkXLpuvuSEdZgID7U= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com; spf=pass smtp.mailfrom=foss.st.com; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b=NoqHyBKg; arc=fail smtp.client-ip=185.132.182.106 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=foss.st.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b="NoqHyBKg" Received: from pps.filterd (m0288072.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5B594hCh2478371; Fri, 5 Dec 2025 10:05:15 +0100 Received: from duzpr83cu001.outbound.protection.outlook.com (mail-northeuropeazon11012041.outbound.protection.outlook.com [52.101.66.41]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 4au7s54ftb-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 05 Dec 2025 10:05:14 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=faY/XCSXWCthJf+jw2DImDkkg5aWw1IWG8kZQofZawVKiREJ5wBOd46XL5EVduIi4eS5rdJgZeF2eJGZt6Trm97yirZg0BFn+4O5rA0/epVSEUL6gaCROMmRoYVK3bHIbDb2KI0ZHd9nNTYmxEWe2sMGFDrlQ/fqshUGcbpi99Kl/T2Nh11Xdkg2YP6lf2IOP11YZ62K1Hdo9O4jfVuQCpLqLBoTV/aum3fLKWPD6AAZbVaMDLpVqqwoHwQLPrcX25TiQ/MMW5LrYE/qQxWwOVAp2akZI9bA0d16wGOvVGfYWe9SXkuVft18J/Q6RHm0n5BbZ4ZLCyZ2jUDRy1mdFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=T/h+ttQocpyxLUgaIlzx3iwhuSNneCP2ewSMetvTTdo=; b=Z9o18qf+YVBuniLlmgbuPJNuyF5GWs8uSQp2WnLuAEGMWiTyhRSatl+Ft5OQSramJ9tviCx2KKJf8a9MpbL/gc9jaCuGzDiqgZETjLkiLe9ByR2n7xS6M0CdoLp4rISgWQyx3l1UYUNkYGcNo6OKLf+L+lkm1FI89f88x0OtBE4kAwwBpVP118WSUi4hrrnz8ynAeq29jSsNkiXtl20QvOwsgl17J70PsBQvbU/PVT4R2V6NXCe9vpxYgrmGeuq2UxlVZlBIJkeXmOxnUKjg4j45O28A+3wqSXNwqMWArDlQA5Z4kcr3DZJMNVDRcZ/ILQ3VYyGhFnaWH51OlyLRTA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=fail (sender ip is 164.130.1.60) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=foss.st.com; dmarc=fail (p=none sp=none pct=100) action=none header.from=foss.st.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=T/h+ttQocpyxLUgaIlzx3iwhuSNneCP2ewSMetvTTdo=; b=NoqHyBKgoK8s8sFxgVkGw0dnyULSlI1JZUT/lPeLXtnYutDFHIrORySpQgdz9VO+0f76MkDzaDjEvmKZMBODVB5jxVagoLCMmvmU1dmhFV4vcji0pxD4tH61Ql7gfz2OmX0CfGiGI1nHb2ejuhPVHcx7z7d2sHTq7tcWuSGgIy7x/7TBAS41NlpLFFC/s1aLGXMnkmPR9x7piLYlLB0gNAmcKm2OQGrSWur9QrPuJQiYzPaen/XHyYsnN+3y8FBQmKofJz3XWO5tZ+K3F12fPOI3PTSq2g7iLRjIQuZS56xBg/En1QaVAtbOKj1Z3CQVofDqus7HGjPgMau49sewPw== Received: from AS4P192CA0040.EURP192.PROD.OUTLOOK.COM (2603:10a6:20b:658::16) by GV2PR10MB9631.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:150:303::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9366.17; Fri, 5 Dec 2025 09:05:12 +0000 Received: from AMS1EPF0000004D.eurprd04.prod.outlook.com (2603:10a6:20b:658:cafe::ec) by AS4P192CA0040.outlook.office365.com (2603:10a6:20b:658::16) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9388.12 via Frontend Transport; Fri, 5 Dec 2025 09:05:10 +0000 X-MS-Exchange-Authentication-Results: spf=fail (sender IP is 164.130.1.60) smtp.mailfrom=foss.st.com; dkim=none (message not signed) header.d=none;dmarc=fail action=none header.from=foss.st.com; Received-SPF: Fail (protection.outlook.com: domain of foss.st.com does not designate 164.130.1.60 as permitted sender) receiver=protection.outlook.com; client-ip=164.130.1.60; helo=smtpO365.st.com; Received: from smtpO365.st.com (164.130.1.60) by AMS1EPF0000004D.mail.protection.outlook.com (10.167.16.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9388.8 via Frontend Transport; Fri, 5 Dec 2025 09:05:12 +0000 Received: from STKDAG1NODE1.st.com (10.75.128.132) by smtpO365.st.com (10.250.44.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Fri, 5 Dec 2025 10:05:49 +0100 Received: from localhost (10.252.31.202) by STKDAG1NODE1.st.com (10.75.128.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Fri, 5 Dec 2025 10:05:11 +0100 From: Patrice Chotard Date: Fri, 5 Dec 2025 10:04:57 +0100 Subject: [PATCH 7/8] spi: stm32-qspi: Remove CR_TCIE and CR_TEIE irq usage Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20251205-upstream_qspi_ospi_updates-v1-7-7e6c8b9f5141@foss.st.com> References: <20251205-upstream_qspi_ospi_updates-v1-0-7e6c8b9f5141@foss.st.com> In-Reply-To: <20251205-upstream_qspi_ospi_updates-v1-0-7e6c8b9f5141@foss.st.com> To: Mark Brown , Maxime Coquelin , Alexandre Torgue CC: , , , , Patrice Chotard X-Mailer: b4 0.14.3 X-ClientProxiedBy: STKCAS1NODE1.st.com (10.75.128.134) To STKDAG1NODE1.st.com (10.75.128.132) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AMS1EPF0000004D:EE_|GV2PR10MB9631:EE_ X-MS-Office365-Filtering-Correlation-Id: 306acd4c-9685-4089-bc9e-08de33dd65c0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|376014|36860700013|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?UmNnbXhDQUd5cnIrZVlwc04xc3cxOG1sbEYydjFzVUZhZTlaUnYyTFA1ZWh5?= =?utf-8?B?Q3VGVnpTUlltcS94UzdKL1VEOXNBRndWWXM0OG9BeVBkREh0akdOZm1jQ3ZL?= =?utf-8?B?eXB6ZTVJb0FESU9hRUE4YW5vb1BQNEoyMTNtNmRUT2xMYjFINUVPN0EyYUho?= =?utf-8?B?SGN4UVpONWlmYVYzckZjQnhJWi8rWExLVE05ZTZIbFpUMnN1NFNTSExtUmE0?= =?utf-8?B?WWxGWFR5U1l0RjVQYXFoaUt3RXRlZ1ZMMW1QT1p3RmY0SWhuaDhmSmNwQmhv?= =?utf-8?B?TEJrWjRrMFlQWVUxUVhnNEJiTDdJSjlnd2NRWFhUY1l5Vm9OUk1abTBpN093?= =?utf-8?B?S3V4Z3V6MEUwbDlKSmg4dzkwdFdhaW1xR3VCMVBUUDhBTUhXTk9VdWhJSXFy?= =?utf-8?B?eVNWOUc2V2lwKzNBaHc5amR2UDRnYWNuSzRkRzZadlg0RTU4RkFaRURVYnRi?= =?utf-8?B?eWhyc0d4RkVhWERGVDZKYzJ0aUo2cEVYSWRIMElrbWY1VXpqVG5kUnQ5WU0z?= =?utf-8?B?RFZVb1VqWTBjUkZ5bUN3SHBobFFjZjJSd1NUNFM2QkpMR3ZOaDliTmVuZlQ3?= =?utf-8?B?NDNNR0dxTVM5UCtyUndKTDBMYXBieG1jY1RWOHZiZGZ1a2lxWXRrenNBRzY2?= =?utf-8?B?bm9ib2JmVjdMcnBTVnlPbHl4RE9TNzFQQm4vRXZsQmdQalNTK1ZObFJiaEVp?= =?utf-8?B?aWM1TXI4U0QwQUtJUzZlNTA3SHFsN3ZpSmk5L2Jmam1HK2xydnNIaWNqU2U3?= =?utf-8?B?U2IybkpKdG1FMlc4amZwdGhKQVYwbWFxLzdyRVBYd1VnR3N3VjRKL0V0a1po?= =?utf-8?B?OUpDYVNiUUliaEI0bXpFZTN0RzBKMGxOU2ZhSHRtcjhjZVVIcDhyRDk4b0dP?= =?utf-8?B?TndTd2xONFNzMnQxUEIwUUNmV3ovOFBXcmJOaWdKRkdVSUlhenk1ZktkUHo4?= =?utf-8?B?eWtOdE00c0dSQ0FDNmtBWTJ5am1kNEpWNVJ5SzRCTDNoR1JiM3BkT3VIMjBq?= =?utf-8?B?YVV3R2RxcEo5U0VFTzFnNWUybHJxQTltdUZYUlFpcURxMktkOXo2QlZCY0Vs?= =?utf-8?B?cFhoVVBWK2c0b3ZFNUcvQnNFTVhPSlFvZUI1TitHc2lMc3NZekJWNFRxN1Fs?= =?utf-8?B?bmFyUU5RU1pBSUw2L1JhRmhGVUxXQjZYbFJvZ2hWVXVpeWlONUNJaTA2Qno5?= =?utf-8?B?eGNlOVIwSXJ2aytkUTVUSEZBU1hxck81T3BnZVhTbnRncURXSHhFaENmSSs2?= =?utf-8?B?QjJ5QlJ1cEg1dGdaNVBid0VRZUVjUkxMd2N0WEwrR2l4RmhKWEYvMnZlek42?= =?utf-8?B?S2Q4a0Z2cXcvT1JXN05tZW5iZW03KytpSCtLaVEvbExHaXIzd1hHbFV6OFNM?= =?utf-8?B?NzBDTFhUU3BOdUFZaE1qSW9rTGt6MGJrUEtDODVoSnkyS3NXM214d1RjRHdo?= =?utf-8?B?d0NSRWtySXJKUVZQMmtPelk5RU5BREZaUGpnZThEY2QxOG0xVDZTZzgzS2l3?= =?utf-8?B?RWlCSzYwZG9LTGdOcEFPVmJ0WEpsOEVXNjY5aUZIWEIzVkcwVTBtejk1RjJh?= =?utf-8?B?c1hYNzlFRkFaQ056eXdENU1mR3pSaVJPUXgvb1IrdnEzMDlFVjFBUWs1OENX?= =?utf-8?B?NGxVU053YkFjYW1XOWVyOTRXVGFVcGpGV3lPU2VHaldicXFFZzUzV09aMlNn?= =?utf-8?B?KzFCajFHRmo2NjN0Y1ptbjZ3K05mS0ZvbGVZTWExZUFFMmNqUk81UncwRSt1?= =?utf-8?B?N2hJMGxpOXpwTkdJQkV1OUZPRk8vVFpJYTJxeXhSK1gwQThNMWprUERRTUJx?= =?utf-8?B?cVVwaFJYdkVaWTltM1dTa1JHd3JkVXduellGTHRrTFdwVGVVVmpUb0ZzWnlh?= =?utf-8?B?SVNTRk8zVnVYbVZaTzk3NFhkei8rTGNIRkNyLzdYYkZ1T0pGYlR1RnA0M3dq?= =?utf-8?B?T0hTa1FiSFhKQXE2TTU1S3hndnJsTGhCWmZUZlJYMkpaSUhzd2JSRHIvZjR3?= =?utf-8?B?eDhENTBkWmt6VW5SYkdFYUFrSkdxYkNhMmVBREFUK1ZhYXI3cWJwbnJsYkEz?= =?utf-8?B?VWFUcjBPVDRScWd4RXJ4QnhUcGR0VmQ4SUpNQmhtS2xIS2lFZHpEZzhFSWha?= =?utf-8?Q?735U=3D?= X-Forefront-Antispam-Report: CIP:164.130.1.60;CTRY:IT;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:smtpO365.st.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(376014)(36860700013)(1800799024);DIR:OUT;SFP:1101; X-OriginatorOrg: foss.st.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Dec 2025 09:05:12.0275 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 306acd4c-9685-4089-bc9e-08de33dd65c0 X-MS-Exchange-CrossTenant-Id: 75e027c9-20d5-47d5-b82f-77d7cd041e8f X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=75e027c9-20d5-47d5-b82f-77d7cd041e8f;Ip=[164.130.1.60];Helo=[smtpO365.st.com] X-MS-Exchange-CrossTenant-AuthSource: AMS1EPF0000004D.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR10MB9631 X-Proofpoint-GUID: fk3KXrWnx98vXFvBzpDjXAV7v2YodzPs X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjA1MDA2NCBTYWx0ZWRfXzPUuo5P9D5Lk Q6Nco5CKDVD2XwvE6CXar4Qm3ioCycBBqtjO+goPLt1HvN3gQ3LutZBOLcuXEmwgwREbEr12evR OeZA/dUEza3k1SeBJzuF+kH0RgJPvpv1sjj0sP525Rgw1v7iEhYpJ3TNok96W+GaQl2SiuNPn0I gFE8daCp5QA1DfqdujF9tZenB+31CeelrpfuNHItXeCy8c39nMozE6MZ1BWfVVT9g38tpCJRTQ5 KJPUaZAs7afgulmKCC283FZkxkPrqN5dWrjEZXFZf1Lyl0i+6aMFXKlCsYMQUCy7mtbqhErDS7h 7WiEuEHIb/P49NYDKSRVR0Mpz41Fbg+GOkZsVaUXyjuwrtc/jNZG3oOT768dnVi0K6WB9czts7e 0X6TzxgBQ3blN52iRrd1o7P0zuwhXg== X-Proofpoint-ORIG-GUID: fk3KXrWnx98vXFvBzpDjXAV7v2YodzPs X-Authority-Analysis: v=2.4 cv=C8zkCAP+ c=1 sm=1 tr=0 ts=6932a04a cx=c_pps a=GxenEFv9DmgebrKzBBA+LA==:117 a=uCuRqK4WZKO1kjFMGfU4lQ==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=Uo5EeBN78AAA:10 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s63m1ICgrNkA:10 a=KrXZwBdWH7kA:10 a=VkNPw1HP01LnGYTKEx00:22 a=8b9GpE9nAAAA:8 a=RFtgH8DZu3AqK6r0WhsA:9 a=QEXdDO2ut3YA:10 a=T3LWEMljR5ZiDmsYVIUa:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-05_03,2025-12-04_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 clxscore=1015 malwarescore=0 lowpriorityscore=0 impostorscore=0 spamscore=0 bulkscore=0 suspectscore=0 priorityscore=1501 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512050064 Replace CR_TCIE and CR_TEIE irq usage by a read_poll_timeout_atomic() in stm32_qspi_wait_cmd(). It will reduce the time waiting for TCF or TEF flags to optimize throughput. before after average time spent in stm32_qspi_wait_cmd: 2615 ns 712 ns Signed-off-by: Patrice Chotard --- drivers/spi/spi-stm32-qspi.c | 45 +++++++++++++---------------------------= ---- 1 file changed, 13 insertions(+), 32 deletions(-) diff --git a/drivers/spi/spi-stm32-qspi.c b/drivers/spi/spi-stm32-qspi.c index c7f2b435d5ee..d6f6f9d4e5be 100644 --- a/drivers/spi/spi-stm32-qspi.c +++ b/drivers/spi/spi-stm32-qspi.c @@ -31,8 +31,6 @@ #define CR_DFM BIT(6) #define CR_FSEL BIT(7) #define CR_FTHRES_SHIFT 8 -#define CR_TEIE BIT(16) -#define CR_TCIE BIT(17) #define CR_FTIE BIT(18) #define CR_SMIE BIT(19) #define CR_TOIE BIT(20) @@ -86,11 +84,12 @@ #define STM32_QSPI_MAX_MMAP_SZ SZ_256M #define STM32_QSPI_MAX_NORCHIP 2 =20 -#define STM32_FIFO_TIMEOUT_US 30000 -#define STM32_BUSY_TIMEOUT_US 100000 -#define STM32_ABT_TIMEOUT_US 100000 -#define STM32_COMP_TIMEOUT_MS 1000 -#define STM32_AUTOSUSPEND_DELAY -1 +#define STM32_FIFO_TIMEOUT_US 30000 +#define STM32_BUSY_TIMEOUT_US 100000 +#define STM32_ABT_TIMEOUT_US 100000 +#define STM32_WAIT_CMD_TIMEOUT_US 5000 +#define STM32_COMP_TIMEOUT_MS 1000 +#define STM32_AUTOSUSPEND_DELAY -1 =20 struct stm32_qspi_flash { u32 cs; @@ -107,7 +106,6 @@ struct stm32_qspi { struct clk *clk; u32 clk_rate; struct stm32_qspi_flash flash[STM32_QSPI_MAX_NORCHIP]; - struct completion data_completion; struct completion match_completion; u32 fmode; =20 @@ -139,15 +137,6 @@ static irqreturn_t stm32_qspi_irq(int irq, void *dev_i= d) cr &=3D ~CR_SMIE; writel_relaxed(cr, qspi->io_base + QSPI_CR); complete(&qspi->match_completion); - - return IRQ_HANDLED; - } - - if (sr & (SR_TEF | SR_TCF)) { - /* disable irq */ - cr &=3D ~CR_TCIE & ~CR_TEIE; - writel_relaxed(cr, qspi->io_base + QSPI_CR); - complete(&qspi->data_completion); } =20 return IRQ_HANDLED; @@ -330,25 +319,18 @@ static int stm32_qspi_wait_nobusy(struct stm32_qspi *= qspi) =20 static int stm32_qspi_wait_cmd(struct stm32_qspi *qspi) { - u32 cr, sr; + u32 sr; int err =3D 0; =20 - if ((readl_relaxed(qspi->io_base + QSPI_SR) & SR_TCF) || - qspi->fmode =3D=3D CCR_FMODE_APM) + if (qspi->fmode =3D=3D CCR_FMODE_APM) goto out; =20 - reinit_completion(&qspi->data_completion); - cr =3D readl_relaxed(qspi->io_base + QSPI_CR); - writel_relaxed(cr | CR_TCIE | CR_TEIE, qspi->io_base + QSPI_CR); + err =3D readl_relaxed_poll_timeout_atomic(qspi->io_base + QSPI_SR, sr, + (sr & (SR_TEF | SR_TCF)), 1, + STM32_WAIT_CMD_TIMEOUT_US); =20 - if (!wait_for_completion_timeout(&qspi->data_completion, - msecs_to_jiffies(STM32_COMP_TIMEOUT_MS))) { - err =3D -ETIMEDOUT; - } else { - sr =3D readl_relaxed(qspi->io_base + QSPI_SR); - if (sr & SR_TEF) - err =3D -EIO; - } + if (sr & SR_TEF) + err =3D -EIO; =20 out: /* clear flags */ @@ -835,7 +817,6 @@ static int stm32_qspi_probe(struct platform_device *pde= v) return ret; } =20 - init_completion(&qspi->data_completion); init_completion(&qspi->match_completion); =20 qspi->clk =3D devm_clk_get(dev, NULL); --=20 2.43.0 From nobody Fri Dec 19 15:51:35 2025 Received: from mx07-00178001.pphosted.com (mx08-00178001.pphosted.com [91.207.212.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 13B883164D9; Fri, 5 Dec 2025 09:05:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=91.207.212.93 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764925551; cv=fail; b=qrqQ4wmIf/EkUwYGQFD0SxHNSYAjJnvihh8MeHlBF5Kgn8b2/pf671P4SXkr1YSc0dnwxS0mFsxCBmFijdttElfivFEqqTCu26t/9CE49hUStLcB4cLA+mPUzzZRHTDRVsnSARtZV/UaSvy95b3q7HnL5Zcxrt59HtYM5Fe8pgk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764925551; c=relaxed/simple; bh=pWArF7Rl6DABaLrLmNIRTns3uzgvldlqMLrrGoV5CbA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=K6ytLi33msbmuN+z0IunNlVXhSFrp5n6fjCjwt7QaP2Hu0afmDZz/wcAbH6UMsYOp5mQW6zmdwl1R3vUPsCLhrfC8xMFaSLWHmJC5hXfCNKSH0cUBOj4opqevdDvpISNVRccx2K3qhLn6NIYYlpdHtK00Tr8zcGy7+OEsjZ/wZU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com; spf=pass smtp.mailfrom=foss.st.com; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b=Ac8tNcS2; arc=fail smtp.client-ip=91.207.212.93 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=foss.st.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b="Ac8tNcS2" Received: from pps.filterd (m0046661.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5B5913M02047817; Fri, 5 Dec 2025 10:05:14 +0100 Received: from duzpr83cu001.outbound.protection.outlook.com (mail-northeuropeazon11012031.outbound.protection.outlook.com [52.101.66.31]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 4aub8nb5ad-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 05 Dec 2025 10:05:14 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=sWi+0hJzGNRlIxgklKsQhaK1/Ajjvti2wPEgHo4/wP+bF1m8kctGp3IhyR4d/w3WbwqTBYVx15Xdp06tu8hQIOblbFJIiO/Sl/eEGW4PGoRHWehYtld7wzIqBfEGVZ5uOTQGUBNHbCJ/ZmVwZFl6iZ9Nfmo9O36cLJ8eDUqg8XwYXNsT7ImmrytYogcSe1nn8CkX6TjlqnkecVMjdXCDiM/nko4lH9xYSWAo1j/Lne4EWgEfbTcZ5zZH4GJMstgb9n5p/FQPohmQkzxJ11YT0olEH89wUphZNoGv12D6wRZfCrPdIvogbHUPtX5B6Q5/0WMR5aBK43uWaW93kHcyFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=u35wuCE7vol6K/ekR+LGiXYA9EvNk8QvRyP5wyyfImM=; b=s21RBljKDiS1Hesa/LUBS2k+rn8BP2Uo7ZwuOV4KkY7fty8DY2/tGJMJnVJjO8CFJvRxwo+J2mfyBlA6QQV9Jdtb3tsx6mjU/sw6w+vrO09npE475WQZmOsW+xuD2gXjubQHVuHH+0jO8j80KeDV9pM9UrPDHwzCXfCO9zEzugEMoWnCuNDplxnqAjql6VgvOUXGFs7V9AIhnUHpBO9k8JK9sIsNP+JAbjHUhj7+xRQhDoFHPFehGi5/cJeXrg10pHM6WO8FLDlagPvTpEiuC//Csb49lzb3WBNLJhLKGV2mcJvtkbEtJxL2juTGHNAdU3i8HdYKYNzSU4Hv3LwTEQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=fail (sender ip is 164.130.1.59) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=foss.st.com; dmarc=fail (p=none sp=none pct=100) action=none header.from=foss.st.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u35wuCE7vol6K/ekR+LGiXYA9EvNk8QvRyP5wyyfImM=; b=Ac8tNcS209lW+X07NA79e0xRKIfj7OoQCVFF9F2QD8D321XujgnWOlH4wvszpnqbmhUsADklJwgfL1tu03fH5N5OgweamMmEZ5/96cFShahce8cg5LIgDlCVu5Uo2/yPPf6UbEeQlGBfvdWFqL4ly/XAZ0JVhd3FRwou/iZYj88JDaj1rLuMmgfAiJqL1lC1kpqCGrzFdW44JKvJbP6Q1kHM839iHW9QBhncYpYTPoup5lJ8plekTKXbZROP/jLgo3AKbSkvZBSdSd9E7ZfarIPCVAxEtuHogYkOvFBkBssk3FHbd/LzEmTOuJHfGWzXdHrpOVxA95Z+OMc8Bm1BFg== Received: from AS4PR10CA0024.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:5d8::16) by AS8PR10MB7087.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:5ed::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9388.12; Fri, 5 Dec 2025 09:05:13 +0000 Received: from AMS1EPF0000003F.eurprd04.prod.outlook.com (2603:10a6:20b:5d8:cafe::44) by AS4PR10CA0024.outlook.office365.com (2603:10a6:20b:5d8::16) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9388.11 via Frontend Transport; Fri, 5 Dec 2025 09:05:13 +0000 X-MS-Exchange-Authentication-Results: spf=fail (sender IP is 164.130.1.59) smtp.mailfrom=foss.st.com; dkim=none (message not signed) header.d=none;dmarc=fail action=none header.from=foss.st.com; Received-SPF: Fail (protection.outlook.com: domain of foss.st.com does not designate 164.130.1.59 as permitted sender) receiver=protection.outlook.com; client-ip=164.130.1.59; helo=smtpO365.st.com; Received: from smtpO365.st.com (164.130.1.59) by AMS1EPF0000003F.mail.protection.outlook.com (10.167.16.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9388.8 via Frontend Transport; Fri, 5 Dec 2025 09:05:13 +0000 Received: from STKDAG1NODE1.st.com (10.75.128.132) by smtpo365.st.com (10.250.44.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Fri, 5 Dec 2025 10:05:53 +0100 Received: from localhost (10.252.31.202) by STKDAG1NODE1.st.com (10.75.128.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Fri, 5 Dec 2025 10:05:12 +0100 From: Patrice Chotard Date: Fri, 5 Dec 2025 10:04:58 +0100 Subject: [PATCH 8/8] spi: stm32-qspi: Simplify SMIE interrupt test Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20251205-upstream_qspi_ospi_updates-v1-8-7e6c8b9f5141@foss.st.com> References: <20251205-upstream_qspi_ospi_updates-v1-0-7e6c8b9f5141@foss.st.com> In-Reply-To: <20251205-upstream_qspi_ospi_updates-v1-0-7e6c8b9f5141@foss.st.com> To: Mark Brown , Maxime Coquelin , Alexandre Torgue CC: , , , , Patrice Chotard X-Mailer: b4 0.14.3 X-ClientProxiedBy: STKCAS1NODE1.st.com (10.75.128.134) To STKDAG1NODE1.st.com (10.75.128.132) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AMS1EPF0000003F:EE_|AS8PR10MB7087:EE_ X-MS-Office365-Filtering-Correlation-Id: 0ec59b93-9f9e-49fd-198a-08de33dd6668 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|36860700013|82310400026; X-Microsoft-Antispam-Message-Info: =?utf-8?B?TTE2QW5hR0N2Rk9Zb2QveVo2Q2huTmNybVJ6N2duZnpHSkt2dWd2cENDTUZv?= =?utf-8?B?ejBST3FxWmJycUhQZHJsbFErek5uUk5PMmpwV3RCbnhjZ0RWc3JnMmw3RXZE?= =?utf-8?B?aXc5RzVPSjN3bzNqcjVPN3B3VDYyL2d4WjI2YXBEbjhXOHVlcHo1RktYSHZ6?= =?utf-8?B?S2NGRDV4MTA2QWJGYWZCNk1TOE1yMWV5TXpaT3N3OTZyWkcwdzJ4Wk5MY2s5?= =?utf-8?B?V0Jrd01DWWE4UllHSUdCY1NoTjRPNHhNWWxxblcxUEF2dFFsNnhMQ05CQ01J?= =?utf-8?B?YVJlYnpwMXZCVFZnRFRqcHo2NHBkRTB1T01pVEFyU0VOY0NtaS9mU0ZDckFp?= =?utf-8?B?NnJHdVgvWWdKK29TNk4rU29lREx4V0xxWDNyZGtja09JS052ZWNEbHF1bUZF?= =?utf-8?B?cHo0NjF3aWtDU0h2Q0lzVzhheXM3TzQyVjFMRWlxUFV1SnlhYUNPMEViYnB4?= =?utf-8?B?ZTdKQ1lSdjgxMURtUXRFSlpOb2lxN2dTaTFpMmhsS1ZESnhwYnRHZE1aTGp6?= =?utf-8?B?eThubDRtdFVkcVphdmRIelpncTA2aVQ3bkN0aldYZ3F4Ty8xOVBTTGpqMlBO?= =?utf-8?B?bG9zMXgvQjJrWCtJSWM2VXFLTlFKQXMrQjYxZUtpd0VKMG9tcGpoR0V3eitG?= =?utf-8?B?bXoxUFJEeG51ZXMzLzU2NU8wU09SU3IvOWcycG5Md0I1R3JqWXF4YlRVYzJ5?= =?utf-8?B?ZjZQb1lZMU9Rb2hrOUxSWHN3bGZmcUdjVndHS2pSRWxVYWJ0OEwyOXVoNVZL?= =?utf-8?B?eVJVcjNkV2dGQ2x5a3dBRkh6allCU2N6U2ZhWGErczBHbXdERW1WMXBVcWdE?= =?utf-8?B?ZnZLOG94K01UUUZoUm0zZHNGS3g4V3A2eG9LRlhVcWFXZXA0YjdBUWd0TnF4?= =?utf-8?B?S0xabHVjNmpsd2lSWFhENTZ6eXFCSjdVOVU1aTZuQ3NVMCs1UW94VWMzbWRY?= =?utf-8?B?czlxUmNiVnFRYUpUM1kvQ3Q4NGdsdTF0N2U2UWc2cElvU3BqaVBJakM5WjBu?= =?utf-8?B?OTRmVHdLS29LeVAxbndiWi8zalMxVDQxblpIOTFja1VncFRtMDAxS0ZZZ2sv?= =?utf-8?B?NU9Eb1hsRUdjemxSc2Rqdmo2V1FHRmhycUtJTDhGeElXeklsdzU5RGFFZXB3?= =?utf-8?B?clplRXJvUUlKTVlrQXhCcHJndm9ReXZ1MndnM1B2Yk9WbGp6Y0JIUGhZV1VZ?= =?utf-8?B?ZXRhcm9XZmpObGo1Sm1XSkJuMFZvZzZYVW16VFl0RjJUaDVYcFJWeG9pNnhT?= =?utf-8?B?UXYva2EwWGNKUUdtdUtybmo4TFpKM3ZVTksrTmhkUzd1K3BDR2EzcnJuUW9X?= =?utf-8?B?blpPMEthemd3K1kweTBxMzByZDJ5aSthcU1PcExxZUtDck5YbmNHcU0rK29i?= =?utf-8?B?ems0b1ZaNTdxRUtSbnBJdXUwOU11R2RpQUx5anQvQU80cEcvTUxpTW96REY4?= =?utf-8?B?Q1d4L25RL3pVbm0yNlBWTElRUVJsNDRueUc1a1lJZytqSzk2SU90Vkp2eTJp?= =?utf-8?B?VUFFbWNyenc0Wm5OTXZkNmExVFY4ZzhCTVlDOGZ3aEhnNGMxVnp4ZWlTTHM4?= =?utf-8?B?Y2lsM2tBcnk4M3lrdEJQWndLK3FMQ1RJaWVCRFdZWGRxRlhpemlxbW1ndkFC?= =?utf-8?B?WjFsaEI2QU9MYnhzaG1ZNmNidTNUTnVFcDhpcGN3aWZxdmVoMXZFL2JOcWg5?= =?utf-8?B?WWxGeGhuSWFHVkZuYVlTU0lUalpKUm0rSXM2YnJ5ZlNPNmxGZi9sSS9yN1NP?= =?utf-8?B?U2tLTjV6QXE3WC82eWlYdHNLbjBMYzhOY0JLL0NqbGE4Rm1hMnAwVlR3bzZw?= =?utf-8?B?cERVTHVFdUdFNUNxdHA2N3RoQWdKemMwZzlMOFI4OHRTWG5rcDU4MjlkbGYv?= =?utf-8?B?NkhvQ01JOGNRWEpnamZiWDliNlhwc2p2KythN1ZINk80ODBwaXN3NFg3N3BK?= =?utf-8?B?VkhtVGNJZ1dXc29ORnJNU2dzY1RGU3JsRG51N2VuYXROWW5McHhXVnY5eTZB?= =?utf-8?B?d1Q2UnF6VndBYXRkVFJ1dk02U0VOQ1hTcjUwbDF4OWdib3c5UUphUG92bm9o?= =?utf-8?B?VUxyNzdNcDdEblJ3aUFkZnlxSUF4WkdGaDhNWHRtekluYUc3Vm1MQjRudHdh?= =?utf-8?Q?nddM=3D?= X-Forefront-Antispam-Report: CIP:164.130.1.59;CTRY:IT;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:smtpO365.st.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(376014)(36860700013)(82310400026);DIR:OUT;SFP:1101; X-OriginatorOrg: foss.st.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Dec 2025 09:05:13.1246 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0ec59b93-9f9e-49fd-198a-08de33dd6668 X-MS-Exchange-CrossTenant-Id: 75e027c9-20d5-47d5-b82f-77d7cd041e8f X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=75e027c9-20d5-47d5-b82f-77d7cd041e8f;Ip=[164.130.1.59];Helo=[smtpO365.st.com] X-MS-Exchange-CrossTenant-AuthSource: AMS1EPF0000003F.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR10MB7087 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjA1MDA2NCBTYWx0ZWRfXwuC1DKXyVu46 pyA8yDY5H92Fvsx2MwXFKNqi5DvX4uiewfnY+JGd8DAeaQRwTo/weCip/Ep55r6blPja5fQxcXN evQsSRe0K0B8HnBYAxSGewsfvtrudFYW4Gzxkql2GGMNoL16UsU+WhAbEQycA+12zwyATyfl//a Mrdz/eN7F35ASCFpxAVe8yH+qdVVnw3/V8h+BC7ZRaqyOcU7cw9QcOg/ayUhxLn9E21CAj5D5RB 3GL1yMdkSoUFXjAE3WGSvJvapRMY0iUSwgnuvU3rUL+2P8lO/2RpxbGOMK9hv0HG+n2bg6nOwCj Ue6xxnvPADUCR0x06Ano9UCNEl5xDaPWcBMeYQJNRiV0BN4M+hzRAhda4iNnOYPRwJc5pFQP3yv WuriOJPlWIIoS9dNhuxHOoV4UP+UKg== X-Proofpoint-GUID: TqeSy2WlAzOjxvEJhP9sKZE8iv9uPtSg X-Authority-Analysis: v=2.4 cv=X99f6WTe c=1 sm=1 tr=0 ts=6932a04a cx=c_pps a=0tZRaOFwq0BxzmvfxNdFUA==:117 a=d6reE3nDawwanmLcZTMRXA==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=Uo5EeBN78AAA:10 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s63m1ICgrNkA:10 a=KrXZwBdWH7kA:10 a=VkNPw1HP01LnGYTKEx00:22 a=8b9GpE9nAAAA:8 a=F6HTmrlUwN8psNLP8S8A:9 a=QEXdDO2ut3YA:10 a=T3LWEMljR5ZiDmsYVIUa:22 X-Proofpoint-ORIG-GUID: TqeSy2WlAzOjxvEJhP9sKZE8iv9uPtSg X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-05_03,2025-12-04_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 impostorscore=0 malwarescore=0 priorityscore=1501 adultscore=0 clxscore=1015 bulkscore=0 spamscore=0 phishscore=0 lowpriorityscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512050064 SR_SMF status bit can only be set if CR_SMIE was previously set, keep status bit check only. Signed-off-by: Patrice Chotard --- drivers/spi/spi-stm32-qspi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-stm32-qspi.c b/drivers/spi/spi-stm32-qspi.c index d6f6f9d4e5be..2a0ee96786fa 100644 --- a/drivers/spi/spi-stm32-qspi.c +++ b/drivers/spi/spi-stm32-qspi.c @@ -132,7 +132,7 @@ static irqreturn_t stm32_qspi_irq(int irq, void *dev_id) cr =3D readl_relaxed(qspi->io_base + QSPI_CR); sr =3D readl_relaxed(qspi->io_base + QSPI_SR); =20 - if (cr & CR_SMIE && sr & SR_SMF) { + if (sr & SR_SMF) { /* disable irq */ cr &=3D ~CR_SMIE; writel_relaxed(cr, qspi->io_base + QSPI_CR); --=20 2.43.0