From nobody Tue Dec 16 15:05:59 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 71D7C339701 for ; Fri, 5 Dec 2025 19:46:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764964016; cv=none; b=uu9Oa50jSMfiir5w0quQKwK0h3/BrlVDo4MawW7n96SzeesaZv0T4t1XIwNVKm5EXewJSWrkowU+lZ2LO9IXAGrY2loIirTvEs7ln+qIBRf7jnAMo1gjwhf4QzIX37YOc25MpviASp8TzYXqYk/WFjZStZy1A8j4R0UaGUZttS0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764964016; c=relaxed/simple; bh=z9S6zDYSq6RyfRn8B4HCTLbBL7NBL7L4ZkDAdn6b+S8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=MAF0c+39/pwFfJtob7S5zyTMvgIK13BG4WyMMh6oD87LT59CpFzTLu0+UbuK/joQTaBJD7HhXT6+VWS1i63YYKKQcrrJQAqrIayF1VJ0lb6FWNmRZVBWoAlhP/CTQQgPo+HsKVEDId93wEOHrw3Dtrr+aN172yLGIw/Ik7lrUls= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=X7KZ6pw9; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=e0PcRveS; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="X7KZ6pw9"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="e0PcRveS" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1764964013; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PCnk3SOexQlPSQvnYnFQ+FpFJGUp1UmIpL0d6S9c950=; b=X7KZ6pw9/WlYMZUkGTgjdIrDYvv7qy3r6dUvKy39zQ8tHhvngTW/ptnk7+EBJtIuWD7ph9 sce2XL1udiom5Vyl/T+/9adhKc4ADFfazKenWMNP1ZInwt9HOtUZE1EsDbNbdgP/xzHDib B/w7WZtl0Kc4FPFvM7oYbCFSERXpbHU= Received: from mail-yx1-f70.google.com (mail-yx1-f70.google.com [74.125.224.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-643-GSocQcW3MOawmsEQwvZuXw-1; Fri, 05 Dec 2025 14:46:51 -0500 X-MC-Unique: GSocQcW3MOawmsEQwvZuXw-1 X-Mimecast-MFC-AGG-ID: GSocQcW3MOawmsEQwvZuXw_1764964011 Received: by mail-yx1-f70.google.com with SMTP id 956f58d0204a3-64203afd866so4355578d50.0 for ; Fri, 05 Dec 2025 11:46:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1764964011; x=1765568811; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=PCnk3SOexQlPSQvnYnFQ+FpFJGUp1UmIpL0d6S9c950=; b=e0PcRveS3juyqvWVqdsibp43KK+kqdrodTRG48PlnGFVbdAHFkaFyzd4sn3YdcYyyv Uo2RmOb3UrRDsbxfYdE4OtCmQyFIYJ20mWZquffo5hh/dIvPDOk9cYPzIO0Ch1xWtkRr bNWdUzHWP19w0GR0KL9bJA+cR4GV9BamCz+DS3Uj1mvFQ3h63KL0v5OJgdgZEXKeyLpV T4WHJvNs0L0tcsHZqjMfPd1fnSJUqBILQMDgwjwtvQspycMQeGec8vQkp2tWYGQ7EnIm yq0VBbVsswAxthIJRt8THlUwGBopQzuV+vbXGdqR93hwtbDZ7Dh6uMdWDZ+P5hzySqHf 19Gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764964011; x=1765568811; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=PCnk3SOexQlPSQvnYnFQ+FpFJGUp1UmIpL0d6S9c950=; b=M72JmGRXRlmPfjVKigCEWLsMPHh9qTti45vWlBwSk1j3dmGFEqE0v/5f3hiDHutTHI u2HUU8soSPSthSVzBT9DUgZx5dh2miyT9+wM1Cxn2Ti574QlXCOd5XaK4kEHu8PdG2Rc dBPX1ctf7C2kBBchE52eI2yq8A/4zJcwk5gu3OzT18yFV70cwgtQKeb5g2Bf7sIN6mAd 6jOpfHMUPC5YDyeRFNRu+F/lAZIqxdBmMorI7DsZVazJxEeudq7XimITxrKzr0gCHIrZ PoIT40Y8DBO+1aDHnhC9cKFc+KA1LsygNkkNU1K95YMFdcRUTV9CF9OsArUn+HeTyDra F9fg== X-Forwarded-Encrypted: i=1; AJvYcCWyOrsomqeLR+hSj8KaeY9xxm+M1/D/30/fwrzmKyeHmE370bnxzxy0G8XZGdOxJ4hcaYw69QKhLc6piLo=@vger.kernel.org X-Gm-Message-State: AOJu0Yz1ByXZMfuKMcpJ+tUdv6Ppabd1o1TzQp1C+T1lz9eULh1uhoLc LQUDkzbf0UrPFv1hHdbtBlRGIuA2vFgVkGK6WU8M1AlV2NF8hunb45589Bs4Q7/8M+cOpuU8eU+ I5bz0LX0Gk5yzYEi40OQiEN0d8Gynnz3JlrSn4n60/Qt/HOWOD6kMCvXjpsg/h6+olQ== X-Gm-Gg: ASbGncsUN6jI1kGXfNqiTcCTrqh9QbcCi2AqPInx8fV/3BMhmy8mLO1G+Ug5KM6MSPw TTYBs9T+XMgpmEQj8OgEwlaeFhlqFGP5xs3wFbiv3MsaPp4ZH0ZinjXB4cjr9lPQeIvaDZVDal2 PoHoD8x48VgAv9IYMkQ5ihWSrnYlYdQqbL6M5NSu1WnNglbthmmH7hxdbHrtnYk/BRAWkFHroBm uevRY9LprHfyB79VOTGybDiio668uBr31kl3mouoVi4Seq8j1T6wqlBWoOXz+joj4WXaEUF19Ue ExlVVf5O4Wj5Vf3vcdGOyFGf8W4+fSIRCyvMy4ZqiH1ud5pjvH6nlev/wtSLl3mVG5ANQfwlQ6T jJAZfqkoD4GDuQK9+qgbYhLSg0cTXaIAKsmaOt/wBw5MN429A X-Received: by 2002:a05:690e:2554:b0:63f:b353:8fb5 with SMTP id 956f58d0204a3-6444df9f5abmr277210d50.15.1764964011230; Fri, 05 Dec 2025 11:46:51 -0800 (PST) X-Google-Smtp-Source: AGHT+IFPCTnHwXvSA/0u8cdC7xQI4iIcuunv7o9haRn4g76piPssnlXwS/AvpPUROxj13yRu0IYpmw== X-Received: by 2002:a05:690e:2554:b0:63f:b353:8fb5 with SMTP id 956f58d0204a3-6444df9f5abmr277192d50.15.1764964010883; Fri, 05 Dec 2025 11:46:50 -0800 (PST) Received: from [192.168.1.3] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-6443f2b80casm2151181d50.9.2025.12.05.11.46.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Dec 2025 11:46:50 -0800 (PST) From: Brian Masney Date: Fri, 05 Dec 2025 14:46:28 -0500 Subject: [PATCH v3 2/4] clk: microchip: core: correct return value on *_get_parent() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251205-clk-microchip-fixes-v3-2-a02190705e47@redhat.com> References: <20251205-clk-microchip-fixes-v3-0-a02190705e47@redhat.com> In-Reply-To: <20251205-clk-microchip-fixes-v3-0-a02190705e47@redhat.com> To: Michael Turquette , Stephen Boyd , Maxime Ripard , Claudiu Beznea , Conor Dooley , Dan Carpenter Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Brian Masney , kernel test robot X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2161; i=bmasney@redhat.com; s=20250903; h=from:subject:message-id; bh=z9S6zDYSq6RyfRn8B4HCTLbBL7NBL7L4ZkDAdn6b+S8=; b=owGbwMvMwCW2/dJd9di6A+2Mp9WSGDKNzZb0hzaodfcG+l0WkzyQfe+hfyKX+LHOe7Exl9KK8 piWFDt0lLIwiHExyIopsizJNSqISF1le++OJgvMHFYmkCEMXJwCMBFJTYb/iS//Bu5YFDRty5bq tZsY/UtP2s4T+hH4Rsa/6HRlxPQXQgy/mISmFMjkzO8+Y/bgjNHCcob8HYcavIRXTvi1LGD5xHh vZgA= X-Developer-Key: i=bmasney@redhat.com; a=openpgp; fpr=A46D32705865AA3DDEDC2904B7D2DD275D7EC087 roclk_get_parent() and sclk_get_parent() has the possibility of returning -EINVAL, however the framework expects this call to always succeed since the return value is unsigned. If there is no parent map defined, then the current value programmed in the hardware is used. Let's use that same value in the case where -EINVAL is currently returned. This index is only used by clk_core_get_parent_by_index(), and it validates that it doesn't overflow the number of available parents. Reported-by: kernel test robot Reported-by: Dan Carpenter Closes: https://lore.kernel.org/r/202512050233.R9hAWsJN-lkp@intel.com/ Signed-off-by: Brian Masney Reported-by lines, with a single Closes. The warning goes away if I do Reviewed-by: Claudiu Beznea --- drivers/clk/microchip/clk-core.c | 25 ++++++++++++------------- 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/drivers/clk/microchip/clk-core.c b/drivers/clk/microchip/clk-c= ore.c index a0163441dfe5c1dfc27dae48e64cf3cb3d6b764f..82f62731fc0ed566b0c6b007381= c4f10a2a8a7e7 100644 --- a/drivers/clk/microchip/clk-core.c +++ b/drivers/clk/microchip/clk-core.c @@ -283,14 +283,13 @@ static u8 roclk_get_parent(struct clk_hw *hw) =20 v =3D (readl(refo->ctrl_reg) >> REFO_SEL_SHIFT) & REFO_SEL_MASK; =20 - if (!refo->parent_map) - return v; - - for (i =3D 0; i < clk_hw_get_num_parents(hw); i++) - if (refo->parent_map[i] =3D=3D v) - return i; + if (refo->parent_map) { + for (i =3D 0; i < clk_hw_get_num_parents(hw); i++) + if (refo->parent_map[i] =3D=3D v) + return i; + } =20 - return -EINVAL; + return v; } =20 static unsigned long roclk_calc_rate(unsigned long parent_rate, @@ -817,13 +816,13 @@ static u8 sclk_get_parent(struct clk_hw *hw) =20 v =3D (readl(sclk->mux_reg) >> OSC_CUR_SHIFT) & OSC_CUR_MASK; =20 - if (!sclk->parent_map) - return v; + if (sclk->parent_map) { + for (i =3D 0; i < clk_hw_get_num_parents(hw); i++) + if (sclk->parent_map[i] =3D=3D v) + return i; + } =20 - for (i =3D 0; i < clk_hw_get_num_parents(hw); i++) - if (sclk->parent_map[i] =3D=3D v) - return i; - return -EINVAL; + return v; } =20 static int sclk_set_parent(struct clk_hw *hw, u8 index) --=20 2.52.0