From nobody Fri Dec 19 17:14:29 2025 Received: from mail-ed1-f66.google.com (mail-ed1-f66.google.com [209.85.208.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0FD9E32B98B for ; Thu, 4 Dec 2025 21:10:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.66 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764882664; cv=none; b=uyrqjboLJ1rz0tVHOBR/VB9Iply2DVf41QWuA0yl38eFn/qqDxD9DPgBX76TukAKoG6woKW3UOBa5WtFKBLoF60VZYbyeu9VdRJSiVg8C8iZG8UUsrD/LTJw9dwj6Ez7HKbAoDGDB8KmGVTZPzt51MnStQpiDWC1pp0ld3aWMwE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764882664; c=relaxed/simple; bh=w3fsxewpQDLfXHQ4U2m1BD9H/RVSNts68FOUpu4tU7Q=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=aqQ74UnVs0QnuWWsXymPTBipLKhkR4gHRGKy+nRPs8Bjf9Ft1ipX9zJKsORe7thKc+VbpLtFGMzahNQUGG4uHXy3U6JpjvsGkqf2mPbrnFLigkhjaXFOTk8sdgjsCiD0Cxc/0LRCK4d703va0+oNEUBWhAaY+TrX8Mu9Y6EGdEQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fm6embI1; arc=none smtp.client-ip=209.85.208.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fm6embI1" Received: by mail-ed1-f66.google.com with SMTP id 4fb4d7f45d1cf-63c489f1e6cso2319225a12.1 for ; Thu, 04 Dec 2025 13:10:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764882658; x=1765487458; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=eprH5ppmLX3mc74864RpHa6sZY3l7+Jd7hL26GBKWpo=; b=fm6embI1MTnNcUt4b01kFXqCFj8x7lYEDOywmJw1UoM4ln8ONfrS41psaeI+MgaUDa dx0h7aEDnVEh5pagigSCuxGD10WqtDhsh83+oJAWk53FF7XIRerb9tx+JPta2wIMDrts wW//pepRm/3ue0kTm1S9ikFZ0XlbF8UOODPmIMxznypQiFbQ5OHPyhb4JKqMBBq3SQX9 RcFp5lffYC7Vwl+dtaObWVF4oYArL9Qr6Q6Ezv0YsALlrIfuOee73Q3uBKHg1eryK7s3 XX1uu/YTgux6SCf5ke11TY30c1OU7t9AAlvmcxkA09IMxLHyh4+sywnwCjhjcY+LtOwZ pX5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764882658; x=1765487458; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=eprH5ppmLX3mc74864RpHa6sZY3l7+Jd7hL26GBKWpo=; b=Y5K2Xn5I6m6JexBRbnIO9OK0xOrK6iw8Y4LHPPKKy02Cr+Uy2nEJjIFoix7uiAqfRS 1DT4SdEbjsQJbPt7VvQV50xR12+PXtYDUYtbwOBmDVZxuWAt8Xfvc+o5siOUNFHlbf2H b/Y7ZLb1coFoQT6ZRXL7bVzvFJY/GK0VnEI2t33JqxciyiLoA/D0LG8f5Jcia9N0SdHH zb6jIBK4PEa17H8ZXWALg8FMeG6sBXe2VZntmflWK84dVntXyHV1Bx3oSxxJfyfzi4sk bV2muq1m6SjqA1zSh406P9v6AUn+C5ySwY0bnjJxaJawblFGKwtBKXokBcizXPhxPD5E AWTA== X-Forwarded-Encrypted: i=1; AJvYcCUPzVyLWMpdsmO2WJLN53HRYrt4ZEQci9UXcE+CU+CaxNV0emjLBFFTb6Udh7tjzNSS4hii28P1CI2p2vY=@vger.kernel.org X-Gm-Message-State: AOJu0Yweuhp8ZQpMN8aLOfTnXy7zfLrslRmd6cr1uIJ7lcviUaDpajSc 7BGSFsAAGy7lMUniY73EeLDGLF8pciDiLselkfaHznt0ntfhbDgfN3Us X-Gm-Gg: ASbGncvZt1OngK+giiOfJ7YT4tm5SiTwVoeanaUBr6MYk/nE5rMS/7qSSSfg87gtXIA NV/VOU/AV4/sZLNTCdtYv2FBExvc0urCOqUC+qXC3zN9ngCPweAHzQQGoAGX3ioOuuoMgHFWdA7 LAvv1uoCLtiiCPSqlKSGIuoT8Rz86pi28+ymxVbwGq4mdFnxAEy1ebuLg1DigPbZ3V24NiPyexd 2RZ9lR/NF42s6FcoLhZi3iBXuqutG00cufocwoKHYbuWlzyecmdppBk5e4Kl2RRZ19V0Kvlsfe7 Xus9Uln47vIHzl61ZKhUnLioSwphkjqt7z5FkzN2/m1ArAVMVV6jrnk2p5hyEVyBdpCPadOyujE 1WB6fM3Mh7+M9X1BhPqpMvjoLosZkRz8zMFRTgGPWA3efPN4h8haj8ED8FkW2yzJmzjnUJXsoay NPRx09Wdw86VSSGr/f1gxBm8TZExn68+PP31L32aJEtOIkTeO18A== X-Google-Smtp-Source: AGHT+IGc66idt8JicKNR4ASpYKwcPBT7B7V1xyFwPjccrBV0T7qHsz7RhYJ/3ncWmVy4NaDDTRu4iw== X-Received: by 2002:a05:6402:40ce:b0:647:62ba:123b with SMTP id 4fb4d7f45d1cf-647a6a23982mr4411205a12.9.1764882658250; Thu, 04 Dec 2025 13:10:58 -0800 (PST) Received: from geekom-a8 (net-93-66-99-25.cust.vodafonedsl.it. [93.66.99.25]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-647b2ec319csm2106940a12.3.2025.12.04.13.10.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Dec 2025 13:10:58 -0800 (PST) From: Massimiliano Pellizzer To: clm@fb.com, dsterba@suse.com Cc: linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, Massimiliano Pellizzer Subject: [PATCH v2] btrfs: remove dead assignment in prepare_one_folio() Date: Thu, 4 Dec 2025 22:09:59 +0100 Message-ID: <20251204210959.9672-1-mpellizzer.dev@gmail.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In prepare_one_folio(), ret is initialized to 0 at declaration, and in an error path we assign ret =3D 0 before jumping to the again label to retry the operation. However, ret is immediately overwritten by ret =3D set_folio_extent_mapped(folio) after the again label. Both assignments are never observed by any code path, therefore they can be safely removed. No functional change. Signed-off-by: Massimiliano Pellizzer Reviewed-by: David Sterba --- v2: Remove also the initial ret =3D 0 assignment for consistency fs/btrfs/file.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/btrfs/file.c b/fs/btrfs/file.c index 7a501e73d880..9e2c2f2cd03f 100644 --- a/fs/btrfs/file.c +++ b/fs/btrfs/file.c @@ -859,7 +859,7 @@ static noinline int prepare_one_folio(struct inode *ino= de, struct folio **folio_ fgf_t fgp_flags =3D (nowait ? FGP_WRITEBEGIN | FGP_NOWAIT : FGP_WRITEBEGI= N) | fgf_set_order(write_bytes); struct folio *folio; - int ret =3D 0; + int ret; =20 again: folio =3D __filemap_get_folio(inode->i_mapping, index, fgp_flags, mask); @@ -877,7 +877,6 @@ static noinline int prepare_one_folio(struct inode *ino= de, struct folio **folio_ /* The folio is already unlocked. */ folio_put(folio); if (!nowait && ret =3D=3D -EAGAIN) { - ret =3D 0; goto again; } return ret; --=20 2.51.0