From nobody Fri Dec 19 17:16:32 2025 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 796E934A79E for ; Thu, 4 Dec 2025 18:55:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764874531; cv=none; b=mrKVfdsKO6wjdyic5ILtq1vYeHiz75nyYFqyfevaACOkWBpXOjVPtqrBtzjykSIf+eEJPOWK2QLFRGooCRSsDiRdHjC8v/RMboAG5F3tBdDUKgM8k52Hu3R4amJ6caExeNXvw9dzKgubsUcfFmi8TcvEphdEOUa1THx2915II70= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764874531; c=relaxed/simple; bh=/zCl0HuPLWjC7Sa6krfiRVgt0gQ+G9nABtH88tweDYg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=CyXH79bmrfyZ6YZns85daCmVc3xIxXGM9Wmdmsd592mz1MyEm+n37Qh80Ugp5f0wMQZ3UNZBCu7BBIFEAJGaDu20WjrchNvs7vpJoLyGOnoAjSMu6V7hHP8nDvc1N85B58v8/7D0G5ZnGibwFMLfQF5un1WKEeGx7Fv4gY5NnPo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=F+UEPaAr; arc=none smtp.client-ip=209.85.210.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="F+UEPaAr" Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-7b9387df58cso1997139b3a.3 for ; Thu, 04 Dec 2025 10:55:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764874521; x=1765479321; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Y2RVHBZV4NpZC/dFubhuGIj8Sf/h6laSe7o6mJh9Dj8=; b=F+UEPaArtquoUXI54Mn+rCLLwttSHhsvEnQA8dd39ggCAie3GiyJoElRDi8xazpZ4q yzuDW2Or2zuvytvqgesVbCP3I8MgAsTBxgOv8lFvjThmq7Sl460x8/GNldfr6bLmcn1Z 609NsRBkEsdTClXA+5aFWKmAGvk5qyMCKZ+LnGI319oi7fdLYqGlhRSQdp5JllhDQ4hN 8LaYOPHFMpcRoYj/BiKUSGaJLTY15FrUS9nYZX2BtVgX3sWQpAYcHaUq3JB9uIZw+kF2 td3SAWS0HAo5+Bik+qCGOOSWdxewFJoWQIlN2l4/53T3193MFTNqS5W8mqQEb1N6QC1E ysTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764874521; x=1765479321; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Y2RVHBZV4NpZC/dFubhuGIj8Sf/h6laSe7o6mJh9Dj8=; b=qVdcvKlyFOh/OmPfrkzInnsXwLnPb0nIKVeA/r/bkO6U+jrhNCthEYtxlXOGcZxM7W deJEfl75rNvN3r8MEyWraKXOdU1CWo67S/3WkuKElkMMe9m7a81GlSPLaUmQAsO5xjUC iqqDRTItFCTjz2Nok+SU/AljHmHWnWpY8GbI+vujzLpNkMWdcohSenGUdJYt4qJbMobj L0WeWMx3/JljdL83RQeR8lW6+jn1U93+Mt77bDk7LITU8ySyJAFl8PD7VGnWoZ63DcIO LKreBuO3zKo42GKhDrFc8Tgkzj9PCAv6tawMDioKYycEbeTQD1jge20+aLYwLfBAeYu2 k1aA== X-Forwarded-Encrypted: i=1; AJvYcCVkOVLEL8EjpLAQm/TuljwZ7LL/MirDFTJwtF34eiv+Fk72aD5Nox9xvLXOIf6+a8pGug9DmTQChQ6/408=@vger.kernel.org X-Gm-Message-State: AOJu0YzpBxvAyWdHEIo23EoODqxcCmZHw3rAtFoEnlbDtjnObK6ucMjt 7iRoV7LruQ1e00sNPmaoD8n0or/uDl8uIvMlRME8T3DQCXto2jhwGh7h X-Gm-Gg: ASbGnctACp4GcsMu30zMnojEjlrZY+87oW9MqIe+LYqYWjxtaqvNw7UtUwBlAWbgmMg ASU8UjTtj+lQ0ZRQ9u+4B5jfBaUh3kVwimf8yimvpXE+6EkIa0geOT5I/qw8OocDD3KadpwFFBR YnaWc2qbLdUpmdgnkfOv+cSvVfdrYDq9rYPtGDBVQELfLajGJpsjTHe/Tausba6vFYYjqTJ630i pFOhZaKWX3lefQdUyy9T1zYkBfQc4mdFa6uJxEdiDeSVC+2eHgpKfVaU80lozHvMCh05StiFMPC kYyKWz7N8JCTnCoREJliIux7bpdSWKmpBFic+8harr4TGN1ljD1Pw3Kz4cVbv9LLy0i9EYDb1BU FOYQ8sSYexfmQmuLMhIzRGCJJywC4GNP5072+S8iss5hd9ylPowkkK3rKncLHCNtFe1jSkKJTaO PexTZw72/dzJ5OyMzpaiuuzkbdhtAhVFrrGTy/+33CadX5Be4Pj9/LA81Vxd5bMNmH1XcW9mgsf qWAixle9+flvTSW8dvzBlZHf7AuAeIZKh9nvMo1d4y92TEFIjhjR1VxWSnCuDzX5OgYyj2e X-Google-Smtp-Source: AGHT+IH9CgxiAXHcIB0H1EEjX3dtHjvletPsU8kPNx6CZxFd8Hf18KX/AyuG1/Mmw94t1QG1VOAinA== X-Received: by 2002:a05:6a20:3d0b:b0:34f:28f7:ed75 with SMTP id adf61e73a8af0-36403763a2bmr4844083637.8.1764874521517; Thu, 04 Dec 2025 10:55:21 -0800 (PST) Received: from Lewboski.localdomain ([181.191.143.42]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7e2af93d910sm2851475b3a.67.2025.12.04.10.55.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Dec 2025 10:55:21 -0800 (PST) From: Tomas Borquez To: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Greg Kroah-Hartman Cc: David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-staging@lists.linux.dev, Tomas Borquez Subject: [PATCH] staging: iio: ad9832: remove platform_data support Date: Thu, 4 Dec 2025 15:54:34 -0300 Message-ID: <20251204185434.4542-1-tomasborquez13@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove legacy platform_data support as there are no in tree users and this approach belongs to a long gone era. The policy decision on what to output is a userspace problem, not something that should be provided from firmware. The driver now initializes the device to a safe state (SLEEP|RESET|CLR) outputting nothing. Userspace can configure the desired frequencies and phases via the existing sysfs attributes once the device is ready to be=20 used. Suggested-by: Jonathan Cameron Signed-off-by: Tomas Borquez Suggested-by: ... --- Original discussion:=20 https://lore.kernel.org/linux-iio/20250628161040.3d21e2c4@jic23-huawei/ drivers/staging/iio/frequency/ad9832.c | 32 ------------------------- drivers/staging/iio/frequency/ad9832.h | 33 -------------------------- 2 files changed, 65 deletions(-) delete mode 100644 drivers/staging/iio/frequency/ad9832.h diff --git a/drivers/staging/iio/frequency/ad9832.c b/drivers/staging/iio/f= requency/ad9832.c index 49388da5a6..e2ad3e5a7a 100644 --- a/drivers/staging/iio/frequency/ad9832.c +++ b/drivers/staging/iio/frequency/ad9832.c @@ -23,8 +23,6 @@ #include #include =20 -#include "ad9832.h" - #include "dds.h" =20 /* Registers */ @@ -299,16 +297,10 @@ static const struct iio_info ad9832_info =3D { =20 static int ad9832_probe(struct spi_device *spi) { - struct ad9832_platform_data *pdata =3D dev_get_platdata(&spi->dev); struct iio_dev *indio_dev; struct ad9832_state *st; int ret; =20 - if (!pdata) { - dev_dbg(&spi->dev, "no platform data?\n"); - return -ENODEV; - } - indio_dev =3D devm_iio_device_alloc(&spi->dev, sizeof(*st)); if (!indio_dev) return -ENOMEM; @@ -379,30 +371,6 @@ static int ad9832_probe(struct spi_device *spi) return ret; } =20 - ret =3D ad9832_write_frequency(st, AD9832_FREQ0HM, pdata->freq0); - if (ret) - return ret; - - ret =3D ad9832_write_frequency(st, AD9832_FREQ1HM, pdata->freq1); - if (ret) - return ret; - - ret =3D ad9832_write_phase(st, AD9832_PHASE0H, pdata->phase0); - if (ret) - return ret; - - ret =3D ad9832_write_phase(st, AD9832_PHASE1H, pdata->phase1); - if (ret) - return ret; - - ret =3D ad9832_write_phase(st, AD9832_PHASE2H, pdata->phase2); - if (ret) - return ret; - - ret =3D ad9832_write_phase(st, AD9832_PHASE3H, pdata->phase3); - if (ret) - return ret; - return devm_iio_device_register(&spi->dev, indio_dev); } =20 diff --git a/drivers/staging/iio/frequency/ad9832.h b/drivers/staging/iio/f= requency/ad9832.h deleted file mode 100644 index d0d840edb8..0000000000 --- a/drivers/staging/iio/frequency/ad9832.h +++ /dev/null @@ -1,33 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0+ */ -/* - * AD9832 SPI DDS driver - * - * Copyright 2011 Analog Devices Inc. - */ -#ifndef IIO_DDS_AD9832_H_ -#define IIO_DDS_AD9832_H_ - -/* - * TODO: struct ad9832_platform_data needs to go into include/linux/iio - */ - -/** - * struct ad9832_platform_data - platform specific information - * @freq0: power up freq0 tuning word in Hz - * @freq1: power up freq1 tuning word in Hz - * @phase0: power up phase0 value [0..4095] correlates with 0..2PI - * @phase1: power up phase1 value [0..4095] correlates with 0..2PI - * @phase2: power up phase2 value [0..4095] correlates with 0..2PI - * @phase3: power up phase3 value [0..4095] correlates with 0..2PI - */ - -struct ad9832_platform_data { - unsigned long freq0; - unsigned long freq1; - unsigned short phase0; - unsigned short phase1; - unsigned short phase2; - unsigned short phase3; -}; - -#endif /* IIO_DDS_AD9832_H_ */ --=20 2.43.0