From nobody Sun Feb 8 18:49:24 2026 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 20B3D3563DA for ; Thu, 4 Dec 2025 17:56:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764870979; cv=none; b=lHSfbiIVoi+5XvaB+BUGoGk/2+DEpf5srHekV+BjTE+TeyNXPb7LP+fOjV3p03XQ1uHk3JCh0hJIl7jfi3sZO+cdS221DTN0w4CuiOFKCmoEdoqJF/74aNHLzQxGrQ0YSLJxgA+WLoU+Q8x68ANiHbHDoSd52IFLD8Fftqn27YU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764870979; c=relaxed/simple; bh=oHO6PTcw3aXh685KOllB4RZtoSmWA3wpKHrLifYr+TE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DXNBA3o1n7Ps2ecmclctYYg9W/lELZctiC8vkW7ewJu3bSy1nbgOUfdxrnS18WLvUdi2z4ekvSPlSsjpo/Or4nOPk9HToLcKmZ4WjSNuiKHCgXUmue3BDaUJuVbUOz0K1EUJ98yl66pkK2eFykgDoVTgXAWbF3RDN4l0dyUOTEU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=k7Rup/Oc; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="k7Rup/Oc" Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5B4FbwZK018535; Thu, 4 Dec 2025 17:55:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=zfrg1rG5jDOEik4rU JgJKPizaKP9IuPevyT0ezbS4NA=; b=k7Rup/Oc37X8e4ZDBHMl3e6oAvsJDDPop C6Yl8IGPHsCaytOEEPvMpOw1OpgtWVeuGd/RuUNhaXT5H9LL3vqJlntlSVN4CwNs w+PAVotty/fa+wgBCc7TM4g022bbNsVk/UWAfaC7QdBLMRIxyNXJe6hdAIGNj1rk uiWkvF29y5CBip1nPAZevgd4Gno0yOerJxDY5BTrpbRR9ZLlE+0gs7Tv0uHCsWX7 y9HSlkg30kmmbDwAp5AeDHTwd0Qb/dBkgKPvKvH+Jzun4rQbQN74QfjWc0xxgOgq qLM8A4KGx/b3j7lDdmOb/i41rRJykOPIObhvyulqNVDDPqQXK5Vxw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4aqp8q9e4k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 04 Dec 2025 17:55:45 +0000 (GMT) Received: from m0356516.ppops.net (m0356516.ppops.net [127.0.0.1]) by pps.reinject (8.18.1.12/8.18.0.8) with ESMTP id 5B4Hk24A031925; Thu, 4 Dec 2025 17:55:44 GMT Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4aqp8q9e4g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 04 Dec 2025 17:55:44 +0000 (GMT) Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 5B4GDWRn003891; Thu, 4 Dec 2025 17:55:43 GMT Received: from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 4ardck0x4x-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 04 Dec 2025 17:55:43 +0000 Received: from smtpav01.fra02v.mail.ibm.com (smtpav01.fra02v.mail.ibm.com [10.20.54.100]) by smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 5B4Htemk48890148 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 4 Dec 2025 17:55:40 GMT Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1068120043; Thu, 4 Dec 2025 17:55:40 +0000 (GMT) Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8F80B20040; Thu, 4 Dec 2025 17:55:36 +0000 (GMT) Received: from sapthagiri.in.ibm.com (unknown [9.39.29.188]) by smtpav01.fra02v.mail.ibm.com (Postfix) with ESMTP; Thu, 4 Dec 2025 17:55:36 +0000 (GMT) From: Srikar Dronamraju To: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Peter Zijlstra Cc: Ben Segall , Christophe Leroy , Dietmar Eggemann , Ingo Molnar , Juri Lelli , K Prateek Nayak , Madhavan Srinivasan , Mel Gorman , Michael Ellerman , Nicholas Piggin , Shrikanth Hegde , Srikar Dronamraju , Steven Rostedt , Swapnil Sapkal , Thomas Huth , Valentin Schneider , Vincent Guittot , virtualization@lists.linux.dev, Yicong Yang , Ilya Leoshkevich Subject: [PATCH 07/17] sched/core: Set balance_callback only if CPU is dying Date: Thu, 4 Dec 2025 23:23:55 +0530 Message-ID: <20251204175405.1511340-8-srikar@linux.ibm.com> X-Mailer: git-send-email 2.51.1 In-Reply-To: <20251204175405.1511340-1-srikar@linux.ibm.com> References: <20251204175405.1511340-1-srikar@linux.ibm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTI5MDAwMCBTYWx0ZWRfX7hJNWLOXP0fe fK/CL+ZvpnG8hHCZ5yh4SryhATLuFhfljDRhCO96hf7tJFtpoH7Xn070n/Hzi6aRMU5V4QJJFwr vuo86ULF+n4OOQXC1lqSr56/fIfrE24iAEbYTjpyd/Q1vRmgwRC3GniYXgkCyAq9nl+0Ozxg7il MJuZZI9KqeFXCLCenD/f7C+ryC0hbAgFX4+2lLBiiTKwOdY2ZSxVR32JrC1MpvsJ1AGJKx4UkEN q0zwIMtNsHGnR984jlLGPp8iTz7l13wxfalvKeEzAxwrOowsVuEnk24LK3uc08lOA9DMTxzU+jx T9hTgZmpZgicw1BYCTKycaoPGxirHPAlhvAYEceDpW2Sf7AoUcc/jVv2miv1iUcbh4dhz7ei0r/ ZzLdiELEhuJRR+lbYqmvnjLj0DLT3g== X-Authority-Analysis: v=2.4 cv=dIerWeZb c=1 sm=1 tr=0 ts=6931cb21 cx=c_pps a=AfN7/Ok6k8XGzOShvHwTGQ==:117 a=AfN7/Ok6k8XGzOShvHwTGQ==:17 a=wP3pNCr1ah4A:10 a=VkNPw1HP01LnGYTKEx00:22 a=VnNF1IyMAAAA:8 a=JESwPpsbOM5vm_rGWyIA:9 X-Proofpoint-ORIG-GUID: 8uU_t1RZRCpbzH0RSd3zI_3XEKNDkQ3R X-Proofpoint-GUID: g6N-ECgPD2VXnbLJPqWWFyz2k-qRoxJ7 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-04_04,2025-12-04_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 lowpriorityscore=0 clxscore=1015 spamscore=0 malwarescore=0 suspectscore=0 adultscore=0 bulkscore=0 impostorscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2510240000 definitions=main-2511290000 Content-Type: text/plain; charset="utf-8" Scheduler is suppose to set balance_callback to push tasks out of a dying CPU. However the current code, unilaterally sets the balance_cpu and then checks if the CPU is indeed dying. Remove this anomaly by setting balance_callback only after checking if the CPU is about to die. Signed-off-by: Srikar Dronamraju --- kernel/sched/core.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/kernel/sched/core.c b/kernel/sched/core.c index f754a60de848..89efff1e1ead 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -8173,11 +8173,6 @@ static void balance_push(struct rq *rq) =20 lockdep_assert_rq_held(rq); =20 - /* - * Ensure the thing is persistent until balance_push_set(.on =3D false); - */ - rq->balance_callback =3D &balance_push_callback; - /* * Only active while going offline and when invoked on the outgoing * CPU. @@ -8185,6 +8180,11 @@ static void balance_push(struct rq *rq) if (!cpu_dying(rq->cpu) || rq !=3D this_rq()) return; =20 + /* + * Ensure the thing is persistent until balance_push_set(.on =3D false); + */ + rq->balance_callback =3D &balance_push_callback; + /* * Both the cpu-hotplug and stop task are in this case and are * required to complete the hotplug process. --=20 2.43.7