From nobody Fri Dec 19 18:00:06 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7BE641D6BB for ; Thu, 4 Dec 2025 10:29:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764844151; cv=none; b=C06v3MHudAsVCNsNtW2mWQGKPdO3g/vMo8oDHXmgUKxeSF94sVxnRBbEE/qJ+6lGwuQSZ1fRfPo5CV/7iVysUEiE4LGpWu83ozhJ7G/MwpObMIPVhBWIhR4m3fJDH9XlmQbzDKtOQoruk/0R2UaGMOK5BC/l3Y/kPCcY9nTX6Ug= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764844151; c=relaxed/simple; bh=nBfm1dfOD97fqzYEFk9S6US8GrxwEUH38I9rnFIfWew=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=d3idt0dpt4Bm94qdaZQj1KKgk213mfJrJU89YI3DTkXFpcbHKTd5F3XK0c7A0V9g6GSwZsOabGbPY2MhpFuCiOOSFY4cufYc1n59J3Uv+byKEhyYlE5PHHZCo1IyoA7ob6iqsUBfNEiubedOa4bzNFQjOCuFOQJQn0er0GGzr50= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=hnXmuWgL; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="hnXmuWgL" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 04B90C4CEFB; Thu, 4 Dec 2025 10:29:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1764844151; bh=nBfm1dfOD97fqzYEFk9S6US8GrxwEUH38I9rnFIfWew=; h=From:To:Cc:Subject:Date:From; b=hnXmuWgLvLI96wwkQMf2nhQH/KyDNSfMqK8aydg0RnUBFZt4jsTrtTM8fr2LlrG7Q rv6uQ1TJDt1dX76FCOAq1mmhPvqwP1k2dfIk/tinVFV17VINhxasY4mH7emsTlQVZ+ Od8GQ2bHBNT8qxjyMn4NDnI11d17oLPt702zByRi/iCyhFcDpqme3Ot0BZGiDHzqD7 5XKxocPi3Ge/z6eyzEz76lYnKpWra6NCfd3VARUMwMFE5gxoEMwoimgffid72WUziG +RsCojDPd6c2UNyLXPn/U+BIB9kZJM9ny95urBvLssJaKV2uXI1M/dqTvWOBJBhCd6 8S5EEcE5yBKpA== From: Arnd Bergmann To: Hugh Dickins , Andrew Morton , Pratyush Yadav , "Mike Rapoport (Microsoft)" , Pasha Tatashin Cc: Arnd Bergmann , Baolin Wang , Kairui Song , David Hildenbrand , Christian Brauner , Lorenzo Stoakes , Kemeng Shi , Guo Weikang , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH] [v2] mm: shmem: avoid build warning for CONFIG_SHMEM=n Date: Thu, 4 Dec 2025 11:28:59 +0100 Message-Id: <20251204102905.1048000-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.5 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Arnd Bergmann The newly added 'flags' variable is unused and causes a warning if CONFIG_SHMEM is disabled, since the shmem_acct_size() macro it is passed into does nothing: mm/shmem.c: In function '__shmem_file_setup': mm/shmem.c:5816:23: error: unused variable 'flags' [-Werror=3Dunused-variab= le] 5816 | unsigned long flags =3D (vm_flags & VM_NORESERVE) ? SHMEM_F= _NORESERVE : 0; | ^~~~~ Replace the two macros with equivalent inline functions tto get the argument checking. Fixes: 6ff1610ced56 ("mm: shmem: use SHMEM_F_* flags instead of VM_* flags") Signed-off-by: Arnd Bergmann Acked-by: David Hildenbrand (Red Hat) Acked-by: Mike Rapoport (Microsoft) Reviewed-by: Baolin Wang Reviewed-by: Pasha Tatashin Reviewed-by: Pratyush Yadav --- v2: make shmem_unacct_size() inline as well. --- mm/shmem.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/mm/shmem.c b/mm/shmem.c index 3f194c9842a8..b329b5302c48 100644 --- a/mm/shmem.c +++ b/mm/shmem.c @@ -5794,8 +5794,15 @@ EXPORT_SYMBOL_GPL(shmem_truncate_range); #define shmem_vm_ops generic_file_vm_ops #define shmem_anon_vm_ops generic_file_vm_ops #define shmem_file_operations ramfs_file_operations -#define shmem_acct_size(flags, size) 0 -#define shmem_unacct_size(flags, size) do {} while (0) + +static inline int shmem_acct_size(unsigned long flags, loff_t size) +{ + return 0; +} + +static inline void shmem_unacct_size(unsigned long flags, loff_t size) +{ +} =20 static inline struct inode *shmem_get_inode(struct mnt_idmap *idmap, struct super_block *sb, struct inode *dir, --=20 2.39.5