From nobody Fri Dec 19 17:55:53 2025 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 358E1338587; Thu, 4 Dec 2025 10:14:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764843243; cv=none; b=MIfsyYLcCxvvOSKAGolM54/mSHOfVIRgNbKwyIx2Mk8Bu89985E9wOKDr52ROE5+YTQjwuWoKfms35Q/bzTVYeREaFOuyw9FhMSeMEhkjnPWKzyCmfcg1tP3SfEznBlyiWtHi0vxp6j2A3YK+7qVCwdJbWZd1CLRXjTx2UqFeig= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764843243; c=relaxed/simple; bh=SYfoyoKuJwgZNbxFEKHK/7ZHnCkMIlEup3jnVGaJJQo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jXuC94Hk8tNxUXJOlwTwTjOQF1/2bR1ypx0r4dQLXvoy7DrwSivgNBgn6xSY+WvKtkKggeN1160C8A8uT1OsXH1/Jrb8TolD1TNJWB0VNu5au/2NxKUgv+iOZHHIObuUY5psYUpYw31wrHRB24DBGURWBXOuDUlr5Nnduzavhy0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1EE8A1575; Thu, 4 Dec 2025 02:13:53 -0800 (PST) Received: from e135073.nice.arm.com (e135073.arm.com [10.34.125.22]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 826B13F73B; Thu, 4 Dec 2025 02:13:57 -0800 (PST) From: Pierre Gondois To: linux-kernel@vger.kernel.org Cc: Christian Loehle , Ionela Voinescu , zhenglifeng1@huawei.com, Jie Zhan , Pierre Gondois , Huang Rui , "Gautham R. Shenoy" , Mario Limonciello , Perry Yuan , "Rafael J. Wysocki" , Viresh Kumar , linux-pm@vger.kernel.org Subject: [PATCH v1 1/4] Revert "cpufreq: Fix re-boost issue after hotplugging a CPU" Date: Thu, 4 Dec 2025 11:13:37 +0100 Message-ID: <20251204101344.192678-2-pierre.gondois@arm.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251204101344.192678-1-pierre.gondois@arm.com> References: <20251204101344.192678-1-pierre.gondois@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" policy->max_freq_req represents the maximum allowed frequency as requested by the policyX/scaling_max_freq sysfs file. This request applies to all CPUs of the policy. It is not possible to request a per-CPU maximum frequency. Thus, the interaction between the policy boost and scaling_max_freq settings should be handled by adding a boost specific QoS constraint. This will be handled in the following patches. This reverts commit 1608f0230510489d74a2e24e47054233b7e4678a. Signed-off-by: Pierre Gondois --- drivers/cpufreq/cpufreq.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c index 852e024facc3c..11b29c7dbea9e 100644 --- a/drivers/cpufreq/cpufreq.c +++ b/drivers/cpufreq/cpufreq.c @@ -1478,10 +1478,6 @@ static int cpufreq_policy_online(struct cpufreq_poli= cy *policy, =20 blocking_notifier_call_chain(&cpufreq_policy_notifier_list, CPUFREQ_CREATE_POLICY, policy); - } else { - ret =3D freq_qos_update_request(policy->max_freq_req, policy->max); - if (ret < 0) - goto out_destroy_policy; } =20 if (cpufreq_driver->get && has_target()) { --=20 2.43.0 From nobody Fri Dec 19 17:55:53 2025 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id EAA26326D73; Thu, 4 Dec 2025 10:14:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764843247; cv=none; b=Tdezpj/SIFwTywL0cNWA1/ap3OPwou7jeZGcN+p4KPPy2RXNt2dKmgW7jkPWcthwYCHawNJKXnQykuEOE7wE2mWcqbx77ZQVs/N6EC9ZJd9KqFBD2NCOHvdkp3mrOeFiY2JaPIXDXFXkI13fFwplIgJrSJ5UbUzPZCp5Iz07R/E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764843247; c=relaxed/simple; bh=9XY4nMc+9Bb3G6FNU9WFpUEwhPv2wCvQ0zwByOnuiUY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=vAyZT+zvY+WMu5J+K7BSA+zCTWqv0GD/dCXTm1Dd79vwDfCQEKxRn3DT22TnPUop8uLjjcNV+HHifXkznBgDJSQ50GEXsN+0lFf2BVFy6/k7RIZEBZGyvgwyu6Qd8mFuA9d/HdR+KGuDkDipQogvApDZSsbgArJFl2R1JtMgGPc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C944F339; Thu, 4 Dec 2025 02:13:56 -0800 (PST) Received: from e135073.nice.arm.com (e135073.arm.com [10.34.125.22]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 67A793F73B; Thu, 4 Dec 2025 02:14:01 -0800 (PST) From: Pierre Gondois To: linux-kernel@vger.kernel.org Cc: Christian Loehle , Ionela Voinescu , zhenglifeng1@huawei.com, Jie Zhan , Pierre Gondois , Huang Rui , "Gautham R. Shenoy" , Mario Limonciello , Perry Yuan , "Rafael J. Wysocki" , Viresh Kumar , linux-pm@vger.kernel.org Subject: [PATCH v1 2/4] cpufreq: Add boost_freq_req QoS request Date: Thu, 4 Dec 2025 11:13:38 +0100 Message-ID: <20251204101344.192678-3-pierre.gondois@arm.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251204101344.192678-1-pierre.gondois@arm.com> References: <20251204101344.192678-1-pierre.gondois@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The Power Management Quality of Service (PM QoS) allows to aggregate constraints from multiple entities. It is currently used to manage the min/max frequency of a given policy. Frequency constraints can come for instance from: - Thermal framework: acpi_thermal_cpufreq_init() - Firmware: _PPC objects: acpi_processor_ppc_init() - User: by setting policyX/scaling_[min|max]_freq The minimum of the max frequency constraints is used to compute the resulting maximum allowed frequency. When enabling boost frequencies, the same frequency request object (policy->max_freq_req) as to handle requests from users is used. As a result, when setting: - scaling_max_freq - boost The last sysfs file used overwrites the request from the other sysfs file. To avoid this, create a per-policy boost_freq_req to save the boost constraints instead of overwriting the last scaling_max_freq constraint. Signed-off-by: Pierre Gondois --- drivers/cpufreq/cpufreq.c | 35 +++++++++++++++++++++++++++++++++++ include/linux/cpufreq.h | 1 + 2 files changed, 36 insertions(+) diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c index 11b29c7dbea9e..23f64346b80f8 100644 --- a/drivers/cpufreq/cpufreq.c +++ b/drivers/cpufreq/cpufreq.c @@ -1370,6 +1370,18 @@ static void cpufreq_policy_free(struct cpufreq_polic= y *policy) freq_qos_remove_request(policy->max_freq_req); } =20 + if (policy->boost_freq_req) { + /* + * Remove boost_freq_req after sending CPUFREQ_REMOVE_POLICY + * notification, since CPUFREQ_CREATE_POLICY notification was + * sent after adding boost_freq_req earlier. + */ + blocking_notifier_call_chain(&cpufreq_policy_notifier_list, + CPUFREQ_REMOVE_POLICY, policy); + freq_qos_remove_request(policy->boost_freq_req); + kfree(policy->boost_freq_req); + } + freq_qos_remove_request(policy->min_freq_req); kfree(policy->min_freq_req); =20 @@ -1476,6 +1488,29 @@ static int cpufreq_policy_online(struct cpufreq_poli= cy *policy, goto out_destroy_policy; } =20 + if (policy->boost_supported) { + policy->boost_freq_req =3D kzalloc(sizeof(*policy->boost_freq_req), + GFP_KERNEL); + if (!policy->boost_freq_req) { + ret =3D -ENOMEM; + goto out_destroy_policy; + } + + ret =3D freq_qos_add_request(&policy->constraints, + policy->boost_freq_req, + FREQ_QOS_MAX, + FREQ_QOS_MAX_DEFAULT_VALUE); + if (ret < 0) { + /* + * So we don't call freq_qos_remove_request() for an + * uninitialized request. + */ + kfree(policy->boost_freq_req); + policy->boost_freq_req =3D NULL; + goto out_destroy_policy; + } + } + blocking_notifier_call_chain(&cpufreq_policy_notifier_list, CPUFREQ_CREATE_POLICY, policy); } diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h index 0465d1e6f72ac..c292a6a19e4f5 100644 --- a/include/linux/cpufreq.h +++ b/include/linux/cpufreq.h @@ -81,6 +81,7 @@ struct cpufreq_policy { struct freq_constraints constraints; struct freq_qos_request *min_freq_req; struct freq_qos_request *max_freq_req; + struct freq_qos_request *boost_freq_req; =20 struct cpufreq_frequency_table *freq_table; enum cpufreq_table_sorting freq_table_sorted; --=20 2.43.0 From nobody Fri Dec 19 17:55:53 2025 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6FC86338F4D; Thu, 4 Dec 2025 10:14:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764843249; cv=none; b=S5P4MZ5nXQqRsjh3lCjgGcCHHCtNhwAgJNgY5uvsFytAZ/utRV/9+o5Y30pZWy7sxMWrK6YdbskDQfsaYTY/c008b8xVw8u9d/i6aOc4AckQNx8rPd5IJtjPS3sCtAbrlYCT9furimkWekfxA69GSo8NshR/3xzHNqAlVLWmiIQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764843249; c=relaxed/simple; bh=jJ+J4azMi46GNdDcZBbnfKfZeONx47CY4QJVdrsGGu8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UlQuzFENMSg6eAiAKkGZanISjdrxhxq5muYH7a7oriL4rZS+rFsIMaWX+GFXD/I77lMhZ6mihWsveNEAcDjO0LGkDbGe0sCrMOZzgBjPv6xz7cHHxSu6MdiTWKYcAEgtFYPTiq6LrAF/Ztx1SP+KamaRa1oq7YMRgBmjl8H2srA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 860B61575; Thu, 4 Dec 2025 02:14:00 -0800 (PST) Received: from e135073.nice.arm.com (e135073.arm.com [10.34.125.22]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 025A33F73B; Thu, 4 Dec 2025 02:14:04 -0800 (PST) From: Pierre Gondois To: linux-kernel@vger.kernel.org Cc: Christian Loehle , Ionela Voinescu , zhenglifeng1@huawei.com, Jie Zhan , Pierre Gondois , Huang Rui , "Gautham R. Shenoy" , Mario Limonciello , Perry Yuan , "Rafael J. Wysocki" , Viresh Kumar , linux-pm@vger.kernel.org Subject: [PATCH v1 3/4] cpufreq: Centralize boost freq QoS requests Date: Thu, 4 Dec 2025 11:13:39 +0100 Message-ID: <20251204101344.192678-4-pierre.gondois@arm.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251204101344.192678-1-pierre.gondois@arm.com> References: <20251204101344.192678-1-pierre.gondois@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" policy_set_boost() calls the cpufreq set_boost callback. Update the newly added boost_freq_req request from there: - whenever boost is toggled - to cover all possible paths Signed-off-by: Pierre Gondois --- drivers/cpufreq/cpufreq.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c index 23f64346b80f8..9d98b98e7981c 100644 --- a/drivers/cpufreq/cpufreq.c +++ b/drivers/cpufreq/cpufreq.c @@ -603,10 +603,16 @@ static int policy_set_boost(struct cpufreq_policy *po= licy, bool enable) policy->boost_enabled =3D enable; =20 ret =3D cpufreq_driver->set_boost(policy, enable); - if (ret) + if (ret) { policy->boost_enabled =3D !policy->boost_enabled; + return ret; + } =20 - return ret; + ret =3D freq_qos_update_request(policy->boost_freq_req, policy->cpuinfo.m= ax_freq); + if (ret < 0) + return ret; + + return 0; } =20 static ssize_t store_local_boost(struct cpufreq_policy *policy, --=20 2.43.0 From nobody Fri Dec 19 17:55:53 2025 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 20AFE3358C6; Thu, 4 Dec 2025 10:14:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764843254; cv=none; b=bGg92IL8hgQAtT66s8ftIlQVN4o47f5pB29npkxTKR1VPXUMCc0GywYb3ZcRUyo/VSuUyItlDQShqFV9NsS0lTS3rg9iL292NPzpIeAXDrxlYw/0yKR9BppPmwU6ScMyC/J+IAV3s/njAQumPt9o+/4GrdlY9mmHcbFI5j82Oaw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764843254; c=relaxed/simple; bh=7p3Q3R/TN0IjnjA1YQqyM+/v+u0kbdHf83OddMbsRo8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=is9CFXkeHF7SURHD48UfmtpGyNxDz7af9WgdTqOd+BpItEmWWHdvtUNyHfqFb3fsA97DyxpwPBBzU9SZGlShIsXkDmmTCottKBYNlffkBJ6YRO+1VtnxtuyUb9YM/6jnoSKBL1qYftnfABBjOF9bn9ABmWyIkY554yCdnnpTxmM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2D91E339; Thu, 4 Dec 2025 02:14:04 -0800 (PST) Received: from e135073.nice.arm.com (e135073.arm.com [10.34.125.22]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id DB88B3F73B; Thu, 4 Dec 2025 02:14:08 -0800 (PST) From: Pierre Gondois To: linux-kernel@vger.kernel.org Cc: Christian Loehle , Ionela Voinescu , zhenglifeng1@huawei.com, Jie Zhan , Pierre Gondois , Huang Rui , "Gautham R. Shenoy" , Mario Limonciello , Perry Yuan , "Rafael J. Wysocki" , Viresh Kumar , linux-pm@vger.kernel.org Subject: [PATCH v1 4/4] cpufreq: Update set_boost callbacks to rely on boost_freq_req Date: Thu, 4 Dec 2025 11:13:40 +0100 Message-ID: <20251204101344.192678-5-pierre.gondois@arm.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251204101344.192678-1-pierre.gondois@arm.com> References: <20251204101344.192678-1-pierre.gondois@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In the existing set_boost() callbacks: - Don't update policy->max as this is done through the qos notifier cpufreq_notifier_max() which calls cpufreq_set_policy(). - Remove freq_qos_update_request() calls as the qos request is now done in policy_set_boost() and updates the new boost_freq_req Signed-off-by: Pierre Gondois --- drivers/cpufreq/amd-pstate.c | 2 -- drivers/cpufreq/cppc_cpufreq.c | 20 ++++---------------- drivers/cpufreq/cpufreq.c | 10 ++-------- 3 files changed, 6 insertions(+), 26 deletions(-) diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index b44f0f7a5ba1c..50416358a96ac 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -754,8 +754,6 @@ static int amd_pstate_cpu_boost_update(struct cpufreq_p= olicy *policy, bool on) else if (policy->cpuinfo.max_freq > nominal_freq) policy->cpuinfo.max_freq =3D nominal_freq; =20 - policy->max =3D policy->cpuinfo.max_freq; - if (cppc_state =3D=3D AMD_PSTATE_PASSIVE) { ret =3D freq_qos_update_request(&cpudata->req[1], policy->cpuinfo.max_fr= eq); if (ret < 0) diff --git a/drivers/cpufreq/cppc_cpufreq.c b/drivers/cpufreq/cppc_cpufreq.c index e23d9abea1359..a2f64099d39a4 100644 --- a/drivers/cpufreq/cppc_cpufreq.c +++ b/drivers/cpufreq/cppc_cpufreq.c @@ -597,21 +597,14 @@ static int cppc_cpufreq_cpu_init(struct cpufreq_polic= y *policy) caps =3D &cpu_data->perf_caps; policy->driver_data =3D cpu_data; =20 - /* - * Set min to lowest nonlinear perf to avoid any efficiency penalty (see - * Section 8.4.7.1.1.5 of ACPI 6.1 spec) - */ - policy->min =3D cppc_perf_to_khz(caps, caps->lowest_nonlinear_perf); - policy->max =3D cppc_perf_to_khz(caps, policy->boost_enabled ? - caps->highest_perf : caps->nominal_perf); - /* * Set cpuinfo.min_freq to Lowest to make the full range of performance * available if userspace wants to use any perf between lowest & lowest * nonlinear perf */ policy->cpuinfo.min_freq =3D cppc_perf_to_khz(caps, caps->lowest_perf); - policy->cpuinfo.max_freq =3D policy->max; + policy->cpuinfo.max_freq =3D cppc_perf_to_khz(caps, policy->boost_enabled= ? + caps->highest_perf : caps->nominal_perf); =20 policy->transition_delay_us =3D cppc_cpufreq_get_transition_delay_us(cpu); policy->shared_type =3D cpu_data->shared_type; @@ -779,14 +772,9 @@ static int cppc_cpufreq_set_boost(struct cpufreq_polic= y *policy, int state) int ret; =20 if (state) - policy->max =3D cppc_perf_to_khz(caps, caps->highest_perf); + policy->cpuinfo.max_freq =3D cppc_perf_to_khz(caps, caps->highest_perf); else - policy->max =3D cppc_perf_to_khz(caps, caps->nominal_perf); - policy->cpuinfo.max_freq =3D policy->max; - - ret =3D freq_qos_update_request(policy->max_freq_req, policy->max); - if (ret < 0) - return ret; + policy->cpuinfo.max_freq =3D cppc_perf_to_khz(caps, caps->nominal_perf); =20 return 0; } diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c index 9d98b98e7981c..c360af436f1ea 100644 --- a/drivers/cpufreq/cpufreq.c +++ b/drivers/cpufreq/cpufreq.c @@ -2820,16 +2820,10 @@ int cpufreq_boost_set_sw(struct cpufreq_policy *pol= icy, int state) return -ENXIO; =20 ret =3D cpufreq_frequency_table_cpuinfo(policy); - if (ret) { + if (ret) pr_err("%s: Policy frequency update failed\n", __func__); - return ret; - } =20 - ret =3D freq_qos_update_request(policy->max_freq_req, policy->max); - if (ret < 0) - return ret; - - return 0; + return ret; } EXPORT_SYMBOL_GPL(cpufreq_boost_set_sw); =20 --=20 2.43.0