From nobody Fri Dec 19 18:53:20 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 862872BE62D for ; Thu, 4 Dec 2025 09:45:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764841556; cv=none; b=d7eyTYkZyLlO1aK4NdpxsxEXGiOuAMNCkmaj81CbXcrZLBqHmJkK2FZKidMxmcHU+wUwp8106va4/030loXchJtfOopWpDMfN0o3BAfUygYvLUDoYBNufKCIgP8xFVLL4SxlGYlYk893r6m/pVFcUa9+v5Ujp1EgclZPjAonCJg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764841556; c=relaxed/simple; bh=2f3vgAhcU3dgW9En/Hjs2lUOgZWqrjrBicUJtS55NvI=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=DwTim3sgbzGiAPcVVww079ZGfCLrVvrtDmwKRu2GdQWuinNs60FEOMgaki/MncQsG7tj1oiSNprci+WbsRsTrwbCxgQk1nzmfKJHZkceI7f4mYtMgOtGgBydq+C98JJp3cTCzUhf5TOIc12IAgsX6NgJ1Zuw2CFWQ9/akUjKqqM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=tGyaleQ1; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="tGyaleQ1" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3A3C2C4CEFB; Thu, 4 Dec 2025 09:45:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1764841556; bh=2f3vgAhcU3dgW9En/Hjs2lUOgZWqrjrBicUJtS55NvI=; h=From:To:Cc:Subject:Date:From; b=tGyaleQ1z+W32h+gSZ/UcAo57LuIs+x3OOJPqsxwLTw4mgmH1ZnwKvuoe1w8ySka5 bbldJvo65I0skfP2CUy77F4IYrl37KyIZzkwpKDtv2CfuivsTRI8VbJwNcoAslM1fy JE/jqbWTdO3MpO/zcr6N56irb3RzgYR2/pO154pWOnclr6nh2Hz/nQZtv5gvLY+1pK 1QT6m3VH/8FoicLFeyZbSK64EH/Yc+N1Gvqv9BTjepDTatBkiwpVvlkU1ZaJu4zNS3 2fkh6ks3CFKKdYdTt19o9lVHDcqzy4l3/nM+J94eOGACtKpZBabobQ1OLtP9cR/QTg uI9g/S3UvOVCw== From: Arnd Bergmann To: Linus Walleij , Neil Armstrong , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Douglas Anderson , Brigham Campbell Cc: Arnd Bergmann , Jessica Zhang , Anusha Srivatsa , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm/panel: novatek-nt35560: avoid on-stack device structure Date: Thu, 4 Dec 2025 10:45:45 +0100 Message-Id: <20251204094550.1030506-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.5 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Arnd Bergmann A cleanup patch apparently by accident used a local device structure instead of a pointer to one in the nt35560_read_id() function, causing a warning about stack usage: drivers/gpu/drm/panel/panel-novatek-nt35560.c: In function 'nt35560_read_id= ': drivers/gpu/drm/panel/panel-novatek-nt35560.c:249:1: error: the frame size = of 1296 bytes is larger than 1280 bytes [-Werror=3Dframe-larger-than=3D] Change this to a pointer as was liley intended here. Fixes: 5fbc0dbb92d6 ("drm/panel: novatek-nt35560: Clean up driver") Signed-off-by: Arnd Bergmann Reviewed-by: Douglas Anderson --- drivers/gpu/drm/panel/panel-novatek-nt35560.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-novatek-nt35560.c b/drivers/gpu/dr= m/panel/panel-novatek-nt35560.c index 561e6643dcbb..6e5173f98a22 100644 --- a/drivers/gpu/drm/panel/panel-novatek-nt35560.c +++ b/drivers/gpu/drm/panel/panel-novatek-nt35560.c @@ -213,7 +213,7 @@ static const struct backlight_properties nt35560_bl_pro= ps =3D { =20 static void nt35560_read_id(struct mipi_dsi_multi_context *dsi_ctx) { - struct device dev =3D dsi_ctx->dsi->dev; + struct device *dev =3D &dsi_ctx->dsi->dev; u8 vendor, version, panel; u16 val; =20 @@ -225,7 +225,7 @@ static void nt35560_read_id(struct mipi_dsi_multi_conte= xt *dsi_ctx) return; =20 if (vendor =3D=3D 0x00) { - dev_err(&dev, "device vendor ID is zero\n"); + dev_err(dev, "device vendor ID is zero\n"); dsi_ctx->accum_err =3D -ENODEV; return; } @@ -236,12 +236,12 @@ static void nt35560_read_id(struct mipi_dsi_multi_con= text *dsi_ctx) case DISPLAY_SONY_ACX424AKP_ID2: case DISPLAY_SONY_ACX424AKP_ID3: case DISPLAY_SONY_ACX424AKP_ID4: - dev_info(&dev, + dev_info(dev, "MTP vendor: %02x, version: %02x, panel: %02x\n", vendor, version, panel); break; default: - dev_info(&dev, + dev_info(dev, "unknown vendor: %02x, version: %02x, panel: %02x\n", vendor, version, panel); break; --=20 2.39.5