From nobody Fri Dec 19 18:41:47 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9036E1A9FAF for ; Thu, 4 Dec 2025 09:44:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764841490; cv=none; b=iJuYGvXVXo1sbJJULQjrfXK44TXHL8NUehT+Lfj2lcPrQEgJKcvzguTkfXprQgd2YgFeyKg2GYYIP78hTeBFRmOgcCFk2S8HFVDWRz7bOMOCf06ZUWxzKRCjP3kuycPSGvDLm8bO1n+Y7qW/RNjkdipWC5fInzxrYT/6m7VQCUU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764841490; c=relaxed/simple; bh=jlmiccTMN/1Oqk4mzHOf5koXbzDGcyAl4fechJYospA=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=azOQ/8jVOmmkhW/uH0A6J5iv1at1bBZukkK+W54y/rWGbI/hftPyhgP9A6sKf4Zy49ucXmrhc6fqUKM2EO9E7Vpg39NWSj4qF+CMN+lXUxquRm+EXPv8ZH3wiunWmVu+Otrr1xQMjDHhRyI1uidl30dLCrfgkChw2/2eSxaYk2M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=dcHgjceE; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="dcHgjceE" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1C3DDC116C6; Thu, 4 Dec 2025 09:44:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1764841490; bh=jlmiccTMN/1Oqk4mzHOf5koXbzDGcyAl4fechJYospA=; h=From:To:Cc:Subject:Date:From; b=dcHgjceE/S19b53sOprVYiTrlqI/08Mr6v7CS1nGxHSNxHrep2exo1uQTYKX7KGHW dowxAtgAVci5tsKjhNLZYk0pN00xbr1bmkM9htxqLXRHNlOzI0GVliDk88GUOTRtlF 0X0ZAJNnFSwRY2XxY0PgIdELvibm1oh9yAfC8de845ZNxsHgv8wjKoI8E245tuDMU3 P6UMFqzlGEydIFy8eUQOvE9MPBTF+1YWuYexKqq2JiOz3oxBndm7d4/ctV5s49ko+z R7/+wGlD8uOWfxDImL9/CXHbOEVHSehnd0/QhGsTzm7a38DHI5uxsgEgwpZIwoJx3K Q6sy5TVSZ5L4w== From: Arnd Bergmann To: Hugh Dickins , Andrew Morton , "Mike Rapoport (Microsoft)" , Pasha Tatashin , Pratyush Yadav Cc: Arnd Bergmann , Baolin Wang , Kairui Song , David Hildenbrand , Christian Brauner , Kemeng Shi , Lorenzo Stoakes , Guo Weikang , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH] mm: shmem: avoid build warning for CONFIG_SHMEM=n Date: Thu, 4 Dec 2025 10:44:40 +0100 Message-Id: <20251204094444.1030143-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.5 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Arnd Bergmann The newly added 'flags' variable is unused and causes a warning if CONFIG_SHMEM is disabled, since the shmem_acct_size() macro it is passed into does nothing: mm/shmem.c: In function '__shmem_file_setup': mm/shmem.c:5816:23: error: unused variable 'flags' [-Werror=3Dunused-variab= le] 5816 | unsigned long flags =3D (vm_flags & VM_NORESERVE) ? SHMEM_F= _NORESERVE : 0; | ^~~~~ Replace the macro with an equivalent inline function to get the argument checking. Fixes: 6ff1610ced56 ("mm: shmem: use SHMEM_F_* flags instead of VM_* flags") Signed-off-by: Arnd Bergmann Reviewed-by: Pasha Tatashin --- mm/shmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/shmem.c b/mm/shmem.c index 3f194c9842a8..93746270c459 100644 --- a/mm/shmem.c +++ b/mm/shmem.c @@ -5794,7 +5794,7 @@ EXPORT_SYMBOL_GPL(shmem_truncate_range); #define shmem_vm_ops generic_file_vm_ops #define shmem_anon_vm_ops generic_file_vm_ops #define shmem_file_operations ramfs_file_operations -#define shmem_acct_size(flags, size) 0 +static inline int shmem_acct_size(unsigned long flags, loff_t size) { retu= rn 0; } #define shmem_unacct_size(flags, size) do {} while (0) =20 static inline struct inode *shmem_get_inode(struct mnt_idmap *idmap, --=20 2.39.5