From nobody Fri Dec 19 18:41:49 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F268A1A9FAF for ; Thu, 4 Dec 2025 09:44:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764841449; cv=none; b=CntGCb81y/2a/mq8D+cTxFMtR3LwoT5l+KBl+COFuzC1etjbw3JLgUms+XJ0X5xMcSXNklKpgWwNSzJOpERF2gMXkD/E9gNjRku9h5x9KPVsBvABLbLMtEFcp71+xo02bz8f7JiJMci5Wp1W6+A0WlxLoC+wTXD0Zg2B7JYv+fs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764841449; c=relaxed/simple; bh=zJYjkLwhKv4+fsVtmZeb/zzmVmKPn4lEwq6nm9Ahoxw=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=obApUM+THPqvE5kHY1Zbb3IManF9mWtlbo+8WKj/VEAzKNXIboK+0CUKVSPyRwdAkBFUTs9MuPCfsFQX0L+0Eussl6tn23mCwLf8XL9WAp6QGtF3NVsDmM2GdB1OH8I3luLQny6i+CtOxhTOECYYm1c3LklVDbgGri3nnXq/NYA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=TGkivWV2; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="TGkivWV2" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 63216C4CEFB; Thu, 4 Dec 2025 09:44:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1764841448; bh=zJYjkLwhKv4+fsVtmZeb/zzmVmKPn4lEwq6nm9Ahoxw=; h=From:To:Cc:Subject:Date:From; b=TGkivWV2vcASpTl6aBgXz7aIjmR9n6D6UN6qnFoWYFZ1RGKpnRVn+MDsaxvYbJ2hS PguutkyxDe6JeJj1VnOzysDUt/B7WzYLDAWIKhg4cJ0nlDbvEPiUfXrPlDLMvWaDFG mg/yJDHHPp0HNa6KQmDFze1c7eTnlcz3h/0QvUq4gZRnL/kpz75KZZvKn2TEMCQP2U 6+G+c4xNaxPAeDerpnC6SliK6tbKdxZ3uK5wBTgNd4hTUD5HHFd9E61DRIaD0oXXsV 6h8DzqRyHe6h0EH6WTu/uPnt1367WnXYnnWEB0/w8N4rLgiwP9Se2eDG/cO6Y/GuBr fY3ZnXiFS4qZg== From: Arnd Bergmann To: Jani Nikula , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , David Airlie , Simona Vetter , Mika Kahola Cc: Arnd Bergmann , =?UTF-8?q?Ville=20Syrj=C3=A4l=C3=A4?= , Ankit Nautiyal , Suraj Kandpal , =?UTF-8?q?Jouni=20H=C3=B6gander?= , intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm/i915/display: Avoid nonliteral printf format string Date: Thu, 4 Dec 2025 10:43:51 +0100 Message-Id: <20251204094401.1029917-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.5 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Arnd Bergmann pipe_config_mismatch() takes a printf-style format string and arguments, not a constant string, so this trigers -Wformat warnings when they are not disabled: drivers/gpu/drm/i915/display/intel_display.c: In function 'pipe_config_cx0p= ll_mismatch': drivers/gpu/drm/i915/display/intel_display.c:4997:9: error: format not a st= ring literal and no format arguments [-Werror=3Dformat-security] 4997 | pipe_config_mismatch(p, fastset, crtc, name, chipname); | ^~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/i915/display/intel_display.c: In function 'pipe_config_lt_p= hy_pll_mismatch': drivers/gpu/drm/i915/display/intel_display.c:5027:9: error: format not a st= ring literal and no format arguments [-Werror=3Dformat-security] 5027 | pipe_config_mismatch(p, fastset, crtc, name, chipname); | ^~~~~~~~~~~~~~~~~~~~ Use either the string literal or the trivial "%s" format so the compiler can prove this to be used correctly. Fixes: 45fe957ae769 ("drm/i915/display: Add compare config for MTL+ platfor= ms") Signed-off-by: Arnd Bergmann --- drivers/gpu/drm/i915/display/intel_display.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm= /i915/display/intel_display.c index 7b4fd18c60e2..83025d5a4aa9 100644 --- a/drivers/gpu/drm/i915/display/intel_display.c +++ b/drivers/gpu/drm/i915/display/intel_display.c @@ -4987,7 +4987,7 @@ pipe_config_cx0pll_mismatch(struct drm_printer *p, bo= ol fastset, struct intel_display *display =3D to_intel_display(crtc); char *chipname =3D a->use_c10 ? "C10" : "C20"; =20 - pipe_config_mismatch(p, fastset, crtc, name, chipname); + pipe_config_mismatch(p, fastset, crtc, name, "%s", chipname); =20 drm_printf(p, "expected:\n"); intel_cx0pll_dump_hw_state(display, a); @@ -5022,9 +5022,8 @@ pipe_config_lt_phy_pll_mismatch(struct drm_printer *p= , bool fastset, const struct intel_lt_phy_pll_state *b) { struct intel_display *display =3D to_intel_display(crtc); - char *chipname =3D "LTPHY"; =20 - pipe_config_mismatch(p, fastset, crtc, name, chipname); + pipe_config_mismatch(p, fastset, crtc, name, "LTPHY"); =20 drm_printf(p, "expected:\n"); intel_lt_phy_dump_hw_state(display, a); --=20 2.39.5