From nobody Fri Dec 19 18:53:20 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D69353074AA for ; Thu, 4 Dec 2025 09:42:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764841321; cv=none; b=OQBw9r8JKoAFKBGAcjf/nhTnbPjamSalHYxTqtMRtPdneGcN+WDhVkeXCD4U7i+Yay/7+jtE9vABI6gQGRY/DmnOoECKLqTp0Tiw4GI+31yVDQ5t2DPEC4vSAqvWoevLzwFa2PqxxPHDMyjFqn/uT0JNDG2sNcn5w4fu3ROARHU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764841321; c=relaxed/simple; bh=kD+qJAqVxFMhhe2jPl9GIafOGfGtCPN4iVsdl++V/HY=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=WCUUcGfHD7u60IPyMim9rgkN9al4+B87DJwy0zfuDYvGavTRSRY0OqUjbDIRYfwvXbIO4WMiTvQNFEOVDFPFDn/JUheAmvgyRMBdLcGO89mdtz+/sqMSnHDrV4TatET/Ue9cG/jjCHU871c2ze5lPwCe2nQTon2E/Z7aj/C9N4Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=giklFLO4; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="giklFLO4" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 72E91C113D0; Thu, 4 Dec 2025 09:41:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1764841320; bh=kD+qJAqVxFMhhe2jPl9GIafOGfGtCPN4iVsdl++V/HY=; h=From:To:Cc:Subject:Date:From; b=giklFLO4ISSaFeZIx89BIbiPz18a7qKOiaSW+RYLdgFIk6Y/BtMm6WBqGmgh2t4Km 6/b+Or1bMPWvagS72zeN/ydWN4FLq7SqZddkbOb/PH8oXdnSNLY8TK+8DQLi9Qz6Z6 wQkVIrPR31r3pM10NMLYDH8eNDUMLvmEACEsLO7uK9deh/5bl9OyNMLE3KqSs8f3Oa aawLySIb7CbddEBQS/NFEvnFuvKKufVsJ+I/FQ5l0nNKBpfwighCVRyaclA/5ZmybK jcmewIxgxMtfOoGZ7VcI53dH6L19m0Qwor2LkZDnaSnFxGycYGdUdFmwfTFkvTuCe6 rKbRnwVed68uQ== From: Arnd Bergmann To: =?UTF-8?q?Thomas=20Hellstr=C3=B6m?= , Rodrigo Vivi , David Airlie , Simona Vetter , =?UTF-8?q?Micha=C5=82=20Winiarski?= , Michal Wajdeczko Cc: Arnd Bergmann , Matthew Brost , Lucas De Marchi , Jani Nikula , Riana Tauro , intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm/xe/pf: fix VFIO link error Date: Thu, 4 Dec 2025 10:41:36 +0100 Message-Id: <20251204094154.1029357-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.5 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Arnd Bergmann The Makefile logic for building xe_sriov_vfio.o was added incorrectly, as setting CONFIG_XE_VFIO_PCI=3Dm means it doesn't get included into a built-in xe driver: ERROR: modpost: "xe_sriov_vfio_stop_copy_enter" [drivers/vfio/pci/xe/xe-vfi= o-pci.ko] undefined! ERROR: modpost: "xe_sriov_vfio_stop_copy_exit" [drivers/vfio/pci/xe/xe-vfio= -pci.ko] undefined! ERROR: modpost: "xe_sriov_vfio_suspend_device" [drivers/vfio/pci/xe/xe-vfio= -pci.ko] undefined! ERROR: modpost: "xe_sriov_vfio_wait_flr_done" [drivers/vfio/pci/xe/xe-vfio-= pci.ko] undefined! ERROR: modpost: "xe_sriov_vfio_error" [drivers/vfio/pci/xe/xe-vfio-pci.ko] = undefined! ERROR: modpost: "xe_sriov_vfio_resume_data_enter" [drivers/vfio/pci/xe/xe-v= fio-pci.ko] undefined! ERROR: modpost: "xe_sriov_vfio_resume_device" [drivers/vfio/pci/xe/xe-vfio-= pci.ko] undefined! ERROR: modpost: "xe_sriov_vfio_resume_data_exit" [drivers/vfio/pci/xe/xe-vf= io-pci.ko] undefined! ERROR: modpost: "xe_sriov_vfio_data_write" [drivers/vfio/pci/xe/xe-vfio-pci= .ko] undefined! ERROR: modpost: "xe_sriov_vfio_migration_supported" [drivers/vfio/pci/xe/xe= -vfio-pci.ko] undefined! WARNING: modpost: suppressed 3 unresolved symbol warnings because there wer= e too many) Check for CONFIG_XE_VFIO_PCI being enabled in the Makefile to decide whethe= r to include the the object instead. Fixes: 17f22465c5a5 ("drm/xe/pf: Export helpers for VFIO") Signed-off-by: Arnd Bergmann Reviewed-by: Michal Wajdeczko --- drivers/gpu/drm/xe/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/xe/Makefile b/drivers/gpu/drm/xe/Makefile index dfc2ded01455..e5f3c2ec9e9a 100644 --- a/drivers/gpu/drm/xe/Makefile +++ b/drivers/gpu/drm/xe/Makefile @@ -185,8 +185,8 @@ xe-$(CONFIG_PCI_IOV) +=3D \ xe_sriov_pf_sysfs.o \ xe_tile_sriov_pf_debugfs.o =20 -ifeq ($(CONFIG_PCI_IOV),y) - xe-$(CONFIG_XE_VFIO_PCI) +=3D xe_sriov_vfio.o +ifdef CONFIG_XE_VFIO_PCI + xe-$(CONFIG_PCI_IOV) +=3D xe_sriov_vfio.o endif =20 # include helpers for tests even when XE is built-in --=20 2.39.5