From nobody Fri Dec 19 19:01:28 2025 Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF739301471 for ; Thu, 4 Dec 2025 06:14:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764828891; cv=none; b=eUpeV4+vfzGlm56f9J3xotIY3flHOxGSa7U2wN6pSoKM7Z+vSzjohyjObUoG4gX+x9H7F7ZzUwo5/hKEzvPczZM3J01wIRG4tBUJO21VT1OId5JDBaFnuiyZNm7RGFNZvI2rJC1l/i+JwBPdr59SGWdob24Vl1vSHcJ71CXnzQs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764828891; c=relaxed/simple; bh=veQ9/3VO6iMznCoUt98pm7IfBkLnXS6jvf70DOTw9Hs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HuEobZZ3bCI6HP+piSMuysrf2+N0ZUHIPejogCkJ4+7hakFU8EydRDm1z4O56rAMcPjljx2j8eTy+4UvGCB9HWpc2HmtBnVKAoWIl1IscZDlx8LOo1rmMv3EumfETo1QeXQKeqavtNiOhaVKYoGSMxWUlahX1iD8JULp5WzgQ+8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lD5X8RWD; arc=none smtp.client-ip=209.85.218.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lD5X8RWD" Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-b73545723ebso84275966b.1 for ; Wed, 03 Dec 2025 22:14:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764828887; x=1765433687; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DQrz/QPYOHYsP4Cfl9B2GTYZm08Xl/E70LbUu7rauuk=; b=lD5X8RWDjMLxgchl4kUIWHME6SI94Js9BsllvPIRwzIaxmosq8zE6FdeiElvx2j0el TuLREHuEJfF6zon9oP3sOdbzLXAzzHNqIeuXfYLKkGxW+F+FZNGNARv/MQ4K4bYXi8Mh mHSX1mxxDDpI5/8m3wguOUsGM9/zfO3ec3d9x1zayrjfjYwm4LiPj3M7YzZSeYTLtwsx 0fzUDzHyvbnmijoL2Gf6qPgxol+8vJp5XpjRjUGD7/vweN0h76/9T7CLAcr1ufdN3Z7j sM8BYcv4rmyM0nTlPv0q4G6jAprcWiWVKfq20yWYwOHhYTtFDI5wn1W68x+yfZpTT6lm imDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764828887; x=1765433687; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=DQrz/QPYOHYsP4Cfl9B2GTYZm08Xl/E70LbUu7rauuk=; b=eOytrJdTBG/YMvZ55woPH/sWaaKJRgtFcB2eMRTDKET2g5zjAOpua33mLkn6Uayfs/ fk053XZ/zQJ3f0HdZDESzTm/1YmtpLiKXkq48QtKcQqSo8BEAdyC1MLDS6IgU4vAmOJ2 wTcTlyAr1ekyxC0uSCx538tQzfGi/bpXPbmY09NZS4tvo5EsU++aIA4qg6ZoSb0LL3uR x2IH6Zd3P6RtiFfMTVWyISj7Z9SOp6Cgo3zeugQhm0E0m8fjRSNrtsS5OndUD0vlGteB Yn3/KPBiYvRGlucs+eIQ0g0dTz7T7UzL/11MkOCFEza06u9cRPVWjKwCg588GsQE0r68 Wbww== X-Forwarded-Encrypted: i=1; AJvYcCVphS9g4LDDPaWel4T9jpV/HWz4RkMhv0CQYRKdXa/37CbZLMkeFhsZUgyM0i1qf7uq+b+2+bX+ug8UPwA=@vger.kernel.org X-Gm-Message-State: AOJu0YwWr//R40gcQEUyjKXVePgYjDaedfevbQ37HGCLfocEnaqQAytG WC6wpioKWa1MQFy3WkryVxx/DWN0UFYl9sRq4zXTl9WvnOKcqhQ1z2Gk X-Gm-Gg: ASbGncsgNIthmJskYTmSkgbTzLUxBSYtpa37BMS6NPZ/U+3w/vPVTgnMF+AZa3f8EZx kVxBc/7ZZlNzLNTIutg21WePJ7R3A43FSX6fxBuXF7rgEotOfKpFHLuGgovTVseIK4QDNh8Flv3 7X4180X7W1HbRN3Snx1xEKMfEwI/nCBp1vpIRc62BjW7GzwoJhYkSyG/51wX9zzdcOY1S6hU+1r o2IJbRVFv4Yktm/8hbN6E2+6FYqp5KpwiAxG/SMiNb4xnBy6ejqxdP8yWOuZUN8CAWnJc99UnZQ S1VR90f44uXCLBrrg+iJYfRGdie6/9xqGsnGk+SKN9+nSLHZw+77q8vDfLJdEM4cs3gBuV5yBvy LMPicLdrVIgIAoXbdXxcR9qq32eEsPwSpgzWOQnaMdNMHO85+x6TR2dvHPYba7ZP3OKUrKDaGHX 0= X-Google-Smtp-Source: AGHT+IH9Td1weLVNisf4to9lzLCPe3cNWf9eIXubukdh2R/fUUXMkNiI22zD2RgZqeyDpQfBYih7ig== X-Received: by 2002:a17:907:7f92:b0:b77:1b03:66a1 with SMTP id a640c23a62f3a-b79dc758d94mr555102666b.41.1764828886847; Wed, 03 Dec 2025 22:14:46 -0800 (PST) Received: from xeon ([188.163.112.74]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b79f445968asm50607866b.3.2025.12.03.22.14.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Dec 2025 22:14:46 -0800 (PST) From: Svyatoslav Ryhel To: Thierry Reding , Thierry Reding , Mikko Perttunen , David Airlie , Simona Vetter , Jonathan Hunter , Svyatoslav Ryhel Cc: dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v1 1/2 RESEND] gpu/drm: tegra: dsi: make SOL delay calculation mode independent Date: Thu, 4 Dec 2025 08:14:35 +0200 Message-ID: <20251204061436.5401-2-clamor95@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251204061436.5401-1-clamor95@gmail.com> References: <20251204061436.5401-1-clamor95@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Move SOL delay calculation outside of video mode conditions. Signed-off-by: Svyatoslav Ryhel --- drivers/gpu/drm/tegra/dsi.c | 41 +++++++++++++++---------------------- 1 file changed, 17 insertions(+), 24 deletions(-) diff --git a/drivers/gpu/drm/tegra/dsi.c b/drivers/gpu/drm/tegra/dsi.c index 924611061cfa..aab555a2eb68 100644 --- a/drivers/gpu/drm/tegra/dsi.c +++ b/drivers/gpu/drm/tegra/dsi.c @@ -560,11 +560,6 @@ static void tegra_dsi_configure(struct tegra_dsi *dsi,= unsigned int pipe, tegra_dsi_writel(dsi, hact << 16 | hbp, DSI_PKT_LEN_2_3); tegra_dsi_writel(dsi, hfp, DSI_PKT_LEN_4_5); tegra_dsi_writel(dsi, 0x0f0f << 16, DSI_PKT_LEN_6_7); - - /* set SOL delay (for non-burst mode only) */ - tegra_dsi_writel(dsi, 8 * mul / div, DSI_SOL_DELAY); - - /* TODO: implement ganged mode */ } else { u16 bytes; =20 @@ -586,28 +581,26 @@ static void tegra_dsi_configure(struct tegra_dsi *dsi= , unsigned int pipe, value =3D MIPI_DCS_WRITE_MEMORY_START << 8 | MIPI_DCS_WRITE_MEMORY_CONTINUE; tegra_dsi_writel(dsi, value, DSI_DCS_CMDS); + } =20 - /* set SOL delay */ - if (dsi->master || dsi->slave) { - unsigned long delay, bclk, bclk_ganged; - unsigned int lanes =3D state->lanes; - - /* SOL to valid, valid to FIFO and FIFO write delay */ - delay =3D 4 + 4 + 2; - delay =3D DIV_ROUND_UP(delay * mul, div * lanes); - /* FIFO read delay */ - delay =3D delay + 6; - - bclk =3D DIV_ROUND_UP(mode->htotal * mul, div * lanes); - bclk_ganged =3D DIV_ROUND_UP(bclk * lanes / 2, lanes); - value =3D bclk - bclk_ganged + delay + 20; - } else { - /* TODO: revisit for non-ganged mode */ - value =3D 8 * mul / div; - } + /* set SOL delay */ + if (dsi->master || dsi->slave) { + unsigned long delay, bclk, bclk_ganged; + unsigned int lanes =3D state->lanes; =20 - tegra_dsi_writel(dsi, value, DSI_SOL_DELAY); + /* SOL to valid, valid to FIFO and FIFO write delay */ + delay =3D 4 + 4 + 2; + delay =3D DIV_ROUND_UP(delay * mul, div * lanes); + /* FIFO read delay */ + delay =3D delay + 6; + + bclk =3D DIV_ROUND_UP(mode->htotal * mul, div * lanes); + bclk_ganged =3D DIV_ROUND_UP(bclk * lanes / 2, lanes); + value =3D bclk - bclk_ganged + delay + 20; + } else { + value =3D 8 * mul / div; } + tegra_dsi_writel(dsi, value, DSI_SOL_DELAY); =20 if (dsi->slave) { tegra_dsi_configure(dsi->slave, pipe, mode); --=20 2.48.1 From nobody Fri Dec 19 19:01:28 2025 Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F0362BEC2C for ; Thu, 4 Dec 2025 06:14:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764828891; cv=none; b=VfnEaYfVUCmdwpDUxe/mlSSQyT/VqzsBW7bdW/nmoUemgr1n1G594nPC34dgVe6cbsdIS4waCGwyO6OCFdAsWINliMbH93qVw60BQq6V8SrZ+uV0k9O7ukm4pUFnuPxDFFH4uj8ZtiaC3y2wqe8xKNYkolJLcc7qi0Q7kfMbxpk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764828891; c=relaxed/simple; bh=ggGdRmXLBbjArTvqcF72EClkwv1lqIc94ZhVFK9wFgQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sgp4rjyiWodf/7pyC5JO10hYVkVgK9yzmFBlaZ+Pli0WMBRqxuopRx0En8DhIlC6QU5mXx1W1bjSheXV8r1GBdKx1GpNodmgOQAFz12l//ai1p77JPIM8gdnLLrVO/KKHrH0veGUCR/9ooi5zmQhvonrTi7q5pc664MrSrJFIdU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=He0JYtR3; arc=none smtp.client-ip=209.85.218.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="He0JYtR3" Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-b75c7cb722aso74971166b.1 for ; Wed, 03 Dec 2025 22:14:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764828888; x=1765433688; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vYiswRj/QaYbkwuLO6ropupZ4HLa9+N1VAg/V5RUYGk=; b=He0JYtR3au0+JXHIcQJ04CJvCtrGRhqMlMBkehZ4rKxNs6BMhGhA2mpbqpHICVOztH eCpZEBxhadXPLHy30QXzY4MbR3YJKIf4wUzvjzdP/ii0vmyZZpuAWVzBXj3yQ/4oDNg1 EDQria3TBOizXbX+u4+57B/EO/OGXpIhGy14pOn8IWztMO1OVpf0GnDLSqA4NGI3miwQ dVViVzj/tjnsj1bEzJcHkd/CkeFr9nJRHC454iOohOy5/f7aO6U26sIseNccBytGMbUE q9ccbTQEE7y3okmuYtDHwlAeIUd4IR/YbLDlhbiwYYc4tikBhHf6pH+t7y1YXxfISJG3 un5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764828888; x=1765433688; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=vYiswRj/QaYbkwuLO6ropupZ4HLa9+N1VAg/V5RUYGk=; b=m/VcOpJnIKh4WnCtDa9JJj7JZmzdGMbYBIkHCRQqcp1KlX9fARSLZThAKTFKX/GB24 rncO8IjVt4GqfRpry2zOcRmL5NSbKlnUPYHtXTA5Y4wJVdKP1MA3SroxAX2k9jYJTp+b xuvo93vkwuTq/9pc9l4KkKx39i4+V7OAsUZUCCoubBCWeXzO8YtNZF/Cf4wmum7dk8KP 3uU1N0roXJhdBxFcHHfhA6lWsb7jAEjLPX826urS1f3Yo6fwUGp/ZkrpOGD4z+PxhKAl fz2waVaGyDuIRwvgxQvlyNDL+DhxQXFWX5lq0yX68DAUW8wZYDHekJTLVK7zveD6lara 1A5w== X-Forwarded-Encrypted: i=1; AJvYcCUWIDkc7/+mEOWngzvkHXNI3SPc68U/Th+M07FFN5CFAf9Sj+7I602PhD2S15atF3Jhfyc3bhGXc9MdEo4=@vger.kernel.org X-Gm-Message-State: AOJu0YyJDOZ2MU3trI3w+qzJIgD3t/LcjBYWy9pJeVnNSvOoTQvkcnGC vRWXR6JLxLlMDGkkyPOApwrrNlBylcBSZlAtvunMjKnpjAI1E1BnsxVz0G1kmQ== X-Gm-Gg: ASbGncv+wFwNj9FFfpOwy/shlNk7holaxFeSW61qbbtHDVH7LTC4pDEVijhNLGGMva6 AuZqf65bHfOgeDthLQ+78c/TPqiPh8O2L4um2+Dkj+jsrYBOSvz/MQRQSD5mlRnRPpk73t1Kce8 09uVAEr69+jufLNf06jiqTGFs9bExiIxZbMiXSfjDUrzgVC2qcqW+KZ5Rr1Oymv6yqndlEhG4E5 tFZmcTT9KRIxp2SnJgirnM7mpS2tyRMFKBG1q+W+bXu8AkssN7COPwz8ZXp8Xi7q+l6nHgGwHL7 4oda+sJuXxdiv3NpJiVrDzryhZNeomn1DOWp/tMnFFhFrhQwhB3YKFDWX295YKQQxkjBKRhsQtu EossS7xWFyIj8NbL/oli18/o9af36VIQHrc1tDBiqJxxAzAtP9YpnZ0/B2ds8aww7H9SiKyr/67 Y= X-Google-Smtp-Source: AGHT+IFFxhTMIa5+kk08uLpT0I+DrZEQ4kNYGNnKIoSZESkvBwYMSmeMpr2IbKVmYL/ijgj/qYJJkQ== X-Received: by 2002:a17:907:9625:b0:b73:8639:cd88 with SMTP id a640c23a62f3a-b79dbe8fd42mr443652866b.22.1764828887748; Wed, 03 Dec 2025 22:14:47 -0800 (PST) Received: from xeon ([188.163.112.74]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b79f445968asm50607866b.3.2025.12.03.22.14.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Dec 2025 22:14:47 -0800 (PST) From: Svyatoslav Ryhel To: Thierry Reding , Thierry Reding , Mikko Perttunen , David Airlie , Simona Vetter , Jonathan Hunter , Svyatoslav Ryhel Cc: dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v1 2/2 RESEND] gpu/drm: tegra: dsi: calculate packet parameters for video mode Date: Thu, 4 Dec 2025 08:14:36 +0200 Message-ID: <20251204061436.5401-3-clamor95@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251204061436.5401-1-clamor95@gmail.com> References: <20251204061436.5401-1-clamor95@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Calculate packet parameters for video mode same way it is done or command mode, by halving timings plugged into equations. Signed-off-by: Svyatoslav Ryhel --- drivers/gpu/drm/tegra/dsi.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/tegra/dsi.c b/drivers/gpu/drm/tegra/dsi.c index aab555a2eb68..1ec3f03d2577 100644 --- a/drivers/gpu/drm/tegra/dsi.c +++ b/drivers/gpu/drm/tegra/dsi.c @@ -545,12 +545,19 @@ static void tegra_dsi_configure(struct tegra_dsi *dsi= , unsigned int pipe, /* horizontal back porch */ hbp =3D (mode->htotal - mode->hsync_end) * mul / div; =20 - if ((dsi->flags & MIPI_DSI_MODE_VIDEO_SYNC_PULSE) =3D=3D 0) - hbp +=3D hsw; - /* horizontal front porch */ hfp =3D (mode->hsync_start - mode->hdisplay) * mul / div; =20 + if (dsi->master || dsi->slave) { + hact /=3D 2; + hsw /=3D 2; + hbp /=3D 2; + hfp /=3D 2; + } + + if ((dsi->flags & MIPI_DSI_MODE_VIDEO_SYNC_PULSE) =3D=3D 0) + hbp +=3D hsw; + /* subtract packet overhead */ hsw -=3D 10; hbp -=3D 14; --=20 2.48.1