From nobody Fri Dec 19 20:34:45 2025 Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9403320C461 for ; Thu, 4 Dec 2025 05:22:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764825779; cv=none; b=bY0Gm4HMj7GJ7Bgzc96LvtxkzXB/1E+aqiMu0k4GMkwCBVrGB/tYJbF1lmyeB0FyKkej/yOBhpiGrgBbvhBYCLeCEnSjdZXejTu7Wpcj5Aj9a5q8Fc45TqADAeemuvjdQ7hADfgPommFEvPhUaNH0akNtxXZ3jyMCEBSEU49pWY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764825779; c=relaxed/simple; bh=jpCd0OHBUEzCSY1ml7HUrOeU5mgCQ8eJQx72dE+bCVU=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=tEC0w5vuF2THJdZ9sQcwifXCTvfosAb3gWByX4ayM7hbUeXrqEXXoqqacuAqIVpymxw2MxJ6k3jaZh5h4QTzYBOgZhC32C27zoSmm0ZCA3X2UxCD8bIkFo2qshSWltQExAafSDeszxHE/VdJa6uBICf0Q90CmenzXAfJy6MRgUI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=aXODxq9N; arc=none smtp.client-ip=209.85.167.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aXODxq9N" Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-59584301f0cso551082e87.0 for ; Wed, 03 Dec 2025 21:22:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764825776; x=1765430576; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=8SQv1SiIIssZ012oxMaXo7fT2SF8X3Lengkaz4PLfkc=; b=aXODxq9NbGQQzujLq7p6spbL+18sz8dJzrDI4zX2wsYgg1hbARSUQo5xSsaUulPSAe LdHBLHhNEYEdbVyiu5xKIgxSp/+NW/ZJqyWX2Xmlfj78fFcRWh89oGiWD9p9p6CADu7Q ibP1HDRy8+j1N3sEYr9LN5PL7eYOkN3pfipautBcyTAAhAqD5bUur0fsQpJT5RSjbVXi /MFQt2TREnNIrGMmKf43bNYeZmv5GAC2Xh+lJ8RxYbCJBXnCAmR86OZtdVz6T7XId8GV 4dFKoqwZJEA3fyWyBcqXkOeUYN+xKcdCW5u9D10WAXFxGa/OTb/oNCKizN0MdMQVA9V2 UAEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764825776; x=1765430576; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8SQv1SiIIssZ012oxMaXo7fT2SF8X3Lengkaz4PLfkc=; b=ILUAVxj87QIPz1wK/yFsFq2HlFf/abIVhKu+8uNW5yBOUtgRVYuEcvrRfQtIWxSY0q KY5sQd3vITbAo4sWSVtbHpr9nFxOh5bRSMRzWZO9r1zYt+iYWqUNcHeh9RyujuT67uOz TyZpa/6BatvFBxjit3e36GGnno5m8utbLB7j/OXaRnHhKeDe0T4V97FHoRQkpgtdIyLm XIC77XyB4C2HYfbKFi5mnGEP8jcQGSuA5gEfZ9vaNihYD7rSinizl0Fug0R8LApeeIYy XAUauwlAe3AzvoUhvz+HZdVQrylg3YwPCZa4BHvUOo7mHNDGphBZ1l34TuzQkIIa9m1B 6GUA== X-Forwarded-Encrypted: i=1; AJvYcCWErCSu4UQtLRzDfj5Txqz5+I9SevgjG0ZAwo76kDYKeQLhkTX/WM8HEdbxPMUmv3xlGaX6O4CefhKwlJs=@vger.kernel.org X-Gm-Message-State: AOJu0YwND/WORiY1t6X+GultAmZJJ4v5ONozunFjlSefkTrV0dInWohH +Qwp5p/Z4SpsniIthMbCoL2EPfI7PV4hsBjs1NYKqiqIbFAcPlRLwWyv X-Gm-Gg: ASbGncvJs0jcAaAl0qKYmcvnQhrnh8GlF3MKeaowF6n/StuJ+TPtYj1jTpuL/6NoGHr hn2hDU37zyEMakmGjgq9KV20vR/8P5AM4Vy8v2zOk+1Vf/uoyBMrcttwQ5tsVvZ6qz28Aw1R8D6 6S43AYLRj98Y83PMCedSzh9N/JDE1o8HWxeeJgLajvCcDpOVEBuKEW8bEoRlQ7YBuJj6WZO/3df +eNWJpdYcXiFueBcYoabtY/Gw7Q0J8ivAai7zUUIiZzaykBl/M9L4VKo061nhtsnHhhxDYycmLm +XpyBNh+ENO9zAyg+MXKhK7JjZLtQEniBu4DEMg6xTTyfoY6uK2A3JPBem7ZIVLxiwkz74yKPJo li1zSjdYXcqmKSbM5I05x4jHQKiHGUp6sbLXk3fWobQ2i7Ud8gFmuIdSEcU6Qm3QRJ4moLCHw13 nOQddJ6RZ8lVfgEQDkenCWl+fRqsfF69X2VxLezilreGHuoZ1D X-Google-Smtp-Source: AGHT+IFwSLqkgHS+SZtUf7B8kZwkS4UQ5FyGPpaYdKBViOr7E5L4BTTmWpLiHu5Mh93G5lsuy/i/MA== X-Received: by 2002:a05:6512:23aa:b0:595:82ed:ff28 with SMTP id 2adb3069b0e04-597d66cdb3dmr518386e87.32.1764825775443; Wed, 03 Dec 2025 21:22:55 -0800 (PST) Received: from home-server.lan (89-109-48-215.dynamic.mts-nn.ru. [89.109.48.215]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-597d7c1e3fasm117445e87.65.2025.12.03.21.22.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Dec 2025 21:22:55 -0800 (PST) From: Alexey Simakov To: Michael Chan Cc: Alexey Simakov , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Michael Buesch , "John W. Linville" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org Subject: [PATCH net] broadcom: b44: prevent uninitialized value usage Date: Thu, 4 Dec 2025 08:22:43 +0300 Message-Id: <20251204052243.5824-1-bigalex934@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" On execution path with raised B44_FLAG_EXTERNAL_PHY, b44_readphy() leaves bmcr value uninitialized and it is used later in the code. Add check of this flag at the beginning of the b44_nway_reset() and exit early of the function if an external PHY is used, that would also correspond to other b44_readphy() call sites. Found by Linux Verification Center (linuxtesting.org) with Svace. Fixes: 753f492093da ("[B44]: port to native ssb support") Signed-off-by: Alexey Simakov Reviewed-by: Andrew Lunn --- drivers/net/ethernet/broadcom/b44.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/broadcom/b44.c b/drivers/net/ethernet/bro= adcom/b44.c index 0353359c3fe9..cbfd65881326 100644 --- a/drivers/net/ethernet/broadcom/b44.c +++ b/drivers/net/ethernet/broadcom/b44.c @@ -1789,6 +1789,9 @@ static int b44_nway_reset(struct net_device *dev) u32 bmcr; int r; =20 + if (bp->flags & B44_FLAG_EXTERNAL_PHY) + return 0; + spin_lock_irq(&bp->lock); b44_readphy(bp, MII_BMCR, &bmcr); b44_readphy(bp, MII_BMCR, &bmcr); --=20 2.34.1