From nobody Fri Dec 19 19:25:24 2025 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB13D1BD9C9 for ; Thu, 4 Dec 2025 05:30:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764826218; cv=none; b=sXAgm5DWNGRhkFAa/LFnDObnJ3hTyrWfeRf2UH+YdmPUq0bhhSbguh7mWhtDR9ImEsBLR4R1CxIkStX2ecFYHf/16n+P/2QG0CMhNIo66hfl4arc06pI/mV5zxHYw3BUKpIlNtjaa/6tQG+tOjSOnIJHaF/jE6SNaaF4X/ZgUwg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764826218; c=relaxed/simple; bh=uLosAoKW4UEMswd2M4EA90oQghOHfsanaCJpU/Bfq2g=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ddpUmo8CugHqQF3pUg0U7ky4ci0frgQC9Y2cDB8Wr8zNeMUNIbRaCm3xXY4Vdsv9ayk8Fm6BDgoEeeQCv477BulHgl4oJfuJkhWuYnL3qSIQrvIlHTruiF3/YskmncTB3tBa6Scg6TAupbLPyPJtTJl1nmZygjyZXrjR2XH9wUE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=njwIJVQo; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="njwIJVQo" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-477a2ab455fso6424315e9.3 for ; Wed, 03 Dec 2025 21:30:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764826214; x=1765431014; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=6uiXWVyRtV9Malz3iQqv5gUlDqbU6hQq55nc6uSoXaA=; b=njwIJVQoHlfnLX6w/60yvQp6yApNVqH5KiQRVgeoI7TiCNuohhd957oAPnJk/b1Jgm FyJv6i7upxonsCYsaGHHXSo8+AD+5xRSdOarATNpWcY8uQ0lB7Twfl/KkraeywK1j4R8 Z869eY6Z2IUCdG4Dfbfy6k8U6GMLCv7QN/dFQHOF3aUEjjyECt8NmxDX7GDQI8RSEVoX sZK/4//1nE0njbUBo/4ZBvRcrCrudoQ+68Lt5phNLA2w9/I3TfVz2nF3IPj0H8ZOgWd+ PDnjoZvVjONRh/MPZc5iQodRVCln8w7HGCv86UY7AQ7xkMsGg88OntJC7yBmnwD9L9fB NYVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764826214; x=1765431014; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6uiXWVyRtV9Malz3iQqv5gUlDqbU6hQq55nc6uSoXaA=; b=v2kwgivVKajWRkF10jaIibi22p/se/WM3EayDAPvIuau54Veoku38ALVJK5/VfTk+9 A5UxhVR4KQvLXo92mdzvNxiAWwHNGlhuGYJTusWnHB6VqMykbJcW00vXZETn49+txPUG A/q2iJ+h6UsoDayqWqGf4INNGj93ziLyG4+Pp5o+Ft+Q+/rUPP+0eUKBk4wCOGnGwOSt LFLKgPNAsTa5DishX+NrBNPYZKPKRSbEqmWJFsm8si1ddLlz69PYcDi3o/ZNKbO26oTF gcgJqcu5xDu+YO6cTFE57xE7dshbZ0hnha5FRtG42Z3ra/X/dIzv4Cmqll50s4fpbGBD hAVg== X-Forwarded-Encrypted: i=1; AJvYcCXvdkKLajG+MdfOoPhr/nz2FErqqM1omnw/c4z4OOqFzQU+MOurSsq7mHB5gIOfisdAnE9Npp+FH0Ip6TI=@vger.kernel.org X-Gm-Message-State: AOJu0YyfMiv5TlbIVKSDQ7CuTUukmvJox0beMJ5cE1Ncs/kgCAIs+QVY ZQzO8C9EOOo5lsD9dpAwDY6qsyI93PonoKEMVoIcIGsSUeKU2vZLPgUF X-Gm-Gg: ASbGncvj79AGDVo0c280RBncau1i6aPN7qrCByyb7Mi7ZBrvsdLtB+IeXdSbaIwksct 8Z6xUUZn3SYnQUszDTZGDUvoo7vx0Yz3KYuv6aOOkGMR9AXpnUBdy3JLbeU4k978Mry4gQTLbKu 0ibVPmahi6Ewtxy9fZZxGtqAKoC1AfytMq3KDL9VxdBKOAPSI6vwjDBQfY2N6gn/FW4pgfDyaXH z+SxBsY4Q5FOLnEpeLXZ7hbnr7ycvMlMv5P8sjja3Fc0dV8WICMCGewiFvx9no+mPFE1datepoB uEqjRQtePl2g5L5UkijS0A/1iAmrmi0OVcauoqyLStHlqpOAL+XShiCB+VkFsmhgDmkj+/QQ5C8 8qa/gM6/zWxsjy5NY8IUAXcPHLdoJIgSLp95ER/cSLrXBmGi4P4OmdQ7Q3jQ7wOGpjFrXvkwzLq /3ppDLK8DvylUujQ== X-Google-Smtp-Source: AGHT+IHAMODDrTmW9Cp4fmTFUUwoZJOM43P2EOQe0XZojPUAd2GUDdmpqNFVKQgYZvDFaweUHLph9Q== X-Received: by 2002:a05:600c:b90:b0:471:14f5:126f with SMTP id 5b1f17b1804b1-4792af4833fmr41821905e9.33.1764826213605; Wed, 03 Dec 2025 21:30:13 -0800 (PST) Received: from gmail.com ([147.161.143.103]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4793092ba4fsm14223155e9.4.2025.12.03.21.30.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Dec 2025 21:30:13 -0800 (PST) From: hariconscious@gmail.com To: perex@perex.cz, tiwai@suse.com, cristian.ciocaltea@collabora.com, cryolitia@uniontech.com, franta-linux@frantovo.cz Cc: khalid@kernel.org, shuah@kernel.org, david.hunter.linux@gmail.com, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, HariKrishna Sagala , Takashi Iwai Subject: [PATCH v2] ALSA: usb-audio: Initialize status1 to fix uninitialized symbol errors Date: Thu, 4 Dec 2025 10:52:03 +0530 Message-ID: <20251204052201.16286-3-hariconscious@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: HariKrishna Sagala Initialize 'status1' with a default value to resolve the static analysis smatch reported error "uninitialized symbol 'status1'". The 'status1' variable is used to create a buff using "kmemdup". So, ensure to initialize the value before it is read. Suggested-by: Takashi Iwai Signed-off-by: HariKrishna Sagala --- This patch fixes the below smatch reported errors. sound/usb/mixer_quirks.c:2462 snd_rme_rate_get() error: uninitialized symbo= l 'status1'. sound/usb/mixer_quirks.c:2467 snd_rme_rate_get() error: uninitialized symbo= l 'status1'. sound/usb/mixer_quirks.c:2472 snd_rme_rate_get() error: uninitialized symbo= l 'status1'. sound/usb/mixer_quirks.c:2495 snd_rme_sync_state_get() error: uninitialized= symbol 'status1'. sound/usb/mixer_quirks.c:2501 snd_rme_sync_state_get() error: uninitialized= symbol 'status1'. sound/usb/mixer_quirks.c:2522 snd_rme_spdif_if_get() error: uninitialized s= ymbol 'status1'. sound/usb/mixer_quirks.c:2535 snd_rme_spdif_format_get() error: uninitializ= ed symbol 'status1'. sound/usb/mixer_quirks.c:2548 snd_rme_sync_source_get() error: uninitialize= d symbol 'status1'. The below is the flow of 'status1' it is used before initialization. snd_rme_rate_get -> status1 is uninitialized and passed snd_rme_get_status1 -> passed as is snd_rme_read_value -> passed as is snd_usb_ctl_msg -> created buf from status1 using k= memdup usb_control_msg -> sent buf for reading/wri= ting Description of "usb_control_msg", states as " * @data: pointer to the data to send" Later from Usb control request, dst buf is copied to src buf but usb control msg request is made before initialization. All the above warning reported functions, call snd_rme_get_status1(). v2: Corrected as suggested by Takashi Iwai to silence the warnings from callee side as it can reduce number of changes. v1: https://lore.kernel.org/all/20251203083319.58555-2-hariconscious@gmail.com/ Thank you. sound/usb/mixer_quirks.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/usb/mixer_quirks.c b/sound/usb/mixer_quirks.c index 828af3095b86..f3e15825bc02 100644 --- a/sound/usb/mixer_quirks.c +++ b/sound/usb/mixer_quirks.c @@ -2440,6 +2440,7 @@ static int snd_rme_get_status1(struct snd_kcontrol *k= control, struct usb_mixer_elem_list *list =3D snd_kcontrol_chip(kcontrol); struct snd_usb_audio *chip =3D list->mixer->chip; =20 + *status1 =3D 0; CLASS(snd_usb_lock, pm)(chip); if (pm.err < 0) return pm.err; base-commit: 4a26e7032d7d57c998598c08a034872d6f0d3945 --=20 2.43.0