From nobody Fri Dec 19 19:33:53 2025 Received: from mail-qk1-f174.google.com (mail-qk1-f174.google.com [209.85.222.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B9DC01D6BB for ; Thu, 4 Dec 2025 04:09:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764821364; cv=none; b=nw5a7u3npdoSCHvP6gTP4tLuHfnpg2BWYhNHHhQpSJLJB1gTqwT2Pxq5t0gx7DZ4Rv6923bH44gEP5j9m+IqjDpPLcgFVslc+2CTGjWrWXnb8ZyHhXW++cotMIaU0ClBIvrO6mZ//HM8HDauVRi3bXfmF+JSTtzYtP3S7vv/iVM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764821364; c=relaxed/simple; bh=2OYLKNphXp7P6kSf7Kaf314+3r1xAZHL96/uhNNk5sQ=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=c/40t/RU3pC46hOjhRx0UF+8UaKkYW9vrKiWQZ0b7tHg7aG6WTe0qitlU7mitUSRw1MELR2OH05aNzRDMte8nNgKYj0KJDscD/DxsN1lGsoDD4OAzG7Z7BwnlGWjKwBqyncFseDmkZ0P8PaJOJgDcyVh/yhmrNv70fFxVkUH21s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KH4KsRyK; arc=none smtp.client-ip=209.85.222.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KH4KsRyK" Received: by mail-qk1-f174.google.com with SMTP id af79cd13be357-8a3eac7ca30so27073185a.2 for ; Wed, 03 Dec 2025 20:09:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764821361; x=1765426161; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=DSAeOhrKRNk2xZ75BysPoFDA4gZkh8gK5u83rkIANjs=; b=KH4KsRyKDU55YcmOnVX51Wl5KP0sGmZM77KGKAujj6x7ZuWq8IyYSjTp5/5JdT+9nc lJOYNqm2m3UsHEF68d+dR4A7JgjXbDjo1haBcc4UejJb5BGnWbAt236oOmD24HvCBsvt JQDjU8iIyHmRCv/jc0Rk3oesr4DRO6DDxkRyqR1xv34Y1EeuLFIzzi9CXZ43oD+1gqHn nxhssI+VDnuavNu4T7yr+1K3c+b4Fs7MWomns57Yx6DD+1B4dnT4DZTaDk4mNdSomcfp GGWrRdouvW0gUAOLT79W+BgniecILcIM4DEepIfmMUWXB0L4ojHHczU412/YSnQ+8ILq /7hA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764821361; x=1765426161; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=DSAeOhrKRNk2xZ75BysPoFDA4gZkh8gK5u83rkIANjs=; b=Pj0TnuB08owquWJAb4IidZffQe8663BCWjkg3xDzbY6nRBR4vfh+SNQsy0LkSoxktB Mb1oAPCXrhOcN4BGrbJiQoLtUKYjhO8yHMAc655iCac6GnhAKkG3dMdFlS4S/5iJEEAF K+zSy+h+dI6JHQeoIDKCAjWFOfASgLWqqqaPe+7oEMXH0K0wrBV/RpWWXfbIzsLQXjoG RkjN4ugtkOk3/Usstqrn3seM5LHNhJYtu3PBps0S+h+45EERSesYDpV73MUEpQBgDxwL DApQK3K9nrqw6uPPP4JcI11NPeN3b9KoTsDdbvyLjaHMg4es3eC36XQqjwoSTRowt3KG TeZA== X-Forwarded-Encrypted: i=1; AJvYcCXbXNkSTIbuubSLfN81UaW2zF28vJxJtmAdymMF+HidRCScRiE9WYo7TTZocWv3Sm8oHU9OmctWqSJae5M=@vger.kernel.org X-Gm-Message-State: AOJu0Yz7n/Yv7CCDmkLobO2BUDPpxIpdGfsGgQ6exLnHnolciDImS9RQ FXUNZDhqwij8GVMSaPj6rE7YJjEwxabD1niVLu4XyUiIImO+Qut2X/xz X-Gm-Gg: ASbGncsFpaYWKHNcIiWk91Bns82AqsyfpSa3iWJg5BI5WPkUVxZAbx83rir0ItsUTmg beANZhyb4nGifiAzsJvIzIxWz6U0wGaZem9qw1LH2L8i80vWj5RPuy8noytfYah9Cj4aTww/wFR UXYhnJAF+FYSTp6r2gfBxMb9N9lnusk15EG8dPC5LaeoldH/AlMalnVBMgxcBQUfkFK86apN5X5 JNkLT8vX5/XjrLvbuVOCA5DrdBm/AGs6g33/3C6LB3b+TQqHLZbyVAm46sEISY81AKvT3JUr3pQ CbdJ4982bzN9L0elyOHaUT9qR9Dh/2ibrZxdGF6RywUIs14Vjl3ian6bRlfq404uFa4F7n4uvdA gRh2dcOPkdyWw6n/QFVbhisUxMNeDHUc2HKzdmc1s4uhrfrL3SxrLc2NOCzr3CEdCJuSeuWTBQX LjTGax6POFInUEGYJVUPEFwS3tjBPGDAJ3DIAtTTTVx44= X-Google-Smtp-Source: AGHT+IGNEgBJct+zHQdh6r+80lmbL0USkGj9xCw1KIGwShDzBz3u3+/9lKBzao89QHS0WFKpVom7Cg== X-Received: by 2002:ac8:5ac8:0:b0:4ee:1dd0:5a40 with SMTP id d75a77b69052e-4f023ac6024mr24423411cf.59.1764821360651; Wed, 03 Dec 2025 20:09:20 -0800 (PST) Received: from kernel-internship-machine.. ([143.110.209.46]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4f027d0261dsm1975441cf.19.2025.12.03.20.09.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Dec 2025 20:09:20 -0800 (PST) From: Vivek BalachandharTN To: brauner@kernel.org Cc: penguin-kernel@I-love.SAKURA.ne.jp, chentaoo@didiglobal.com, linux-kernel@vger.kernel.org, vivek.balachandhar@gmail.com Subject: [PATCH] minix: return -EIO when superblock read fails Date: Thu, 4 Dec 2025 04:09:19 +0000 Message-Id: <20251204040919.2522790-1-vivek.balachandhar@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When minix_fill_super() fails to read the on-disk superblock, it prints "MINIX-fs: unable to read superblock" but still returns -EINVAL. This is misleading for callers, since the failure is due to an I/O error rather than an invalid superblock format or mount option. Return -EIO in this case so that the errno better reflects the actual error condition and allows userspace to distinguish I/O failures from format or parameter errors. Signed-off-by: Vivek BalachandharTN --- fs/minix/inode.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/minix/inode.c b/fs/minix/inode.c index 32db676127a9..2b2b64a31724 100644 --- a/fs/minix/inode.c +++ b/fs/minix/inode.c @@ -365,6 +365,7 @@ static int minix_fill_super(struct super_block *s, stru= ct fs_context *fc) goto out; =20 out_bad_sb: + ret =3D -EIO; printk("MINIX-fs: unable to read superblock\n"); out: s->s_fs_info =3D NULL; --=20 2.34.1